pippi 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b69820f23560f62844335dba76692a5b29c40523
-  data.tar.gz: bfdc9ccdd89aab53afc19f82c247c55e32f56eef
+  metadata.gz: 71a917fd7fe564b1259bbe2e1bd5816f99642c95
+  data.tar.gz: 04ee328c79590242bdf9901dfbf19128c20174fd
 SHA512:
-  metadata.gz: 11480a7cce7761a9c2aeff77f31829872f79e577945082e1f6b7975f851b1968991d07c17eea8bbb3d28ae0e1eeceb0223edb99e578458e4fe987633a53b3ff1
-  data.tar.gz: 361ff7703eb9af5c59ea6a3385c6e2d8def03be9a2b94b4a2b6342e7689055fa4bc9497b2a2b8f85d5b797dfcf0ae4ad311a7eaec2989bf6a4eaabc2e3a9a887
+  metadata.gz: 4322323a5f61a25e4697774e900c403aaa17a206dc721583d0778ffe32337f8a791bae64c9dd17967c2ed778f34e08b40f9b09c97ec3bbd8fe8f2f3f2a906dcb
+  data.tar.gz: 46c707010d0424970e002c07a90f21ab8a37a633a955afcba21be1331f7b667c477026bb5de0bfe81d35eaa42a14eec6c65ff22d7a7dcd532b64b95ab840f4e3

data/CHANGELOG.md

@@ -1,16 +1,25 @@
-Nov 5, 2014 - 0.0.5:
-Added SelectFollowedByEmpty
+## 0.0.6 (2014-11-18)
 
-Oct 30, 2014 - 0.0.4:
-Bugfixes around method delegation
+ * [NEW] Added SelectFollowedBySelect
 
-Oct 22, 2014 - 0.0.3:
-Moved AssertWithNil to "buggy" checkset until I can figure out issues.
+## 0.0.5 (2014-11-05)
 
-Oct 22, 2014 - 0.0.2:
-Added AssertWithNil
+ * [NEW] Added SelectFollowedByEmpty
 
-Oct 22, 2014 - 0.0.1:
-Initial release.
+## 0.0.4 (2014-10-30)
+
+ * [FIXED] Bugfixes around method delegation
+
+## 0.0.3 (2014-10-22)
+
+ * [CHANGED] Moved AssertWithNil to "buggy" checkset until I can figure out issues.
+
+## 0.0.2 (2014-10-22)
+
+ * [NEW] Added AssertWithNil
+
+## 0.0.1 (2014-10-22)
+
+ * [NEW] Initial release.
 
 

data/README.md

@@ -81,19 +81,28 @@ Here's a [demo Rails application](https://github.com/tcopeland/pippi_demo#pippi-
 ### Rails with rspec
 
 * Add `gem 'pippi'` to the `test` group in your project's `Gemfile`
-* Add this to the bottom of `spec_helper.rb`:
+* Add this to the top of `spec/spec_helper.rb`:
 
 ```ruby
 if ENV['USE_PIPPI'].present?
+  require 'pippi'
   Pippi::AutoRunner.new(:checkset => ENV['PIPPI_CHECKSET'] || "basic")
 end
 ```
+
 * Run it:
 
 ```text
 USE_PIPPI=true bundle exec rake spec && cat log/pippi.log
 ```
 
+### As part of a continuous integration job
+
+[Dan Kohn](https://github.com/dankohn) suggests you could use something like:
+
+```bash
+if grep -v gem < log/pippi.log; then echo "$(wc -l < log/pippi.log) Pippi flaws found" && false; else echo 'No pippi flaws found'; fi
+```
 
 ### From the command line:
 
@@ -164,6 +173,22 @@ Instead, consider doing this:
 [1,2,3].detect {|x| x > 1 }
 ```
 
+#### SelectFollowedBySelect
+
+Don't use consecutive select blocks; use a single select instead
+
+For example, rather than doing this:
+
+```ruby
+[1,2,3].select {|x| x > 1 }.select {|x| x > 2 }
+```
+
+Instead, consider doing this:
+
+```ruby
+[1,2,3].select {|x| x > 2 }
+```
+
 #### SelectFollowedBySize
 
 Don't use select followed by size; use count instead
@@ -199,12 +224,12 @@ x = nil ; assert_nil(x)
 
 #### MapFollowedByFlatten
 
-Don't use map followed by flatten; use flat_map instead
+Don't use map followed by flatten(1); use flat_map instead
 
 For example, rather than doing this:
 
 ```ruby
-[1,2,3].map {|x| [x,x+1] }.flatten
+[1,2,3].map {|x| [x,x+1] }.flatten(1)
 ```
 
 Instead, consider doing this:
@@ -212,6 +237,7 @@ Instead, consider doing this:
 ```ruby
 [1,2,3].flat_map {|x| [x, x+1]}
 ```
+
 ## Ideas for other problems to detect:
 
 ```ruby
@@ -306,6 +332,7 @@ rm -rf pippi_debug.log pippi.log .bundle/gems/pippi-0.0.1/ .bundle/cache/pippi-0
 * Commit, push
 * `bundle exec gem build pippi.gemspec`
 * `gem push pippi-x.gem`
+* Update pippi_demo
 
 ## Credits
 

data/doc/docs.md

@@ -48,6 +48,22 @@ Instead, consider doing this:
 [1,2,3].detect {|x| x > 1 }
 ```
 
+#### SelectFollowedBySelect
+
+Don't use select followed by select; use a single select instead
+
+For example, rather than doing this:
+
+```ruby
+[1,2,3].select {|x| x > 1 }.select {|x| x > 2 }
+```
+
+Instead, consider doing this:
+
+```ruby
+[1,2,3].select {|x| x > 2 }
+```
+
 #### SelectFollowedBySize
 
 Don't use select followed by size; use count instead
@@ -83,12 +99,12 @@ x = nil ; assert_nil(x)
 
 #### MapFollowedByFlatten
 
-Don't use map followed by flatten; use flat_map instead
+Don't use map followed by flatten(1); use flat_map instead
 
 For example, rather than doing this:
 
 ```ruby
-[1,2,3].map {|x| [x,x+1] }.flatten
+[1,2,3].map {|x| [x,x+1] }.flatten(1)
 ```
 
 Instead, consider doing this:

data/lib/pippi.rb

@@ -13,5 +13,6 @@ require 'pippi/checks/reverse_followed_by_each'
 require 'pippi/checks/select_followed_by_first'
 require 'pippi/checks/select_followed_by_size'
 require 'pippi/checks/select_followed_by_empty'
+require 'pippi/checks/select_followed_by_select'
 require 'pippi/checks/assert_with_nil'
 require 'pippi/checks/debug_check'

data/lib/pippi/check_set_mapper.rb

@@ -24,6 +24,7 @@ module Pippi
           "SelectFollowedBySize",
           "SelectFollowedByEmpty",
           "ReverseFollowedByEach",
+          "SelectFollowedBySelect"
         ],
         "training" => [
         ],

data/lib/pippi/checks/map_followed_by_flatten.rb

@@ -41,11 +41,11 @@ module Pippi::Checks
 
     class Documentation
       def description
-        "Don't use map followed by flatten; use flat_map instead"
+        "Don't use map followed by flatten(1); use flat_map instead"
       end
 
       def sample
-        '[1,2,3].map {|x| [x,x+1] }.flatten'
+        '[1,2,3].map {|x| [x,x+1] }.flatten(1)'
       end
 
       def instead_use

data/lib/pippi/checks/select_followed_by_select.rb

@@ -0,0 +1,49 @@
+module Pippi::Checks
+
+  class SelectFollowedBySelect < Check
+
+    module MySecondSelect
+      def select(&blk)
+        self.class._pippi_check_select_followed_by_select.add_problem
+        super
+      end
+    end
+
+    module MyFirstSelect
+      def select(&blk)
+        result = super
+        if !self.class._pippi_check_select_followed_by_select.nil?
+          result.extend MySecondSelect
+          self.class._pippi_check_select_followed_by_select.array_mutator_methods.each do |this_means_its_ok_sym|
+            result.define_singleton_method(this_means_its_ok_sym, self.class._pippi_check_select_followed_by_select.its_ok_watcher_proc(MySecondSelect, :select))
+          end
+        end
+        result
+      end
+    end
+
+    def decorate
+      Array.class_exec(self) do |my_check|
+        @_pippi_check_select_followed_by_select = my_check
+        def self._pippi_check_select_followed_by_select
+          @_pippi_check_select_followed_by_select
+        end
+      end
+      Array.prepend MyFirstSelect
+    end
+
+    class Documentation
+      def description
+        "Don't use consecutive select blocks; use a single select instead"
+      end
+      def sample
+        "[1,2,3].select {|x| x > 1 }.select {|x| x > 2 }"
+      end
+      def instead_use
+        "[1,2,3].select {|x| x > 2 }"
+      end
+    end
+
+  end
+
+end

data/lib/pippi/version.rb

@@ -1,3 +1,3 @@
 module Pippi
-  VERSION = '0.0.5'
+  VERSION = '0.0.6'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pippi
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Tom Copeland
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-05 00:00:00.000000000 Z
+date: 2014-11-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -76,6 +76,7 @@ files:
 - lib/pippi/checks/reverse_followed_by_each.rb
 - lib/pippi/checks/select_followed_by_empty.rb
 - lib/pippi/checks/select_followed_by_first.rb
+- lib/pippi/checks/select_followed_by_select.rb
 - lib/pippi/checks/select_followed_by_size.rb
 - lib/pippi/context.rb
 - lib/pippi/exec_runner.rb