pipejump 0.2.0 → 0.3.0

data/spec/pipejump/resources/deal_spec.rb

@@ -1,61 +1,67 @@
-require 'spec/spec_helper'
+require 'spec_helper'
+
 describe Pipejump::Deal do
 
-  before do 
+  before do
     @session = PipejumpSpec.session
-    @client = @session.clients.create(:name => 'Client1')
+    @client = @session.contacts.create(:name => 'Client2' + uuid, :is_organisation => true)
+    @client.id.should_not be_nil
   end
-  
+
   after do
     @client.destroy
   end
-  
+
   describe '#create' do
-    
+
     it "should create deal with valid params" do
-      @deal = @session.deals.create(:name => 'New deal', :client_id => @client.id)
-      @deal.attributes.keys.sort.should == ["client", "client_id", "deal_tags", "hot", "id", "name", "scope", "stage_name"] 
-      (@deal.attributes.keys - ['client']).each do |attribute|
+      @deal = @session.deals.create(:name => 'New deal' + uuid, :entity_id => @client.id)
+      @deal.id.should_not be_nil
+      ["entity_id", "deal_tags", "hot", "id", "last_stage_change_at", "name", "scope", "stage_name"].each do |key|
+        @deal.attributes.keys.should include(key)
+      end
+
+      (@deal.attributes.keys - ['entity']).each do |attribute|
         @deal.send(attribute).should == @deal.attributes[attribute]
       end
-      @deal.client.class.should == Pipejump::Client
+      @deal.entity.class.should == Pipejump::Contact
       @deal.destroy
     end
-    
+
     it "should return errors with invalid params" do
       @deal = @session.deals.create({})
       @deal.id.should == nil
-      @deal.errors['deal'].collect{ |e| e['error']['field'] }.sort.should == ['client', 'name']
+      @deal.errors['deal'].collect{ |e| e['error']['field'] }.sort.should == ['entity', 'name']
     end
-    
+
   end
-  
+
   describe '.find' do
 
     it "should find deal" do
-      @deal = @session.deals.create(:name => 'New deal', :client_id => @client.id)
+      @deal = @session.deals.create(:name => 'New deal' + uuid, :entity_id => @client.id)
       @found = @session.deals.find(@deal.id)
       @found.name == @deal.name
       @deal.destroy
     end
-      
+
     it "should raise error if not found" do
       lambda {
         @session.deals.find(-1)
       }.should raise_error(Pipejump::ResourceNotFound)
     end
   end
-  
+
   describe '#update' do
-   
+
     before do
-      @deal = @session.deals.create(:name => 'New deal', :client_id => @client.id)
+      @deal = @session.deals.create(:name => 'New deal' + uuid, :entity_id => @client.id)
     end
-    
-    after do 
+
+    after do
       @deal.destroy
-    end 
-    
+    end
+
     it "should update deal with valid params" do
       @deal.name = 'Updated deal'
       @deal.save
@@ -63,38 +69,38 @@ describe Pipejump::Deal do
       @found = @session.deals.find(@deal.id)
       @found.name.should == 'Updated deal'
     end
-    
+
     it "should return errors with invalid params" do
       @deal.name = ''
-      @deal.save.should == false      
+      @deal.save.should == false
       @deal.errors['deal'].collect{ |e| e['error']['field'] }.sort.should == ['name']
     end
-    
+
   end
-  
+
   describe '#contacts' do
-    
-    before do 
-      @deal = @session.deals.create(:name => 'New deal', :client_id => @client.id)
-      @contact = @session.contacts.create(:name => 'Tom', :client_id => @client.id)
-      @contact2 = @session.contacts.create(:name => 'Mike', :client_id => @client.id)
+
+    before do
+      @deal = @session.deals.create(:name => 'New deal' + uuid, :entity_id => @client.id)
+      @contact = @session.contacts.create(:name => 'Tom' + uuid, :contact_id => @client.id)
+      @contact2 = @session.contacts.create(:name => 'Mike' + uuid, :contact_id => @client.id)
       @deal.contacts.update(@contact.id).should == true
     end
-    
+
     after do
       @contact.destroy
       @contact2.destroy
     end
-    
+
     it "should return a collection of contacts" do
       contacts = @deal.contacts
       contacts.class.should == Pipejump::Collection
       contacts.respond_to?(:update).should == true
       contacts.size.should == 1
     end
-    
+
     describe '#update' do
-      
+
       it "should update a collection of contacts and be smart about it" do
         @deal.contacts.update([@contact.id, @contact2.id])
         @deal.contacts.size.should == 2
@@ -107,9 +113,9 @@ describe Pipejump::Deal do
         @deal.contacts.update([@contact.id, @contact2.id].join(','))
         @deal.contacts.size.should == 2
       end
-      
+
     end
-    
+
   end
-  
+
 end

data/spec/pipejump/resources/source_spec.rb

@@ -1,42 +1,45 @@
-require 'spec/spec_helper'
+require 'spec_helper'
+
 describe Pipejump::Source do
 
-  before do 
+  before do
     @session = PipejumpSpec.session
-    @source1 = @session.sources.create(:name => 'Source1')
+    @source1 = @session.sources.create(:name => 'Source1'+uuid)
     @source1.id.should_not be_nil
-    @source2 = @session.sources.create(:name => 'Source2')
+    @source2 = @session.sources.create(:name => 'Source2'+uuid)
     @source2.id.should_not be_nil
   end
-  
+
   after do
     @source1.destroy
     @source2.destroy
   end
-  
+
   describe '@session.sources' do
-    
+
     it ".all should return all sources" do
-      @session.sources.all.collect(&:name).should == [@source1, @source2].collect(&:name) 
+      sources = @session.sources.all.collect(&:name)
+      sources.should include(@source1.name)
+      sources.should include(@source2.name)
     end
 
     it ".first should return first source" do
-      @session.sources.first.name.should == @source1.name
+      @session.sources.first.should be_a(Pipejump::Source)
     end
 
     it ".last should return last source" do
-      @session.sources.last.name.should == @source2.name
+      @session.sources.last.should be_a(Pipejump::Source)
     end
-    
+
     it ".find should find exact source" do
       @session.sources.find(@source1.id).name.should == @source1.name
     end
-    
-  end  
-  
+
+  end
+
   describe '#method_missing' do
-    
-    it "should correctly get and set attributes" do 
+
+    it "should correctly get and set attributes" do
       @source1.attributes.keys.sort.should == ['id', 'name']
       @source1.attributes.keys.each do |attribute|
         @source1.send(attribute).should == @source1.attributes[attribute]
@@ -45,17 +48,17 @@ describe Pipejump::Source do
       @source1.name.should == 'Different name'
       @source1.attributes['name'].should == 'Different name'
     end
-    
+
     it "should raise a NoMethodError when no accessor is set" do
       lambda {
         @source1.not_a_method_name
       }.should raise_error(NoMethodError)
     end
- 
+
   end
 
   describe '#create' do
-    
+
     it "should create record" do
       @source3 = @session.sources.create(:name => 'Source3')
       @source3.id.should_not be_nil
@@ -63,29 +66,29 @@ describe Pipejump::Source do
       @session.sources.find(@source3.id).name.should == 'Source3'
       @source3.destroy
     end
-    
+
     it "should return error on validation fail" do
       @source3 = @session.sources.create(:name => '')
       @source3.id.should be_nil
-      @source3.errors.should_not == {}      
+      @source3.errors.should_not == {}
     end
-    
+
   end
 
   describe '#update' do
-    
+
     it "should update record" do
       @source1.name = 'Different name'
       @source1.save.should == true
       @session.sources.find(@source1.id).name.should == 'Different name'
     end
-    
+
     it "should return error on validation fail" do
       @source1.name = ''
       @source1.save.should == false
-      @source1.errors.should_not == {}      
+      @source1.errors.should_not == {}
     end
-    
+
   end
 
 end

data/spec/pipejump/session_spec.rb

@@ -1,33 +1,32 @@
-require 'spec/spec_helper'
+require 'spec_helper'
+
 describe Pipejump::Session do
 
-  before do 
+  before do
     @session = Pipejump::Session.new(AUTH.dup)
   end
-  
+
   it "should have token" do
     @session.token.should_not be_nil
   end
-  
+
   it "should raise an error on wrong credentials" do
     lambda {
       @session = Pipejump::Session.new(AUTH.merge({'password' => 'NOT_CORRECT_PASSWORD_123qwe'}).dup)
     }.should raise_error(Pipejump::AuthenticationFailed)
   end
-  
+
   it "should return account data on /account" do
     account = @session.account
     account.class.should == Pipejump::Account
-    account.attributes.keys.sort.should == ["currency_name", "id", "name"]
+    ["currency_name", "id", "name"].each do |key|
+      account.attributes.keys.should include(key)
+    end
   end
-  
+
   it "#connection should return a connection" do
     @session.connection.class.should == Pipejump::Connection
   end
-  
-  it "#clients should return a collection of clients" do
-    @session.clients.class.should == Pipejump::Collection
-  end
 
   it "#contacts should return a collection of contacts" do
     @session.contacts.class.should == Pipejump::Collection
@@ -40,5 +39,5 @@ describe Pipejump::Session do
   it "#deals should return a collection of deals" do
     @session.deals.class.should == Pipejump::Collection
   end
-  
-end 
+
+end

data/spec/spec_helper.rb

@@ -1,6 +1,8 @@
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 $LOAD_PATH.unshift(File.dirname(__FILE__))
-require 'lib/pipejump'
+require "rubygems"
+require "bundler/setup"
+require 'pipejump'
 require 'yaml'
 AUTH = YAML.load_file(File.join(Dir.pwd, 'spec', 'connection.yml'))
 
@@ -9,4 +11,17 @@ class PipejumpSpec
     attr_accessor :session
   end
 end
-PipejumpSpec.session = Pipejump::Session.new(AUTH.dup)
+PipejumpSpec.session = Pipejump::Session.new(AUTH.dup)
+
+def uuid
+  Time.now.to_i.to_s + 'x' + rand(100000000).to_s + 'X' + rand(100000000).to_s
+end
+
+
+RSpec.configure do |config|
+  config.before(:all) do
+  end
+
+  config.after(:all) do
+  end
+end

metadata

@@ -1,13 +1,8 @@
 --- !ruby/object:Gem::Specification 
 name: pipejump
 version: !ruby/object:Gem::Version 
-  hash: 23
-  prerelease: false
-  segments: 
-  - 0
-  - 2
-  - 0
-  version: 0.2.0
+  prerelease: 
+  version: 0.3.0
 platform: ruby
 authors: 
 - Marcin Bunsch
@@ -15,35 +10,22 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-11-03 00:00:00 +01:00
+date: 2011-08-31 00:00:00 +02:00
 default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
-  type: :development
-  prerelease: false
-  name: bundler
-  version_requirements: &id001 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
-  requirement: *id001
+dependencies: []
+
 description: Pipejump API Ruby client
-email: marcin@pipejump.com
+email: marcin@futuresimple.com
 executables: []
 
 extensions: []
 
-extra_rdoc_files: 
-- LICENSE
-- README.rdoc
+extra_rdoc_files: []
+
 files: 
 - .document
 - .gitignore
+- .rspec
 - Gemfile
 - Gemfile.lock
 - LICENSE
@@ -57,28 +39,30 @@ files:
 - lib/pipejump/base/resource.rb
 - lib/pipejump/base/session.rb
 - lib/pipejump/resources/account.rb
-- lib/pipejump/resources/client.rb
 - lib/pipejump/resources/contact.rb
 - lib/pipejump/resources/deal.rb
 - lib/pipejump/resources/note.rb
 - lib/pipejump/resources/reminder.rb
 - lib/pipejump/resources/source.rb
+- lib/pipejump/version.rb
+- pipejump.gemspec
 - spec/connection.sample.yml
-- spec/pipejump/resources/client_spec.rb
+- spec/pipejump/resources/contact/note_spec.rb
+- spec/pipejump/resources/contact/reminder_spec.rb
 - spec/pipejump/resources/contact_spec.rb
+- spec/pipejump/resources/deal/note_spec.rb
+- spec/pipejump/resources/deal/reminder_spec.rb
 - spec/pipejump/resources/deal_spec.rb
-- spec/pipejump/resources/note_spec.rb
-- spec/pipejump/resources/reminder_spec.rb
 - spec/pipejump/resources/source_spec.rb
 - spec/pipejump/session_spec.rb
 - spec/spec_helper.rb
 has_rdoc: true
-homepage: http://github.com/pipejump/pipejump
+homepage: http://pipejump.com/api
 licenses: []
 
 post_install_message: 
-rdoc_options: 
-- --charset=UTF-8
+rdoc_options: []
+
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
@@ -86,32 +70,28 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
       version: "0"
 requirements: []
 
-rubyforge_project: 
-rubygems_version: 1.3.7
+rubyforge_project: pipejump
+rubygems_version: 1.6.2
 signing_key: 
 specification_version: 3
 summary: Pipejump API Ruby client
 test_files: 
-- spec/pipejump/resources/client_spec.rb
+- spec/connection.sample.yml
+- spec/pipejump/resources/contact/note_spec.rb
+- spec/pipejump/resources/contact/reminder_spec.rb
 - spec/pipejump/resources/contact_spec.rb
+- spec/pipejump/resources/deal/note_spec.rb
+- spec/pipejump/resources/deal/reminder_spec.rb
 - spec/pipejump/resources/deal_spec.rb
-- spec/pipejump/resources/note_spec.rb
-- spec/pipejump/resources/reminder_spec.rb
 - spec/pipejump/resources/source_spec.rb
 - spec/pipejump/session_spec.rb
 - spec/spec_helper.rb

data/lib/pipejump/resources/client.rb

@@ -1,162 +0,0 @@
-module Pipejump
-  
-
-  # The Client resource is represented by an instance of Pipejump::Client.
-  # 
-  # *Note*: To access any resources, you need a valid Session instance, referred to as @session in the following examples.
-  # 
-  # == Access
-  # 
-  # === Collection
-  # 
-  # To fetch a collection of Pipejump::Client instances, call
-  # 
-  # 
-  #      @session.clients 
-  #      # => #<Pipejump::Collection resource: Pipejump::Client>
-  # 
-  # 
-  # This returns a Pipejump::Collection instance. To retrieve an array of Pipejump::Client instances, call the _all_ method on the collection:
-  # 
-  # 
-  #      @session.clients.all 
-  #      # => [#<Pipejump::Client name: "My Client", id: "1">, #<Pipejump::Client name: "Another Client", id: "2">]
-  # 
-  # 
-  # Instead of _all_, you can also call a variety of Array methods in the collection which will be delegated to the array returned by _all_, such as:
-  # 
-  # * first
-  # * last
-  # * each
-  # * size
-  # * collect
-  # * reject
-  # 
-  # *Examples*:
-  # 
-  #      @session.clients.first 
-  #      # => #<Pipejump::Client name: "My Client", id: "1">
-  #      @session.clients.last 
-  #      # => #<Pipejump::Client name: "Another Client", id: "2">
-  #      @session.clients.size
-  #      # => 2
-  #      @session.clients.each { |client| puts client.name } 
-  #      # Prints out "My Client" and "Another Client"
-  #      @session.clients.collect { |client| client.name } 
-  #      # => ["My Client",  "Another Client"]
-  #      @session.clients.reject { |client| client.name == 'My Client' } 
-  #      # => ["My Client",  "Another Client"]
-  # 
-  # 
-  # === Resource
-  # 
-  # To fetch a single resource, call the _find_ method with the resource id as an argument:
-  # 
-  # 
-  #      @session.clients.find(1) 
-  #      # => #<Pipejump::Client name: "My Client", id: "1">
-  # 
-  # 
-  # == Creation
-  # 
-  # *Note*: Clients require the following fields in the hash of attributes:
-  # 
-  # * _name_: a valid name
-  # 
-  # To create a new client, call the _create_ method on the Client Pipejump::Collection with a hash of attributes as an argument:
-  # 
-  # 
-  #      @session.clients.create(:name => 'Third Client') 
-  #      # => #<Pipejump::Client name: "Third Client", id: "3">
-  # 
-  # 
-  # If the resource was created properly, it will be returned with a id assigned to it. You can check it by calling the created? method
-  # 
-  # 
-  #      client = @session.clients.create(:name => 'Third Client') 
-  #      # => #<Pipejump::Client name: "Third Client", id: "3">
-  #      client.created? 
-  #      # => true
-  #      client = @session.clients.create(:name => '') 
-  #      # => #<Pipejump::Client name: "">
-  #      client.created? 
-  #      # => false
-  # 
-  # 
-  # You can access validation/creation errors by calling the _errors_ method on the instance returned by _create_:
-  # 
-  # 
-  #      client = @session.clients.create(:name => '') 
-  #      # => #<Pipejump::Client name: "">
-  #      client.created? 
-  #      # => false
-  #      client.errors 
-  #      # => {"client"=>[{"error"=>{"code"=>"E0001", "field"=>"name", "description"=>"can't be blank"}}]}
-  # 
-  # 
-  # == Update
-  # 
-  # To update a resource, change the attributes and call the _save_ method.
-  # 
-  # === Changing attributes
-  # 
-  # Each attribute has an accessor which you can use to change the values:
-  # 
-  # 
-  #      client = @session.clients.create(:name => 'Third Client') 
-  #      # => #<Pipejump::Client name: "Third Client", id: "3">
-  #      client.name 
-  #      # => 'Third Client'
-  #      client.name = 'Super Client' 
-  #      # => 'Super Client'
-  #      client.name 
-  #      # => 'Super Client'
-  # 
-  # 
-  # === Saving
-  # 
-  # Once you've changed the attributes, call the _save_ method on the resource instance:
-  # 
-  # 
-  #      client = @session.clients.create(:name => 'Third Client') 
-  #      # => #<Pipejump::Client name: "Third Client", id: "3">
-  #      client.name 
-  #      # => 'Third Client'
-  #      client.save
-  #      # => true
-  # 
-  # 
-  # _save_ returns _true_ if save was successful and _false_ if it failed. In the latter scenario, you can access the errors via the _errors_ method:
-  # 
-  # 
-  #      client = @session.clients.create(:name => 'Third Client') 
-  #      # => #<Pipejump::Client name: "Third Client", id: "3">
-  #      client.name = 'Super Client'
-  #      # => 'Super Client'
-  #      client.save 
-  #      # => true
-  #      client.name = '' 
-  #      # => ''
-  #      client.save 
-  #      # => false
-  #      client.errors 
-  #      # => {"client"=>[{"error"=>{"code"=>"E0001", "field"=>"name", "description"=>"can't be blank"}}]}
-  # 
-  # 
-  # == Removal
-  # 
-  # To remove a resource, call the _destroy_ method on the instance:
-  # 
-  # 
-  #      client = @session.clients.find(1) 
-  #      #  => #<Pipejump::Client name: "My Client", id: "1">
-  #      client.destroy 
-  #      # => true
-  # 
-  class Client < Resource 
-    has_many :contacts do
-      disable :create
-    end
-  end
-  
-end