pipedrive_api_rb 1.0.2 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 34edb7a0733415f941f047f754e503941391529778f346b137323678351bd9e6
-  data.tar.gz: 8e3290131d2563f730692b2826cedcf34298a5948b460e8863360aade1573649
+  metadata.gz: f63dd4128df57e96da7b36e726860a8cc18c7dc0f67b1708db603df53a6a384b
+  data.tar.gz: 3a1b0dd17a9b38fd2a40a357ed0fc2f370530e269d089a4f0972bcc74b453e87
 SHA512:
-  metadata.gz: 6da6268e0be9b0a18d258e5c27459fcad9a6c1af77f1722a0d3d675e187eaaaff71bcf5410ea38f226b96d49e34aa047667fb3d74679b189c17ddf0ecf9f1986
-  data.tar.gz: 77f4d99a00e014a12a2462016e10728fa26358703dd482b4af3f63b9ec7ba021863ac3058e0f9ca2ed5ac448137c17fad72c0e6237a8f483a11965d6c78c28bf
+  metadata.gz: ba4868af19ca27937e82c57d6a49416087dc9d5700a6d8a4c6bfd62621e7cedcb33315c4c66b8c86e29b85b5f68a3171bff664a92bb691be15315d4ae9004c9c
+  data.tar.gz: 31c0608214ca10457af5be4cd9e5b32f8d2679269cc46d24efc4c5a9d197a87927c32c203449d64b15c7cf092b9d6a6eb90142db29586d6cc35a0ad2cd0562f0

data/.rubocop.yml

@@ -103,3 +103,7 @@ Performance/StringInclude:
   Enabled: true
 RSpec/ContextWording:
   Enabled: false
+RSpec/NamedSubject:
+  Enabled: false
+RSpec/SubjectStub:
+  Enabled: false

data/Gemfile

@@ -4,3 +4,11 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in pipedrive.gemspec
 gemspec
+
+gem 'bundler'
+gem 'rake'
+gem 'rspec'
+gem 'rubocop'
+gem 'rubocop-performance'
+gem 'rubocop-rspec'
+gem 'webmock'

data/lib/pipedrive/operations/read.rb

@@ -8,7 +8,7 @@ module Pipedrive
       include ::Pipedrive::Utils
 
       def each(params = {}, &block)
-        return to_enum(:each, params) unless block_given?
+        return to_enum(:each, params) unless block
 
         follow_pagination(:chunk, [], params, &block)
       end
@@ -24,7 +24,7 @@ module Pipedrive
         res
       end
 
-      def find_by_id(id)
+      def find(id)
         make_api_call(:get, id)
       end
     end

data/lib/pipedrive/organization.rb

@@ -8,13 +8,14 @@ module Pipedrive
     include ::Pipedrive::Operations::Delete
     include ::Pipedrive::Utils
 
-    def find_by_name(*args, &block)
+    def search(*args, &block)
       params = args.extract_options!
       params[:term] ||= args[0]
       raise 'term is missing' unless params[:term]
-      return to_enum(:find_by_name, params) unless block_given?
 
-      follow_pagination(:make_api_call, [:get, 'find'], params, &block)
+      return to_enum(:search, params) unless block
+
+      follow_pagination(:make_api_call, [:get, 'search'], params, &block)
     end
   end
 end

data/lib/pipedrive/person.rb

@@ -14,7 +14,8 @@ module Pipedrive
       raise 'term is missing' unless params[:term]
 
       params[:fields] ||= args[1]
-      return to_enum(:search, params) unless block_given?
+      params.delete :fields if params[:fields].blank?
+      return to_enum(:search, params) unless block
 
       follow_pagination(:make_api_call, [:get, 'search'], params, &block)
     end

data/lib/pipedrive/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Pipedrive
-  VERSION = '1.0.2'
+  VERSION = '1.0.5'
 end

data/lib/pipedrive.rb

@@ -2,6 +2,7 @@
 
 require 'logger'
 require 'active_support/core_ext/hash'
+require 'active_support/core_ext/array'
 require 'active_support/concern'
 require 'active_support/inflector'
 
@@ -41,7 +42,7 @@ module Pipedrive
   reset!
 end
 
-require 'pipedrive/railties' if defined?(::Rails)
+require 'pipedrive/railties' if defined?(Rails)
 
 # Core
 require 'pipedrive/base'

data/pipedrive.gemspec

@@ -16,7 +16,6 @@ Gem::Specification.new do |gem|
 
   gem.files         = `git ls-files -z`.split("\x0")
   gem.executables   = gem.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ['lib']
   gem.required_ruby_version = '>=2.5'
 
@@ -24,11 +23,5 @@ Gem::Specification.new do |gem|
   gem.add_dependency('faraday')
   gem.add_dependency('faraday-mashify')
   gem.add_dependency('hashie', '>= 3.0')
-  gem.add_development_dependency('bundler')
-  gem.add_development_dependency('rake', '> 12')
-  gem.add_development_dependency('rspec', '>= 3.0')
-  gem.add_development_dependency('rubocop')
-  gem.add_development_dependency('rubocop-performance')
-  gem.add_development_dependency('rubocop-rspec')
-  gem.add_development_dependency('webmock')
+  gem.metadata['rubygems_mfa_required'] = 'true'
 end

data/spec/lib/pipedrive/activity_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe ::Pipedrive::Activity do
+RSpec.describe Pipedrive::Activity do
   subject { described_class.new('token') }
 
   describe '#entity_name' do

data/spec/lib/pipedrive/activity_type_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe ::Pipedrive::ActivityType do
+RSpec.describe Pipedrive::ActivityType do
   subject { described_class.new('token') }
 
   describe '#entity_name' do

data/spec/lib/pipedrive/base_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe ::Pipedrive::Base do
+RSpec.describe Pipedrive::Base do
   subject { described_class.new('token') }
 
   describe '#entity_name' do
@@ -16,32 +16,32 @@ RSpec.describe ::Pipedrive::Base do
 
     it {
       expect(subject).to eq({
-        url:     'https://api.pipedrive.com',
-        headers: { accept: 'application/json', content_type: "application/json", user_agent: 'Pipedrive Ruby Client v0.3.0' }
-        })
-      }
-    end
+                              url:     'https://api.pipedrive.com',
+        headers: { accept: 'application/json', content_type: 'application/json', user_agent: "Pipedrive Ruby Client v#{Pipedrive::VERSION}" }
+                            })
+    }
+  end
 
   context '::connection' do
     subject { super().connection }
 
-    it { is_expected.to be_kind_of(::Faraday::Connection) }
+    it { is_expected.to be_a(Faraday::Connection) }
   end
 
   describe '#failed_response' do
     subject { super().failed_response(res) }
 
-    let(:res) { double('res', body: ::Hashie::Mash.new({}), status: status) }
+    let(:res) { double('res', body: Hashie::Mash.new({}), status: status) }
 
     context 'status is 401' do
       let(:status) { 401 }
 
       it {
-        expect(subject).to eq(::Hashie::Mash.new({
-                                                   failed:         false,
+        expect(subject).to eq(Hashie::Mash.new({
+                                                 failed:         false,
                                                   not_authorized: true,
                                                   success:        false
-                                                 }))
+                                               }))
       }
     end
 
@@ -49,11 +49,11 @@ RSpec.describe ::Pipedrive::Base do
       let(:status) { 420 }
 
       it {
-        expect(subject).to eq(::Hashie::Mash.new({
-                                                   failed:         true,
+        expect(subject).to eq(Hashie::Mash.new({
+                                                 failed:         true,
                                                   not_authorized: false,
                                                   success:        false
-                                                 }))
+                                               }))
       }
     end
 
@@ -61,11 +61,11 @@ RSpec.describe ::Pipedrive::Base do
       let(:status) { 400 }
 
       it {
-        expect(subject).to eq(::Hashie::Mash.new({
-                                                   failed:         false,
+        expect(subject).to eq(Hashie::Mash.new({
+                                                 failed:         false,
                                                   not_authorized: false,
                                                   success:        false
-                                                 }))
+                                               }))
       }
     end
   end
@@ -78,32 +78,32 @@ RSpec.describe ::Pipedrive::Base do
     context 'without id' do
       it 'calls :get' do
         stub_request(:get, 'https://api.pipedrive.com/v1/bases?api_token=token').to_return(status: 200, body: {}.to_json, headers: {})
-        expect_any_instance_of(::Faraday::Connection).to receive(:get).with('/v1/bases?api_token=token', {}).and_call_original
+        expect_any_instance_of(Faraday::Connection).to have_received(:get).with('/v1/bases?api_token=token', {}).and_call_original
         expect(subject.make_api_call(:get))
       end
 
       it 'calls :post' do
         stub_request(:post, 'https://api.pipedrive.com/v1/bases?api_token=token').to_return(status: 200, body: {}.to_json, headers: {})
-        expect_any_instance_of(::Faraday::Connection).to receive(:post).with('/v1/bases?api_token=token', { test: 'bar' }.to_json).and_call_original
+        expect_any_instance_of(Faraday::Connection).to have_received(:post).with('/v1/bases?api_token=token', { test: 'bar' }.to_json).and_call_original
         expect(subject.make_api_call(:post, test: 'bar'))
       end
 
       it 'calls :put' do
         stub_request(:put, 'https://api.pipedrive.com/v1/bases?api_token=token').to_return(status: 200, body: {}.to_json, headers: {})
-        expect_any_instance_of(::Faraday::Connection).to receive(:put).with('/v1/bases?api_token=token', { test: 'bar' }.to_json).and_call_original
+        expect_any_instance_of(Faraday::Connection).to have_received(:put).with('/v1/bases?api_token=token', { test: 'bar' }.to_json).and_call_original
         expect(subject.make_api_call(:put, test: 'bar'))
       end
 
       it 'uses field_selector properly' do
         stub_request(:get, 'https://api.pipedrive.com/v1/bases:(a,b,c)?api_token=token').to_return(status: 200, body: {}.to_json, headers: {})
-        expect_any_instance_of(::Faraday::Connection).to receive(:get)
+        expect_any_instance_of(Faraday::Connection).to have_received(:get)
           .with('/v1/bases:(a,b,c)?api_token=token', {}).and_call_original
         expect(subject.make_api_call(:get, fields_to_select: %w[a b c]))
       end
 
       it 'does not use field_selector if it empty' do
         stub_request(:get, 'https://api.pipedrive.com/v1/bases?api_token=token').to_return(status: 200, body: {}.to_json, headers: {})
-        expect_any_instance_of(::Faraday::Connection).to receive(:get)
+        expect_any_instance_of(Faraday::Connection).to have_received(:get)
           .with('/v1/bases?api_token=token', {}).and_call_original
         expect(subject.make_api_call(:get, fields_to_select: []))
       end
@@ -111,10 +111,10 @@ RSpec.describe ::Pipedrive::Base do
       it 'retries if Errno::ETIMEDOUT' do
         stub_request(:get, 'https://api.pipedrive.com/v1/bases?api_token=token').to_return(status: 200, body: {}.to_json, headers: {})
         connection = subject.connection
-        allow(subject).to receive(:connection).and_return(connection)
-        allow(connection).to receive(:get)
+        allow(subject).to have_received(:connection).and_return(connection)
+        allow(connection).to have_received(:get)
           .with('/v1/bases?api_token=token', {}).and_raise(Errno::ETIMEDOUT)
-        expect(connection).to receive(:get)
+        expect(connection).to have_received(:get)
           .with('/v1/bases?api_token=token', {}).and_call_original
         expect(subject.make_api_call(:get, fields_to_select: []))
       end
@@ -123,32 +123,32 @@ RSpec.describe ::Pipedrive::Base do
     context 'with id' do
       it 'calls :get' do
         stub_request(:get, 'https://api.pipedrive.com/v1/bases/12?api_token=token').to_return(status: 200, body: {}.to_json, headers: {})
-        expect_any_instance_of(::Faraday::Connection).to receive(:get).with('/v1/bases/12?api_token=token', {}).and_call_original
+        expect_any_instance_of(Faraday::Connection).to have_received(:get).with('/v1/bases/12?api_token=token', {}).and_call_original
         expect(subject.make_api_call(:get, 12))
       end
 
       it 'calls :post' do
         stub_request(:post, 'https://api.pipedrive.com/v1/bases/13?api_token=token').to_return(status: 200, body: {}.to_json, headers: {})
-        expect_any_instance_of(::Faraday::Connection).to receive(:post).with('/v1/bases/13?api_token=token', { test: 'bar' }.to_json).and_call_original
+        expect_any_instance_of(Faraday::Connection).to have_received(:post).with('/v1/bases/13?api_token=token', { test: 'bar' }.to_json).and_call_original
         expect(subject.make_api_call(:post, 13, test: 'bar'))
       end
 
       it 'calls :put' do
         stub_request(:put, 'https://api.pipedrive.com/v1/bases/14?api_token=token').to_return(status: 200, body: {}.to_json, headers: {})
-        expect_any_instance_of(::Faraday::Connection).to receive(:put).with('/v1/bases/14?api_token=token', { test: 'bar' }.to_json).and_call_original
+        expect_any_instance_of(Faraday::Connection).to have_received(:put).with('/v1/bases/14?api_token=token', { test: 'bar' }.to_json).and_call_original
         expect(subject.make_api_call(:put, 14, test: 'bar'))
       end
     end
 
     it 'calls Hashie::Mash if return empty string' do
       stub_request(:get, 'https://api.pipedrive.com/v1/bases?api_token=token').to_return(status: 200, body: '', headers: {})
-      expect(::Hashie::Mash).to receive(:new).with(success: true).and_call_original
+      expect(Hashie::Mash).to have_received(:new).with(success: true).and_call_original
       expect(subject.make_api_call(:get))
     end
 
     it 'calls #failed_response if failed status' do
       stub_request(:get, 'https://api.pipedrive.com/v1/bases?api_token=token').to_return(status: 400, body: '', headers: {})
-      expect(subject).to receive(:failed_response)
+      expect(subject).to have_received(:failed_response)
       expect(subject.make_api_call(:get))
     end
   end

data/spec/lib/pipedrive/deal_field_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe ::Pipedrive::DealField do
+RSpec.describe Pipedrive::DealField do
   subject { described_class.new('token') }
 
   describe '#entity_name' do

data/spec/lib/pipedrive/deal_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe ::Pipedrive::Deal do
+RSpec.describe Pipedrive::Deal do
   subject { described_class.new('token') }
 
   describe '#entity_name' do

data/spec/lib/pipedrive/file_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe ::Pipedrive::File do
+RSpec.describe Pipedrive::File do
   subject { described_class.new('token') }
 
   describe '#entity_name' do

data/spec/lib/pipedrive/filter_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe ::Pipedrive::Filter do
+RSpec.describe Pipedrive::Filter do
   subject { described_class.new('token') }
 
   describe '#entity_name' do

data/spec/lib/pipedrive/goal_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe ::Pipedrive::Goal do
+RSpec.describe Pipedrive::Goal do
   subject { described_class.new('token') }
 
   describe '#entity_name' do

data/spec/lib/pipedrive/lead_label_spec.rb

@@ -1,9 +1,11 @@
 require 'spec_helper'
 
-RSpec.describe ::Pipedrive::LeadLabel do
+RSpec.describe Pipedrive::LeadLabel do
   subject { described_class.new('token') }
-  context '#entity_name' do
+
+  describe '#entity_name' do
     subject { super().entity_name }
+
     it { is_expected.to eq('leadLabels') }
   end
 end

data/spec/lib/pipedrive/lead_spec.rb

@@ -1,9 +1,11 @@
 require 'spec_helper'
 
-RSpec.describe ::Pipedrive::Lead do
+RSpec.describe Pipedrive::Lead do
   subject { described_class.new('token') }
-  context '#entity_name' do
+
+  describe '#entity_name' do
     subject { super().entity_name }
+
     it { is_expected.to eq('leads') }
   end
 end

data/spec/lib/pipedrive/note_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe ::Pipedrive::Note do
+RSpec.describe Pipedrive::Note do
   subject { described_class.new('token') }
 
   describe '#entity_name' do

data/spec/lib/pipedrive/operations/create_spec.rb

@@ -2,16 +2,16 @@
 
 require 'spec_helper'
 
-RSpec.describe ::Pipedrive::Operations::Create do
+RSpec.describe Pipedrive::Operations::Create do
   subject do
-    Class.new(::Pipedrive::Base) do
-      include ::Pipedrive::Operations::Create
+    Class.new(Pipedrive::Base) do
+      include Pipedrive::Operations::Create
     end.new('token')
   end
 
   describe '#create' do
     it 'calls #make_api_call' do
-      expect(subject).to receive(:make_api_call).with(:post, { foo: 'bar' })
+      expect(subject).to have_received(:make_api_call).with(:post, { foo: 'bar' })
       subject.create(foo: 'bar')
     end
   end

data/spec/lib/pipedrive/operations/delete_spec.rb

@@ -2,23 +2,23 @@
 
 require 'spec_helper'
 
-RSpec.describe ::Pipedrive::Operations::Delete do
+RSpec.describe Pipedrive::Operations::Delete do
   subject do
-    Class.new(::Pipedrive::Base) do
-      include ::Pipedrive::Operations::Delete
+    Class.new(Pipedrive::Base) do
+      include Pipedrive::Operations::Delete
     end.new('token')
   end
 
   describe '#delete' do
     it 'calls #make_api_call' do
-      expect(subject).to receive(:make_api_call).with(:delete, 12)
+      expect(subject).to have_received(:make_api_call).with(:delete, 12)
       subject.delete(12)
     end
   end
 
   describe '#delete_all' do
     it 'calls #make_api_call' do
-      expect(subject).to receive(:make_api_call).with(:delete)
+      expect(subject).to have_received(:make_api_call).with(:delete)
       subject.delete_all
     end
   end

data/spec/lib/pipedrive/operations/read_spec.rb

@@ -2,16 +2,16 @@
 
 require 'spec_helper'
 
-RSpec.describe ::Pipedrive::Operations::Read do
+RSpec.describe Pipedrive::Operations::Read do
   subject do
-    Class.new(::Pipedrive::Base) do
-      include ::Pipedrive::Operations::Read
+    Class.new(Pipedrive::Base) do
+      include Pipedrive::Operations::Read
     end.new('token')
   end
 
   describe '#find_by_id' do
     it 'calls #make_api_call' do
-      expect(subject).to receive(:make_api_call).with(:get, 12)
+      expect(subject).to have_received(:make_api_call).with(:get, 12)
       subject.find_by_id(12)
     end
   end
@@ -22,32 +22,32 @@ RSpec.describe ::Pipedrive::Operations::Read do
     end
 
     it 'returns Enumerator if no block given' do
-      expect(subject.each).to be_a(::Enumerator)
+      expect(subject.each).to be_a(Enumerator)
     end
 
     it 'calls to_enum with params' do
-      expect(subject).to receive(:to_enum).with(:each, { foo: 'bar' })
+      expect(subject).to have_received(:to_enum).with(:each, { foo: 'bar' })
       subject.each(foo: 'bar')
     end
 
     it 'yields data' do
-      expect(subject).to receive(:chunk).and_return(::Hashie::Mash.new(data: [1, 2], success: true))
+      expect(subject).to have_received(:chunk).and_return(Hashie::Mash.new(data: [1, 2], success: true))
       expect { |b| subject.each(&b) }.to yield_successive_args(1, 2)
     end
 
     it 'follows pagination' do
-      expect(subject).to receive(:chunk).with(start: 0).and_return(::Hashie::Mash.new(data: [1, 2], success: true, additional_data: additional_data))
-      expect(subject).to receive(:chunk).with(start: 10).and_return(::Hashie::Mash.new(data: [3, 4], success: true))
+      expect(subject).to have_received(:chunk).with({ start: 0 }).and_return(Hashie::Mash.new(data: [1, 2], success: true, additional_data: additional_data))
+      expect(subject).to have_received(:chunk).with({ start: 10 }).and_return(Hashie::Mash.new(data: [3, 4], success: true))
       expect { |b| subject.each(&b) }.to yield_successive_args(1, 2, 3, 4)
     end
 
     it 'does not yield anything if result is empty' do
-      expect(subject).to receive(:chunk).with(start: 0).and_return(::Hashie::Mash.new(success: true))
+      expect(subject).to have_received(:chunk).with({ start: 0 }).and_return(Hashie::Mash.new(success: true))
       expect { |b| subject.each(&b) }.to yield_successive_args
     end
 
     it 'does not yield anything if result is not success' do
-      expect(subject).to receive(:chunk).with(start: 0).and_return(::Hashie::Mash.new(success: false))
+      expect(subject).to have_received(:chunk).with({ start: 0 }).and_return(Hashie::Mash.new(success: false))
       expect { |b| subject.each(&b) }.to yield_successive_args
     end
   end
@@ -55,8 +55,8 @@ RSpec.describe ::Pipedrive::Operations::Read do
   describe '#all' do
     it 'calls #each' do
       arr = double('enumerator')
-      allow(arr).to receive(:to_a)
-      expect(subject).to receive(:each).and_return(arr)
+      allow(arr).to have_received(:to_a)
+      expect(subject).to have_received(:each).and_return(arr)
       subject.all
     end
   end
@@ -64,13 +64,13 @@ RSpec.describe ::Pipedrive::Operations::Read do
   describe '#chunk' do
     it 'returns []' do
       res = double('res', success?: false)
-      expect(subject).to receive(:make_api_call).with(:get, {}).and_return(res)
+      expect(subject).to have_received(:make_api_call).with(:get, {}).and_return(res)
       expect(subject.chunk).to eq([])
     end
 
     it 'returns result' do
       res = double('res', success?: true)
-      expect(subject).to receive(:make_api_call).with(:get, {}).and_return(res)
+      expect(subject).to have_received(:make_api_call).with(:get, {}).and_return(res)
       expect(subject.chunk).to eq(res)
     end
   end

data/spec/lib/pipedrive/operations/update_spec.rb

@@ -2,21 +2,21 @@
 
 require 'spec_helper'
 
-RSpec.describe ::Pipedrive::Operations::Update do
+RSpec.describe Pipedrive::Operations::Update do
   subject do
-    Class.new(::Pipedrive::Base) do
-      include ::Pipedrive::Operations::Update
+    Class.new(Pipedrive::Base) do
+      include Pipedrive::Operations::Update
     end.new('token')
   end
 
   describe '#create' do
     it 'calls #make_api_call' do
-      expect(subject).to receive(:make_api_call).with(:put, 12, { foo: 'bar' })
+      expect(subject).to have_received(:make_api_call).with(:put, 12, { foo: 'bar' })
       subject.update(12, foo: 'bar')
     end
 
     it 'calls #make_api_call with id in params' do
-      expect(subject).to receive(:make_api_call).with(:put, 14, { foo: 'bar' })
+      expect(subject).to have_received(:make_api_call).with(:put, 14, { foo: 'bar' })
       subject.update(foo: 'bar', id: 14)
     end
   end

data/spec/lib/pipedrive/organization_field_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe ::Pipedrive::OrganizationField do
+RSpec.describe Pipedrive::OrganizationField do
   subject { described_class.new('token') }
 
   describe '#entity_name' do

data/spec/lib/pipedrive/{ogranization_spec.rb → organization_spec.rb}

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe ::Pipedrive::Organization do
+RSpec.describe Pipedrive::Organization do
   subject { described_class.new('token') }
 
   describe '#entity_name' do

data/spec/lib/pipedrive/person_field_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe ::Pipedrive::PersonField do
+RSpec.describe Pipedrive::PersonField do
   subject { described_class.new('token') }
 
   describe '#entity_name' do

data/spec/lib/pipedrive/person_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe ::Pipedrive::Person do
+RSpec.describe Pipedrive::Person do
   subject { described_class.new('token') }
 
   describe '#entity_name' do
@@ -13,18 +13,18 @@ RSpec.describe ::Pipedrive::Person do
 
   describe '#search' do
     it 'calls #make_api_call with term' do
-      expect(subject).to receive(:make_api_call).with(:get, 'search', { term: 'term', fields: nil})
+      expect(subject).to have_received(:make_api_call).with(:get, 'search', { term: 'term', start: 0 })
       expect { |b| subject.search('term', &b) }.to yield_successive_args
     end
 
     it 'calls #make_api_call with term and search_by_email' do
-      expect(subject).to receive(:make_api_call).with(:get, 'search', { term: 'term', fields: "email" })
-      expect { |b| subject.search('term', "email", &b) }.to yield_successive_args
+      expect(subject).to have_received(:make_api_call).with(:get, 'search', { term: 'term', fields: 'email', start: 0 })
+      expect { |b| subject.search('term', 'email', &b) }.to yield_successive_args
     end
 
     it 'yields results' do
-      expect(subject).to receive(:make_api_call).with(:get, 'search', { term: 'term', fields: nil, start: 0 }).
-        and_return(::Hashie::Mash.new(data: [1, 2], success: true))
+      expect(subject).to have_received(:make_api_call).with(:get, 'search', { term: 'term', start: 0 })
+                                                      .and_return(Hashie::Mash.new(data: [1, 2], success: true))
       expect { |b| subject.search('term', &b) }.to yield_successive_args(1, 2)
     end
   end

data/spec/lib/pipedrive/product_field_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe ::Pipedrive::ProductField do
+RSpec.describe Pipedrive::ProductField do
   subject { described_class.new('token') }
 
   describe '#entity_name' do

data/spec/lib/pipedrive/product_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe ::Pipedrive::Product do
+RSpec.describe Pipedrive::Product do
   subject { described_class.new('token') }
 
   describe '#entity_name' do

data/spec/lib/pipedrive_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe ::Pipedrive do
+RSpec.describe Pipedrive do
   subject { described_class }
 
   before do
@@ -13,7 +13,7 @@ RSpec.describe ::Pipedrive do
     describe '#user_agent' do
       subject { super().user_agent }
 
-      it { is_expected.to eq("Pipedrive Ruby Client v#{::Pipedrive::VERSION}") }
+      it { is_expected.to eq("Pipedrive Ruby Client v#{Pipedrive::VERSION}") }
     end
 
     describe '#api_token' do
@@ -25,7 +25,7 @@ RSpec.describe ::Pipedrive do
     describe '#logger' do
       subject { super().logger }
 
-      it { is_expected.to be_kind_of(::Logger) }
+      it { is_expected.to be_a(Logger) }
     end
   end
 
@@ -41,7 +41,7 @@ RSpec.describe ::Pipedrive do
       end
 
       it 'sets logger' do
-        newlogger = ::Logger.new($stderr)
+        newlogger = Logger.new($stderr)
         client.setup do |c|
           c.logger = newlogger
         end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pipedrive_api_rb
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.5
 platform: ruby
 authors:
 - Jan Sterba
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-01-30 00:00:00.000000000 Z
+date: 2023-01-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -67,104 +67,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">"
-      - !ruby/object:Gem::Version
-        version: '12'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">"
-      - !ruby/object:Gem::Version
-        version: '12'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop-performance
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: webmock
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Pipedrive.com API Wrapper
 email:
 - info@jansterba.com
@@ -225,12 +127,12 @@ files:
 - spec/lib/pipedrive/lead_label_spec.rb
 - spec/lib/pipedrive/lead_spec.rb
 - spec/lib/pipedrive/note_spec.rb
-- spec/lib/pipedrive/ogranization_spec.rb
 - spec/lib/pipedrive/operations/create_spec.rb
 - spec/lib/pipedrive/operations/delete_spec.rb
 - spec/lib/pipedrive/operations/read_spec.rb
 - spec/lib/pipedrive/operations/update_spec.rb
 - spec/lib/pipedrive/organization_field_spec.rb
+- spec/lib/pipedrive/organization_spec.rb
 - spec/lib/pipedrive/person_field_spec.rb
 - spec/lib/pipedrive/person_spec.rb
 - spec/lib/pipedrive/product_field_spec.rb
@@ -240,7 +142,8 @@ files:
 homepage: https://github.com/honzasterba/pipedrive_api_rb
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -260,27 +163,4 @@ rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: Pipedrive.com API Wrapper
-test_files:
-- spec/lib/pipedrive/activity_spec.rb
-- spec/lib/pipedrive/activity_type_spec.rb
-- spec/lib/pipedrive/base_spec.rb
-- spec/lib/pipedrive/deal_field_spec.rb
-- spec/lib/pipedrive/deal_spec.rb
-- spec/lib/pipedrive/file_spec.rb
-- spec/lib/pipedrive/filter_spec.rb
-- spec/lib/pipedrive/goal_spec.rb
-- spec/lib/pipedrive/lead_label_spec.rb
-- spec/lib/pipedrive/lead_spec.rb
-- spec/lib/pipedrive/note_spec.rb
-- spec/lib/pipedrive/ogranization_spec.rb
-- spec/lib/pipedrive/operations/create_spec.rb
-- spec/lib/pipedrive/operations/delete_spec.rb
-- spec/lib/pipedrive/operations/read_spec.rb
-- spec/lib/pipedrive/operations/update_spec.rb
-- spec/lib/pipedrive/organization_field_spec.rb
-- spec/lib/pipedrive/person_field_spec.rb
-- spec/lib/pipedrive/person_spec.rb
-- spec/lib/pipedrive/product_field_spec.rb
-- spec/lib/pipedrive/product_spec.rb
-- spec/lib/pipedrive_spec.rb
-- spec/spec_helper.rb
+test_files: []