pipedrive.rb 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 174f47371cadbd8c2b38b1df1b578b4b2a51d26047e0cd276a6cd775e2269b84
-  data.tar.gz: '0887f64ee16bea1c672d666b6b6039e907b0494de309f017e6e9aedaff75cf9b'
+  metadata.gz: f7e40f6c74545bc03a4ff8c6d21ebbd6cecebbc4dd7ac7d850762282e1934ea9
+  data.tar.gz: 6803a9949ee5045b78b21b1fd26839070606745e7fe72e3b3e6f3cf968967c51
 SHA512:
-  metadata.gz: d1c4295874a4652eda241e363bebc5f5efe7b877f8a124d066febef50616ae580b50ef29c21cb05d684c4ceabad4988f8d8ea974f3c5de0a2916c73aa6e094d4
-  data.tar.gz: 830f1e1829b68811fcb0dd73369a44e015e6a2844b073928b2456c5799b9f224cf0dafc26ddbe587db07bbdeddb027f2d2d5965399d7d93b43ccb8c5dccff58d
+  metadata.gz: 990a3812062360039f8b50d2a5e295a6839f9c28ec0220f4675c8ff560f7b26b9430ca7a1cbaf802115667344fdb038047fb5c8d433323e302e2a129c9d7004c
+  data.tar.gz: 1e4c52a0bfc631c21675efc1560ebdc400ae06f48e9b224043bd7dd28f6e0bd5818ca7e41d5e62f0862cdba8f879cbacb23bf0a5235088980f8537390a2608dc

data/.rubocop.yml

@@ -1,17 +1,105 @@
+require:
+  - rubocop/cop/internal_affairs
+  - rubocop-performance
+  - rubocop-rspec
 AllCops:
-  Include:
-    - '**/Rakefile'
+  NewCops: enable
   Exclude:
-    - 'spec/**/*'
-Metrics/LineLength:
-  Max: 99
-Naming/FileName:
+    - "bin/*"
+    - "vendor/**/*"
+    - "Rakefile"
+    - "tmp/**/*"
+    - ".git/**/*"
+  TargetRubyVersion: 2.5
+Style/Documentation:
+  Enabled: false
+Layout/LineLength:
+  Max: 1000
+Metrics/MethodLength:
+  Max: 250
+Metrics/ClassLength:
+  Max: 1000
+Metrics/AbcSize:
+  Max: 250
+Metrics/BlockLength:
+  Max: 1500
+Metrics/CyclomaticComplexity:
+  Max: 50
+Metrics/PerceivedComplexity:
+  Max: 50
+Style/ClassAndModuleChildren:
   Enabled: false
 Style/ModuleFunction:
   Enabled: false
-Style/Encoding:
+Style/ParallelAssignment:
   Enabled: false
-Documentation:
+Style/SymbolProc:
+  Enabled: false
+Layout/HashAlignment:
+  Enabled: false
+Metrics/BlockNesting:
+  Enabled: false
+Lint/NonLocalExitFromIterator:
+  Enabled: false
+Style/HashEachMethods:
+  Enabled: true
+Style/HashTransformKeys:
+  Enabled: true
+Style/HashTransformValues:
+  Enabled: true
+Style/AndOr:
+  Enabled: false
+RSpec/ExampleLength:
+  Enabled: false
+RSpec/MultipleExpectations:
+  Enabled: false
+RSpec/DescribeClass:
+  Enabled: false
+Style/IfInsideElse:
+  Enabled: false
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+Lint/RaiseException:
+  Enabled: true
+Lint/StructNewOverride:
+  Enabled: true
+Style/ExponentialNotation:
+  Enabled: false
+Style/RedundantFetchBlock:
+  Enabled: true
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+Style/RedundantRegexpEscape:
+  Enabled: true
+Style/SlicingWithRange:
+  Enabled: true
+Style/AccessorGrouping:
+  Enabled: true
+Style/BisectedAttrAccessor:
+  Enabled: true
+Style/RedundantAssignment:
+  Enabled: true
+Performance/AncestorsInclude:
+  Enabled: true
+Performance/BigDecimalWithNumericArgument:
+  Enabled: true
+Performance/RedundantSortBlock:
+  Enabled: true
+Performance/RedundantStringChars:
+  Enabled: true
+Performance/ReverseFirst:
+  Enabled: true
+Performance/SortReverse:
+  Enabled: true
+Performance/Squeeze:
+  Enabled: true
+Performance/StringInclude:
+  Enabled: true
+RSpec/ContextWording:
   Enabled: false
-Metrics/MethodLength:
-  Max: 15

data/.travis.yml

@@ -2,19 +2,16 @@ language: ruby
 rvm:
   - ruby-head
   - jruby-19mode
-  - rbx-2
-  - 2.1.10
-  - 2.2.10
-  - 2.3.8
-  - 2.4.6
-  - 2.5.5
   - 2.6.3
+  - 2.7.2
+
+jdk:
+  - openjdk8
 
 matrix:
   allow_failures:
     - rvm: ruby-head
     - rvm: jruby-19mode
-    - rvm: rbx-2
 
 bundler_args: --without local_development
 

data/Gemfile

@@ -1,17 +1,15 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in pipedrive.gemspec
 gemspec
 
 group :test do
-  gem 'simplecov', '>= 0.9.0', :require => false
-  gem 'coveralls', :require => false
+  gem 'coveralls', require: false
+  gem 'simplecov', require: false
 end
 
 group :local_development do
-  gem 'terminal-notifier-guard', require: false if RUBY_PLATFORM.downcase.include?('darwin')
-  gem 'guard-rspec', '>= 4.3.1' ,require: false
-  gem 'guard-bundler', require: false
-  gem 'guard-rubocop', require: false
   gem 'pry'
 end

data/HISTORY.md

@@ -0,0 +1,43 @@
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+## [v0.3.0](https://github.com/amoniacou/pipedrive.rb/compare/v0.2.0...v0.3.0) - 2020-10-10
+
+### Merged
+
+- add User endpoints [`#15`](https://github.com/amoniacou/pipedrive.rb/pull/15)
+- add pipeline endpoints [`#17`](https://github.com/amoniacou/pipedrive.rb/pull/17)
+- add pipeline endpoints [`#2`](https://github.com/amoniacou/pipedrive.rb/pull/2)
+
+### Commits
+
+- Small code improvements [`fb28bb4`](https://github.com/amoniacou/pipedrive.rb/commit/fb28bb4ed3d86c15a4f2a95247e13393d598aad1)
+- Fix specs [`e772b83`](https://github.com/amoniacou/pipedrive.rb/commit/e772b837c61150b574ef3f6c95b495e1f2dfda9a)
+- Update .travis.yml [`873cea4`](https://github.com/amoniacou/pipedrive.rb/commit/873cea4cfd82806ef71f62a3db823322b168f964)
+
+## [v0.2.0](https://github.com/amoniacou/pipedrive.rb/compare/v0.1.0...v0.2.0) - 2020-01-14
+
+### Merged
+
+- Inflection fix for persons [`#9`](https://github.com/amoniacou/pipedrive.rb/pull/9)
+- Move adapter setup to the last line in defining connection [`#7`](https://github.com/amoniacou/pipedrive.rb/pull/7)
+- Replace find by find_by_id in the docs [`#5`](https://github.com/amoniacou/pipedrive.rb/pull/5)
+- Find by name organisation && update personfields [`#3`](https://github.com/amoniacou/pipedrive.rb/pull/3)
+
+### Commits
+
+- Remove problematic reek and cane [`bf8535c`](https://github.com/amoniacou/pipedrive.rb/commit/bf8535c10d0894fb508828a43aefb036b000c263)
+- Fix tests [`bca6171`](https://github.com/amoniacou/pipedrive.rb/commit/bca6171ae43068bd671bf6b8ecf924a7e2ad1af3)
+- Fix outdated rubocop, contrain on rake to pass reek [`e799cbc`](https://github.com/amoniacou/pipedrive.rb/commit/e799cbca4eada29582e6c5a1e20e8f97ed709713)
+
+## v0.1.0 - 2014-10-16
+
+### Commits
+
+- Initial commit [`cbd2138`](https://github.com/amoniacou/pipedrive.rb/commit/cbd2138ae11a19f4a398af3c25fac8ed2e6a0e1b)
+- Test coverage and small refactoring [`ca0577f`](https://github.com/amoniacou/pipedrive.rb/commit/ca0577fef23f59515cb58ea152e10d3130f26730)
+- Add more entities basic support. Add support for field selector [`73b47a4`](https://github.com/amoniacou/pipedrive.rb/commit/73b47a4455b1c50906bbc811bddac7d979fae966)

data/Rakefile

@@ -1,9 +1,12 @@
 # frozen_string_literal: true
 
 require 'bundler/gem_tasks'
-require 'rspec/core/rake_task'
 
-RSpec::Core::RakeTask.new(:spec)
+begin
+  require 'rspec/core/rake_task'
+  RSpec::Core::RakeTask.new(:spec)
+rescue LoadError
+end
 
 # rubocop
 require 'rubocop/rake_task'

data/lib/pipedrive.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'logger'
 require 'active_support/core_ext/hash'
 require 'active_support/concern'
@@ -33,7 +35,7 @@ module Pipedrive
   end
 
   def logger
-    @logger ||= Logger.new(STDOUT)
+    @logger ||= Logger.new($stdout)
   end
 
   reset!
@@ -86,3 +88,9 @@ require 'pipedrive/file'
 
 # Notes
 require 'pipedrive/note'
+
+# Users
+require 'pipedrive/user'
+
+# Pipelines
+require 'pipedrive/pipeline'

data/lib/pipedrive/activity.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Pipedrive
   class Activity < Base
     include ::Pipedrive::Operations::Create

data/lib/pipedrive/activity_type.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Pipedrive
   class ActivityType < Base
     include ::Pipedrive::Operations::Create

data/lib/pipedrive/base.rb

@@ -1,7 +1,10 @@
+# frozen_string_literal: true
+
 module Pipedrive
   class Base
     def initialize(api_token = ::Pipedrive.api_token)
-      fail 'api_token should be set' unless api_token.present?
+      raise 'api_token should be set' unless api_token.present?
+
       @api_token = api_token
     end
 
@@ -12,7 +15,8 @@ module Pipedrive
     def make_api_call(*args)
       params = args.extract_options!
       method = args[0]
-      fail 'method param missing' unless method.present?
+      raise 'method param missing' unless method.present?
+
       url = build_url(args, params.delete(:fields_to_select))
       begin
         res = connection.__send__(method.to_sym, url, params)
@@ -26,11 +30,9 @@ module Pipedrive
     end
 
     def build_url(args, fields_to_select = nil)
-      url = "/v1/#{entity_name}"
+      url = +"/v1/#{entity_name}"
       url << "/#{args[1]}" if args[1]
-      if fields_to_select.is_a?(::Array) && fields_to_select.size > 0
-        url << ":(#{fields_to_select.join(',')})"
-      end
+      url << ":(#{fields_to_select.join(',')})" if fields_to_select.is_a?(::Array) && fields_to_select.size.positive?
       url << "?api_token=#{@api_token}"
       url
     end
@@ -52,16 +54,16 @@ module Pipedrive
                                   failed: false)
       case res.status
       when 401
-        failed_res.merge! not_authorized: true
+        failed_res[:not_authorized] = true
       when 420
-        failed_res.merge! failed: true
+        failed_res[:failed] = true
       end
       failed_res
     end
 
     def entity_name
-      class_name = self.class.name.split("::")[-1].downcase.pluralize
-      class_names = { "people" => "persons" }
+      class_name = self.class.name.split('::')[-1].downcase.pluralize
+      class_names = { 'people' => 'persons' }
       class_names[class_name] || class_name
     end
 
@@ -77,7 +79,8 @@ module Pipedrive
       end
 
       # This method smells of :reek:TooManyStatements
-      def connection # :nodoc
+      # :nodoc
+      def connection
         @connection ||= Faraday.new(faraday_options) do |conn|
           conn.request :url_encoded
           conn.response :mashify

data/lib/pipedrive/deal.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Pipedrive
   class Deal < Base
     include ::Pipedrive::Operations::Create

data/lib/pipedrive/deal_field.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Pipedrive
   class DealField < Base
     include ::Pipedrive::Operations::Create

data/lib/pipedrive/file.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Pipedrive
   class File < Base
     include ::Pipedrive::Operations::Create

data/lib/pipedrive/filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Pipedrive
   class Filter < Base
     include ::Pipedrive::Operations::Read

data/lib/pipedrive/goal.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Pipedrive
   class Goal < Base
     include ::Pipedrive::Operations::Create

data/lib/pipedrive/note.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Pipedrive
   class Note < Base
     include ::Pipedrive::Operations::Create

data/lib/pipedrive/operations/create.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Pipedrive
   module Operations
     module Create

data/lib/pipedrive/operations/delete.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Pipedrive
   module Operations
     module Delete

data/lib/pipedrive/operations/read.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Pipedrive
   module Operations
     module Read
@@ -5,10 +7,10 @@ module Pipedrive
       include ::Enumerable
       include ::Pipedrive::Utils
 
-      # This method smells of :reek:TooManyStatements but ignores them
-      def each(params = {})
+      def each(params = {}, &block)
         return to_enum(:each, params) unless block_given?
-        follow_pagination(:chunk, [], params) { |item| yield item }
+
+        follow_pagination(:chunk, [], params, &block)
       end
 
       def all(params = {})
@@ -18,6 +20,7 @@ module Pipedrive
       def chunk(params = {})
         res = make_api_call(:get, params)
         return [] unless res.success?
+
         res
       end
 

data/lib/pipedrive/operations/update.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Pipedrive
   module Operations
     module Update
@@ -7,7 +9,8 @@ module Pipedrive
         params = args.extract_options!
         params.symbolize_keys!
         id = params.delete(:id) || args[0]
-        fail 'id must be provided' unless id
+        raise 'id must be provided' unless id
+
         make_api_call(:put, id, params)
       end
     end

data/lib/pipedrive/organization.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Pipedrive
   class Organization < Base
     include ::Pipedrive::Operations::Read
@@ -6,12 +8,13 @@ module Pipedrive
     include ::Pipedrive::Operations::Delete
     include ::Pipedrive::Utils
 
-    def find_by_name(*args)
+    def find_by_name(*args, &block)
       params = args.extract_options!
       params[:term] ||= args[0]
-      fail 'term is missing' unless params[:term]
+      raise 'term is missing' unless params[:term]
       return to_enum(:find_by_name, params) unless block_given?
-      follow_pagination(:make_api_call, [:get, 'find'], params) { |item| yield item }
+
+      follow_pagination(:make_api_call, [:get, 'find'], params, &block)
     end
   end
 end