pipedrive.rb 0.2.0 → 0.3.0

data/spec/lib/pipedrive/filter_spec.rb

@@ -1,9 +1,13 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe ::Pipedrive::Filter do
   subject { described_class.new('token') }
-  context '#entity_name' do
+
+  describe '#entity_name' do
     subject { super().entity_name }
+
     it { is_expected.to eq('filters') }
   end
-end
+end

data/spec/lib/pipedrive/goal_spec.rb

@@ -1,9 +1,13 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe ::Pipedrive::Goal do
   subject { described_class.new('token') }
-  context '#entity_name' do
+
+  describe '#entity_name' do
     subject { super().entity_name }
+
     it { is_expected.to eq('goals') }
   end
-end
+end

data/spec/lib/pipedrive/note_spec.rb

@@ -1,9 +1,13 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe ::Pipedrive::Note do
   subject { described_class.new('token') }
-  context '#entity_name' do
+
+  describe '#entity_name' do
     subject { super().entity_name }
+
     it { is_expected.to eq('notes') }
   end
-end
+end

data/spec/lib/pipedrive/ogranization_spec.rb

@@ -1,9 +1,13 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe ::Pipedrive::Organization do
   subject { described_class.new('token') }
-  context '#entity_name' do
+
+  describe '#entity_name' do
     subject { super().entity_name }
+
     it { is_expected.to eq('organizations') }
   end
-end
+end

data/spec/lib/pipedrive/operations/create_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe ::Pipedrive::Operations::Create do
@@ -7,9 +9,9 @@ RSpec.describe ::Pipedrive::Operations::Create do
     end.new('token')
   end
 
-  context '#create' do
-    it 'should call #make_api_call' do
-      expect(subject).to receive(:make_api_call).with(:post, {foo: 'bar'})
+  describe '#create' do
+    it 'calls #make_api_call' do
+      expect(subject).to receive(:make_api_call).with(:post, { foo: 'bar' })
       subject.create(foo: 'bar')
     end
   end

data/spec/lib/pipedrive/operations/delete_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe ::Pipedrive::Operations::Delete do
@@ -7,16 +9,17 @@ RSpec.describe ::Pipedrive::Operations::Delete do
     end.new('token')
   end
 
-  context '#delete' do
-    it 'should call #make_api_call' do
+  describe '#delete' do
+    it 'calls #make_api_call' do
       expect(subject).to receive(:make_api_call).with(:delete, 12)
       subject.delete(12)
     end
   end
-  context '#delete_all' do
-    it 'should call #make_api_call' do
+
+  describe '#delete_all' do
+    it 'calls #make_api_call' do
       expect(subject).to receive(:make_api_call).with(:delete)
       subject.delete_all
     end
   end
-end
+end

data/spec/lib/pipedrive/operations/read_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe ::Pipedrive::Operations::Read do
@@ -7,45 +9,51 @@ RSpec.describe ::Pipedrive::Operations::Read do
     end.new('token')
   end
 
-  context '#find_by_id' do
-    it 'should call #make_api_call' do
+  describe '#find_by_id' do
+    it 'calls #make_api_call' do
       expect(subject).to receive(:make_api_call).with(:get, 12)
       subject.find_by_id(12)
     end
   end
 
-  context '#each' do
+  describe '#each' do
     let(:additional_data) do
-      {pagination: { more_items_in_collection?: true, next_start: 10}}
+      { pagination: { more_items_in_collection?: true, next_start: 10 } }
     end
-    it 'should return Enumerator if no block given' do
+
+    it 'returns Enumerator if no block given' do
       expect(subject.each).to be_a(::Enumerator)
     end
-    it 'should call to_enum with params' do
-      expect(subject).to receive(:to_enum).with(:each, {foo: 'bar'})
+
+    it 'calls to_enum with params' do
+      expect(subject).to receive(:to_enum).with(:each, { foo: 'bar' })
       subject.each(foo: 'bar')
     end
-    it 'should yield data' do
-      expect(subject).to receive(:chunk).and_return(::Hashie::Mash.new(data: [1,2], success: true))
-      expect { |b| subject.each(&b)}.to yield_successive_args(1,2)
+
+    it 'yields data' do
+      expect(subject).to receive(:chunk).and_return(::Hashie::Mash.new(data: [1, 2], success: true))
+      expect { |b| subject.each(&b) }.to yield_successive_args(1, 2)
     end
-    it 'should follow pagination' do
-      expect(subject).to receive(:chunk).with(start: 0).and_return(::Hashie::Mash.new(data: [1,2], success: true, additional_data: additional_data))
-      expect(subject).to receive(:chunk).with(start: 10).and_return(::Hashie::Mash.new(data: [3,4], success: true))
-      expect { |b| subject.each(&b)}.to yield_successive_args(1,2,3,4)
+
+    it 'follows pagination' do
+      expect(subject).to receive(:chunk).with(start: 0).and_return(::Hashie::Mash.new(data: [1, 2], success: true, additional_data: additional_data))
+      expect(subject).to receive(:chunk).with(start: 10).and_return(::Hashie::Mash.new(data: [3, 4], success: true))
+      expect { |b| subject.each(&b) }.to yield_successive_args(1, 2, 3, 4)
     end
-    it 'should not yield anything if result is empty' do
+
+    it 'does not yield anything if result is empty' do
       expect(subject).to receive(:chunk).with(start: 0).and_return(::Hashie::Mash.new(success: true))
-      expect { |b| subject.each(&b)}.to yield_successive_args
+      expect { |b| subject.each(&b) }.to yield_successive_args
     end
-    it 'should not yield anything if result is not success' do
+
+    it 'does not yield anything if result is not success' do
       expect(subject).to receive(:chunk).with(start: 0).and_return(::Hashie::Mash.new(success: false))
-      expect { |b| subject.each(&b)}.to yield_successive_args
+      expect { |b| subject.each(&b) }.to yield_successive_args
     end
   end
 
-  context '#all' do
-    it 'should call #each' do
+  describe '#all' do
+    it 'calls #each' do
       arr = double('enumerator')
       allow(arr).to receive(:to_a)
       expect(subject).to receive(:each).and_return(arr)
@@ -53,17 +61,17 @@ RSpec.describe ::Pipedrive::Operations::Read do
     end
   end
 
-  context '#chunk' do
-    it 'should return []' do
+  describe '#chunk' do
+    it 'returns []' do
       res = double('res', success?: false)
       expect(subject).to receive(:make_api_call).with(:get, {}).and_return(res)
       expect(subject.chunk).to eq([])
     end
 
-    it 'should return result' do
+    it 'returns result' do
       res = double('res', success?: true)
       expect(subject).to receive(:make_api_call).with(:get, {}).and_return(res)
       expect(subject.chunk).to eq(res)
     end
   end
-end
+end

data/spec/lib/pipedrive/operations/update_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe ::Pipedrive::Operations::Update do
@@ -7,14 +9,15 @@ RSpec.describe ::Pipedrive::Operations::Update do
     end.new('token')
   end
 
-  context '#create' do
-    it 'should call #make_api_call' do
-      expect(subject).to receive(:make_api_call).with(:put, 12, {foo: 'bar'})
+  describe '#create' do
+    it 'calls #make_api_call' do
+      expect(subject).to receive(:make_api_call).with(:put, 12, { foo: 'bar' })
       subject.update(12, foo: 'bar')
     end
-    it 'should call #make_api_call with id in params' do
-      expect(subject).to receive(:make_api_call).with(:put, 14, {foo: 'bar'})
+
+    it 'calls #make_api_call with id in params' do
+      expect(subject).to receive(:make_api_call).with(:put, 14, { foo: 'bar' })
       subject.update(foo: 'bar', id: 14)
     end
   end
-end
+end

data/spec/lib/pipedrive/organization_field_spec.rb

@@ -1,9 +1,13 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe ::Pipedrive::OrganizationField do
   subject { described_class.new('token') }
-  context '#entity_name' do
+
+  describe '#entity_name' do
     subject { super().entity_name }
+
     it { is_expected.to eq('organizationFields') }
   end
-end
+end

data/spec/lib/pipedrive/person_field_spec.rb

@@ -1,9 +1,13 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe ::Pipedrive::PersonField do
   subject { described_class.new('token') }
-  context '#entity_name' do
+
+  describe '#entity_name' do
     subject { super().entity_name }
+
     it { is_expected.to eq('personFields') }
   end
-end
+end

data/spec/lib/pipedrive/person_spec.rb

@@ -1,24 +1,30 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe ::Pipedrive::Person do
   subject { described_class.new('token') }
-  context '#entity_name' do
+
+  describe '#entity_name' do
     subject { super().entity_name }
+
     it { is_expected.to eq('persons') }
   end
 
-  context '#find_by_name' do
-    it 'should call #make_api_call with term' do
-      expect(subject).to receive(:make_api_call).with(:get, 'find', {term: 'term', search_by_email: 0, start: 0})
-      expect { |b| subject.find_by_name('term', &b)}.to yield_successive_args
+  describe '#find_by_name' do
+    it 'calls #make_api_call with term' do
+      expect(subject).to receive(:make_api_call).with(:get, 'find', { term: 'term', search_by_email: 0, start: 0 })
+      expect { |b| subject.find_by_name('term', &b) }.to yield_successive_args
     end
-    it 'should call #make_api_call with term and search_by_email' do
-      expect(subject).to receive(:make_api_call).with(:get, 'find', {term: 'term', search_by_email: 1, start: 0})
-      expect { |b| subject.find_by_name('term', true, &b)}.to yield_successive_args
+
+    it 'calls #make_api_call with term and search_by_email' do
+      expect(subject).to receive(:make_api_call).with(:get, 'find', { term: 'term', search_by_email: 1, start: 0 })
+      expect { |b| subject.find_by_name('term', true, &b) }.to yield_successive_args
     end
-    it 'should yield results' do
-      expect(subject).to receive(:make_api_call).with(:get, 'find', {term: 'term', search_by_email: 0, start: 0}).and_return(::Hashie::Mash.new(data: [1,2], success: true))
-      expect { |b| subject.find_by_name('term', &b)}.to yield_successive_args(1,2)
+
+    it 'yields results' do
+      expect(subject).to receive(:make_api_call).with(:get, 'find', { term: 'term', search_by_email: 0, start: 0 }).and_return(::Hashie::Mash.new(data: [1, 2], success: true))
+      expect { |b| subject.find_by_name('term', &b) }.to yield_successive_args(1, 2)
     end
   end
-end
+end

data/spec/lib/pipedrive/product_field_spec.rb

@@ -1,9 +1,13 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe ::Pipedrive::ProductField do
   subject { described_class.new('token') }
-  context '#entity_name' do
+
+  describe '#entity_name' do
     subject { super().entity_name }
+
     it { is_expected.to eq('productFields') }
   end
-end
+end

data/spec/lib/pipedrive/product_spec.rb

@@ -1,9 +1,13 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe ::Pipedrive::Product do
   subject { described_class.new('token') }
-  context '#entity_name' do
+
+  describe '#entity_name' do
     subject { super().entity_name }
+
     it { is_expected.to eq('products') }
   end
-end
+end

data/spec/lib/pipedrive_spec.rb

@@ -1,65 +1,73 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe ::Pipedrive do
-
   subject { described_class }
 
-  before :each do
+  before do
     described_class.reset!
   end
 
-  context '#reset!' do
+  describe '#reset!' do
     describe '#user_agent' do
       subject { super().user_agent }
+
       it { is_expected.to eq("Pipedrive Ruby Client v#{::Pipedrive::VERSION}") }
     end
 
     describe '#api_token' do
       subject { super().api_token }
+
       it { is_expected.to be_nil }
     end
 
     describe '#logger' do
       subject { super().logger }
+
       it { is_expected.to be_kind_of(::Logger) }
     end
   end
 
-  context '#setup' do
+  describe '#setup' do
     context 'single call' do
-      it 'should set user_agent' do
-        subject.setup do |c|
+      let(:client) { described_class }
+
+      it 'sets user_agent' do
+        client.setup do |c|
           c.user_agent = 'Test1245'
         end
-        expect(subject.user_agent).to eq('Test1245')
+        expect(client.user_agent).to eq('Test1245')
       end
 
-      it 'should set logger' do
-        newlogger = ::Logger.new(STDERR)
-        subject.setup do |c|
+      it 'sets logger' do
+        newlogger = ::Logger.new($stderr)
+        client.setup do |c|
           c.logger = newlogger
         end
-        expect(subject.logger).to eq(newlogger)
+        expect(client.logger).to eq(newlogger)
       end
 
-      it 'should set api_token' do
-        subject.setup do |c|
+      it 'sets api_token' do
+        client.setup do |c|
           c.api_token = 'test-api-key'
         end
-        expect(subject.api_token).to eq('test-api-key')
+        expect(client.api_token).to eq('test-api-key')
       end
     end
 
-    context 'double call' do
-      it 'should not accept running setup more then once' do
-        subject.setup do |c|
+    context 'with double call' do
+      let(:client) { described_class }
+
+      it 'does not accept running setup more then once' do
+        client.setup do |c|
           c.api_token = 'test-api-key'
         end
-        subject.setup do |c|
+        client.setup do |c|
           c.api_token = 'test-api-key2'
         end
-        expect(subject.api_token).to eq('test-api-key')
+        expect(client.api_token).to eq('test-api-key')
       end
     end
   end
-end
+end

data/spec/spec_helper.rb

@@ -1,9 +1,9 @@
+# frozen_string_literal: true
+
 require 'simplecov'
-require 'coveralls'
 
 SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
   SimpleCov::Formatter::HTMLFormatter,
-  Coveralls::SimpleCov::Formatter
 ]
 SimpleCov.start do
   add_filter 'spec'