pipedrive.rb 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 11021dff174077aefb3589a979112cedc1677918
-  data.tar.gz: 76c18fb73b4f56968d580352c6b7590959570bdc
+SHA256:
+  metadata.gz: 174f47371cadbd8c2b38b1df1b578b4b2a51d26047e0cd276a6cd775e2269b84
+  data.tar.gz: '0887f64ee16bea1c672d666b6b6039e907b0494de309f017e6e9aedaff75cf9b'
 SHA512:
-  metadata.gz: 96a28445400ffc9cb4a59da4ed0a300c7a2aab5df6a81081dcfeca4b4d2daf0446372fa5608b0f631ee4feff20412c5ac8c8bc9488df29ed9a04714e7ab91056
-  data.tar.gz: fcffc1f3a0b89de8a9b5a7b99c180964645007fef72972e57dbf20e1d3ad8cda0002684acc1b993f809d4b458ab996c23416520e2b8b4ae1faedb735949421df
+  metadata.gz: d1c4295874a4652eda241e363bebc5f5efe7b877f8a124d066febef50616ae580b50ef29c21cb05d684c4ceabad4988f8d8ea974f3c5de0a2916c73aa6e094d4
+  data.tar.gz: 830f1e1829b68811fcb0dd73369a44e015e6a2844b073928b2456c5799b9f224cf0dafc26ddbe587db07bbdeddb027f2d2d5965399d7d93b43ccb8c5dccff58d

data/.rubocop.yml

@@ -3,9 +3,9 @@ AllCops:
     - '**/Rakefile'
   Exclude:
     - 'spec/**/*'
-Style/LineLength:
+Metrics/LineLength:
   Max: 99
-Style/FileName:
+Naming/FileName:
   Enabled: false
 Style/ModuleFunction:
   Enabled: false
@@ -13,5 +13,5 @@ Style/Encoding:
   Enabled: false
 Documentation:
   Enabled: false
-Style/MethodLength:
+Metrics/MethodLength:
   Max: 15

data/.travis.yml

@@ -1,10 +1,21 @@
 language: ruby
 rvm:
-  - 2.0.0
-  - 2.1
   - ruby-head
   - jruby-19mode
   - rbx-2
+  - 2.1.10
+  - 2.2.10
+  - 2.3.8
+  - 2.4.6
+  - 2.5.5
+  - 2.6.3
+
 matrix:
   allow_failures:
     - rvm: ruby-head
+    - rvm: jruby-19mode
+    - rvm: rbx-2
+
+bundler_args: --without local_development
+
+before_install: gem install bundler -v 1.17.3

data/Gemfile

@@ -12,9 +12,6 @@ group :local_development do
   gem 'terminal-notifier-guard', require: false if RUBY_PLATFORM.downcase.include?('darwin')
   gem 'guard-rspec', '>= 4.3.1' ,require: false
   gem 'guard-bundler', require: false
-  gem 'guard-preek', require: false
   gem 'guard-rubocop', require: false
-  gem 'guard-cane', require: false
-  gem 'guard-reek', github: 'pericles/guard-reek', require: false
   gem 'pry'
-end
+end

data/README.md

@@ -1,8 +1,7 @@
 # Pipedrive
 
-[![Build Status](https://travis-ci.org/dotpromo/pipedrive.rb.svg?branch=master)](https://travis-ci.org/dotpromo/pipedrive.rb)
-[![Code Climate](https://codeclimate.com/github/dotpromo/pipedrive.rb.png)](https://codeclimate.com/github/dotpromo/pipedrive.rb)
-[![Coverage Status](https://img.shields.io/coveralls/dotpromo/pipedrive.rb.svg)](https://coveralls.io/r/dotpromo/pipedrive.rb)
+[![Build Status](https://travis-ci.org/amoniacou/pipedrive.rb.svg?branch=master)](https://travis-ci.org/amoniacou/pipedrive.rb)
+[![Code Climate](https://codeclimate.com/github/amoniacou/pipedrive.rb.png)](https://codeclimate.com/github/amoniacou/pipedrive.rb)
 
 Pipedrive.com API wrapper
 
@@ -33,7 +32,7 @@ client = ::Pipedrive::Person.new('api_token')
 You can get person's JSON data:
 
 ```ruby
-person = client.find(12345)
+person = client.find_by_id(12345)
 person.success? # check what request was successful
 person.data # JSON data of person entity
 ```
@@ -93,7 +92,7 @@ And you can skip providing `api_token` to the entities classes.
 
 ## Contributing
 
-1. Fork it ( https://github.com/simonoff/pipedrive/fork )
+1. Fork it ( https://github.com/amoniacou/pipedrive/fork )
 2. Create your feature branch (`git checkout -b my-new-feature`)
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 
@@ -7,21 +9,6 @@ RSpec::Core::RakeTask.new(:spec)
 require 'rubocop/rake_task'
 RuboCop::RakeTask.new(:rubocop)
 
-# reek
-require 'reek/rake/task'
-
-Reek::Rake::Task.new do |t|
-  t.fail_on_error = false
-  t.source_files = Dir['lib/**/*.rb']
-end
-
-default_tasks = [:spec, :rubocop, :reek]
-
-unless defined? ::Rubinius
-  # cane
-  require 'cane/rake_task'
-  Cane::RakeTask.new
-  default_tasks << :cane
-end
+default_tasks = %i[spec rubocop]
 
 task default: default_tasks

data/lib/pipedrive.rb

@@ -3,10 +3,6 @@ require 'active_support/core_ext/hash'
 require 'active_support/concern'
 require 'active_support/inflector'
 
-ActiveSupport::Inflector.inflections do |inflect|
-  inflect.irregular 'person', 'persons'
-end
-
 require 'hashie'
 require 'faraday'
 require 'faraday_middleware'

data/lib/pipedrive/base.rb

@@ -18,6 +18,9 @@ module Pipedrive
         res = connection.__send__(method.to_sym, url, params)
       rescue Errno::ETIMEDOUT
         retry
+      rescue Faraday::ParsingError
+        sleep 5
+        retry
       end
       process_response(res)
     end
@@ -57,7 +60,9 @@ module Pipedrive
     end
 
     def entity_name
-      self.class.name.split('::')[-1].downcase.pluralize
+      class_name = self.class.name.split("::")[-1].downcase.pluralize
+      class_names = { "people" => "persons" }
+      class_names[class_name] || class_name
     end
 
     class << self
@@ -77,9 +82,9 @@ module Pipedrive
           conn.request :url_encoded
           conn.response :mashify
           conn.response :json, content_type: /\bjson$/
-          conn.adapter Faraday.default_adapter
           conn.use FaradayMiddleware::ParseJson
           conn.response :logger, ::Pipedrive.logger if ::Pipedrive.debug
+          conn.adapter Faraday.default_adapter
         end
       end
     end

data/lib/pipedrive/organization.rb

@@ -4,5 +4,14 @@ module Pipedrive
     include ::Pipedrive::Operations::Create
     include ::Pipedrive::Operations::Update
     include ::Pipedrive::Operations::Delete
+    include ::Pipedrive::Utils
+
+    def find_by_name(*args)
+      params = args.extract_options!
+      params[:term] ||= args[0]
+      fail 'term is missing' unless params[:term]
+      return to_enum(:find_by_name, params) unless block_given?
+      follow_pagination(:make_api_call, [:get, 'find'], params) { |item| yield item }
+    end
   end
 end

data/lib/pipedrive/person_field.rb

@@ -2,6 +2,7 @@ module Pipedrive
   class PersonField < Base
     include ::Pipedrive::Operations::Read
     include ::Pipedrive::Operations::Create
+    include ::Pipedrive::Operations::Update
     include ::Pipedrive::Operations::Delete
 
     def entity_name

data/lib/pipedrive/version.rb

@@ -1,3 +1,3 @@
 module Pipedrive
-  VERSION = '0.1.0'
+  VERSION = '0.2.0'
 end

data/pipedrive.gemspec

@@ -7,23 +7,24 @@ Gem::Specification.new do |gem|
   gem.name          = "pipedrive.rb"
   gem.version       = Pipedrive::VERSION
   gem.authors       = ["Alexander Simonov"]
-  gem.email         = ["alex@simonov.me"]
+  gem.email         = ["alex@amoniac.eu"]
   gem.summary       = %q{Pipedrive.com API Wrapper}
   gem.description   = %q{Pipedrive.com API Wrapper}
-  gem.homepage      = 'https://github.com/dotpromo/pipedrive.rb'
+  gem.homepage      = 'https://github.com/amoniacou/pipedrive.rb'
   gem.license       = 'MIT'
 
   gem.files         = `git ls-files -z`.split("\x0")
   gem.executables   = gem.files.grep(%r{^bin/}) { |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
-  gem.require_paths = ["lib"]
+  gem.require_paths = ['lib']
 
+  gem.add_dependency('activesupport', '>= 4.0.0')
   gem.add_dependency('faraday')
   gem.add_dependency('faraday_middleware')
-  gem.add_dependency('activesupport', '>= 4.0.0')
   gem.add_dependency('hashie', '>= 3.0')
-  gem.add_development_dependency('bundler', '~> 1.6')
-  gem.add_development_dependency('rake')
+  gem.add_development_dependency('bundler')
+  gem.add_development_dependency('rake', '< 12')
   gem.add_development_dependency('rspec', '>= 3.0')
+  gem.add_development_dependency('rubocop')
   gem.add_development_dependency('webmock')
 end

data/spec/lib/pipedrive/base_spec.rb

@@ -11,7 +11,7 @@ RSpec.describe ::Pipedrive::Base do
     subject { described_class.faraday_options }
     it { is_expected.to eq({
       url:     'https://api.pipedrive.com',
-      headers: { accept: 'application/json', user_agent: 'Pipedrive Ruby Client v0.0.1' }
+      headers: { accept: 'application/json', user_agent: 'Pipedrive Ruby Client v0.1.0' }
     }) }
   end
 
@@ -54,34 +54,34 @@ RSpec.describe ::Pipedrive::Base do
     end
     context 'without id' do
       it 'should call :get' do
-        stub_request(:get, 'https://api.pipedrive.com/v1/bases?api_token=token').to_return(:status => 200, :body => {}, :headers => {})
+        stub_request(:get, 'https://api.pipedrive.com/v1/bases?api_token=token').to_return(:status => 200, :body => {}.to_json, :headers => {})
         expect_any_instance_of(::Faraday::Connection).to receive(:get).with('/v1/bases?api_token=token', {}).and_call_original
         expect(subject.make_api_call(:get))
       end
       it 'should call :post' do
-        stub_request(:post, 'https://api.pipedrive.com/v1/bases?api_token=token').to_return(:status => 200, :body => {}, :headers => {})
+        stub_request(:post, 'https://api.pipedrive.com/v1/bases?api_token=token').to_return(:status => 200, :body => {}.to_json, :headers => {})
         expect_any_instance_of(::Faraday::Connection).to receive(:post).with('/v1/bases?api_token=token', { test: 'bar' }).and_call_original
         expect(subject.make_api_call(:post, test: 'bar'))
       end
       it 'should call :put' do
-        stub_request(:put, 'https://api.pipedrive.com/v1/bases?api_token=token').to_return(:status => 200, :body => {}, :headers => {})
+        stub_request(:put, 'https://api.pipedrive.com/v1/bases?api_token=token').to_return(:status => 200, :body => {}.to_json, :headers => {})
         expect_any_instance_of(::Faraday::Connection).to receive(:put).with('/v1/bases?api_token=token', { test: 'bar' }).and_call_original
         expect(subject.make_api_call(:put, test: 'bar'))
       end
       it 'should use field_selector properly' do
-        stub_request(:get, 'https://api.pipedrive.com/v1/bases:(a,b,c)?api_token=token').to_return(:status => 200, :body => {}, :headers => {})
+        stub_request(:get, 'https://api.pipedrive.com/v1/bases:(a,b,c)?api_token=token').to_return(:status => 200, :body => {}.to_json, :headers => {})
         expect_any_instance_of(::Faraday::Connection).to receive(:get).
           with('/v1/bases:(a,b,c)?api_token=token', {}).and_call_original
         expect(subject.make_api_call(:get, fields_to_select: %w(a b c)))
       end
       it 'should not use field_selector if it empty' do
-        stub_request(:get, 'https://api.pipedrive.com/v1/bases?api_token=token').to_return(:status => 200, :body => {}, :headers => {})
+        stub_request(:get, 'https://api.pipedrive.com/v1/bases?api_token=token').to_return(:status => 200, :body => {}.to_json, :headers => {})
         expect_any_instance_of(::Faraday::Connection).to receive(:get).
           with('/v1/bases?api_token=token', {}).and_call_original
         expect(subject.make_api_call(:get, fields_to_select: []))
       end
       it 'should retry if Errno::ETIMEDOUT' do
-        stub_request(:get, 'https://api.pipedrive.com/v1/bases?api_token=token').to_return(:status => 200, :body => {}, :headers => {})
+        stub_request(:get, 'https://api.pipedrive.com/v1/bases?api_token=token').to_return(:status => 200, :body => {}.to_json, :headers => {})
         connection = subject.connection
         allow(subject).to receive(:connection).and_return(connection)
         allow(connection).to receive(:get).
@@ -93,17 +93,17 @@ RSpec.describe ::Pipedrive::Base do
     end
     context 'with id' do
       it 'should call :get' do
-        stub_request(:get, 'https://api.pipedrive.com/v1/bases/12?api_token=token').to_return(:status => 200, :body => {}, :headers => {})
+        stub_request(:get, 'https://api.pipedrive.com/v1/bases/12?api_token=token').to_return(:status => 200, :body => {}.to_json, :headers => {})
         expect_any_instance_of(::Faraday::Connection).to receive(:get).with('/v1/bases/12?api_token=token', {}).and_call_original
         expect(subject.make_api_call(:get, 12))
       end
       it 'should call :post' do
-        stub_request(:post, 'https://api.pipedrive.com/v1/bases/13?api_token=token').to_return(:status => 200, :body => {}, :headers => {})
+        stub_request(:post, 'https://api.pipedrive.com/v1/bases/13?api_token=token').to_return(:status => 200, :body => {}.to_json, :headers => {})
         expect_any_instance_of(::Faraday::Connection).to receive(:post).with('/v1/bases/13?api_token=token', { test: 'bar' }).and_call_original
         expect(subject.make_api_call(:post, 13, test: 'bar'))
       end
       it 'should call :put' do
-        stub_request(:put, 'https://api.pipedrive.com/v1/bases/14?api_token=token').to_return(:status => 200, :body => {}, :headers => {})
+        stub_request(:put, 'https://api.pipedrive.com/v1/bases/14?api_token=token').to_return(:status => 200, :body => {}.to_json, :headers => {})
         expect_any_instance_of(::Faraday::Connection).to receive(:put).with('/v1/bases/14?api_token=token', { test: 'bar' }).and_call_original
         expect(subject.make_api_call(:put, 14, test: 'bar'))
       end
@@ -119,4 +119,4 @@ RSpec.describe ::Pipedrive::Base do
       expect(subject.make_api_call(:get))
     end
   end
-end
+end

metadata

@@ -1,31 +1,31 @@
 --- !ruby/object:Gem::Specification
 name: pipedrive.rb
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Alexander Simonov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-16 00:00:00.000000000 Z
+date: 2020-01-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: faraday
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 4.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 4.0.0
 - !ruby/object:Gem::Dependency
-  name: faraday_middleware
+  name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -39,19 +39,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: faraday_middleware
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.0.0
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.0.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: hashie
   requirement: !ruby/object:Gem::Requirement
@@ -70,30 +70,30 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '12'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -108,6 +108,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -124,7 +138,7 @@ dependencies:
         version: '0'
 description: Pipedrive.com API Wrapper
 email:
-- alex@simonov.me
+- alex@amoniac.eu
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -187,7 +201,7 @@ files:
 - spec/lib/pipedrive/product_spec.rb
 - spec/lib/pipedrive_spec.rb
 - spec/spec_helper.rb
-homepage: https://github.com/dotpromo/pipedrive.rb
+homepage: https://github.com/amoniacou/pipedrive.rb
 licenses:
 - MIT
 metadata: {}
@@ -206,8 +220,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: Pipedrive.com API Wrapper