pipedrive-connect 1.2.13 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 35988325b69c627a5892597bc7a2f1b0a25d0e30f4ceb34390ba8479e70f299b
-  data.tar.gz: 5fe78e92cdc521ee89a9ef102b12e22ee5b48e5aaf4314b8bb93fe80830b81be
+  metadata.gz: 8eea5a65d7d2e39294f3fa5a4a48fc0435776e3b026d315da8bad5ad6f167bdb
+  data.tar.gz: 9f36431228dfed9f9e05cad2083796d5ab2806c9195821b901df9a81893eef0d
 SHA512:
-  metadata.gz: 636f0f99a7a2a32a33bad658b060867c703df03af930a97dda717bd019cbd1115b1ffc8a08aaa8d1c2936861066436e3310429a9a3a061f17cd3d9935523bb39
-  data.tar.gz: 481e86ad08a91796abe0f3a52e6b90d509e6beae87a1686867391bd792028c4208d5f56bdf5f492266bfc0ad5ee02b044ef992fbf555ce23982d46c29530f684
+  metadata.gz: 598554f66789fa6be6e2896fba4badb65c2cfa757e2e084ad30496cac5f5dce5845b1900f6976d4c6d94fdfde2c0dcfd89a0e4449a18198daa55126453b6d204
+  data.tar.gz: 18c041a8723dc4d4a8e9f9c636daeec1ef549346d62d149baf1602019c70f30cd3b71d0bf18a23bfbee2d9b170d7551d90a87c9fc2af7e3ed5a155aefc9083d9

data/CHANGELOG.md

@@ -4,6 +4,17 @@ This file contains all notable changes to this project.
 This project adheres to [Semantic Versioning](http://semver.org/).
 This change log follows the conventions of [keepachangelog.com](http://keepachangelog.com/).
 
+## [1.3.0] - 2023-04-17
+
+- Modify `has_many` to generate methods to `add` and `delete` resources. ie. `add_participant`, `add_product`, `delete_product`
+- Add `Pipedrive::Participant` resource and add the association to `Pipedrive::Deal`
+- BREAKING CHANGE: Removed `delete_attached_product` in favor of `delete_product` passing a hash of params instead of an instance of `Pipedrive::Resource`
+- BREAKING CHANGE: `add_product` changed method signature because of the changes introduced in `has_many`
+
+## [1.2.14] - 2023-01-31
+
+- The codebase paginates until fetching all the fields so the diccionary of custom fields is complete (checkout `lib/pipedrive/fields` for more info)
+
 ## [1.2.13] - 2022-12-08
 
 - Update `LeadLabel` resource to use _PATCH_ method (as according to the API doc)

data/Gemfile

@@ -7,6 +7,7 @@ gemspec
 group :development do
   gem "byebug"
   gem "mocha"
+  gem "pry"
   gem "rspec"
   gem "rubocop"
   gem "simplecov", require: false

data/bin/console

@@ -4,13 +4,24 @@
 
 require "bundler/setup"
 require "pipedrive"
+require "pry"
+require "irb"
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
 
-# (If you use this, don't forget to add pry to your Gemfile!)
-# require "pry"
-# Pry.start
+def reload!(print = true)
+  puts "Reloading ..." if print
+  # Main project directory.
+  root_dir = File.expand_path("..", __dir__)
+  # Directories within the project that should be reloaded.
+  reload_dirs = %w[lib]
+  # Loop through and reload every file in all relevant project directories.
+  reload_dirs.each do |dir|
+    Dir.glob("#{root_dir}/#{dir}/**/*.rb").each { |f| load(f) }
+  end
+  # Return true when complete.
+  true
+end
 
-require "irb"
 IRB.start(__FILE__)

data/lib/pipedrive/fields.rb

@@ -12,7 +12,19 @@ module Pipedrive
     module ClassMethods
       def fields
         url = fields_url || "#{class_name.downcase}Fields"
-        data = request(:get, url).dig(:data)
+
+        data = []
+        start = 0
+        request_more_fields = true
+
+        while request_more_fields
+          response = request(:get, url, start: start)
+          data.concat(response.dig(:data))
+          # Check wether there are more fields to bring
+          metadata = response.dig(:additional_data, :pagination)
+          request_more_fields = metadata&.fetch(:more_items_in_collection, false)
+          start = metadata[:next_start] if request_more_fields
+        end
         # return a hash prefilled with
         # the fields hash and name parameterized
         # and the original array of fields (schema)

data/lib/pipedrive/resource.rb

@@ -10,7 +10,7 @@ module Pipedrive
     class << self
       attr_accessor :resources_url
 
-      def update_method(method_override=nil)
+      def update_method(method_override = nil)
         @update_method ||= method_override
       end
 
@@ -66,20 +66,22 @@ module Pipedrive
         response.dig(:data, :items).map { |d| new(d.dig(:item)) }
       end
 
-      def has_many(resource_name, class_name:)
+      def has_many(resource_name, args = {})
+        class_name = args[:class_name]
         unless resource_name && class_name
           raise "You must specify the resource name and its class name " \
                 "For example has_many :deals, class_name: 'Deal'"
         end
         class_name_lower_case = class_name.downcase
+        singular = args[:singular] || class_name_lower_case[0..-1]
         # always include all the data of the resource
         options = { "include_#{class_name_lower_case}_data": 1 }
         # add namespace to class_name
         class_name = "::Pipedrive::#{class_name}" unless class_name.include?("Pipedrive")
         define_method(resource_name) do |params = {}|
           response = request(:get,
-                            "#{resource_url}/#{resource_name}",
-                            params.merge(options))
+                             "#{resource_url}/#{resource_name}",
+                             params.merge(options))
           response.dig(:data)&.map do |data|
             class_name_as_sym = class_name_lower_case.to_sym
             data[:metadata] = data
@@ -89,6 +91,22 @@ module Pipedrive
             Object.const_get(class_name).new(data)
           end
         end
+
+        define_method("add_#{singular}") do |params|
+          response = request(
+            :post,
+            "#{resource_url}/#{resource_name}",
+            params.merge(id: id)
+          )
+          Object.const_get(class_name).new(response.dig(:data))
+        end
+
+        define_method("delete_#{singular}") do |resource|
+          raise "Param *resource* is not an instance of Pipedrive::Resource" \
+            unless resource.is_a?(Pipedrive::Resource)
+          response = request(:delete, "#{resource_url}/#{resource_name}/#{resource.id}")
+          response[:success]
+        end
       end
     end
 

data/lib/pipedrive/resources/deal.rb

@@ -6,28 +6,6 @@ module Pipedrive
     include Merge
 
     has_many :products, class_name: "Product"
-
-    # POST /deals/:id/products
-    # Add a product to this deal
-    def add_product(product, params)
-      raise "Param *product* is not an instance of Pipedrive::Product" \
-        unless product.is_a?(Pipedrive::Product)
-      raise "Param :item_price is required" unless params.key?(:item_price)
-      raise "Param :quantity is required" unless params.key?(:quantity)
-
-      response = request(
-        :post,
-        "#{resource_url}/products",
-        params.merge(id: id, product_id: product.id)
-      )
-      Product.new(response.dig(:data))
-    end
-
-    # DELETE /deals/:id/products/:product_attachment_id
-    # Detach a product from this deal
-    def delete_attached_product(product_attachment_id)
-      response = request(:delete, "#{resource_url}/products/#{product_attachment_id}")
-      response[:success]
-    end
+    has_many :participants, class_name: "Participant"
   end
 end

data/lib/pipedrive/resources/participant.rb

@@ -0,0 +1,6 @@
+# frozen_string_literal: true
+
+module Pipedrive
+  class Participant < Resource
+  end
+end

data/lib/pipedrive/resources.rb

@@ -14,6 +14,7 @@ require "pipedrive/resources/lead_source"
 require "pipedrive/resources/lead"
 require "pipedrive/resources/organization"
 require "pipedrive/resources/organization_field"
+require "pipedrive/resources/participant"
 require "pipedrive/resources/pipeline"
 require "pipedrive/resources/product"
 require "pipedrive/resources/person"

data/lib/pipedrive/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Pipedrive
-  VERSION = "1.2.13"
+  VERSION = "1.3.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pipedrive-connect
 version: !ruby/object:Gem::Version
-  version: 1.2.13
+  version: 1.3.0
 platform: ruby
 authors:
 - Get on Board
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-12-08 00:00:00.000000000 Z
+date: 2023-05-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -67,6 +67,7 @@ files:
 - lib/pipedrive/resources/note.rb
 - lib/pipedrive/resources/organization.rb
 - lib/pipedrive/resources/organization_field.rb
+- lib/pipedrive/resources/participant.rb
 - lib/pipedrive/resources/person.rb
 - lib/pipedrive/resources/pipeline.rb
 - lib/pipedrive/resources/product.rb