pio 0.30.0 → 0.30.2

data/spec/pio/open_flow13/match_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'pio/open_flow13/match'
 
 # rubocop:disable LineLength
@@ -386,7 +388,7 @@ describe Pio::OpenFlow13::Match do
       end
       Then { match.ether_type == 0x0800 }
       Then { match.ip_protocol == 1 }
-      Then { match.icmpv4_code == 0 }
+      Then { match.icmpv4_code.zero? }
       And { match.class == Pio::OpenFlow13::Match }
       And { match.length == 24 }
       And { match.match_type == Pio::OpenFlow13::MATCH_TYPE_OXM }
@@ -696,15 +698,15 @@ describe Pio::OpenFlow13::Match do
   end
 
   def read_raw_data_file(name)
-    IO.read File.join(__dir__, '..', '..', '..', name)
+    IO.read File.join(__dir__, '..', '..', '..', 'fixtures', name)
   end
 
   describe '.read' do
     When(:match) { Pio::OpenFlow13::Match.read(raw_data) }
 
-    context 'with file "features/open_flow13/oxm_no_fields.raw"' do
+    context 'with file "open_flow13/oxm_no_fields.raw"' do
       Given(:raw_data) do
-        read_raw_data_file 'features/open_flow13/oxm_no_fields.raw'
+        read_raw_data_file 'open_flow13/oxm_no_fields.raw'
       end
       Then { match.match_fields == [] }
       And { match.class == Pio::OpenFlow13::Match }
@@ -713,9 +715,9 @@ describe Pio::OpenFlow13::Match do
       And { match.match_length == 4 }
     end
 
-    context 'with file "features/open_flow13/oxm_in_port_field.raw"' do
+    context 'with file "open_flow13/oxm_in_port_field.raw"' do
       Given(:raw_data) do
-        read_raw_data_file 'features/open_flow13/oxm_in_port_field.raw'
+        read_raw_data_file 'open_flow13/oxm_in_port_field.raw'
       end
       Then { match.in_port == 1 }
       And { match.class == Pio::OpenFlow13::Match }
@@ -735,9 +737,9 @@ describe Pio::OpenFlow13::Match do
       And { match.match_fields[0].oxm_length == 4 }
     end
 
-    context 'with file "features/open_flow13/oxm_ether_destination_field.raw"' do
+    context 'with file "open_flow13/oxm_ether_destination_field.raw"' do
       Given(:raw_data) do
-        read_raw_data_file 'features/open_flow13/oxm_ether_destination_field.raw'
+        read_raw_data_file 'open_flow13/oxm_ether_destination_field.raw'
       end
       Then { match.destination_mac_address == 'ff:ff:ff:ff:ff:ff' }
       And { match.class == Pio::OpenFlow13::Match }
@@ -757,9 +759,9 @@ describe Pio::OpenFlow13::Match do
       And { match.match_fields[0].oxm_length == 6 }
     end
 
-    context 'with file "features/open_flow13/oxm_ether_source_field.raw"' do
+    context 'with file "open_flow13/oxm_ether_source_field.raw"' do
       Given(:raw_data) do
-        read_raw_data_file 'features/open_flow13/oxm_ether_source_field.raw'
+        read_raw_data_file 'open_flow13/oxm_ether_source_field.raw'
       end
       Then { match.source_mac_address == '01:02:03:04:05:06' }
       And { match.class == Pio::OpenFlow13::Match }
@@ -779,9 +781,9 @@ describe Pio::OpenFlow13::Match do
       And { match.match_fields[0].oxm_length == 6 }
     end
 
-    context 'with file "features/open_flow13/oxm_masked_ether_destination_field.raw"' do
+    context 'with file "open_flow13/oxm_masked_ether_destination_field.raw"' do
       Given(:raw_data) do
-        read_raw_data_file 'features/open_flow13/oxm_masked_ether_destination_field.raw'
+        read_raw_data_file 'open_flow13/oxm_masked_ether_destination_field.raw'
       end
       Then { match.destination_mac_address == 'ff:ff:ff:ff:ff:ff' }
       Then { match.destination_mac_address_mask == 'ff:ff:ff:00:00:00' }
@@ -802,9 +804,9 @@ describe Pio::OpenFlow13::Match do
       And { match.match_fields[0].oxm_length == 12 }
     end
 
-    context 'with file "features/open_flow13/oxm_masked_ether_source_field.raw"' do
+    context 'with file "open_flow13/oxm_masked_ether_source_field.raw"' do
       Given(:raw_data) do
-        read_raw_data_file 'features/open_flow13/oxm_masked_ether_source_field.raw'
+        read_raw_data_file 'open_flow13/oxm_masked_ether_source_field.raw'
       end
       Then { match.source_mac_address == '01:02:03:04:05:06' }
       Then { match.source_mac_address_mask == 'ff:ff:ff:00:00:00' }
@@ -825,11 +827,11 @@ describe Pio::OpenFlow13::Match do
       And { match.match_fields[0].oxm_length == 12 }
     end
 
-    context 'with file "features/open_flow13/oxm_ether_type_field.raw"' do
+    context 'with file "open_flow13/oxm_ether_type_field.raw"' do
       Given(:raw_data) do
-        read_raw_data_file 'features/open_flow13/oxm_ether_type_field.raw'
+        read_raw_data_file 'open_flow13/oxm_ether_type_field.raw'
       end
-      Then { match.ether_type == 0 }
+      Then { match.ether_type.zero? }
       And { match.class == Pio::OpenFlow13::Match }
       And { match.length == 16 }
       And { match.match_type == Pio::OpenFlow13::MATCH_TYPE_OXM }
@@ -847,9 +849,9 @@ describe Pio::OpenFlow13::Match do
       And { match.match_fields[0].oxm_length == 2 }
     end
 
-    context 'with file "features/open_flow13/oxm_vlan_vid_field.raw"' do
+    context 'with file "open_flow13/oxm_vlan_vid_field.raw"' do
       Given(:raw_data) do
-        read_raw_data_file 'features/open_flow13/oxm_vlan_vid_field.raw'
+        read_raw_data_file 'open_flow13/oxm_vlan_vid_field.raw'
       end
       Then { match.vlan_vid == 10 }
       And { match.class == Pio::OpenFlow13::Match }
@@ -869,9 +871,9 @@ describe Pio::OpenFlow13::Match do
       And { match.match_fields[0].oxm_length == 2 }
     end
 
-    context 'with file "features/open_flow13/oxm_vlan_pcp_field.raw"' do
+    context 'with file "open_flow13/oxm_vlan_pcp_field.raw"' do
       Given(:raw_data) do
-        read_raw_data_file 'features/open_flow13/oxm_vlan_pcp_field.raw'
+        read_raw_data_file 'open_flow13/oxm_vlan_pcp_field.raw'
       end
       Then { match.vlan_pcp == 5 }
       And { match.class == Pio::OpenFlow13::Match }
@@ -891,9 +893,9 @@ describe Pio::OpenFlow13::Match do
       And { match.match_fields[0].oxm_length == 2 }
     end
 
-    context 'with file "features/open_flow13/oxm_ip_dscp_field.raw"' do
+    context 'with file "open_flow13/oxm_ip_dscp_field.raw"' do
       Given(:raw_data) do
-        read_raw_data_file 'features/open_flow13/oxm_ip_dscp_field.raw'
+        read_raw_data_file 'open_flow13/oxm_ip_dscp_field.raw'
       end
       Then { match.ip_dscp == 0x2e }
       And { match.class == Pio::OpenFlow13::Match }
@@ -913,9 +915,9 @@ describe Pio::OpenFlow13::Match do
       And { match.match_fields[0].oxm_length == 2 }
     end
 
-    context 'with file "features/open_flow13/oxm_ip_ecn_field.raw"' do
+    context 'with file "open_flow13/oxm_ip_ecn_field.raw"' do
       Given(:raw_data) do
-        read_raw_data_file 'features/open_flow13/oxm_ip_ecn_field.raw'
+        read_raw_data_file 'open_flow13/oxm_ip_ecn_field.raw'
       end
       Then { match.ip_ecn == 3 }
       And { match.class == Pio::OpenFlow13::Match }
@@ -935,9 +937,9 @@ describe Pio::OpenFlow13::Match do
       And { match.match_fields[0].oxm_length == 2 }
     end
 
-    context 'with file "features/open_flow13/oxm_ipv4_source_field.raw"' do
+    context 'with file "open_flow13/oxm_ipv4_source_field.raw"' do
       Given(:raw_data) do
-        read_raw_data_file 'features/open_flow13/oxm_ipv4_source_field.raw'
+        read_raw_data_file 'open_flow13/oxm_ipv4_source_field.raw'
       end
       Then { match.ether_type == 0x0800 }
       Then { match.ipv4_source_address == '1.2.3.4' }
@@ -968,9 +970,9 @@ describe Pio::OpenFlow13::Match do
       And { match.match_fields[1].oxm_length == 4 }
     end
 
-    context 'with file "features/open_flow13/oxm_ipv4_destination_field.raw"' do
+    context 'with file "open_flow13/oxm_ipv4_destination_field.raw"' do
       Given(:raw_data) do
-        read_raw_data_file 'features/open_flow13/oxm_ipv4_destination_field.raw'
+        read_raw_data_file 'open_flow13/oxm_ipv4_destination_field.raw'
       end
       Then { match.ether_type == 0x0800 }
       Then { match.ipv4_destination_address == '11.22.33.44' }

data/spec/pio/open_flow13/meter_spec.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 require 'pio/open_flow13/meter'
 
-describe Pio::Meter do
+describe Pio::OpenFlow13::Meter do
   describe '.new' do
-    When(:meter) { Pio::Meter.new(options) }
+    When(:meter) { Pio::OpenFlow13::Meter.new(options) }
 
     context 'with 1' do
       Given(:options) { 1 }

data/spec/pio/open_flow13/nicira_reg_load_spec.rb

@@ -0,0 +1,73 @@
+# frozen_string_literal: true
+
+require 'pio/open_flow13/nicira_reg_load'
+
+describe Pio::OpenFlow13::NiciraRegLoad do
+  describe '.new' do
+    When(:nicira_reg_load) do
+      Pio::OpenFlow13::NiciraRegLoad.new(value, destination, options)
+    end
+
+    context 'with 0xdeadbeef, :reg0' do
+      Given(:value) { 0xdeadbeef }
+      Given(:destination) { :reg0 }
+      Given(:options) { {} }
+
+      Invariant do
+        nicira_reg_load.n_bits == nicira_reg_load._destination[:oxm_length] * 8
+      end
+
+      Then { nicira_reg_load.action_type == 0xffff }
+      Then { nicira_reg_load.action_length == 24 }
+      Then { nicira_reg_load.vendor == 0x2320 }
+      Then { nicira_reg_load.subtype == 7 }
+      Then { nicira_reg_load.offset.zero? }
+      Then { nicira_reg_load.n_bits == 32 }
+      Then { nicira_reg_load.destination == :reg0 }
+      Then { nicira_reg_load._destination[:oxm_class] == 1 }
+      Then { nicira_reg_load._destination[:oxm_field].zero? }
+      Then { nicira_reg_load._destination[:oxm_length] == 4 }
+      Then { nicira_reg_load.value == 0xdeadbeef }
+    end
+
+    context 'with 0xdeadbeef, :metadata' do
+      Given(:value) { 0xdeadbeef }
+      Given(:destination) { :metadata }
+      Given(:options) { {} }
+
+      Invariant do
+        nicira_reg_load.n_bits == nicira_reg_load._destination[:oxm_length] * 8
+      end
+
+      Then { nicira_reg_load.action_type == 0xffff }
+      Then { nicira_reg_load.action_length == 24 }
+      Then { nicira_reg_load.vendor == 0x2320 }
+      Then { nicira_reg_load.subtype == 7 }
+      Then { nicira_reg_load.offset.zero? }
+      Then { nicira_reg_load.n_bits == 64 }
+      Then { nicira_reg_load.destination == :metadata }
+      Then { nicira_reg_load._destination[:oxm_class] == 0x8000 }
+      Then { nicira_reg_load._destination[:oxm_field] == 2 }
+      Then { nicira_reg_load._destination[:oxm_length] == 8 }
+      Then { nicira_reg_load.value == 0xdeadbeef }
+    end
+
+    context 'with 0xdeadbeef, :reg0, offset: 16, n_bits: 16' do
+      Given(:value) { 0xdeadbeef }
+      Given(:destination) { :reg0 }
+      Given(:options) { { offset: 16, n_bits: 16 } }
+
+      Then { nicira_reg_load.action_type == 0xffff }
+      Then { nicira_reg_load.action_length == 24 }
+      Then { nicira_reg_load.vendor == 0x2320 }
+      Then { nicira_reg_load.subtype == 7 }
+      Then { nicira_reg_load.offset == 16 }
+      Then { nicira_reg_load.n_bits == 16 }
+      Then { nicira_reg_load.destination == :reg0 }
+      Then { nicira_reg_load._destination[:oxm_class] == 1 }
+      Then { nicira_reg_load._destination[:oxm_field].zero? }
+      Then { nicira_reg_load._destination[:oxm_length] == 4 }
+      Then { nicira_reg_load.value == 0xdeadbeef }
+    end
+  end
+end

data/spec/pio/open_flow13/nicira_reg_move_spec.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+require 'pio/open_flow13/nicira_reg_move'
+
+describe Pio::OpenFlow13::NiciraRegMove do
+  describe '.new' do
+    When(:nicira_reg_move) do
+      Pio::OpenFlow13::NiciraRegMove.new(options)
+    end
+
+    context 'with source: :arp_sender_hardware_address,'\
+            ' destination: :arp_target_hardware_address' do
+      Given(:options) do
+        { source: :arp_sender_hardware_address,
+          destination: :arp_target_hardware_address }
+      end
+
+      Invariant do
+        nicira_reg_move.n_bits ==
+          nicira_reg_move._source[:oxm_length] * 8
+      end
+
+      Then { nicira_reg_move.action_type == 0xffff }
+      Then { nicira_reg_move.action_length == 24 }
+      Then { nicira_reg_move.vendor == 0x2320 }
+      Then { nicira_reg_move.subtype == 6 }
+      Then { nicira_reg_move.n_bits == 48 }
+      Then { nicira_reg_move.source_offset.zero? }
+      Then { nicira_reg_move.destination_offset.zero? }
+      Then { nicira_reg_move.source == :arp_sender_hardware_address }
+      Then { nicira_reg_move._source[:oxm_class] == 0x8000 }
+      Then { nicira_reg_move._source[:oxm_field] == 24 }
+      Then { nicira_reg_move._source[:oxm_hasmask].zero? }
+      Then { nicira_reg_move._source[:oxm_length] == 6 }
+      Then { nicira_reg_move.destination == :arp_target_hardware_address }
+      Then { nicira_reg_move._destination[:oxm_class] == 0x8000 }
+      Then { nicira_reg_move._destination[:oxm_field] == 25 }
+      Then { nicira_reg_move._destination[:oxm_hasmask].zero? }
+      Then { nicira_reg_move._destination[:oxm_length] == 6 }
+    end
+  end
+end

data/spec/pio/open_flow13/nicira_send_out_port_spec.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require 'pio/open_flow13/nicira_send_out_port'
+
+describe Pio::OpenFlow13::NiciraSendOutPort do
+  describe '.new' do
+    When(:nicira_send_out_port) do
+      Pio::OpenFlow13::NiciraSendOutPort.new(source)
+    end
+
+    context 'with :reg0' do
+      Given(:source) { :reg0 }
+
+      Invariant do
+        nicira_send_out_port.n_bits ==
+          nicira_send_out_port._source[:oxm_length] * 8
+      end
+
+      Then { nicira_send_out_port.action_type == 0xffff }
+      Then { nicira_send_out_port.action_length == 24 }
+      Then { nicira_send_out_port.vendor == 0x2320 }
+      Then { nicira_send_out_port.subtype == 15 }
+      Then { nicira_send_out_port.offset.zero? }
+      Then { nicira_send_out_port.n_bits == 32 }
+      Then { nicira_send_out_port.source == :reg0 }
+      Then { nicira_send_out_port._source[:oxm_class] == 1 }
+      Then { nicira_send_out_port._source[:oxm_field].zero? }
+      Then { nicira_send_out_port._source[:oxm_length] == 4 }
+    end
+  end
+end

data/spec/pio/open_flow13/packet_in_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'pio/open_flow13/packet_in'
 
 describe Pio::OpenFlow13::PacketIn do

data/spec/pio/open_flow13/packet_out_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'pio/open_flow13/packet_out'
 
 describe Pio::OpenFlow13::PacketOut do

data/spec/pio/open_flow13/write_metadata_spec.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 require 'pio/open_flow13/write_metadata'
 
-describe Pio::WriteMetadata do
+describe Pio::OpenFlow13::WriteMetadata do
   describe '.new' do
-    When(:write_metadata) { Pio::WriteMetadata.new(options) }
+    When(:write_metadata) { Pio::OpenFlow13::WriteMetadata.new(options) }
 
     context 'with metadata: 1' do
       Given(:options) do
@@ -11,7 +13,7 @@ describe Pio::WriteMetadata do
         }
       end
       Then { write_metadata.metadata == 1 }
-      Then { write_metadata.metadata_mask == 0 }
+      Then { write_metadata.metadata_mask.zero? }
     end
 
     context 'with metadata: 1, metadata_mask: 1' do

data/spec/pio/open_flow_spec.rb

@@ -1,33 +1,35 @@
+# frozen_string_literal: true
+
 require 'pio/open_flow'
 
 describe Pio::OpenFlow do
   describe 'switch_version' do
-    When(:error) { Pio::OpenFlow.switch_version(version) }
+    When(:result) { Pio::OpenFlow.version = version }
 
     context 'with :OpenFlow10' do
       Given(:version) { :OpenFlow10 }
-      Then { Pio::OpenFlow.version == 'OpenFlow10' }
+      Then { Pio::OpenFlow.version == :OpenFlow10 }
     end
 
     context 'with "OpenFlow10"' do
       Given(:version) { 'OpenFlow10' }
-      Then { Pio::OpenFlow.version == 'OpenFlow10' }
+      Then { Pio::OpenFlow.version == :OpenFlow10 }
     end
 
     context 'with :OpenFlow13' do
       Given(:version) { :OpenFlow13 }
-      Then { Pio::OpenFlow.version == 'OpenFlow13' }
+      Then { Pio::OpenFlow.version == :OpenFlow13 }
     end
 
     context 'with "OpenFlow13"' do
       Given(:version) { 'OpenFlow13' }
-      Then { Pio::OpenFlow.version == 'OpenFlow13' }
+      Then { Pio::OpenFlow.version == :OpenFlow13 }
     end
 
     context 'with :OpenFlow100' do
       Given(:version) { :OpenFlow100 }
       Then do
-        error == Failure(RuntimeError, 'OpenFlow100 is not supported yet.')
+        result == Failure(RuntimeError, 'OpenFlow100 is not supported yet.')
       end
     end
   end

data/spec/spec_helper.rb

@@ -1,15 +1,4 @@
-require 'simplecov'
-require 'codeclimate-test-reporter'
-require 'coveralls'
-
-formatters = [SimpleCov::Formatter::HTMLFormatter]
-formatters << Coveralls::SimpleCov::Formatter if ENV['COVERALLS_REPO_TOKEN']
-if ENV['CODECLIMATE_REPO_TOKEN']
-  formatters << CodeClimate::TestReporter::Formatter
-end
-
-SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[*formatters]
-SimpleCov.start { add_filter '/vendor/' }
+# frozen_string_literal: true
 
 require 'rspec/given'
 Dir['./spec/support/**/*.rb'].sort.each { |f| require f }

data/spec/support/shared_examples_for_openflow_messages.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 shared_examples 'an OpenFlow message' do |klass|
   describe '.new' do
     When(:message) { klass.new(options) }
@@ -38,18 +40,6 @@ shared_examples 'an OpenFlow message' do |klass|
   end
 end
 
-shared_examples 'an OpenFlow message with no body' do |klass|
-  describe '.new' do
-    When(:message) { klass.new(options) }
-
-    context "with body: 'DEADBEEF'" do
-      When(:options) { { body: 'DEADBEEF' } }
-
-      Then { message.body == '' }
-    end
-  end
-end
-
 shared_examples 'an OpenFlow message with Datapath ID' do |klass|
   When(:message) { klass.new(options) }
 
@@ -63,14 +53,18 @@ shared_examples 'an OpenFlow message with Datapath ID' do |klass|
 
   context 'with { datapath_id: 0 }' do
     Given(:options) { { datapath_id: 0 } }
-    Then { message.datapath_id == 0 }
+    Then { message.datapath_id.zero? }
+    And { message.dpid.zero? }
     And { message.datapath_id.is_a? Integer }
+    And { message.dpid.is_a? Integer }
   end
 
   context 'with { datapath_id: 2**64 - 1 }' do
     Given(:options) { { datapath_id: 2**64 - 1 } }
     Then { message.datapath_id == 2**64 - 1 }
+    And { message.dpid == 2**64 - 1 }
     And { message.datapath_id.is_a? Integer }
+    And { message.dpid.is_a? Integer }
   end
 
   context 'with { datapath_id: 2**64 }' do