ping 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 036d44b633820e66e18e6711acace01648034351
-  data.tar.gz: d27bc8570003420c9507d30fbf48f5f694cffb44
+  metadata.gz: 6d4873e809919a2dbae3e2ba7f759413002d7fc1
+  data.tar.gz: 6ec66bdfb0f99f3c7ead5a27aea970774e4219f3
 SHA512:
-  metadata.gz: 7cbee0d6277080a360aa6a50b119756350692c951c41d9a5fc4576898dc2791d3982bfb9889aae3eb67ab39787c78d4dc703217bb29318157f5c8cd2b18be239
-  data.tar.gz: 4452025bfd32322e299a0c9140b202621ed6566d1c94a25276530d270fa05e64d3b51b4de1b9f12b7cc27d4bdc1abde25f1c8be78f2f60fa2ee3f4341c3e8a13
+  metadata.gz: d459bf0d42d17e01400201fd9a56443ab0b2d5831377479a313b0152623eaac4e6af1cab3ce403fb782b5b7bac4238fcd12760aa627cb78d6a6316b421bb7d80
+  data.tar.gz: 20a8203520a10bf9be20a97c1c0b6571aebfb4c0fd2cc55a90e181d7eb5fca3578f92e71a441fe56a4b3983ec6e566758d87c808f6c9f3da1c43b82995deb70a

data/lib/ping/issue.rb

@@ -7,13 +7,13 @@ module Ping
       need|needs|needed|require|requires|required
     /ix
 
-    RepositoryName = /[a-z0-9][a-z0-9-]*\/[a-z0-9][a-z0-9-]*/
+    RepositoryName = /[a-z0-9][a-z0-9-]*\/[a-z0-9][a-z0-9\-_]*/
 
     Pattern = /
       (?:^|\W)                    # beginning of string or non-word char
       (?:(#{Qualifiers})(?:\s))?  # qualifier (optional)
-      (#{RepositoryName})?        # repository name (optional)
-      \#(\d+)                     # issue number
+      (?:(#{RepositoryName})?     # repository name (optional)
+      \#|(?:GH\-))(\d+)           # issue number
       (?=
         \.+[ \t\W]|               # dots followed by space or non-word character
         \.+$|                     # dots at end of line
@@ -22,7 +22,7 @@ module Ping
       )
     /ix
 
-    # See http://rubular.com/r/LxWUfwmPhM
+    # See http://rubular.com/r/bb7Ks0JK9l now http://rubular.com/r/evB7RlvUfI
 
     def initialize(qualifier, repository, number)
       @qualifier = qualifier

data/lib/ping/version.rb

@@ -1,3 +1,3 @@
 module Ping
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/test/ping/parser_test.rb

@@ -81,6 +81,15 @@ class Ping::ParserTest < MiniTest::Test
       assert_equal "43", issue.number
     end
 
+    should "handle odd repository names" do
+      text = "giant-sequoia-123/scaling_octokitten#43"
+      parser = Ping::Parser.new(text)
+      issue = parser.issues.first
+
+      assert_equal "giant-sequoia-123/scaling_octokitten", issue.repository
+      assert_equal "43", issue.number
+    end
+
     should "extract multiple references" do
       text = "You should look at #2 and #4 because #5 fixes codetree/codetree#6"
       parser = Ping::Parser.new(text)
@@ -121,4 +130,110 @@ class Ping::ParserTest < MiniTest::Test
       assert_equal "43", issue.number
     end
   end
+
+  context "GH-issues" do
+    should "extract single issue references" do
+      text = "See GH-43"
+      parser = Ping::Parser.new(text)
+      issue = parser.issues.first
+
+      assert_equal nil, issue.qualifier
+      assert_equal nil, issue.repository
+      assert_equal "43", issue.number
+    end
+
+    should "extract lower case issue references" do
+      text = "See gh-43"
+      parser = Ping::Parser.new(text)
+      issue = parser.issues.first
+
+      assert_equal nil, issue.qualifier
+      assert_equal nil, issue.repository
+      assert_equal "43", issue.number
+    end
+
+    should "extract single issue references followed by a period" do
+      text = "See GH-43."
+      parser = Ping::Parser.new(text)
+      issue = parser.issues.first
+
+      assert_equal nil, issue.qualifier
+      assert_equal nil, issue.repository
+      assert_equal "43", issue.number
+    end
+
+    should "extract close qualifiers" do
+      %w{fix fixes fixed close closes closed resolve resolves resolved}.each do |q|
+        text = "#{q} GH-55"
+        parser = Ping::Parser.new(text)
+        issue = parser.issues.first
+
+        assert_equal q, issue.qualifier
+        assert_equal nil, issue.repository
+        assert_equal "55", issue.number
+      end
+    end
+
+    should "extract dependency qualifiers" do
+      %w{need needs needed require requires required}.each do |q|
+        text = "#{q} GH-123"
+        parser = Ping::Parser.new(text)
+        issue = parser.issues.first
+
+        assert_equal q, issue.qualifier
+        assert_equal nil, issue.repository
+        assert_equal "123", issue.number
+      end
+    end
+
+    should "extract multiple references" do
+      text = "You should look at GH-2 and GH-4 because GH-5 fixes codetree/codetree#6"
+      parser = Ping::Parser.new(text)
+
+      assert parser.issues.include?(2)
+      assert parser.issues.include?(4)
+      assert parser.issues.include?(5)
+      assert parser.issues.include?(6)
+    end
+
+    should "not extract similar non-qualifiers" do
+      text = "afixes GH-43"
+      parser = Ping::Parser.new(text)
+      issue = parser.issues.first
+
+      assert_equal nil, issue.qualifier
+      assert_equal nil, issue.repository
+      assert_equal "43", issue.number
+    end
+
+    should "not choke on case" do
+      text = "FIxEs GH-43"
+      parser = Ping::Parser.new(text)
+      issue = parser.issues.first
+
+      assert_equal "FIxEs", issue.qualifier
+      assert_equal nil, issue.repository
+      assert_equal "43", issue.number
+    end
+
+    should "require only one space between qualifier and issue" do
+      text = "fixes   GH-43"
+      parser = Ping::Parser.new(text)
+      issue = parser.issues.first
+
+      assert_equal nil, issue.qualifier
+      assert_equal nil, issue.repository
+      assert_equal "43", issue.number
+    end
+
+    should "require at least one space before GH" do
+      text = "fixes codetree/codetreeGH-99 and fixes GH-43"
+      parser = Ping::Parser.new(text)
+      issue = parser.issues.first
+
+      assert_equal "fixes", issue.qualifier
+      assert_equal nil, issue.repository
+      assert_equal "43", issue.number
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ping
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Derrick Reimer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-26 00:00:00.000000000 Z
+date: 2014-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler