pin_up 1.4.2 → 1.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b9d8c52115e2b37980524773fe44a0ccbffd91ecb3b5a033ac60f49fd1cc17c4
-  data.tar.gz: d1b6259a2b5f15478731d1068cd2983b4f5e306c8fab2bf7a6bac2d62357bb1c
+  metadata.gz: 1fe1a32870ffc34d85629f81a363474e79a62499f8f5a38e14f96f0b292b6017
+  data.tar.gz: e67a6b43dac04ee50e47349792030937ff7b8afa9583a4db4b26779cea21c0a2
 SHA512:
-  metadata.gz: d83a6f44dc31bab5c5140a0d3047e4fb8ea4827d0f94ae4a17573406f712f3a40ac514e634e2e2143afef6f9e89f1cfbefd32e0682d8fc0b44ffe7d27c1fa508
-  data.tar.gz: a2eb58981ca0ef056654bed2c86abadcf60c57de40be630b65bbc99e7a72a94a322e0815f5c794a8394dd83206df86c6408d027d194209deb402eeaf018b2db4
+  metadata.gz: d563d8e6c9d69ad1d1bc3e6d07fbfa79b780f087711cf558a10f386de2b222e2d281de650ba3054ab1a0956916c6e5df1b35fa85b13c392c263615dbe10753fb
+  data.tar.gz: 58ff548e91c809c51274c1badfde3ad39e5ea63d447a57f0507e1a48a115a6c9565bc8be82c3fba4fac8df52fc72457cc2d6529b98da0c3d3e884aa087af8e84

data/.travis.yml

@@ -2,7 +2,7 @@
 script: bundle exec rspec spec
 language: ruby
 sudo: false
-before_install: gem update bundler
+before_install: gem install bundler:1.17.2
 rvm:
   - 2.3.0
   - 2.4.0

data/Gemfile

@@ -1,3 +1,15 @@
-source "https://rubygems.org"
+source 'https://rubygems.org'
+
+gem 'httparty'
+gem 'rexml'
+
+group :development do
+  gem 'rake'
+  gem 'rdoc'
+  gem 'rspec'
+  gem 'juwelier', '~> 2.1.0'
+  gem 'simplecov'
+  gem 'webmock'
+  gem 'vcr'
+end
 
-gemspec

data/Gemfile.lock

@@ -1,51 +1,114 @@
-PATH
-  remote: .
-  specs:
-    pin_up (1.4.2)
-      httparty (= 0.17.0)
-
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.6.0)
-      public_suffix (>= 2.0.2, < 4.0)
-    crack (0.4.3)
-      safe_yaml (~> 1.0.0)
-    diff-lcs (1.3)
-    hashdiff (0.4.0)
-    httparty (0.17.0)
-      mime-types (~> 3.0)
+    addressable (2.8.5)
+      public_suffix (>= 2.0.2, < 6.0)
+    builder (3.2.4)
+    crack (0.4.5)
+      rexml
+    descendants_tracker (0.0.4)
+      thread_safe (~> 0.3, >= 0.3.1)
+    diff-lcs (1.5.0)
+    docile (1.4.0)
+    faraday (1.10.3)
+      faraday-em_http (~> 1.0)
+      faraday-em_synchrony (~> 1.0)
+      faraday-excon (~> 1.1)
+      faraday-httpclient (~> 1.0)
+      faraday-multipart (~> 1.0)
+      faraday-net_http (~> 1.0)
+      faraday-net_http_persistent (~> 1.0)
+      faraday-patron (~> 1.0)
+      faraday-rack (~> 1.0)
+      faraday-retry (~> 1.0)
+      ruby2_keywords (>= 0.0.4)
+    faraday-em_http (1.0.0)
+    faraday-em_synchrony (1.0.0)
+    faraday-excon (1.1.0)
+    faraday-httpclient (1.0.1)
+    faraday-multipart (1.0.4)
+      multipart-post (~> 2)
+    faraday-net_http (1.0.1)
+    faraday-net_http_persistent (1.2.0)
+    faraday-patron (1.0.0)
+    faraday-rack (1.0.0)
+    faraday-retry (1.0.3)
+    git (1.18.0)
+      addressable (~> 2.8)
+      rchardet (~> 1.8)
+    github_api (0.19.0)
+      addressable (~> 2.4)
+      descendants_tracker (~> 0.0.4)
+      faraday (>= 0.8, < 2)
+      hashie (~> 3.5, >= 3.5.2)
+      oauth2 (~> 1.0)
+    hashdiff (1.0.1)
+    hashie (3.6.0)
+    highline (2.1.0)
+    httparty (0.21.0)
+      mini_mime (>= 1.0.0)
       multi_xml (>= 0.5.2)
-    json (1.8.6)
-    mime-types (3.2.2)
-      mime-types-data (~> 3.2015)
-    mime-types-data (3.2019.0331)
-    multi_json (1.13.1)
+    juwelier (2.1.3)
+      builder
+      bundler (>= 1.13)
+      git (>= 1.2.5)
+      github_api
+      highline (>= 1.6.15)
+      nokogiri (>= 1.5.10)
+      rake
+      rdoc
+      semver
+    jwt (2.7.1)
+    mini_mime (1.1.5)
+    mini_portile2 (2.8.5)
+    multi_json (1.15.0)
     multi_xml (0.6.0)
-    public_suffix (3.1.1)
-    rdoc (3.12.2)
-      json (~> 1.4)
-    rspec (3.7.0)
-      rspec-core (~> 3.7.0)
-      rspec-expectations (~> 3.7.0)
-      rspec-mocks (~> 3.7.0)
-    rspec-core (3.7.1)
-      rspec-support (~> 3.7.0)
-    rspec-expectations (3.7.0)
+    multipart-post (2.3.0)
+    nokogiri (1.15.4)
+      mini_portile2 (~> 2.8.2)
+      racc (~> 1.4)
+    oauth2 (1.4.11)
+      faraday (>= 0.17.3, < 3.0)
+      jwt (>= 1.0, < 3.0)
+      multi_json (~> 1.3)
+      multi_xml (~> 0.5)
+      rack (>= 1.2, < 4)
+    psych (5.1.1.1)
+      stringio
+    public_suffix (5.0.3)
+    racc (1.7.3)
+    rack (3.0.8)
+    rake (13.1.0)
+    rchardet (1.8.0)
+    rdoc (6.6.0)
+      psych (>= 4.0.0)
+    rexml (3.2.6)
+    rspec (3.12.0)
+      rspec-core (~> 3.12.0)
+      rspec-expectations (~> 3.12.0)
+      rspec-mocks (~> 3.12.0)
+    rspec-core (3.12.2)
+      rspec-support (~> 3.12.0)
+    rspec-expectations (3.12.3)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.7.0)
-    rspec-mocks (3.7.0)
+      rspec-support (~> 3.12.0)
+    rspec-mocks (3.12.6)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.7.0)
-    rspec-support (3.7.1)
-    safe_yaml (1.0.5)
-    simplecov (0.7.1)
-      multi_json (~> 1.0)
-      simplecov-html (~> 0.7.1)
-    simplecov-html (0.7.1)
-    vcr (4.0.0)
-    webmock (3.6.0)
-      addressable (>= 2.3.6)
+      rspec-support (~> 3.12.0)
+    rspec-support (3.12.1)
+    ruby2_keywords (0.0.5)
+    semver (1.0.1)
+    simplecov (0.22.0)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+      simplecov_json_formatter (~> 0.1)
+    simplecov-html (0.12.3)
+    simplecov_json_formatter (0.1.4)
+    stringio (3.0.9)
+    thread_safe (0.3.6)
+    vcr (6.2.0)
+    webmock (3.19.1)
+      addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
 
@@ -53,12 +116,15 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  pin_up!
-  rdoc (~> 3.12)
-  rspec (~> 3.7.0)
-  simplecov (~> 0.7.1)
-  vcr (~> 4.0.0)
-  webmock (~> 3.6.0)
+  httparty
+  juwelier (~> 2.1.0)
+  rake
+  rdoc
+  rexml
+  rspec
+  simplecov
+  vcr
+  webmock
 
 BUNDLED WITH
-   1.17.2
+   2.4.14

data/Rakefile

@@ -11,8 +11,8 @@ rescue Bundler::BundlerError => e
 end
 require 'rake'
 
-require 'jeweler'
-Jeweler::Tasks.new do |gem|
+require 'juwelier'
+Juwelier::Tasks.new do |gem|
   # gem is a Gem::Specification... see http://docs.rubygems.org/read/chapter/20 for more options
   gem.name = "pin_up"
   gem.homepage = "http://github.com/dNitza/pin_up"
@@ -24,7 +24,7 @@ Jeweler::Tasks.new do |gem|
   # dependencies defined in Gemfile
   gem.files.exclude(Dir.glob('spec/vcr/*.yml'))
 end
-Jeweler::RubygemsDotOrgTasks.new
+Juwelier::RubygemsDotOrgTasks.new
 
 require 'rake/testtask'
 Rake::TestTask.new(:test) do |test|

data/VERSION

@@ -1 +1 @@
-1.4.2
+1.4.4

data/lib/pin_up/charge.rb

@@ -37,7 +37,7 @@ module Pin
       options.merge! page: page if page
 
       options.each do |key, option|
-        term += "#{key.to_s}=#{URI.encode(option.to_s)}&"
+        term += "#{key.to_s}=#{CGI.escape(option.to_s)}&"
       end
       build_collection_response(make_request(:get, {url: "charges/search?#{term}" } ), pagination)
     end

data/lib/pin_up/pin_errors.rb

@@ -36,6 +36,8 @@ module Pin
       when 422
         message = handle_bad_response(response)
         raise Pin::InvalidResource.new(response, message)
+      else
+        raise Pin::Unknown.new(response, "Unknown error with status code #{http_status}")
       end
     end
 
@@ -72,6 +74,9 @@ module Pin
     end
   end
 
+  class Unknown < SimpleError
+  end
+
   class Unauthorized < SimpleError
   end
 

data/lib/pin_up/subscription.rb

@@ -38,7 +38,7 @@ module Pin
     # and any of: email, card (hash),card_token
     # args: token (String), options (Hash)
     # returns: a subscription object
-    # https://pin.net.au/docs/api/subscriptions#put-subscription
+    # https://pinpayments.com/developers/api-reference/subscriptions#put-subscription
     # NB: When providing a card (hash), you need to specify
     # the full list of details.
     def self.update(token, card_token = nil)

data/lib/pin_up/transfer.rb

@@ -44,7 +44,7 @@ module Pin
       options.merge! page: page if page
 
       options.each do |key, option|
-        term += "#{key.to_s}=#{URI.encode(option.to_s)}&"
+        term += "#{key.to_s}=#{CGI.escape(option.to_s)}&"
       end
       build_collection_response(make_request(:get, {url: "transfers/search?#{term}" } ), pagination)
     end

data/pin_up.gemspec

@@ -1,20 +1,21 @@
-# Generated by jeweler
+# Generated by juwelier
 # DO NOT EDIT THIS FILE DIRECTLY
-# Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
+# Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: pin_up 1.4.0 ruby lib
+# stub: pin_up 1.4.4 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "pin_up".freeze
-  s.version = "1.4.2"
+  s.version = "1.4.4"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Daniel Nitsikopoulos".freeze]
-  s.date = "2018-06-15"
+  s.date = "2023-11-16"
   s.description = "A Ruby gem wrapper for the pin-payments (pinpayments.com) API".freeze
   s.email = "dnitza@gmail.com".freeze
   s.extra_rdoc_files = [
+    "CHANGELOG.md",
     "LICENSE.txt",
     "README.md"
   ]
@@ -64,26 +65,33 @@ Gem::Specification.new do |s|
   ]
   s.homepage = "http://github.com/dNitza/pin_up".freeze
   s.licenses = ["MIT".freeze]
-  s.rubygems_version = "2.7.3".freeze
+  s.rubygems_version = "3.2.22".freeze
   s.summary = "A Ruby gem wrapper for the pin-payments API".freeze
 
   if s.respond_to? :specification_version then
     s.specification_version = 4
+  end
 
-    if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_runtime_dependency(%q<httparty>.freeze, ["= 0.17.0"])
-      s.add_development_dependency(%q<rdoc>.freeze, ["~> 3.12"])
-      s.add_development_dependency(%q<rspec>.freeze, ["~> 3.7.0"])
-      s.add_development_dependency(%q<simplecov>.freeze, ["~> 0.7.1"])
-      s.add_development_dependency(%q<webmock>.freeze, ["~> 3.6.0"])
-      s.add_development_dependency(%q<vcr>.freeze, ["~> 4.0.0"])
-    else
-      s.add_dependency(%q<httparty>.freeze, ["= 0.17.0"])
-      s.add_dependency(%q<rdoc>.freeze, ["~> 3.12"])
-    end
+  if s.respond_to? :add_runtime_dependency then
+    s.add_runtime_dependency(%q<httparty>.freeze, [">= 0"])
+    s.add_runtime_dependency(%q<rexml>.freeze, [">= 0"])
+    s.add_development_dependency(%q<rake>.freeze, [">= 0"])
+    s.add_development_dependency(%q<rdoc>.freeze, [">= 0"])
+    s.add_development_dependency(%q<rspec>.freeze, [">= 0"])
+    s.add_development_dependency(%q<juwelier>.freeze, ["~> 2.1.0"])
+    s.add_development_dependency(%q<simplecov>.freeze, [">= 0"])
+    s.add_development_dependency(%q<webmock>.freeze, [">= 0"])
+    s.add_development_dependency(%q<vcr>.freeze, [">= 0"])
   else
-    s.add_dependency(%q<httparty>.freeze, ["= 0.17.0"])
-    s.add_dependency(%q<rdoc>.freeze, ["~> 3.12"])
+    s.add_dependency(%q<httparty>.freeze, [">= 0"])
+    s.add_dependency(%q<rexml>.freeze, [">= 0"])
+    s.add_dependency(%q<rake>.freeze, [">= 0"])
+    s.add_dependency(%q<rdoc>.freeze, [">= 0"])
+    s.add_dependency(%q<rspec>.freeze, [">= 0"])
+    s.add_dependency(%q<juwelier>.freeze, ["~> 2.1.0"])
+    s.add_dependency(%q<simplecov>.freeze, [">= 0"])
+    s.add_dependency(%q<webmock>.freeze, [">= 0"])
+    s.add_dependency(%q<vcr>.freeze, [">= 0"])
   end
 end
 

data/spec/bank_accounts_spec.rb

@@ -6,7 +6,7 @@ describe Pin::BankAccounts, :vcr do
   end
 
   it 'creates a bank account token and returns its details' do
-    options = { name: 'Roland Robot', bsb: '123456', number: '987654321' }
+    options = { name: 'Roland Robot', bsb: '012984', number: '987654321' }
     expect(Pin::BankAccounts.create(options)['token']).to match(/^[a-z]{2}[_]/)
   end
 end

data/spec/cards_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe 'Card', :vcr, class: Pin::Card do
   let(:card_1) {
     { number: '5520000000000000',
       expiry_month: '12',
-      expiry_year: '2025',
+      expiry_year: Date.today.next_year.year.to_s,
       cvc: '123',
       name: 'Roland Robot',
       address_line1: '123 Fake Street',

data/spec/charges_spec.rb

@@ -4,7 +4,7 @@ describe 'Charge', :vcr, class: Pin::Charges do
   let(:card_1) {
     { number: '5520000000000000',
       expiry_month: '12',
-      expiry_year: '2025',
+      expiry_year: Date.today.next_year.year.to_s,
       cvc: '123',
       name: 'Roland Robot',
       address_line1: '123 Fake Street',

data/spec/customers_spec.rb

@@ -4,7 +4,7 @@ describe 'Customer', :vcr, class: Pin::Customer do
   let(:card_1) {
     { number: '5520000000000000',
       expiry_month: '12',
-      expiry_year: '2025',
+      expiry_year: Date.today.next_year.year.to_s,
       cvc: '123',
       name: 'Roland Robot',
       address_line1: '123 Fake Street',
@@ -17,7 +17,7 @@ describe 'Customer', :vcr, class: Pin::Customer do
   let(:card_2) {
     { number: '4200000000000000',
       expiry_month: '12',
-      expiry_year: '2020',
+      expiry_year: Date.today.next_year.year.to_s,
       cvc: '111',
       name: 'Roland TestRobot',
       address_line1: '123 Fake Road',

data/spec/errors_spec.rb

@@ -4,7 +4,7 @@ describe 'Errors', :vcr, class: Pin::PinError do
   let(:card_1) {
     { number: '5520000000000000',
       expiry_month: '12',
-      expiry_year: '2025',
+      expiry_year: Date.today.next_year.year.to_s,
       cvc: '123',
       name: 'Roland Robot',
       address_line1: '123 Fake Street',
@@ -17,7 +17,7 @@ describe 'Errors', :vcr, class: Pin::PinError do
   let(:card_2) {
     { number: '4200000000000000',
      expiry_month: '12',
-     expiry_year: '2020',
+     expiry_year: Date.today.next_year.year.to_s,
      cvc: '111',
      name: 'Roland TestRobot',
      address_line1: '123 Fake Road',
@@ -36,26 +36,6 @@ describe 'Errors', :vcr, class: Pin::PinError do
     Pin::Customer.create('email@example.com', card_1)['token']
   }
 
-  let(:charge_hash) {
-    { email: 'email@example.com',
-      description: 'A new charge from testing Pin gem',
-      amount: '400',
-      currency: 'AUD',
-      ip_address: '127.0.0.1',
-      card: {
-        number: '5520000000000000',
-        expiry_month: '05',
-        expiry_year: '2012',
-        cvc: '123',
-        name: 'Roland Robot',
-        address_line1: '42 Sevenoaks St',
-        address_city: 'Lathlain',
-        address_postcode: '6454',
-        address_state: 'WA',
-        address_country: 'Australia'
-      } }
-  }
-
   let(:hash_of_details) {
     { email: 'email@example.com',
       description: 'A new charge from testing Pin gem',
@@ -65,7 +45,7 @@ describe 'Errors', :vcr, class: Pin::PinError do
       card: {
         number: '5560000000000001',
         expiry_month: '12',
-        expiry_year: '2025',
+        expiry_year: Date.today.next_year.year.to_s,
         cvc: '123',
         name: 'Roland Robot',
         address_line1: '42 Sevenoaks St',
@@ -335,11 +315,11 @@ describe 'Errors', :vcr, class: Pin::PinError do
     end
   end
 
-  it 'should raise a 400 invalid state when deleting a cancelled subscription' do
+  it 'should raise a 422 invalid state when deleting a cancelled subscription' do
     deleted_subscription_token = Pin::Subscription.delete(subscription_1_token)['token']
     expect { Pin::Subscription.delete(deleted_subscription_token) }.to raise_error do |error|
       expect(error).to be_a Pin::InvalidResource
-      expect(error.message).to eq 'Cannot cancel subscription when state is trial_cancelling'
+      expect(error.message).to eq 'invalid_request: Cannot cancel subscription when state is cancelling'
       expect(error.response).to be_a Hash
     end
   end

data/spec/plan_spec.rb

@@ -35,7 +35,7 @@ describe 'Plan', :vcr, class: Pin::Plan do
   let(:card_1) {
     { number: '5520000000000000',
      expiry_month: '12',
-     expiry_year: '2025',
+     expiry_year: Date.today.next_year.year.to_s,
      cvc: '123',
      name: 'Roland Robot',
      address_line1: '123 Fake Street',
@@ -48,7 +48,7 @@ describe 'Plan', :vcr, class: Pin::Plan do
   let(:card_2) {
     { number: '4200000000000000',
      expiry_month: '12',
-     expiry_year: '2020',
+     expiry_year: Date.today.next_year.year.to_s,
      cvc: '111',
      name: 'Roland TestRobot',
      address_line1: '123 Fake Road',
@@ -114,8 +114,12 @@ describe 'Plan', :vcr, class: Pin::Plan do
                                  "created_at"=>match(/\d/),
                                  "customer_permissions"=>["cancel"],
                                  "token"=>match(/(plan)[_]([\w-]{22})/),
-                                 "active_subscriptions"=>0,
-                                 "trial_subscriptions"=>0)
+                                 "subscription_counts" => {
+                                   "trial"=>0,
+                                    "active"=>0,
+                                    "cancelling"=>0,
+                                    "cancelled"=>0
+                                 })
   end
 
   it 'should return a paginated list of all plans' do

data/spec/recipients_spec.rb

@@ -6,7 +6,7 @@ describe Pin::Recipient, :vcr do
       name: 'Roland Robot',
       bank_account: {
         name: 'Roland Robot',
-        bsb: '123456',
+        bsb: '012984',
         number: 987654321
       } }
   }

data/spec/refund_spec.rb

@@ -4,7 +4,7 @@ describe 'Refund', :vcr, class: Pin::Refund do
   let(:card_1) {
     { number: '5520000000000000',
      expiry_month: '12',
-     expiry_year: '2025',
+     expiry_year: Date.today.next_year.year.to_s,
      cvc: '123',
      name: 'Roland Robot',
      address_line1: '123 Fake Street',

data/spec/spec_helper.rb

@@ -25,7 +25,7 @@ RSpec.configure do |config|
           .gsub(/[^\w\/]+/, '_')
     valid_keys = %w[record match_on_requests_on]
     options = example.metadata.select { |key,_| valid_keys.include? key }
-    VCR.use_cassette(name, record: :all) { example.call }
+    VCR.use_cassette(name, record: :once) { example.call }
   end
 end
 
@@ -33,4 +33,7 @@ VCR.configure do |c|
   c.cassette_library_dir = 'spec/vcr'
   c.hook_into :webmock
   c.allow_http_connections_when_no_cassette = true
+
+  c.filter_sensitive_data('PIN_SECRET') { ENV['PIN_SECRET'] }
+  c.filter_sensitive_data('PIN_SECRET_BASIC_AUTH') { Base64.strict_encode64(ENV['PIN_SECRET'].to_s + ':') }
 end

data/spec/subscription_spec.rb

@@ -35,7 +35,7 @@ describe 'Subscription', :vcr, class: Pin::Subscription do
   let(:card_1) {
     { number: '5520000000000000',
      expiry_month: '12',
-     expiry_year: '2025',
+     expiry_year: Date.today.next_year.year.to_s,
      cvc: '123',
      name: 'Roland Robot',
      address_line1: '123 Fake Street',
@@ -48,7 +48,7 @@ describe 'Subscription', :vcr, class: Pin::Subscription do
   let(:card_2) {
     { number: '4200000000000000',
      expiry_month: '12',
-     expiry_year: '2020',
+     expiry_year: Date.today.next_year.year.to_s,
      cvc: '111',
      name: 'Roland TestRobot',
      address_line1: '123 Fake Road',
@@ -173,27 +173,30 @@ describe 'Subscription', :vcr, class: Pin::Subscription do
     expect(Pin::Subscription.reactivate(deactivated['token'])['state']).to eq('active')
   end
 
-  it 'should fetch history for a subscription given a token' do
-    expect(Pin::Subscription.history(subscription_2_token)).to_not eq []
-  end
+  ## History no longer exists as an endpoint
+  ## Leaving this in for reference
 
-  it 'should go to a specific page when page parameter is passed' do
-    request = Pin::Subscription.history(subscription_2_token, 20, true)
-    expect(request[:pagination]['current']).to eq 20
-  end
+  # it 'should fetch history for a subscription given a token' do
+  #   expect(Pin::Subscription.history(subscription_2_token)).to_not eq []
+  # end
 
-  it 'should list subscriptions on a page given a page' do
-    request = Pin::Subscription.history(subscription_2_token, 1, true)
-    expect(request[:response]).to_not eq []
-  end
+  # it 'should go to a specific page when page parameter is passed' do
+  #   request = Pin::Subscription.history(subscription_2_token, 20, true)
+  #   expect(request[:pagination]['current']).to eq 20
+  # end
 
-  it 'should return pagination if true is passed for pagination' do
-    request = Pin::Subscription.history(subscription_2_token, 1, true)
-    request[:pagination].key?(%W('current previous next per_page pages count))
-  end
+  # it 'should list subscriptions on a page given a page' do
+  #   request = Pin::Subscription.history(subscription_2_token, 1, true)
+  #   expect(request[:response]).to_not eq []
+  # end
 
-  it 'should not list subscriptions for a given page if there are no subscriptions' do
-    request = Pin::Subscription.history(subscription_2_token, 25, true)
-    expect(request[:response]).to eq []
-  end
+  # it 'should return pagination if true is passed for pagination' do
+  #   request = Pin::Subscription.history(subscription_2_token, 1, true)
+  #   request[:pagination].key?(%W('current previous next per_page pages count))
+  # end
+
+  # it 'should not list subscriptions for a given page if there are no subscriptions' do
+  #   request = Pin::Subscription.history(subscription_2_token, 25, true)
+  #   expect(request[:response]).to eq []
+  # end
 end

data/spec/transfers_spec.rb

@@ -5,7 +5,7 @@ describe Pin::Transfer, :vcr do
     { email: 'test@example.com',
       name: 'Roland Robot',
       bank_account: { name: 'Roland Robot',
-                      bsb: '123456',
+                      bsb: '012984',
                       number: 987654321 } }
   }
 
@@ -55,5 +55,5 @@ describe Pin::Transfer, :vcr do
 
   it 'should list transfers for search on a page given a page' do
     expect(Pin::Transfer.search(1, query: 'Pay day')).to_not eq []
-  end  
+  end
 end

data/spec/webhook_endpoints_spec.rb

@@ -2,8 +2,12 @@ require 'spec_helper'
 require 'securerandom'
 
 RSpec.describe 'WebhookEndpoints', :vcr, class: Pin::WebhookEndpoints do
+  let(:create_endpoint) {
+    Pin::WebhookEndpoints.create(url: "http://example.com/webhooks#{SecureRandom.urlsafe_base64}/")
+  }
+
   let(:token) {
-    Pin::WebhookEndpoints.create({ url: "http://example.com/webhooks#{SecureRandom.urlsafe_base64}/" })['token']
+    create_endpoint['token']
   }
 
   before(:each) do
@@ -16,11 +20,13 @@ RSpec.describe 'WebhookEndpoints', :vcr, class: Pin::WebhookEndpoints do
   end
 
   it 'should list webhook endpoints' do
+    create_endpoint
     expect(Pin::WebhookEndpoints.all).to_not eq []
     Pin::WebhookEndpoints.delete(token) # since we are only allowed 5 or so sandbox webhooks
   end
 
   it 'should list webhook endpoint on a page given a page' do
+    create_endpoint
     request = Pin::WebhookEndpoints.all(1, true)
     expect(request[:response]).to_not eq []
     Pin::WebhookEndpoints.delete(token) # since we are only allowed 5 or so sandbox webhooks

metadata

@@ -1,104 +1,147 @@
 --- !ruby/object:Gem::Specification
 name: pin_up
 version: !ruby/object:Gem::Version
-  version: 1.4.2
+  version: 1.4.4
 platform: ruby
 authors:
 - Daniel Nitsikopoulos
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-06-15 00:00:00.000000000 Z
+date: 2023-11-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.17.0
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.17.0
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rexml
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.12'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.12'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: juwelier
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.7.0
+        version: 2.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.7.0
+        version: 2.1.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.7.1
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.7.1
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.6.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.6.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 4.0.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 4.0.0
+        version: '0'
 description: A Ruby gem wrapper for the pin-payments (pinpayments.com) API
 email: dnitza@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files:
+- CHANGELOG.md
 - LICENSE.txt
 - README.md
 files:
@@ -148,7 +191,7 @@ homepage: http://github.com/dNitza/pin_up
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -163,8 +206,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.2.22
+signing_key:
 specification_version: 4
 summary: A Ruby gem wrapper for the pin-payments API
 test_files: []