piliponi 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e17b42c405d47c28ce0322084f2807d51bfaca6d
-  data.tar.gz: a4bd72acdc0c0c7ae91f1a05e3d7cc8f27800f02
+  metadata.gz: 2fc73d412120edaa5b8dbd13b56df4742cdcb0c3
+  data.tar.gz: e9bb625a0be9c043c20e28bcfeb3f0da28b37b2e
 SHA512:
-  metadata.gz: db1d7ff2967a5fe8478e129d412e7d82635b7b5b2a80012640ca602e0b82a40dd4918ca3c4b6d4d29385747eaad930c3f8b4547089bc555182b5ada6414bf640
-  data.tar.gz: d7210b10f80175e02137bb9a500b6629e28bcae974934b237d8cf7b8ec7c7bb79148d10e1a7c8c10380cbc1c8244f0106e9a382b67266ec3c06938413932b9c4
+  metadata.gz: 61f57fc4c136cdfe3758bb0bb1eeaf59d38ae78a3e65931be7e947bf9f72b2fd92139440c6fcd90ff8dcd6f979309f3234264215c88e24efbc677bd40c240640
+  data.tar.gz: a5e8368ed8c8dfd83d66211c4be625b3322565be48cacc3dd971a5beea4067f13175571ad4a7098a1fa2d6c01b53764703f28fcd9cee17bbfcf086f207611f8a

data/README.md

@@ -78,8 +78,6 @@ Returns formatted numbers as specified
 ##Needs
 
 Accepting Integers
-<br>
-Thorough testing
 
 ## Contributing
 

data/lib/piliponi/config/telco.yml

@@ -0,0 +1,57 @@
+smart:
+  - 0813
+  - 0907
+  - 0908
+  - 0909
+  - 0910
+  - 0911
+  - 0912
+  - 0913
+  - 0914
+  - 0918
+  - 0919
+  - 0920
+  - 0921
+  - 0928
+  - 0929
+  - 0930
+  - 0938
+  - 0939
+  - 0946
+  - 0947
+  - 0948
+  - 0949
+  - 0989
+  - 0998
+  - 0999
+sun: 
+  - 0922
+  - 0923
+  - 0924
+  - 0932
+  - 0933
+  - 0934
+  - 0942
+  - 0943
+globe: 
+  - 0817
+  - 0905
+  - 0906
+  - 0915
+  - 0916
+  - 0917
+  - 0925
+  - 0926
+  - 0927
+  - 0935
+  - 0936
+  - 0937
+  - 0994
+  - 0996
+  - 0997
+  - 0977
+  - 0979
+exetel:
+  - 0973
+  - 0974
+

data/lib/piliponi/piliponi_api.rb

@@ -1,23 +1,14 @@
+require 'yaml'
+
 module Core
+
+  PREFIXES = YAML.load_file(File.join(File.dirname(__FILE__),"config/telco.yml"))
+
   class PiliponiApi
     def lookup(prefix)
-      smart = %w{0813 0918 0947 0998 0999}
-      globe = %w{0817 0905 0906 0915 0916 0917 0925 0926 0927 0935 0936 0937 0945 0994 0995 0996 0997}
-      sun = %w{0922 0923 0932 0933 0934 0942 0943}
-      smart_others = %w{0907 0908 0909 0910 0912 0919 0920 0921 0928 0929 0930 0938 0939 0946 0948 0949 0989}
-
+      network = PREFIXES.find { |k,v| v.include? prefix }
 
-      if smart.include? prefix
-        "smart"
-      elsif globe.include? prefix
-        "globe"
-      elsif sun.include? prefix
-        "sun"
-      elsif smart_others.include? prefix
-        "smart_others"
-      else
-        "unknown"
-      end
+      network ? network[0] : "unknown"
     end
 
   end

data/lib/piliponi/version.rb

@@ -1,3 +1,3 @@
 module Piliponi
-  VERSION = "1.1.0"
+  VERSION = "1.2.0"
 end

data/spec/piliponi_spec.rb

@@ -1,259 +1,128 @@
 require 'spec_helper'
 
-class Dummy
-  include Piliponi
-end
-
 describe Piliponi do
 
-  describe "as Instance Methods" do
-    let!(:piliponi) { Dummy.new }
-
-    context "#plausible?" do
-
-      it "works" do
-        lambda do
-          piliponi.plausible?("whatevs")
-        end.should_not raise_error
-      end
-
-      it "returns true given 9170000001" do
-        piliponi.plausible?("9170000001").should eq(true)
-      end
-
-      it "returns true given 639170000001" do
-        piliponi.plausible?("639170000001").should eq(true)
-      end
-
-      it "returns true given +639170000001" do
-        piliponi.plausible?("+639170000001").should eq(true)
-      end
-
-      it "returns false given a non-numerical string" do
-        piliponi.plausible?("wawa").should eq(false)
-      end
+  describe ".plausible?" do
 
+    it "returns true given 9170000001" do
+      expect(Piliponi.plausible? "9170000001").to eq(true)
     end
 
-    context "#clean" do
-
-      it "removes characters" do
-        piliponi.clean("+639170000001").should eq("639170000001")
-      end
-
-      it "returns nil if no number is placed" do
-        piliponi.clean.should be_nil
-      end
-
+    it "returns true given 639170000001" do
+      expect(Piliponi.plausible? "639170000001").to eq(true)
     end
 
-    context "#normalize" do
-      let(:number) { '(0919) 363-2598' }
-
-      it "formats to 09XXXXXXXX" do
-        piliponi.normalize(number, {format: 'local'}).should eq('09193632598')
-      end
-
-      it "formats to +639XXXXXXX" do
-        piliponi.normalize(number, {format: 'international'}).should eq('+639193632598')
-      end
-
-      it "formats to 9XXXXXXX" do
-        piliponi.normalize(number, {format: 'pure'}).should eq('9193632598')
-      end
-
-      context "when the format passed is not recognized" do
-
-        it "raises FormatNotRecognizedException" do
-          expect{
-            piliponi.normalize(number, format: :foo)
-          }.to raise_error(FormatNotRecognizedException)
-
-          expect{
-            piliponi.normalize(number, format: :foo)
-          }.to raise_error(FormatNotRecognizedException)
-        end
-
-      end
-
-      context "when the number is not valid" do
-
-        it "raises InvalidPhoneNumberException" do
-          expect{
-            piliponi.normalize("notanumber", format: :local)
-          }.to raise_error(InvalidPhoneNumberException)
-        end
-
-      end
+    it "returns true given +639170000001" do
+      expect(Piliponi.plausible? "+639170000001").to eq(true)
     end
 
-    context "#telco?" do
-
-      it "returns smart for 09XX" do
-        piliponi.telco?('09181234567').should eq('smart')
-      end
-
-      it "returns globe for 09XX" do
-        piliponi.telco?("09170000000").should eq("globe")
-      end
-
-      it "returns sun for 09XX" do
-        piliponi.telco?("09220000000").should eq("sun")
-      end
-
-      it "returns talk and text/ addict or red" do
-        piliponi.telco?("09070000000").should eq("smart_others")
-      end
-
+    it "returns false given a non-numerical string" do
+      expect(Piliponi.plausible? "wawa").to eq(false)
     end
 
-    context '#prefix' do
-      describe '09171231234' do
+  end
 
-        it 'returns 0917' do
-          expect(piliponi.prefix('09171231234')).to eq '0917'
-          expect(piliponi.prefix('639171231234')).to eq '0917'
-          expect(piliponi.prefix('9171231234')).to eq '0917'
-        end
+  describe ".clean" do
 
-      end
+    it "removes characters" do
+      expect(Piliponi.clean "+639170000001").to eq("639170000001")
     end
 
-    context '#clean_prefix' do
-      describe '0917' do
-
-        it 'retunrs 0917' do
-          expect(piliponi.prefix('0917')).to eq '0917'
-          expect(piliponi.prefix('63917')).to eq '0917'
-          expect(piliponi.prefix('917')).to eq '0917'
-        end
-
-      end
+    it "returns nil if no number is placed" do
+      expect(Piliponi.clean).to be_nil
     end
-  end
-
-  describe "as Singleton Methods" do
-
-    context "#plausible?" do
 
-      it "works" do
-        lambda do
-          Piliponi.plausible?("whatevs")
-        end.should_not raise_error
-      end
-
-      it "returns true given 9170000001" do
-        Piliponi.plausible?("9170000001").should eq(true)
-      end
-
-      it "returns true given 639170000001" do
-        Piliponi.plausible?("639170000001").should eq(true)
-      end
+  end
 
-      it "returns true given +639170000001" do
-        Piliponi.plausible?("+639170000001").should eq(true)
-      end
-
-      it "returns false given a non-numerical string" do
-        Piliponi.plausible?("wawa").should eq(false)
-      end
+  describe ".normalize" do
+    let(:number) { '(0919) 363-2598' }
 
+    it "formats to 09XXXXXXXX" do
+      expect(Piliponi.normalize number, {format: 'local'}).to eq('09193632598')
     end
 
-    context "#clean" do
-
-      it "removes characters" do
-        Piliponi.clean("+639170000001").should eq("639170000001")
-      end
-
-      it "returns nil if no number is placed" do
-        Piliponi.clean.should be_nil
-      end
-
+    it "formats to +639XXXXXXX" do
+      expect(Piliponi.normalize number, {format: 'international'}).to eq('+639193632598')
     end
 
-    context "#normalize" do
-      let(:number) { '(0919) 363-2598' }
+    it "formats to 9XXXXXXX" do
+      expect(Piliponi.normalize number, {format: 'pure'}).to eq('9193632598')
+    end
 
-      it "formats to 09XXXXXXXX" do
-        Piliponi.normalize(number, {format: 'local'}).should eq('09193632598')
-      end
+    context "when the format passed is not recognized" do
 
-      it "formats to +639XXXXXXX" do
-        Piliponi.normalize(number, {format: 'international'}).should eq('+639193632598')
-      end
+      it "raises FormatNotRecognizedException" do
+        expect{
+          Piliponi.normalize(number, format: :foo)
+        }.to raise_error(FormatNotRecognizedException)
 
-      it "formats to 9XXXXXXX" do
-        Piliponi.normalize(number, {format: 'pure'}).should eq('9193632598')
+        expect{
+          Piliponi.normalize(number, format: :foo)
+        }.to raise_error(FormatNotRecognizedException)
       end
 
-      context "when the format passed is not recognized" do
-
-        it "raises FormatNotRecognizedException" do
-          expect{
-            Piliponi.normalize(number, format: :foo)
-          }.to raise_error(FormatNotRecognizedException)
+    end
 
-          expect{
-            Piliponi.normalize(number, format: :foo)
-          }.to raise_error(FormatNotRecognizedException)
-        end
+    context "when the number is not valid" do
 
+      it "raises InvalidPhoneNumberException" do
+        expect{
+          Piliponi.normalize("notanumber", format: :local)
+        }.to raise_error(InvalidPhoneNumberException)
       end
 
-      context "when the number is not valid" do
-
-        it "raises InvalidPhoneNumberException" do
-          expect{
-            Piliponi.normalize("notanumber", format: :local)
-          }.to raise_error(InvalidPhoneNumberException)
-        end
-
-      end
     end
+  end
 
-    context "#telco?" do
+  describe ".telco?" do
 
+    context "with valid prefixes"  do
       it "returns smart for 09XX" do
-        Piliponi.telco?('09181234567').should eq('smart')
+        expect(Piliponi.telco? '09181234567').to eq('smart')
       end
 
       it "returns globe for 09XX" do
-        Piliponi.telco?("09170000000").should eq("globe")
+        expect(Piliponi.telco? "09170000000").to eq('globe')
       end
 
       it "returns sun for 09XX" do
-        Piliponi.telco?("09220000000").should eq("sun")
+        expect(Piliponi.telco? "09220000000").to eq('sun')
       end
 
-      it "returns talk and text/ addict or red" do
-        Piliponi.telco?("09070000000").should eq("smart_others")
+      it "returns exetel" do
+        expect(Piliponi.telco? "09730000000").to eq('exetel')
       end
+    end
 
+    context "with unknown prefixes" do
+      it "returns unknown" do
+        expect(Piliponi.telco? "0890000000").to eq('unknown')
+      end
     end
 
-    context '#prefix' do
-      describe '09171231234' do
+  end
 
-        it 'returns 0917' do
-          expect(Piliponi.prefix('09171231234')).to eq '0917'
-          expect(Piliponi.prefix('639171231234')).to eq '0917'
-          expect(Piliponi.prefix('9171231234')).to eq '0917'
-        end
+  describe '.prefix' do
+    context '09171231234' do
 
+      it 'returns 0917' do
+        expect(Piliponi.prefix('09171231234')).to eq '0917'
+        expect(Piliponi.prefix('639171231234')).to eq '0917'
+        expect(Piliponi.prefix('9171231234')).to eq '0917'
       end
-    end
 
-    context '#clean_prefix' do
-      describe '0917' do
+    end
+  end
 
-        it 'retunrs 0917' do
-          expect(Piliponi.prefix('0917')).to eq '0917'
-          expect(Piliponi.prefix('63917')).to eq '0917'
-          expect(Piliponi.prefix('917')).to eq '0917'
-        end
+  describe '.clean_prefix' do
+    context '0917' do
 
+      it 'returns 0917' do
+        expect(Piliponi.prefix('0917')).to eq '0917'
+        expect(Piliponi.prefix('63917')).to eq '0917'
+        expect(Piliponi.prefix('917')).to eq '0917'
       end
+
     end
   end
 end

metadata

@@ -1,55 +1,55 @@
 --- !ruby/object:Gem::Specification
 name: piliponi
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Ace Dimasuhid
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-06 00:00:00.000000000 Z
+date: 2015-06-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Philippine Mobile Phone Formatter
@@ -59,13 +59,14 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - lib/piliponi.rb
+- lib/piliponi/config/telco.yml
 - lib/piliponi/core.rb
 - lib/piliponi/piliponi_api.rb
 - lib/piliponi/support.rb
@@ -83,17 +84,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.6
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Mobile Phone Number Formatter for the Philippines