pike13 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b5f3e87a08c579d9ce3a38bf31c5b22005bddf994ccce24e7f00141acb05d7c6
-  data.tar.gz: 6d4dda290d920e1c0a23fa00eb7eb7eeca1c9a6da0bb2e35430d6dc2860f4fac
+  metadata.gz: d5117c5f082b975cbb6e9a129a6307053ec1f467d38308afe24720177bd83672
+  data.tar.gz: ad02587897b224c080c5f239fb76a9006a020467a408a570397a03fb685d2d7c
 SHA512:
-  metadata.gz: 85846555ad55cb506f48b72448e0299b80e3b74fb65c401087b953f8b5dce051f7a5ae24aac8a5779334871820763a9c0a8e773e8938059404c615bc0365085f
-  data.tar.gz: 101ece99ffe6d5fd57f557e77e706b2ed8125e3cfa77eae1aba0dd3233ca8c05edf49c37503514f01ce6dc02aecf2701b6fcf6237e03e97d3bdf8ce7903c391d
+  metadata.gz: 1ae0eb982ed50a1ada4b807be1ae05aa891a8a9ff92552dfe86bb872ddd2e22d0f5d93073b823a15345ede7c33c0df60e0ea51f1f081f586bef2ac4135b7713c
+  data.tar.gz: 87559b54a79aee56f30a28f4cf6cd3b12b65d73a9d6863d89de77075dd7bfaea0fe3f9f7108759e94fe57fcfe01755a1f2fcc9db02f87f1ad3da55c81de00384

data/CHANGELOG.md

@@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.1.2] - 2025-11-06
+
+### Fixed
+- **Desk::MakeUp**: Removed unsupported `find(id)` method that was not supported by the Pike13 API v2.
+
 ## [0.1.1] - 2025-11-02
 
 ### Fixed

data/README.md

@@ -1,5 +1,7 @@
 # Pike13 Ruby Client
 
+[![CI](https://github.com/juanhuttemann/pike13-ruby/actions/workflows/ci.yml/badge.svg)](https://github.com/juanhuttemann/pike13-ruby/actions/workflows/ci.yml)
+
 A Ruby gem for interacting with the Pike13 API, supporting both:
 - **[Core API](https://developer.pike13.com/docs/api/v2)** - CRUD operations for managing people, events, invoices, and more
 - **[Reporting API](https://developer.pike13.com/docs/reporting/v3)** - Advanced analytics and reporting queries
@@ -256,7 +258,6 @@ Pike13::Desk::Note.destroy(person_id: 123, id: 1000)
 #### Make-Ups
 
 ```ruby
-Pike13::Desk::MakeUp.find(1100)                             # Find make-up
 Pike13::Desk::MakeUp.reasons                                # List make-up reasons
 Pike13::Desk::MakeUp.generate(visit_id: 456, make_up_reason_id: 5, free_form_reason: "Client was sick")
 ```

data/lib/pike13/api/v2/account/business.rb

@@ -10,7 +10,6 @@ module Pike13
             def all
               client.get("account/businesses")
             end
-
           end
         end
       end

data/lib/pike13/api/v2/desk/make_up.rb

@@ -6,11 +6,6 @@ module Pike13
       module Desk
         class MakeUp < Base
           class << self
-            # GET /desk/make_ups/:id
-            def find(id)
-              client.get("desk/make_ups/#{id}")
-            end
-
             # GET /desk/make_ups/reasons
             def reasons
               client.get("desk/make_ups/reasons")

data/lib/pike13/validators.rb

@@ -11,13 +11,9 @@ module Pike13
     # @raise [ValidationError] if token is invalid
     # @return [Boolean] true if valid
     def self.validate_idempotency_token!(token)
-      if token.nil? || token.to_s.strip.empty?
-        raise ValidationError, "Idempotency token cannot be blank"
-      end
+      raise ValidationError, "Idempotency token cannot be blank" if token.nil? || token.to_s.strip.empty?
 
-      unless token.is_a?(String)
-        raise ValidationError, "Idempotency token must be a string, got #{token.class}"
-      end
+      raise ValidationError, "Idempotency token must be a string, got #{token.class}" unless token.is_a?(String)
 
       if token.length > 255
         raise ValidationError, "Idempotency token must be 255 characters or less, got #{token.length}"
@@ -32,9 +28,7 @@ module Pike13
     # @raise [ValidationError] if attributes are invalid
     # @return [Boolean] true if valid
     def self.validate_note_attributes!(attributes)
-      unless attributes.is_a?(Hash)
-        raise ValidationError, "Note attributes must be a hash, got #{attributes.class}"
-      end
+      raise ValidationError, "Note attributes must be a hash, got #{attributes.class}" unless attributes.is_a?(Hash)
 
       if attributes.key?(:body) || attributes.key?("body")
         raise ValidationError,
@@ -47,9 +41,7 @@ module Pike13
       end
 
       note_value = attributes[:note] || attributes["note"]
-      if note_value.to_s.strip.empty?
-        raise ValidationError, "Note text cannot be blank"
-      end
+      raise ValidationError, "Note text cannot be blank" if note_value.to_s.strip.empty?
 
       true
     end
@@ -62,13 +54,11 @@ module Pike13
     def self.validate_form_of_payment_type!(type)
       valid_types = %w[creditcard ach]
 
-      unless type.is_a?(String)
-        raise ValidationError, "Form of payment type must be a string, got #{type.class}"
-      end
+      raise ValidationError, "Form of payment type must be a string, got #{type.class}" unless type.is_a?(String)
 
       unless valid_types.include?(type.downcase)
         raise ValidationError,
-              "Form of payment type must be one of: #{valid_types.join(', ')}. Got: '#{type}'"
+              "Form of payment type must be one of: #{valid_types.join(", ")}. Got: '#{type}'"
       end
 
       true
@@ -80,15 +70,11 @@ module Pike13
     # @raise [ValidationError] if parameters are invalid
     # @return [Boolean] true if valid
     def self.validate_booking_params!(params)
-      unless params.is_a?(Hash)
-        raise ValidationError, "Booking parameters must be a hash, got #{params.class}"
-      end
+      raise ValidationError, "Booking parameters must be a hash, got #{params.class}" unless params.is_a?(Hash)
 
       # Check for idempotency token
       token = params[:idempotency_token] || params["idempotency_token"]
-      if token
-        validate_idempotency_token!(token)
-      end
+      validate_idempotency_token!(token) if token
 
       # Require either event_occurrence_id or leases array
       has_event = params[:event_occurrence_id] || params["event_occurrence_id"]
@@ -108,27 +94,19 @@ module Pike13
     # @raise [ValidationError] if attributes are invalid
     # @return [Boolean] true if valid
     def self.validate_person_attributes!(attributes)
-      unless attributes.is_a?(Hash)
-        raise ValidationError, "Person attributes must be a hash, got #{attributes.class}"
-      end
+      raise ValidationError, "Person attributes must be a hash, got #{attributes.class}" unless attributes.is_a?(Hash)
 
       # Check required fields
       first_name = attributes[:first_name] || attributes["first_name"]
       last_name = attributes[:last_name] || attributes["last_name"]
 
-      if first_name.to_s.strip.empty?
-        raise ValidationError, "Person must have a first_name"
-      end
+      raise ValidationError, "Person must have a first_name" if first_name.to_s.strip.empty?
 
-      if last_name.to_s.strip.empty?
-        raise ValidationError, "Person must have a last_name"
-      end
+      raise ValidationError, "Person must have a last_name" if last_name.to_s.strip.empty?
 
       # Validate email format if provided
       email = attributes[:email] || attributes["email"]
-      if email && !email.to_s.match?(/\A[^@\s]+@[^@\s]+\z/)
-        raise ValidationError, "Invalid email format: #{email}"
-      end
+      raise ValidationError, "Invalid email format: #{email}" if email && !email.to_s.match?(/\A[^@\s]+@[^@\s]+\z/)
 
       true
     end

data/lib/pike13/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Pike13
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pike13
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Juan Huttemann