pier_logging 0.1.4 → 0.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1d355c6b8850fce6ffea3a958ade583412cc4d315668c2b3795924ec281ceb1e
-  data.tar.gz: 0c3382adb12ff55ebb201468f6470b722baa6344460a62b8666be0effba6a07c
+  metadata.gz: 35cdfc0d8703bece81fe50518a2e834b7216dbf409960126285f7a319cbaabf4
+  data.tar.gz: 6d13d3e9e03414af4bbcdeb04b895654cff354760c3f8f2e23f2db8511fdbdd8
 SHA512:
-  metadata.gz: 9cb167ecc0b099d029a22b7c60a9d8ad2f8dddf0e586435d936a0344c1b6d3da0e6a8630ddc8e5ad3cb60d0271d56d4e1063ee385064fb7534b31735031b7ce9
-  data.tar.gz: 68c003813d5e5bdb3aa07ee1008cd16e6faad3361d6add6849f3503e6aaadc8621ca86c6fe192719f71c12a20b21f3d602ff06f5ab8f35aa768fd38103d6319a
+  metadata.gz: c9627c7c496e508244c3a9b7c4cbc659d26e77b9a06dceaef2282656bc7ff2705c26cb7065635dad953ac69d571d6f4f623b487b6dbe2c915f22e99627991897
+  data.tar.gz: 4b4d2b2f0ba570aeeea62580dac125a7df90f4d85883056f06855f6e4e51596b0f2fe2f93cd5c080f33a1349095e84f17f01232c54f6c754d8e319c47fd50d7d

data/.github/CODEOWNERS

@@ -0,0 +1,40 @@
+# This is a comment.
+# Each line is a file pattern followed by one or more owners.
+
+# These owners will be the default owners for everything in
+# the repo. Unless a later match takes precedence,
+# @global-owner1 and @global-owner2 will be requested for
+# review when someone opens a pull request.
+*               @pier-digital/backend
+.github/*       @pier-digital/backend @pier-digital/devops
+bin/*           @pier-digital/backend @pier-digital/devops
+
+# # Order is important; the last matching pattern takes the most
+# # precedence. When someone opens a pull request that only
+# # modifies JS files, only @js-owner and not the global
+# # owner(s) will be requested for a review.
+# *.js    @js-owner
+
+# # You can also use email addresses if you prefer. They'll be
+# # used to look up users just like we do for commit author
+# # emails.
+# *.go docs@example.com
+
+# # In this example, @doctocat owns any files in the build/logs
+# # directory at the root of the repository and any of its
+# # subdirectories.
+# /build/logs/ @doctocat
+
+# # The `docs/*` pattern will match files like
+# # `docs/getting-started.md` but not further nested files like
+# # `docs/build-app/troubleshooting.md`.
+# docs/*  docs@example.com
+
+# # In this example, @octocat owns any file in an apps directory
+# # anywhere in your repository.
+# apps/ @octocat
+
+# # In this example, @doctocat owns any file in the `/docs`
+# # directory in the root of your repository.
+# /docs/ @doctocat
+

data/Gemfile.lock

@@ -1,8 +1,9 @@
 PATH
   remote: .
   specs:
-    pier_logging (0.1.2)
+    pier_logging (0.1.7)
       awesome_print
+      facets
       ougai
       rails
 
@@ -70,6 +71,7 @@ GEM
     concurrent-ruby (1.1.6)
     crass (1.0.6)
     erubi (1.9.0)
+    facets (3.1.0)
     globalid (0.4.2)
       activesupport (>= 4.2.0)
     i18n (1.8.3)

data/README.md

@@ -1,8 +1,6 @@
 # PierLogging
 
-Welcome to your new gem! In this directory, you'll find the files you need to be able to package up your Ruby library into a gem. Put your Ruby code in the file `lib/pier_logging`. To experiment with that code, run `bin/console` for an interactive prompt.
-
-TODO: Delete this and the text above, and describe your gem
+A gem developed by [PIER](https://www.pier.digital/) to standardize our logs (request and general-purpose)
 
 ## Installation
 
@@ -22,17 +20,75 @@ Or install it yourself as:
 
 ## Usage
 
-TODO: Write usage instructions here
+- Create an initializer at `config/initializers/pier_logging.rb` to configure the gem.
+- Configure General-purpose logging, Request logging and register the request logger rails middleware.
+- Configure your logger on `config/application.rb` to use `PierLogging::Logger`
+
+### General-purpose logging
+
+Use `PierLogging.configure_logger` block to configure general-purpose logs. Accepted configs are:
+
+| config    | Required | Type                      | Default                            |
+| --------- | --------:| -------------------------:| ----------------------------------:|
+| app_name  | true     | string                    | nil                                |
+| env       | true     | string                    | nil                                |
+| formatter | false    | `Ougai::Formatters::Base` | `PierLogging::Formatter::Json.new` |
+
+### Request logging
+
+Use `PierLogging.configure_request_logger` block to configure request logs. Accepted configs are:
+
+| config           | Required | Type            | Default    |
+| ---------------- | --------:| ---------------:| ----------:|
+| enabled          | false    | boolean         | false      |
+| user_info_getter | true     | block (headers) | nil        |
+
+The block passed to `user_info_getter` receives the headers of the request so you can use your headers to define the username or role. 
 
-## Development
+You have at your disposal the following helper methods:
 
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake test` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+- has_basic_credentials(headers): checks if there are basic auth credentials in the header
+- get_basic_credentials_user(headers): get the user from the basic auth credential
 
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+### Example
+
+```ruby
+# config/initializers/pier_logging.rb
+
+PierLogging.configure_logger do |config|
+  config.app_name = Rails.application.class.module_parent_name.underscore.dasherize
+  config.env = Rails.env
+  config.formatter = Rails.env.production? ? PierLogging::Formatter::Json.new : 
+    PierLogging::Formatter::Readable.new
+end 
+
+PierLogging.configure_request_logger do |config|
+  config.user_info_getter do |headers|
+    if headers['MY-USER-HEADER'].present?
+      { username: headers['MY-USER-HEADER']  }
+    elsif has_basic_credentials?(headers)
+      { username: get_basic_credentials_user(headers) }
+    else
+      { username: 'anonymous' }
+    end
+  end
+  config.enabled = ENV.fetch('REQUEST_LOG_ENABLED', 'true') == 'true'
+end
+
+Rails.application.config.middleware.use PierLogging::RequestLogger, PierLogging::Logger.new(STDOUT)
+```
+
+```ruby
+# config/application.rb
+
+# ...
+config.logger = PierLogging::Logger.new(STDOUT)
+# ...
+```
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/pier_logging.
+Bug reports and pull requests are welcome on GitHub at https://github.com/pier-digital/pier_logging.
 
 ## License
 

data/lib/pier_logging.rb

@@ -1,11 +1,14 @@
 require "rails"
 require "ougai"
+require "awesome_print"
+require "facets"
 require "pier_logging/version"
 require "pier_logging/logger"
 require "pier_logging/request_logger"
 require "pier_logging/formatter/base"
 require "pier_logging/formatter/json"
 require "pier_logging/formatter/readable"
+require "pier_logging/helpers/headers"
 
 module PierLogging
   def self.logger_configuration
@@ -57,12 +60,13 @@ module PierLogging
       @enabled = false
     end
 
-    def user_info_getter(&block)
-      raise ArgumentError, "Config 'user_info_getter' must be a 'Proc'" unless block_given?
-      @user_info_getter = block
+    def user_info_getter=(proc)
+      raise ArgumentError, "Config 'user_info_getter' must be a 'Proc'" unless proc.is_a? Proc
+      @user_info_getter = proc
     end
     
     def enabled=(enabled = false)
+      raise ArgumentError, "Config 'enabled' must be a 'boolean'" unless !!enabled == enabled
       @enabled = enabled
     end
   end

data/lib/pier_logging/helpers/headers.rb

@@ -0,0 +1,20 @@
+module PierLogging
+  module Helpers
+    class Headers
+      def self.has_basic_credentials?(headers)
+        auth_header = headers['AUTHENTICATION'].to_s
+        return false if auth_header.blank?
+        # Optimization: https://github.com/JuanitoFatas/fast-ruby#stringcasecmp-vs-stringdowncase---code
+        return false if auth_header.split(' ', 2)[0].casecmp('basic') == 0
+        return false if auth_header.split(' ', 2)[1].blank?
+        return true
+      end
+
+      def self.get_basic_credentials_user(headers)
+        auth_headers = headers['AUTHENTICATION'].to_s
+        credentials = auth_headers.split(' ', 2)[1]
+        ::Base64.decode64(credentials).split(':', 2)[0]
+      end
+    end
+  end
+end

data/lib/pier_logging/request_logger.rb

@@ -67,7 +67,7 @@ module PierLogging
       # We should never fall in this part as the only errors that could result in this are errors
       # in our logger (inside this same method)
       @logger.error(error.message)
-    end
+    end 
 
     private
     def get_request_headers_from_env(env)
@@ -87,16 +87,15 @@ module PierLogging
     end
 
     def parse_body(body)
-      if body.is_a? String # when string
-        JSON.parse(body, nil, allow_blank: true)
-      elsif body.is_a? Array # Grape body
-        JSON.parse(body.last, nil, allow_blank: true)
-      elsif body.is_a? ActionDispatch::Response::RackBody # Rails body
-        JSON.parse(body.body, nil, allow_blank: true)
-      else
-        body
-      end
+      body_object = get_body_object(body)
+      Oj.load(body_object, allow_blank: true)
     rescue
+      body_object || body
+    end
+
+    def get_body_object(body)
+      return body.last if body.is_a? Array # Grape body
+      return body.body if body.is_a? ActionDispatch::Response::RackBody # Rails body
       body
     end
 
@@ -125,20 +124,5 @@ module PierLogging
     rescue
       500
     end
-
-    def has_basic_credentials?(headers)
-      auth_header = headers['AUTHENTICATION'].to_s
-      return false if auth_header.blank?
-      # Optimization: https://github.com/JuanitoFatas/fast-ruby#stringcasecmp-vs-stringdowncase---code
-      return false if auth_header.split(' ', 2)[0].casecmp('basic') == 0
-      return false if auth_header.split(' ', 2)[1].blank?
-      return true
-    end
-
-    def get_basic_credentials_user(headers)
-      auth_headers = headers['AUTHENTICATION'].to_s
-      credentials = auth_headers.split(' ', 2)[1]
-      ::Base64.decode64(credentials).split(':', 2)[0]
-    end 
   end
 end

data/lib/pier_logging/version.rb

@@ -1,3 +1,3 @@
 module PierLogging
-  VERSION = "0.1.4"
+  VERSION = "0.1.9"
 end

data/pier_logging.gemspec

@@ -26,6 +26,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency "ougai"
   spec.add_dependency "awesome_print"
   spec.add_dependency "rails"
+  spec.add_dependency "facets"
 
   spec.add_development_dependency "bundler", ">= 2.1.4"
   spec.add_development_dependency "rake", ">= 12.3.3"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pier_logging
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.9
 platform: ruby
 authors:
 - Mauricio Banduk
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-07-03 00:00:00.000000000 Z
+date: 2020-07-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ougai
@@ -52,6 +52,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: facets
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -115,6 +129,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/CODEOWNERS"
 - ".github/workflows/publish.yml"
 - ".gitignore"
 - ".ruby-version"
@@ -134,6 +149,7 @@ files:
 - lib/pier_logging/formatter/base.rb
 - lib/pier_logging/formatter/json.rb
 - lib/pier_logging/formatter/readable.rb
+- lib/pier_logging/helpers/headers.rb
 - lib/pier_logging/logger.rb
 - lib/pier_logging/request_logger.rb
 - lib/pier_logging/version.rb