picturehouse_uk 3.0.14 → 4.0.0

data/test/lib/picturehouse_uk/cinema_test.rb

@@ -2,11 +2,10 @@ require_relative '../../test_helper'
 
 describe PicturehouseUk::Cinema do
   let(:described_class) { PicturehouseUk::Cinema }
-  let(:website) { MockWebsite.new }
+  let(:website) { FakeWebsite.new }
 
-  before do
-    WebMock.disable_net_connect!
-  end
+  before { WebMock.disable_net_connect! }
+  after { WebMock.allow_net_connect! }
 
   describe '.all' do
     subject { described_class.all }
@@ -22,7 +21,7 @@ describe PicturehouseUk::Cinema do
 
     it 'returns the correctly sized array' do
       PicturehouseUk::Internal::Website.stub :new, website do
-        subject.size.must_equal 22
+        subject.size.must_equal 23
       end
     end
 
@@ -34,55 +33,19 @@ describe PicturehouseUk::Cinema do
     end
   end
 
-  describe '.find(id)' do
-    subject { described_class.find(id) }
-
-    let(:id) { 'Duke_Of_Yorks' }
-
-    it 'returns a cinema' do
-      PicturehouseUk::Internal::Website.stub :new, website do
-        subject.must_be_instance_of(PicturehouseUk::Cinema)
-
-        subject.id.must_equal id
-        subject.brand.must_equal 'Picturehouse'
-        subject.name.must_equal "Duke of York's Picturehouse"
-        subject.slug.must_equal 'duke-of-yorks-picturehouse'
-        subject.url.must_equal "http://www.picturehouses.com/cinema/#{id}"
-      end
-    end
-  end
-
-  describe '.new(options)' do
-    let(:options) do
-      {
-        id:   'Dukes_At_Komedia',
-        name: "Duke's At Komedia",
-        url:  '/cinema/Dukes_At_Komedia'
-      }
-    end
-
-    subject { described_class.new(options) }
+  describe '.new(id)' do
+    subject { described_class.new('Dukes_At_Komedia') }
 
     it 'stores id, name, slug and url' do
-      subject.id.must_equal 'Dukes_At_Komedia'
-      subject.brand.must_equal 'Picturehouse'
-      subject.name.must_equal "Duke's At Komedia"
-      subject.slug.must_equal 'dukes-at-komedia'
-      subject.url.must_equal 'http://www.picturehouses.com/cinema/Dukes_At_Komedia'
+      subject.must_be_instance_of(PicturehouseUk::Cinema)
     end
   end
 
   describe '#adr' do
-    let(:options) do
-      {
-        id:   'Phoenix_Picturehouse',
-        name: "Pheonix Picturehouse",
-        url:  '/cinema/Phoenix_Picturehouse'
-      }
-    end
+    subject { described_class.new(id).adr }
 
-    describe '#adr' do
-      subject { described_class.new(options).adr }
+    describe 'no region' do
+      let(:id) { 'Phoenix_Picturehouse' }
 
       it 'returns address hash' do
         PicturehouseUk::Internal::Website.stub :new, website do
@@ -92,24 +55,14 @@ describe PicturehouseUk::Cinema do
             locality:         'Oxford',
             region:           nil,
             postal_code:      'OX2 6AE',
-            country:          'United Kingdom'
+            country_name:     'United Kingdom'
           )
         end
       end
     end
-  end
-
-  describe 'integration-y address tests' do
-    let(:options) do
-      {
-        id:   'Dukes_At_Komedia',
-        name: "Duke's At Komedia",
-        url:  '/cinema/Dukes_At_Komedia'
-      }
-    end
 
-    describe '#adr' do
-      subject { described_class.new(options).adr }
+    describe 'with region' do
+      let(:id) { 'Dukes_At_Komedia' }
 
       it 'returns address hash' do
         PicturehouseUk::Internal::Website.stub :new, website do
@@ -119,134 +72,152 @@ describe PicturehouseUk::Cinema do
             locality:         'Brighton',
             region:           'East Sussex',
             postal_code:      'BN1 1UN',
-            country:          'United Kingdom'
+            country_name:     'United Kingdom'
           )
         end
       end
     end
+  end
+
+  describe '#address' do
+    subject { described_class.new(id).address }
 
-    describe '#street_address' do
-      subject { described_class.new(options).street_address }
+    describe 'no region' do
+      let(:id) { 'Phoenix_Picturehouse' }
 
-      it 'returns first line of address' do
+      it 'returns address hash' do
         PicturehouseUk::Internal::Website.stub :new, website do
-          subject.must_equal('44–47 Gardner Street')
+          subject.must_equal(
+            street_address:   '57 Walton Street',
+            extended_address: nil,
+            locality:         'Oxford',
+            region:           nil,
+            postal_code:      'OX2 6AE',
+            country_name:     'United Kingdom'
+          )
         end
       end
     end
+  end
 
-    describe '#extended_address' do
-      subject { described_class.new(options).extended_address }
+  describe '#brand' do
+    subject { described_class.new(id).brand }
 
-      it 'returns second line of address' do
-        PicturehouseUk::Internal::Website.stub :new, website do
-          subject.must_equal(nil)
-        end
+    let(:id) { 'Dukes_At_Komedia' }
+
+    it 'returns Picturehouse' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        subject.must_equal('Picturehouse')
       end
     end
+  end
 
-    describe '#locality' do
-      subject { described_class.new(options).locality }
+  describe '#country_name' do
+    subject { described_class.new(id).country_name }
 
-      it 'returns second line of address' do
-        PicturehouseUk::Internal::Website.stub :new, website do
-          subject.must_equal('Brighton')
-        end
+    let(:id) { 'Dukes_At_Komedia' }
+
+    it 'returns country' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        subject.must_equal('United Kingdom')
       end
     end
+  end
 
-    describe '#region' do
-      subject { described_class.new(options).region }
+  describe '#extended_address' do
+    subject { described_class.new(id).extended_address }
 
-      it 'returns second line of address' do
-        PicturehouseUk::Internal::Website.stub :new, website do
-          subject.must_equal('East Sussex')
-        end
+    let(:id) { 'Dukes_At_Komedia' }
+
+    it 'returns second line of address' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        subject.must_equal('')
       end
     end
+  end
 
-    describe '#postal_code' do
-      subject { described_class.new(options).postal_code }
+  describe '#full_name' do
+    subject { described_class.new(id).full_name }
 
-      it 'returns second line of address' do
-        PicturehouseUk::Internal::Website.stub :new, website do
-          subject.must_equal('BN1 1UN')
-        end
+    let(:id) { 'Dukes_At_Komedia' }
+
+    it 'returns full name (same as name)' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        subject.must_equal("Duke's at Komedia")
+        subject.must_equal(described_class.new(id).name)
       end
     end
   end
 
-  describe '#films' do
-    let(:options) do
-      {
-        id:   'Dukes_At_Komedia',
-        name: "Duke's At Komedia",
-        url:  '/cinema/Dukes_At_Komedia'
-      }
-    end
+  describe '#locality' do
+    subject { described_class.new(id).locality }
 
-    subject { described_class.new(options).films }
+    let(:id) { 'Dukes_At_Komedia' }
 
-    it 'calls out to Film object' do
-      PicturehouseUk::Film.stub :at, [:film] do
-        subject.must_equal([:film])
+    it 'returns second line of address' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        subject.must_equal('Brighton')
       end
     end
   end
 
-  describe '#full_name' do
-    let(:options) do
-      {
-        id:   'Dukes_At_Komedia',
-        name: "Duke's At Komedia",
-        url:  '/cinema/Dukes_At_Komedia'
-      }
-    end
+  describe '#name' do
+    subject { described_class.new(id).name }
 
-    subject { described_class.new(options).full_name }
+    let(:id) { 'Dukes_At_Komedia' }
 
-    it 'returns the cinema name' do
-      subject.must_equal "Duke's At Komedia"
+    it 'returns full name (same as name)' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        subject.must_equal("Duke's at Komedia")
+      end
     end
   end
 
-  describe '#screenings' do
-    let(:options) do
-      {
-        id:   'Dukes_At_Komedia',
-        name: "Duke's At Komedia",
-        url:  '/cinema/Dukes_At_Komedia'
-      }
-    end
+  describe '#postal_code' do
+    subject { described_class.new(id).postal_code }
 
-    subject { described_class.new(options).screenings }
+    let(:id) { 'Dukes_At_Komedia' }
 
-    it 'calls out to Screening object' do
-      PicturehouseUk::Screening.stub :at, [:screening] do
-        subject.must_equal([:screening])
+    it 'returns second line of address' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        subject.must_equal('BN1 1UN')
       end
     end
   end
 
-  private
+  describe '#region' do
+    subject { described_class.new(id).region }
 
-  class MockWebsite
-    def home
-      read_file('../../../fixtures/home.html')
-    end
+    let(:id) { 'Dukes_At_Komedia' }
 
-    def cinema(filename)
-      read_file("../../../fixtures/cinema/#{filename}.html")
+    it 'returns second line of address' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        subject.must_equal('East Sussex')
+      end
     end
+  end
 
-    def info(filename)
-      read_file("../../../fixtures/info/#{filename}.html")
+  describe '#slug' do
+    subject { described_class.new(id).slug }
+
+    let(:id) { 'Dukes_At_Komedia' }
+
+    it 'returns downcased' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        subject.must_equal('dukes-at-komedia')
+      end
     end
+  end
+
+  describe '#street_address' do
+    subject { described_class.new(id).street_address }
 
-    private
+    let(:id) { 'Dukes_At_Komedia' }
 
-    def read_file(filepath)
-      File.read(File.expand_path(filepath, __FILE__))
+    it 'returns first line of address' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        subject.must_equal('44–47 Gardner Street')
+      end
     end
   end
 end

data/test/lib/picturehouse_uk/internal/parser/{address_parser_test.rb → address_test.rb}

@@ -18,7 +18,7 @@ describe PicturehouseUk::Internal::Parser::Address do
                            locality:         nil,
                            region:           nil,
                            postal_code:      nil,
-                           country:          "United Kingdom")
+                           country_name:     "United Kingdom")
       end
     end
 
@@ -32,7 +32,7 @@ describe PicturehouseUk::Internal::Parser::Address do
                            locality:         nil,
                            region:           nil,
                            postal_code:      nil,
-                           country:          "United Kingdom")
+                           country_name:     "United Kingdom")
       end
     end
 
@@ -46,7 +46,7 @@ describe PicturehouseUk::Internal::Parser::Address do
                            locality:         "not an address",
                            region:           nil,
                            postal_code:      "not an address",
-                           country:          "United Kingdom")
+                           country_name:     "United Kingdom")
       end
     end
   end

data/test/lib/picturehouse_uk/internal/parser/screenings_test.rb

@@ -2,12 +2,10 @@ require_relative '../../../../test_helper'
 
 describe PicturehouseUk::Internal::Parser::Screenings do
   let(:described_class) { PicturehouseUk::Internal::Parser::Screenings }
-
   let(:website) { Minitest::Mock.new }
 
-  before do
-    WebMock.disable_net_connect!
-  end
+  before { WebMock.disable_net_connect! }
+  after { WebMock.allow_net_connect! }
 
   %w(Duke_Of_Yorks Dukes_At_Komedia Phoenix_Picturehouse).each do |cinema|
     describe "#{cinema}: #to_a" do
@@ -22,15 +20,15 @@ describe PicturehouseUk::Internal::Parser::Screenings do
 
           subject.each do |element|
             element.must_be_instance_of(Hash)
-            element.keys.must_equal([:film_name, :dimension, :variant, :booking_url, :time])
+            element.keys.must_equal([:film_name, :dimension, :variant,
+                                     :booking_url, :starting_at])
             element[:film_name].must_be_kind_of(String)
             element[:dimension].must_match(/\A[23]d\z/)
             if element[:booking_url]
-              element[:booking_url].must_match(/\Ahttps?\:\/\//)
-              element[:booking_url].must_match(/ticketing/)
-              element[:booking_url].must_match(/visSelectTickets\.aspx\?cinemacode=\d+\&txtSessionId=\d+/)
+              element[:booking_url].must_match(%r{\Ahttps?\://picturehouses.com})
+              element[:booking_url].must_match(%r{/cinema/#{cinema}/film/[-\w]+/tickets/\d+})
             end
-            element[:time].must_be_kind_of(Time)
+            element[:starting_at].must_be_kind_of(Time)
           end
 
           variants = subject.flat_map { |e| e[:variant] }.uniq
@@ -67,6 +65,6 @@ describe PicturehouseUk::Internal::Parser::Screenings do
   end
 
   def html(cinema)
-    read_file("../../../../../fixtures/whats_on/#{cinema}.html")
+    read_file("../../../../../fixtures/#{cinema}/whats_on.html")
   end
 end

data/test/lib/picturehouse_uk/internal/website_test.rb

@@ -3,6 +3,9 @@ require_relative '../../../test_helper'
 describe PicturehouseUk::Internal::Website do
   let(:described_class) { PicturehouseUk::Internal::Website }
 
+  before { WebMock.disable_net_connect! }
+  after { WebMock.allow_net_connect! }
+
   describe '#cinema(id)' do
     subject { described_class.new.cinema('Duke_Of_Yorks') }
 
@@ -56,15 +59,15 @@ describe PicturehouseUk::Internal::Website do
   private
 
   def duke_of_yorks_html
-    read_file('../../../../fixtures/cinema/Duke_Of_Yorks.html')
+    read_file('../../../../fixtures/Duke_Of_Yorks/cinema.html')
   end
 
   def duke_of_yorks_contact_us_html
-    read_file('../../../../fixtures/info/Duke_Of_Yorks.html')
+    read_file('../../../../fixtures/Duke_Of_Yorks/info.html')
   end
 
   def duke_of_yorks_whats_on_html
-    read_file('../../../../fixtures/whats_on/Duke_Of_Yorks.html')
+    read_file('../../../../fixtures/Duke_Of_Yorks/whats_on.html')
   end
 
   def home_html

data/test/lib/picturehouse_uk/{screening_test.rb → performance_test.rb}

@@ -1,31 +1,33 @@
 require_relative '../../test_helper'
 
-describe PicturehouseUk::Screening do
-  let(:website) { MockWebsite.new }
+describe PicturehouseUk::Performance do
+  let(:described_class) { PicturehouseUk::Performance }
+  let(:website) { FakeWebsite.new }
 
   before { WebMock.disable_net_connect! }
+  after { WebMock.allow_net_connect! }
 
   describe '.at(cinema_id)' do
-    subject { PicturehouseUk::Screening.at('Duke_Of_Yorks') }
+    subject { described_class.at('Duke_Of_Yorks') }
 
     it 'returns an array of screenings' do
       PicturehouseUk::Internal::Website.stub :new, website do
         subject.must_be_instance_of(Array)
         subject.each do |screening|
-          screening.must_be_instance_of(PicturehouseUk::Screening)
+          screening.must_be_instance_of(PicturehouseUk::Performance)
         end
       end
     end
 
     it 'returns correct number of screenings' do
       PicturehouseUk::Internal::Website.stub :new, website do
-        subject.count.must_equal 58
+        subject.count.must_be :>, 40
       end
     end
 
     it 'has valid screenings' do
       PicturehouseUk::Internal::Website.stub :new, website do
-        subject.map(&:showing_at).each do |time|
+        subject.map(&:starting_at).each do |time|
           time.wont_equal Time.utc(1970, 1, 1, 0, 0)
         end
       end
@@ -33,7 +35,7 @@ describe PicturehouseUk::Screening do
   end
 
   describe '.new' do
-    subject { PicturehouseUk::Screening.new(options) }
+    subject { described_class.new(options) }
 
     describe 'simple' do
       let(:options) do
@@ -41,7 +43,7 @@ describe PicturehouseUk::Screening do
           film_name:   'Iron Man 3',
           cinema_id:   3,
           cinema_name: 'Cineworld Brighton',
-          time:        Time.utc(2013, 9, 12, 11, 0)
+          starting_at: Time.utc(2013, 9, 12, 11, 0)
         }
       end
 
@@ -65,11 +67,11 @@ describe PicturehouseUk::Screening do
         dimension:   '3d',
         cinema_id:   3,
         cinema_name: 'Cineworld Brighton',
-        time:        Time.utc(2013, 9, 12, 11, 0)
+        starting_at: Time.utc(2013, 9, 12, 11, 0)
       }
     end
 
-    subject { PicturehouseUk::Screening.new(options).dimension }
+    subject { described_class.new(options).dimension }
 
     it 'returns 2d or 3d' do
       subject.must_be_instance_of(String)
@@ -77,8 +79,8 @@ describe PicturehouseUk::Screening do
     end
   end
 
-  describe '#showing_at' do
-    subject { PicturehouseUk::Screening.new(options).showing_at }
+  describe '#starting_at' do
+    subject { described_class.new(options).starting_at }
 
     describe 'with utc time' do
       let(:options) do
@@ -86,7 +88,7 @@ describe PicturehouseUk::Screening do
           film_name:   'Iron Man 3',
           cinema_id:   3,
           cinema_name: 'Cineworld Brighton',
-          time:        Time.utc(2013, 9, 12, 11, 0)
+          starting_at: Time.utc(2013, 9, 12, 11, 0)
         }
       end
 
@@ -102,7 +104,7 @@ describe PicturehouseUk::Screening do
           film_name:   'Iron Man 3',
           cinema_id:   3,
           cinema_name: 'Cineworld Brighton',
-          time:        Time.parse('2013-09-12 11:00')
+          starting_at: Time.parse('2013-09-12 11:00')
         }
       end
 
@@ -119,11 +121,11 @@ describe PicturehouseUk::Screening do
         film_name:   'Iron Man 3',
         cinema_id:   3,
         cinema_name: 'Cineworld Brighton',
-        time:        Time.utc(2013, 9, 12, 11, 0)
+        starting_at: Time.utc(2013, 9, 12, 11, 0)
       }
     end
 
-    subject { PicturehouseUk::Screening.new(options).showing_on }
+    subject { described_class.new(options).showing_on }
 
     it 'returns date of showing' do
       subject.must_be_instance_of(Date)
@@ -132,14 +134,14 @@ describe PicturehouseUk::Screening do
   end
 
   describe '#variant' do
-    subject { PicturehouseUk::Screening.new(options).variant }
+    subject { described_class.new(options).variant }
 
     let(:options) do
       {
         film_name:   'Iron Man 3',
         cinema_id:   3,
         cinema_name: 'Cineworld Brighton',
-        time:        Time.utc(2013, 9, 12, 11, 0),
+        starting_at: Time.utc(2013, 9, 12, 11, 0),
         variant:     ['Kids']
       }
     end
@@ -152,30 +154,4 @@ describe PicturehouseUk::Screening do
       subject.must_equal %w(kids)
     end
   end
-
-  private
-
-  class MockWebsite
-    def home
-      read_file('../../../fixtures/home.html')
-    end
-
-    def cinema(filename)
-      read_file("../../../fixtures/cinema/#{filename}.html")
-    end
-
-    def contact_us(filename)
-      read_file("../../../fixtures/contact_us/#{filename}.html")
-    end
-
-    def whats_on(filename)
-      read_file("../../../fixtures/whats_on/#{filename}.html")
-    end
-
-    private
-
-    def read_file(filepath)
-      File.read(File.expand_path(filepath, __FILE__))
-    end
-  end
 end