picturehouse_uk 1.0.2 → 2.0.0

data/test/lib/picturehouse_uk/film_test.rb

@@ -1,16 +1,55 @@
 require_relative '../../test_helper'
 
 describe PicturehouseUk::Film do
+  let(:described_class) { PicturehouseUk::Film }
+
   describe '.new(name)' do
     it 'stores name' do
-      film = PicturehouseUk::Film.new 'Iron Man 3'
+      film = described_class.new('Iron Man 3')
       film.name.must_equal 'Iron Man 3'
     end
   end
 
+  describe '.at(cinema_id)' do
+    let(:website) { Minitest::Mock.new }
+
+    subject { described_class.at('Duke_Of_Yorks') }
+
+    before do
+      website.expect(:cinema, cinema_html('Duke_Of_Yorks'), ['Duke_Of_Yorks'])
+    end
+
+    it 'returns an array of films' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        subject.must_be_instance_of(Array)
+        subject.each do |film|
+          film.must_be_instance_of(PicturehouseUk::Film)
+        end
+      end
+    end
+
+    it 'returns a decent number of films' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        subject.count.must_be :>, 5
+      end
+    end
+
+    it 'returns uniquely named films' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        subject.each_with_index do |item, index|
+          subject.each_with_index do |jtem, i|
+            next if index == i
+            item.name.wont_equal jtem.name
+            item.wont_equal jtem
+          end
+        end
+      end
+    end
+  end
+
   describe 'Comparable' do
     it 'includes comparable methods' do
-      film = PicturehouseUk::Film.new 'AAAA'
+      film = described_class.new 'AAAA'
       film.methods.must_include :<
       film.methods.must_include :>
       film.methods.must_include :==
@@ -21,30 +60,30 @@ describe PicturehouseUk::Film do
 
     describe 'uniqueness' do
       it 'defines #hash' do
-        film = PicturehouseUk::Film.new 'AAAA'
+        film = described_class.new 'AAAA'
         film.methods.must_include :hash
       end
 
       describe '#hash' do
         it 'returns a hash of the slug' do
-          film = PicturehouseUk::Film.new 'AAAA'
+          film = described_class.new 'AAAA'
           film.hash == film.slug.hash
         end
       end
 
       it 'defines #eql?(other)' do
-        film = PicturehouseUk::Film.new 'AAAA'
+        film = described_class.new 'AAAA'
         film.methods.must_include :eql?
       end
 
       describe 'two identically named films' do
-        let(:film)      { PicturehouseUk::Film.new 'AAAA' }
-        let(:otherfilm) { PicturehouseUk::Film.new 'AAAA' }
+        let(:film)      { described_class.new 'AAAA' }
+        let(:otherfilm) { described_class.new 'AAAA' }
 
         it 'retuns only one' do
           result = [film, otherfilm].uniq
           result.count.must_equal 1
-          result.must_equal [ PicturehouseUk::Film.new('AAAA') ]
+          result.must_equal [ described_class.new('AAAA') ]
         end
       end
     end
@@ -53,8 +92,8 @@ describe PicturehouseUk::Film do
       subject { film <=> otherfilm }
 
       describe 'film less than other' do
-        let(:film)      { PicturehouseUk::Film.new 'AAAA' }
-        let(:otherfilm) { PicturehouseUk::Film.new 'BBBB' }
+        let(:film)      { described_class.new 'AAAA' }
+        let(:otherfilm) { described_class.new 'BBBB' }
 
         it 'retuns -1' do
           subject.must_equal -1
@@ -62,8 +101,8 @@ describe PicturehouseUk::Film do
       end
 
       describe 'film greater than other' do
-        let(:film)      { PicturehouseUk::Film.new 'CCCC' }
-        let(:otherfilm) { PicturehouseUk::Film.new 'BBBB' }
+        let(:film)      { described_class.new 'CCCC' }
+        let(:otherfilm) { described_class.new 'BBBB' }
 
         it 'retuns 1' do
           subject.must_equal 1
@@ -71,8 +110,8 @@ describe PicturehouseUk::Film do
       end
 
       describe 'film same as other (exact name)' do
-        let(:film)      { PicturehouseUk::Film.new 'AAAA' }
-        let(:otherfilm) { PicturehouseUk::Film.new 'AAAA' }
+        let(:film)      { described_class.new 'AAAA' }
+        let(:otherfilm) { described_class.new 'AAAA' }
 
         it 'retuns 0' do
           subject.must_equal 0
@@ -80,8 +119,8 @@ describe PicturehouseUk::Film do
       end
 
       describe 'film same as other (inexact name)' do
-        let(:film)      { PicturehouseUk::Film.new 'blue jasmine' }
-        let(:otherfilm) { PicturehouseUk::Film.new 'Blue Jasmine' }
+        let(:film)      { described_class.new 'blue jasmine' }
+        let(:otherfilm) { described_class.new 'Blue Jasmine' }
 
         it 'retuns 0' do
           subject.must_equal 0
@@ -89,4 +128,14 @@ describe PicturehouseUk::Film do
       end
     end
   end
+
+  private
+
+  def cinema_html(filename)
+    read_file("../../../fixtures/cinema/#{filename}.html")
+  end
+
+  def read_file(filepath)
+    File.read(File.expand_path(filepath, __FILE__))
+  end
 end

data/test/lib/picturehouse_uk/internal/address_parser_test.rb

@@ -0,0 +1,55 @@
+require_relative '../../../test_helper'
+
+describe PicturehouseUk::Internal::AddressParser do
+  let(:described_class) { PicturehouseUk::Internal::AddressParser }
+
+  describe '#address' do
+    subject { described_class.new(html).address }
+
+    describe 'standard address' do # brighton
+      let(:html) { address_html('duke-of-yorks') }
+
+      it 'returns a hash' do
+        subject.class.must_equal Hash
+      end
+
+      it 'contains the correct keys' do
+        subject.must_equal(
+          street_address:   'Preston Circus',
+          extended_address: nil,
+          locality:         'Brighton',
+          postal_code:      'BN1 4NA',
+          country:          'United Kingdom'
+        )
+      end
+    end
+
+    describe 'freak address: hackney' do
+      let(:html) { address_html('hackney-picturehouse') }
+
+      it 'returns a hash' do
+        subject.class.must_equal Hash
+      end
+
+      it 'contains the correct keys' do
+        subject.must_equal(
+          street_address:   '270 Mare Street',
+          extended_address: nil,
+          locality:         'London',
+          postal_code:      'E8 1HE',
+          country:          'United Kingdom'
+        )
+      end
+    end
+  end
+
+  private
+
+  def read_file(filepath)
+    File.read(File.expand_path(filepath, __FILE__))
+  end
+
+  def address_html(cinema)
+    read_file("../../../../fixtures/address-fragments/#{cinema}.html")
+  end
+end

data/test/lib/picturehouse_uk/internal/cinema_page_test.rb

@@ -0,0 +1,51 @@
+require_relative '../../../test_helper'
+
+describe PicturehouseUk::Internal::CinemaPage do
+  let(:described_class) { PicturehouseUk::Internal::CinemaPage }
+
+  let(:website) { Minitest::Mock.new }
+
+  before do
+    WebMock.disable_net_connect!
+  end
+
+  describe '#film_html' do
+    subject { described_class.new('Duke_Of_Yorks').film_html }
+
+    before do
+      website.expect(:cinema, dukes_html, ['Duke_Of_Yorks'])
+    end
+
+    it 'returns an non-zero array of film screenings html fragments' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        subject.must_be_instance_of(Array)
+        subject.size.must_be :>, 0
+
+        subject.each do |film_html|
+          film_html.must_be_instance_of(String)
+          film_html.size.must_be :>, 0
+        end
+      end
+    end
+
+    it 'returns an array with correct content' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        subject[1..-1].each do |html|
+          html.must_include('class="imageborder"') # poster
+          html.must_include('class="movielink"')   # title
+          html.must_include('epoch="')             # screening
+        end
+      end
+    end
+  end
+
+  private
+
+  def read_file(filepath)
+    File.read(File.expand_path(filepath, __FILE__))
+  end
+
+  def dukes_html
+    read_file('../../../../fixtures/cinema/Duke_Of_Yorks.html')
+  end
+end

data/test/lib/picturehouse_uk/internal/film_with_screenings_parser_test.rb

@@ -1,185 +1,78 @@
 require_relative '../../../test_helper'
 
 describe PicturehouseUk::Internal::FilmWithScreeningsParser do
+  let(:described_class) { PicturehouseUk::Internal::FilmWithScreeningsParser }
 
   describe '#film_name' do
-    subject { PicturehouseUk::Internal::FilmWithScreeningsParser.new(film_html).film_name }
+    subject { described_class.new(film_html).film_name }
 
-    describe 'simple name' do
-      let(:film_html) { read_film_html 'blue-jasmine-future'}
+    describe 'passed film html from page' do
+      let(:film_html) { read_film_html('Duke_Of_Yorks/film_second') }
 
-      it 'removes certificate' do
-        subject.must_be_instance_of String
-        subject.must_equal 'Blue Jasmine'
+      it 'returns the film name' do
+        subject.must_be_instance_of(String)
+        subject.must_equal('Gone Girl')
       end
     end
 
-    describe 'simple name with dimensionality' do
-      let(:film_html) { read_film_html 'planes-with-kids-club'}
+    describe 'passed film html from end of page' do
+      let(:film_html) { read_film_html('Duke_Of_Yorks/film_last') }
 
-      it 'removes version designation' do
-        subject.must_be_instance_of String
-        subject.must_equal 'Planes'
-      end
-    end
-
-    describe 'royal opera house with no cert' do
-      let(:film_html) { read_film_html 'royal-opera-house-don-quixote'}
-
-      it 'removes live designation, certificate and spells out Royal Opera House' do
-        subject.must_be_instance_of String
-        subject.must_equal 'Royal Opera House: Don Quixote'
-      end
-    end
-
-    describe 'bolshoi with no cert' do
-      let(:film_html) { read_film_html 'bolshoi-spartacus'}
-
-      it 'removes certificate' do
-        subject.must_be_instance_of String
-        subject.must_equal 'Bolshoi: Spartacus'
-      end
-    end
-
-    describe 'nt encore with no cert' do
-      let(:film_html) { read_film_html 'nt-encore-hamlet'}
-
-      it 'removes certificate' do
-        subject.must_be_instance_of String
-        subject.must_equal 'National Theatre: Hamlet'
-      end
-    end
-
-    describe 'rsc live with no cert' do
-      let(:film_html) { read_film_html 'rsc-live-richard-ii'}
-
-      it 'removes certificate' do
-        subject.must_be_instance_of String
-        subject.must_equal 'Royal Shakespeare Company: Richard II'
-      end
-    end
-
-    describe 'rsc encore with no cert' do
-      let(:film_html) { read_film_html 'rsc-encore-richard-ii'}
-
-      it 'removes certificate' do
-        subject.must_be_instance_of String
-        subject.must_equal 'Royal Shakespeare Company: Richard II'
-      end
-    end
-
-    describe 'met encore as live with no cert' do
-      let(:film_html) { read_film_html 'met-encore-rusalka-as-live'}
-
-      it 'removes certificate' do
-        subject.must_be_instance_of String
-        subject.must_equal 'Met Opera: Rusalka'
-      end
-    end
-
-    describe 'rsc live with zeroed cert' do
-      let(:film_html) { read_film_html 'rsc-live-the-two-gentlemen-of-verona-zero-cert' }
-
-      it 'removes certificate' do
-        subject.must_be_instance_of String
-        subject.must_equal 'Royal Shakespeare Company: The Two Gentlemen of Verona'
+      it 'returns the film name' do
+        subject.must_be_instance_of(String)
+        subject.must_equal('The Judge')
       end
     end
   end
 
-  describe '#showings' do
-    subject { PicturehouseUk::Internal::FilmWithScreeningsParser.new(film_html).showings }
+  describe '#to_a' do
+    subject { described_class.new(film_html).to_a }
 
-    describe 'multiple screenings' do
-      let(:film_html) { read_film_html 'blue-jasmine-future'}
+    describe 'passed film html from top of page' do
+      let(:film_html)       { read_film_html('Duke_Of_Yorks/film_second') }
+      let(:permitted_types) { %w(baby hfr kids silver) }
 
-      it 'returns a hash keyed by type of performance' do
-        subject.must_be_instance_of Hash
-        subject.keys.each { |key| key.must_be_instance_of String }
+      it 'returns a non-zero array of hashes' do
+        subject.must_be_instance_of(Array)
+        subject.size.must_be :>=, 1
+        subject.each do |hash|
+          hash.must_be_instance_of(Hash)
+        end
       end
 
-      it 'returns an array of Times for each type of performance' do
-        subject.each do |key, value|
-          value.must_be_instance_of Array
-          value.each do |item|
-            item.must_be_instance_of Time
+      it 'contains properly completed hashes' do
+        subject.each do |hash|
+          hash[:booking_url].must_include('http://www.picturehouses.co.uk')
+          hash[:dimension].must_match(/\A[23]d\z/)
+          hash[:time].must_be_instance_of(Time)
+          hash[:variant].must_be_instance_of(Array)
+          hash[:variant].each do |type|
+            type.must_be_instance_of(String)
+            permitted_types.must_include(type)
           end
         end
       end
-
-      it 'returns the correct number of Times' do
-        subject.keys.must_equal ['2d']
-        subject['2d'].count.must_equal 2
-      end
-
-      it 'returns Times in UTC' do
-        subject['2d'].first.must_equal Time.utc(2013, 10, 15, 9, 30, 0)
-        subject['2d'].last.must_equal Time.utc(2013, 10, 15, 20, 15, 0)
-      end
     end
 
-    describe 'screenings including OAP & subtitled' do
-      let(:film_html) { read_film_html 'captain-phillips-with-silver-screen-and-subtitles'}
+    describe 'passed film html from top of dbox cinema page' do
+      let(:film_html)       { read_film_html('Duke_Of_Yorks/film_last') }
+      let(:permitted_types) { %w(baby dbox hfr kids silver) }
 
-      it 'returns an array of Times for each type of performance' do
-        subject.each do |key, value|
-          value.must_be_instance_of Array
-          value.each do |item|
-            item.must_be_instance_of Time
+      it 'returns a hash with allowed variants' do
+        subject.each do |hash|
+          hash[:variant].each do |type|
+            type.must_be_instance_of(String)
+            permitted_types.must_include(type)
           end
         end
       end
-
-      it 'returns the correct number of Times' do
-        subject.keys.sort.must_equal ['2d', 'silver', 'subtitled']
-
-        subject['2d'].count.must_equal 1
-        subject['silver'].count.must_equal 2
-        subject['subtitled'].count.must_equal 1
-      end
-    end
-
-    describe 'screenings including toddler time' do
-      let(:film_html) { read_film_html 'london-film-festival-with-toddler-time'}
-
-      it 'returns the correct number of Times' do
-        subject.keys.must_equal ['kids']
-        subject['kids'].count.must_equal 1
-      end
-    end
-
-    describe 'screenings including baby' do
-      let(:film_html) { read_film_html 'fifth-estate-with-big-scream'}
-
-      it 'returns the correct number of Times' do
-        subject.keys.sort.must_equal ['2d', 'baby']
-
-        subject['2d'].count.must_equal 4
-        subject['baby'].count.must_equal 1
-      end
-    end
-
-    describe 'screenings including kids' do
-      let(:film_html) { read_film_html 'planes-with-kids-club'}
-
-      it 'returns the correct number of Times' do
-        subject.keys.must_equal ['kids']
-        subject['kids'].count.must_equal 1
-      end
-    end
-
-    describe 'expired screenings' do
-      let(:film_html) { read_film_html 'blue-jasmine-done'}
-
-      it 'returns an empty hash' do
-        subject.must_be_instance_of Hash
-        subject.must_be_empty
-      end
     end
   end
 
+  private
+
   def read_film_html(filename)
-    path = "../../../../fixtures/film_node"
-    File.read(File.expand_path("#{path}/#{filename}.html", __FILE__))
+    path = '../../../../fixtures/cinema/'
+    File.read(File.expand_path(path + "#{filename}.html", __FILE__))
   end
 end