picture_from 0.0.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 11924f08d55e6f4104bc764e3ee2f49de4a130ac
-  data.tar.gz: 7396b3c9329034a6caf1853ff70b49bada0513cd
+  metadata.gz: cb7f865aafa5ad8a359f4a3c9cbf3bcdfc9f19b4
+  data.tar.gz: 5d8e3f71b4186d10eaf1ab0c218ba61d2bdb1c32
 SHA512:
-  metadata.gz: e5fc95bfdf460835a048601f91f5aff3db9b20ce6a284ce56317de19ce8772e586cecde541e30f38295caddc1ea949373aeba2401bbc78ccb189cb496a3e2676
-  data.tar.gz: ece08909c8b2b98d9eea91c57af861d7f2e7b683f45000c8a28c100e0164f5b90192196d05b9f150b41fb41deb3eafbe2ea67cbfe613422fb4291aea4e2d4c9e
+  metadata.gz: d2ae1cc6afd91c116577c9c5ffc4b4c6cba109282258a27a68cca707c3f093dbd6f7f6168e82a5308a5ffe1490dfe1e3cbefe4fe46d241d9b1939acba9b228e9
+  data.tar.gz: 6fa907f00f53441ade90e99257fed809af8964fab8475c696a40cbf57b96d0f20f0d2ec5632fb169d9fb6a872864e4b4d9620e6191e2e30f67078e05a10b9b4f

data/.travis.yml

@@ -9,5 +9,4 @@ notifications:
     on_failure: change
 
 script:
-  - bundle exec rspec
-  - bundle exec rubocop
+  - bundle exec rake ci

data/README.md

@@ -29,21 +29,15 @@ PictureFrom.url('karreiro')
 
 Engines
 ------------
-PicutreFrom has many engines for finding the appropriete image for any user in your application:
+PicutreFrom has many engines for finding the appropriate image for any user in your application:
 
   - Gravatar
-    - by e-mail ✔
-    - by GitHub username
+    - by e-mail
   - Facebook
-    - by username ✔
-    - by e-mail ✔
-    - by user information ✔
-  - Twitter
     - by username
+    - by e-mail
     - by user information
-  - Linkedin
-    - by username
-  - Ello
+  - Twitter
     - by username
 
 Contributing

data/Rakefile

@@ -1,5 +1,6 @@
 #!/usr/bin/env rake
 require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
 
 begin
   Bundler.setup :default, :development
@@ -17,6 +18,13 @@ task :coverage do
 end
 
 RSpec::Core::RakeTask.new(:spec)
+RuboCop::RakeTask.new(:rubocop)
 
 desc 'Default: run tests'
 task default: [:spec]
+
+desc 'C.I: run tests and rubocop'
+task :ci do
+  Rake::Task['rubocop'].execute
+  Rake::Task['spec'].execute
+end

data/lib/picture_from/apis/facebook_api.rb

@@ -0,0 +1,23 @@
+require 'open-uri'
+require 'nokogiri'
+
+module PictureFrom
+  module Apis
+    class FacebookApi
+
+      # TODO: Use the http://graph.facebook.com/karreiro/picture?redirect=false
+      # API to identify silhouette pictures.
+      def image_url_by_username(username)
+        url = "http://graph.facebook.com/#{username}/picture"
+        open URI.escape(url)
+      rescue OpenURI::HTTPError
+        # handle 404 and 400
+        nil
+      rescue RuntimeError
+        # handle 302
+        url
+      end
+
+    end
+  end
+end

data/lib/picture_from/crawlers/base_crawler.rb

@@ -0,0 +1,19 @@
+require 'open-uri'
+require 'nokogiri'
+
+module PictureFrom
+  module Crawlers
+    class BaseCrawler
+
+      class Page
+        def open_url(url)
+          uri = URI.escape(url)
+          Nokogiri::HTML open(uri)
+        rescue OpenURI::HTTPError
+          nil
+        end
+      end
+
+    end
+  end
+end

data/lib/picture_from/crawlers/facebook_crawler.rb

@@ -1,27 +1,31 @@
-require 'open-uri'
-require 'nokogiri'
-
 module PictureFrom
   module Crawlers
     class FacebookCrawler
 
-      def query(keyword)
-        page = search_page(keyword)
-        results = page.css('#pagelet_search_results .instant_search_title a')
-        username_from_url(results.first['href']) if results.size > 0
+      def image_url_by_user_info(user_info)
+        page = SearchPage.new(user_info)
+        page.usernames.first
       end
 
-      private
+      class SearchPage < BaseCrawler::Page
+        def initialize(user_info)
+          @page = open_url("https://www.facebook.com/search.php?q=#{user_info}")
+        end
 
-      def search_page(query)
-        search_page_url = "https://www.facebook.com/search.php?q=#{query}"
-        Nokogiri::HTML open(search_page_url)
-      end
+        def usernames
+          results.map { |result| username_from_url(result['href']) }.compact
+        end
+
+        private
+
+        def username_from_url(url)
+          match = %r{^https?://(www\.)?facebook.com/(?<u>[^/\.]*)/?$}.match(url)
+          match[:u] if match
+        end
 
-      def username_from_url(url)
-        url_regex = %r{^https?://(www\.)?facebook.com/(?<username>[^/\.]*)}
-        match = url_regex.match(url)
-        match[:username] if match
+        def results
+          @page.css('#pagelet_search_results .instant_search_title a')
+        end
       end
 
     end

data/lib/picture_from/crawlers/twitter_crawler.rb

@@ -0,0 +1,22 @@
+module PictureFrom
+  module Crawlers
+    class TwitterCrawler
+
+      def image_url_by_username(username)
+        page = ProfilePage.new(username)
+        page.avatar_image
+      end
+
+      class ProfilePage < BaseCrawler::Page
+        def initialize(username)
+          @page = open_url("https://twitter.com/#{username}")
+        end
+
+        def avatar_image
+          @page.css('.ProfileAvatar-image').first['src'] if @page
+        end
+      end
+
+    end
+  end
+end

data/lib/picture_from/facebook_picture.rb

@@ -3,14 +3,15 @@ module PictureFrom
 
     def initialize
       @facebook_crawler = Crawlers::FacebookCrawler.new
+      @facebook_api = Apis::FacebookApi.new
     end
 
     def picture_from_username(username)
-      "http://graph.facebook.com/#{username}/picture"
+      @facebook_api.image_url_by_username(username)
     end
 
     def picture_from_user_info(user_info)
-      username = @facebook_crawler.query(user_info)
+      username = @facebook_crawler.image_url_by_user_info(user_info)
       picture_from_username(username)
     end
 

data/lib/picture_from/gravatar_picture.rb

@@ -3,6 +3,8 @@ require 'digest/md5'
 module PictureFrom
   class GravatarPicture
 
+    # TODO: Gravatar always returns an image. The default Gravatar image should
+    # be rejected.
     def picture_from_email(email)
       "http://www.gravatar.com/avatar/#{digest(email)}"
     end

data/lib/picture_from/keyword.rb

@@ -0,0 +1,22 @@
+module PictureFrom
+  class Keyword
+
+    attr_reader :value
+
+    def initialize(value)
+      @value = value
+    end
+
+    def type
+      case value
+      when /^@?([\w\.])*$/
+        :username
+      when /.+@.+/
+        :email
+      else
+        :user_info
+      end
+    end
+
+  end
+end

data/lib/picture_from/search_engine.rb

@@ -0,0 +1,44 @@
+module PictureFrom
+  class SearchEngine
+
+    DEFAULT_RULES = {
+      username: [
+        { facebook: :picture_from_username },
+        { twitter: :picture_from_username },
+        { facebook: :picture_from_user_info }
+      ],
+      email: [
+        { gravatar: :picture_from_email },
+        { facebook: :picture_from_user_info }
+      ],
+      user_info: [
+        { facebook: :picture_from_user_info }
+      ]
+    }
+
+    def initialize(keyword_value = '')
+      @keyword = Keyword.new(keyword_value)
+    end
+
+    def image_url
+      default_rules.each do |rule|
+        rule.each do |provider, method|
+          image_url = initialize_provider(provider).send(method, @keyword.value)
+          return image_url if image_url
+        end
+      end
+    end
+
+    private
+
+    def default_rules
+      DEFAULT_RULES[@keyword.type]
+    end
+
+    def initialize_provider(provider)
+      provider_name = "#{provider.capitalize}Picture"
+      PictureFrom.const_get(provider_name).new
+    end
+
+  end
+end

data/lib/picture_from/twitter_picture.rb

@@ -0,0 +1,13 @@
+module PictureFrom
+  class TwitterPicture
+
+    def initialize
+      @twitter_crawler = Crawlers::TwitterCrawler.new
+    end
+
+    def picture_from_username(username)
+      @twitter_crawler.image_url_by_username(username)
+    end
+
+  end
+end

data/lib/picture_from/version.rb

@@ -1,3 +1,3 @@
 module PictureFrom
-  VERSION = '0.0.1'
+  VERSION = '1.0.0'
 end

data/lib/picture_from.rb

@@ -1,7 +1,18 @@
+require 'picture_from/crawlers/base_crawler'
 require 'picture_from/crawlers/facebook_crawler'
+require 'picture_from/crawlers/twitter_crawler'
+require 'picture_from/apis/facebook_api'
 require 'picture_from/facebook_picture'
 require 'picture_from/gravatar_picture'
+require 'picture_from/twitter_picture'
+require 'picture_from/search_engine'
+require 'picture_from/keyword'
 
 module PictureFrom
-  # TODO
+
+  def self.url(keyword_value)
+    search_engine = SearchEngine.new(keyword_value)
+    search_engine.image_url
+  end
+
 end