picture_from 0.0.1 → 1.0.0

data/spec/lib/picture_from/apis/facebook_api_spec.rb

@@ -0,0 +1,46 @@
+require 'spec_helper'
+
+describe PictureFrom::Apis::FacebookApi do
+
+  describe '#image_url_by_username' do
+    subject { described_class.new }
+
+    describe 'when username is blank' do
+      let(:url) { subject.image_url_by_username('') }
+
+      it 'returns nil' do
+        fake('http://graph.facebook.com//picture',
+             status: 400,
+             message: 'Bad Request')
+
+        expect(url).to be_nil
+      end
+    end
+
+    describe 'when username does not exist' do
+      let(:url) { subject.image_url_by_username('g_carreiro') }
+
+      it 'returns nil' do
+        fake('http://graph.facebook.com/g_carreiro/picture',
+             status: 404,
+             message: 'Not Found')
+
+        expect(url).to be_nil
+      end
+    end
+
+    describe 'when username is valid' do
+      let(:url) { subject.image_url_by_username('karreiro') }
+
+      it 'returns a valid url' do
+        fake('http://graph.facebook.com/karreiro/picture',
+             status: 302,
+             message: 'Found',
+             location: 'https://fbcdn-profile-a.akamaihd.net/image.png')
+
+        expect(url).to eq('http://graph.facebook.com/karreiro/picture')
+      end
+    end
+  end
+
+end

data/spec/lib/picture_from/crawlers/facebook_crawler_spec.rb

@@ -2,16 +2,15 @@ require 'spec_helper'
 
 describe PictureFrom::Crawlers::FacebookCrawler do
 
-  describe '#query' do
+  describe '#image_url_by_user_info' do
     subject { described_class.new }
 
     describe 'when some profiles are found' do
       it 'returns an image url' do
-        search_url = 'https://www.facebook.com/search.php?q=karreiro@gmail.com'
-        search_response = 'facebook_crawler.response'
-        fake(search_url, search_response)
+        fake('https://www.facebook.com/search.php?q=karreiro@gmail.com',
+             file: 'facebook_crawler.response')
 
-        username = subject.query('karreiro@gmail.com')
+        username = subject.image_url_by_user_info('karreiro@gmail.com')
 
         expect(username).to eq('karreiro')
       end
@@ -19,51 +18,58 @@ describe PictureFrom::Crawlers::FacebookCrawler do
 
     describe 'when any profile is found' do
       it 'does not return an image url' do
-        search_url = 'https://www.facebook.com/search.php?q=karreiro@gmail.com'
-        search_response = 'facebook_crawler_empty.response'
-        fake(search_url, search_response)
+        fake('https://www.facebook.com/search.php?q=guilherme@gmail.com',
+             file: 'facebook_crawler_empty.response')
 
-        username = subject.query('karreiro@gmail.com')
+        username = subject.image_url_by_user_info('guilherme@gmail.com')
 
         expect(username).to be_nil
       end
     end
-
   end
 
-  describe '#username_from_url' do
-    subject { described_class.new }
+  describe PictureFrom::Crawlers::FacebookCrawler::SearchPage do
+
+    describe '#username_from_url' do
 
-    describe 'when receives valid URLs' do
-      let(:urls) do
-        [
-          'https://www.facebook.com/karreiro',
-          'http://www.facebook.com/karreiro',
-          'http://facebook.com/karreiro/',
-          'http://facebook.com/karreiro'
-        ]
+      subject do
+        fake('https://www.facebook.com/search.php?q=')
+        described_class.new('')
       end
 
-      it 'returns a valid username' do
-        urls.each do |url|
-          expect(subject.send(:username_from_url, url)).to eq('karreiro')
+      describe 'when receives valid URLs' do
+        let(:urls) do
+          [
+            'https://www.facebook.com/karreiro',
+            'http://www.facebook.com/karreiro',
+            'http://facebook.com/karreiro/',
+            'http://facebook.com/karreiro'
+          ]
         end
-      end
-    end
 
-    describe 'when receives invalid URLs' do
-      let(:urls) do
-        [
-          'https://orkut.com/karreiro',
-          'http://fb.com/karreiro'
-        ]
+        it 'returns a valid username' do
+          urls.each do |url|
+            expect(subject.send(:username_from_url, url)).to eq('karreiro')
+          end
+        end
       end
 
-      it 'does not return any username' do
-        urls.each do |url|
-          expect(subject.send(:username_from_url, url)).to be_nil
+      describe 'when receives invalid URLs' do
+        let(:urls) do
+          [
+            'https://orkut.com/karreiro',
+            'http://fb.com/karreiro',
+            'https://www.facebook.com/pages/Mark-Zuckerberg/112845672063384'
+          ]
+        end
+
+        it 'does not return any username' do
+          urls.each do |url|
+            expect(subject.send(:username_from_url, url)).to be_nil
+          end
         end
       end
+
     end
 
   end

data/spec/lib/picture_from/crawlers/twitter_crawler_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper'
+
+describe PictureFrom::Crawlers::TwitterCrawler do
+
+  describe '#image_url_by_username' do
+    subject { described_class.new }
+
+    describe 'when some profiles are found' do
+      it 'returns an image url' do
+        fake('https://twitter.com/g_carreiro', file: 'twitter_crawler.response')
+
+        image_url = subject.image_url_by_username('g_carreiro')
+
+        expect(image_url).to eq('https://pbs.twimg.com/profile_images/524721838002143233/nNdh6ftm_400x400.jpeg')
+      end
+    end
+
+    describe 'when any profile is found' do
+      it 'does not return an image url' do
+        fake('https://twitter.com/g_carreiro_fake',
+             status: 404,
+             message: 'Not Found')
+
+        image_url = subject.image_url_by_username('g_carreiro_fake')
+
+        expect(image_url).to be_nil
+      end
+    end
+
+  end
+
+end

data/spec/lib/picture_from/facebook_picture_spec.rb

@@ -11,17 +11,17 @@ describe PictureFrom::FacebookPicture do
     end
   end
 
-  describe '#picture_from_user_info' do
-    subject { described_class.new }
+  describe 'online tests' do
 
-    it 'returns the image url' do
-      search_url = 'https://www.facebook.com/search.php?q=karreiro@gmail.com'
-      search_response = 'facebook_crawler.response'
-      fake(search_url, search_response)
+    describe '#picture_from_user_info' do
+      subject { described_class.new }
 
-      link = subject.picture_from_user_info('karreiro@gmail.com')
-      expect(link).to eq('http://graph.facebook.com/karreiro/picture')
+      it 'returns the image url' do
+        link = subject.picture_from_user_info('Mark Zuckerberg')
+        expect(link).to eq('http://graph.facebook.com/zuck/picture')
+      end
     end
+
   end
 
 end

data/spec/lib/picture_from/keyword_spec.rb

@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+describe PictureFrom::Keyword do
+
+  describe '#email?' do
+
+    describe 'when a valid email is passed' do
+      subject { described_class.new('karreiro@gmail.com') }
+
+      it 'returns true' do
+        expect(subject.type).to eq(:email)
+      end
+    end
+
+    describe 'when a twitter username is passed' do
+      subject { described_class.new('@g_carreiro') }
+
+      it 'returns true' do
+        expect(subject.type).to eq(:username)
+      end
+    end
+
+    describe 'when a facebook username is passed' do
+      subject { described_class.new('karreiro') }
+
+      it 'returns true' do
+        expect(subject.type).to eq(:username)
+      end
+    end
+
+    describe 'when an user info is passed' do
+      subject { described_class.new('Guilherme Carreiro') }
+
+      it 'returns true' do
+        expect(subject.type).to eq(:user_info)
+      end
+    end
+
+  end
+
+end

data/spec/lib/picture_from/search_engine_spec.rb

@@ -0,0 +1,9 @@
+require 'spec_helper'
+
+describe PictureFrom::SearchEngine do
+
+  describe '#picture_from_username' do
+
+  end
+
+end

data/spec/lib/picture_from/twitter_picture_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+
+describe PictureFrom::TwitterPicture do
+
+  describe 'online tests' do
+
+    describe '#picture_from_username' do
+      subject { described_class.new }
+
+      it 'returns the image url' do
+        link = subject.picture_from_username('unclebobmartin')
+        expect(link).to eq('https://pbs.twimg.com/profile_images/1102364992/clean_code_72_color_400x400.png')
+      end
+    end
+
+  end
+
+end

data/spec/lib/picture_from_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper'
+
+describe PictureFrom do
+  subject { PictureFrom }
+
+  describe 'facebook engine' do
+    it 'returns the image url' do
+      fake('http://graph.facebook.com/karreiro/picture',
+           status: 302,
+           message: 'Found',
+           location: 'https://fbcdn-profile-a.akamaihd.net/image.png')
+      link = subject.url('karreiro')
+      expect(link).to eq('http://graph.facebook.com/karreiro/picture')
+    end
+  end
+
+  describe 'twitter engine' do
+    it 'returns the image url' do
+      fake('http://graph.facebook.com/g_carreiro/picture', status: 404)
+      fake('https://twitter.com/g_carreiro', file: 'twitter_crawler.response')
+      link = subject.url('g_carreiro')
+      expect(link).to eq('https://pbs.twimg.com/profile_images/524721838002143233/nNdh6ftm_400x400.jpeg')
+    end
+  end
+
+  describe 'gravatar engine' do
+    it 'returns the image url' do
+      link = subject.url('karreiro@gmail.com')
+      expect(link).to eq('http://www.gravatar.com/avatar/16be5820a296f5bce151f0c1b5e16fc8')
+    end
+  end
+end

data/spec/support/fake_web_helper.rb

@@ -1,14 +1,21 @@
 module FakeWebHelper
-  def fake(uri, file, verb = :get)
-    FakeWeb.register_uri(verb, uri, response: response(file))
+  def fake(uri, options = {})
+    verb = options[:verb] || :get
+    FakeWeb.register_uri(verb, uri, response: response(options))
   end
 
-  def header(html)
-    "HTTP/1.1 200 OK\n\n#{html}"
+  def response(options)
+    header(options) + body(options)
   end
 
-  def response(file)
-    html = File.read("spec/fixtures/#{file}")
-    header(html)
+  def header(options)
+    status = options[:status] || 200
+    message = options[:message] || 'OK'
+    location = options[:location] || ''
+    "HTTP/1.1 #{status} #{message}\nLocation: #{location}\n\n"
+  end
+
+  def body(options)
+    options[:file] ? File.read("spec/fixtures/#{options[:file]}") : ''
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: picture_from
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 1.0.0
 platform: ruby
 authors:
 - Guilherme Carreiro
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-25 00:00:00.000000000 Z
+date: 2014-12-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -139,16 +139,29 @@ files:
 - README.md
 - Rakefile
 - lib/picture_from.rb
+- lib/picture_from/apis/facebook_api.rb
+- lib/picture_from/crawlers/base_crawler.rb
 - lib/picture_from/crawlers/facebook_crawler.rb
+- lib/picture_from/crawlers/twitter_crawler.rb
 - lib/picture_from/facebook_picture.rb
 - lib/picture_from/gravatar_picture.rb
+- lib/picture_from/keyword.rb
+- lib/picture_from/search_engine.rb
+- lib/picture_from/twitter_picture.rb
 - lib/picture_from/version.rb
 - picture_from.gemspec
 - spec/fixtures/facebook_crawler.response
 - spec/fixtures/facebook_crawler_empty.response
+- spec/fixtures/twitter_crawler.response
+- spec/lib/picture_from/apis/facebook_api_spec.rb
 - spec/lib/picture_from/crawlers/facebook_crawler_spec.rb
+- spec/lib/picture_from/crawlers/twitter_crawler_spec.rb
 - spec/lib/picture_from/facebook_picture_spec.rb
 - spec/lib/picture_from/gravatar_picture_spec.rb
+- spec/lib/picture_from/keyword_spec.rb
+- spec/lib/picture_from/search_engine_spec.rb
+- spec/lib/picture_from/twitter_picture_spec.rb
+- spec/lib/picture_from_spec.rb
 - spec/spec_helper.rb
 - spec/support/coverage.rb
 - spec/support/fake_web_helper.rb
@@ -179,9 +192,16 @@ summary: PictureFrom is the most efficient library for getting profile pictures.
 test_files:
 - spec/fixtures/facebook_crawler.response
 - spec/fixtures/facebook_crawler_empty.response
+- spec/fixtures/twitter_crawler.response
+- spec/lib/picture_from/apis/facebook_api_spec.rb
 - spec/lib/picture_from/crawlers/facebook_crawler_spec.rb
+- spec/lib/picture_from/crawlers/twitter_crawler_spec.rb
 - spec/lib/picture_from/facebook_picture_spec.rb
 - spec/lib/picture_from/gravatar_picture_spec.rb
+- spec/lib/picture_from/keyword_spec.rb
+- spec/lib/picture_from/search_engine_spec.rb
+- spec/lib/picture_from/twitter_picture_spec.rb
+- spec/lib/picture_from_spec.rb
 - spec/spec_helper.rb
 - spec/support/coverage.rb
 - spec/support/fake_web_helper.rb