picky 4.0.0pre1 → 4.0.0pre2

data/spec/lib/interfaces/live_parameters/unicorn_spec.rb

@@ -0,0 +1,160 @@
+# encoding: utf-8
+#
+require 'spec_helper'
+
+describe Picky::Interfaces::LiveParameters::Unicorn do
+
+  before(:each) do
+    @parent = stub :parent
+    @child  = stub :child
+    IO.stub! :pipe => [@child, @parent]
+    @parameters = described_class.new
+    @parameters.stub! :exclaim
+  end
+
+  describe Picky::Interfaces::LiveParameters::Unicorn::CouldNotUpdateConfigurationError do
+    before(:each) do
+      @error = Picky::Interfaces::LiveParameters::Unicorn::CouldNotUpdateConfigurationError.new :some_key, 'some message'
+    end
+  end
+
+  describe 'querying_removes_characters' do
+    it 'works' do
+      expect do
+        @parameters.querying_removes_characters
+      end.to_not raise_error
+    end
+  end
+  describe 'querying_stopwords' do
+    it 'works' do
+      expect do
+        @parameters.querying_stopwords
+      end.to_not raise_error
+    end
+  end
+  describe 'querying_splits_text_on' do
+    it 'works' do
+      expect do
+        @parameters.querying_splits_text_on
+      end.to_not raise_error
+    end
+  end
+
+  describe 'parameters' do
+    context 'all goes well' do
+      it 'does a few things in order' do
+        @parameters.should_receive(:close_child).once.with().ordered
+        @parameters.should_receive(:try_updating_configuration_with).once.with(:a => :b).ordered
+        @parameters.should_receive(:write_parent).once.with(:a => :b).ordered
+        @parameters.should_receive(:extract_configuration).once.with().ordered
+
+        @parameters.parameters :a => :b
+      end
+    end
+    context 'updating failed' do
+      before(:each) do
+        @parameters.should_receive(:try_updating_configuration_with).and_raise Picky::Interfaces::LiveParameters::Unicorn::CouldNotUpdateConfigurationError.new(:a, 'hello')
+      end
+      it 'kills itself and returns' do
+        @parameters.should_receive(:close_child).once.ordered
+        @parameters.should_receive(:harakiri).once.ordered
+
+        @parameters.parameters( :a => :b ).should == { :a => :ERROR }
+      end
+    end
+  end
+
+  describe 'harakiri' do
+    before(:each) do
+      Process.stub! :pid => :some_pid
+    end
+    it 'kills itself' do
+      Process.should_receive(:kill).once.with :QUIT, :some_pid
+
+      @parameters.harakiri
+    end
+  end
+
+  describe 'write_parent' do
+    before(:each) do
+      Process.stub! :pid => :some_pid
+    end
+    it 'calls the parent' do
+      @parent.should_receive(:write).once.with "[:some_pid, {:a=>:b}];;;"
+
+      @parameters.write_parent :a => :b
+    end
+  end
+
+  describe 'close_child' do
+    context 'child is closed' do
+      before(:each) do
+        @child.stub! :closed? => true
+      end
+      it 'does not receive close' do
+        @child.should_receive(:close).never
+
+        @parameters.close_child
+      end
+    end
+    context 'child not yet closed' do
+      before(:each) do
+        @child.stub! :closed? => false
+      end
+      it 'does receives close' do
+        @child.should_receive(:close).once.with()
+
+        @parameters.close_child
+      end
+    end
+  end
+
+  describe 'kill_worker' do
+    context 'all goes well' do
+      it 'uses Process.kill' do
+        Process.should_receive(:kill).once.with :some_signal, :some_pid
+
+        @parameters.kill_worker :some_signal, :some_pid
+      end
+    end
+    context 'there is no such process' do
+      it 'uses Process.kill' do
+        Process.should_receive(:kill).and_raise Errno::ESRCH.new
+
+        @parameters.should_receive(:remove_worker).once.with :some_pid
+
+        @parameters.kill_worker :some_signal, :some_pid
+      end
+    end
+  end
+
+  describe 'kill_each_worker_except' do
+    context 'worker pid in the worker pids' do
+      before(:each) do
+        @parameters.stub! :worker_pids => [1,2,3,4]
+      end
+      it 'kills each except the one' do
+        @parameters.should_receive(:kill_worker).once.with(:KILL, 1)
+        @parameters.should_receive(:kill_worker).once.with(:KILL, 2)
+
+        @parameters.should_receive(:kill_worker).once.with(:KILL, 4)
+
+        @parameters.kill_each_worker_except 3
+      end
+    end
+    context 'worker pid not in the worker pids (unrealistic, but...)' do
+      before(:each) do
+        @parameters.stub! :worker_pids => [1,2,3,4]
+      end
+      it 'kills each except the one' do
+        @parameters.should_receive(:kill_worker).once.with(:KILL, 1)
+        @parameters.should_receive(:kill_worker).once.with(:KILL, 2)
+        @parameters.should_receive(:kill_worker).once.with(:KILL, 3)
+        @parameters.should_receive(:kill_worker).once.with(:KILL, 4)
+
+        @parameters.kill_each_worker_except 5
+      end
+    end
+  end
+
+end

data/spec/lib/loader_spec.rb

@@ -3,62 +3,102 @@ require 'spec_helper'
 describe Picky::Loader do
 
   before(:each) do
+    described_class.stub! :exclaim
     @loader_path = File.absolute_path("#{File.dirname(__FILE__)}/../../lib/picky/loader.rb")
   end
-  
+
+  describe 'load self and framework' do
+    it 'it is quick' do
+      performance_of do
+        described_class.load_self
+        described_class.load_framework
+      end.should < 0.025
+    end
+  end
+
   describe 'load_application' do
-    before(:each) do
-      Picky::Application.stub! :reload
+    it 'does ok' do
+      Kernel.should_receive(:load).once.with 'spec/test_directory/app.rb'
+
+      lambda { described_class.load_application }.should_not raise_error
     end
-    it "does ok" do
-      lambda { Picky::Loader.load_application }.should_not raise_error
+    it 'loads correctly' do
+      described_class.should_receive(:load_user).once.with 'app'
+
+      described_class.load_application
+    end
+    it 'loads correctly' do
+      described_class.should_receive(:load_user).once.with 'special_app'
+
+      described_class.load_application 'special_app'
     end
   end
-  
+
   describe 'load_framework' do
     before(:each) do
-      Picky::Loader.stub! :load_relative
+      described_class.stub! :load_relative
     end
-    it "does ok" do
-      lambda { Picky::Loader.load_framework }.should_not raise_error
+    it 'does ok' do
+      lambda { described_class.load_framework }.should_not raise_error
     end
   end
-  
+
   describe 'load_self' do
     before(:each) do
-      Picky::Loader.stub! :load
-      Picky::Loader.stub! :exclaim
+      described_class.stub! :load
     end
     after(:each) do
-      Picky::Loader.load_self
+      described_class.load_self
     end
     it 'should load __SELF__' do
-      Picky::Loader.should_receive(:load).once.with @loader_path
+      Kernel.should_receive(:load).once.with @loader_path
     end
   end
 
   describe 'reload' do
     before(:each) do
       load @loader_path
-      Picky::Loader.stub! :exclaim
-      Picky::Loader.stub! :load_framework
-      Picky::Loader.stub! :load_application
+      described_class.stub! :load_framework
+      described_class.stub! :load_application
+      Dir.stub! :chdir
+    end
+    it 'should call the right methods in order' do
+      described_class.should_receive(:load_self).ordered
+      described_class.should_receive(:load_framework).ordered
+      described_class.should_receive(:load_application).ordered
+
+      described_class.reload
+    end
+    it 'should load itself only once' do
+      described_class.should_receive(:load_self).once
+
+      described_class.reload
+    end
+    # it 'can load a specific app' do
+    #   described_class.should_receive(:load_application).once.with 'special_app'
+    #
+    #   described_class.reload 'special_app'
+    # end
+  end
+
+  describe 'load' do
+    before(:each) do
+      load @loader_path
+      described_class.stub! :load_framework
+      described_class.stub! :load_application
       Dir.stub! :chdir
     end
     after(:each) do
-      Picky::Loader.reload
+      described_class.load
     end
     it 'should call the right methods in order' do
-      Picky::Loader.should_receive(:load_self).ordered
-      Picky::Loader.should_receive(:load_framework).ordered
-      Picky::Loader.should_receive(:load_application).ordered
+      described_class.should_receive(:load_self).ordered
+      described_class.should_receive(:load_framework).ordered
+      described_class.should_receive(:load_application).ordered
     end
     it 'should load itself only once' do
-      Picky::Loader.should_receive(:load_self).once
+      described_class.should_receive(:load_self).once
     end
-    # it 'should load the app only once' do
-    #   Loader.should_receive(:load_framework).once
-    # end
   end
 
 end

data/spec/lib/query/allocation_spec.rb

@@ -1,30 +1,22 @@
 require 'spec_helper'
 
 describe Picky::Query::Allocation do
-  
+
   before(:each) do
     @backend      = stub :backend
     @index        = stub :index, :result_identifier => :some_result_identifier, :backend => @backend
     @combinations = stub :combinations, :empty? => false
     @allocation   = described_class.new @index, @combinations
   end
-  
-  describe "eql?" do
-    # TODO This works, but is not acceptable.
-    #
-    it "returns true" do
-      @allocation.eql?(:anything).should == true
-    end
-  end
-  
+
   describe "hash" do
     it "delegates to the combinations" do
       @combinations.should_receive(:hash).once.with
-      
+
       @allocation.hash
     end
   end
-  
+
   describe "to_s" do
     before(:each) do
       @combinations.stub! :to_result => 'combinations_result'
@@ -40,15 +32,15 @@ describe Picky::Query::Allocation do
       end
     end
   end
-  
+
   describe 'remove' do
     it 'should delegate to the combinations' do
       @combinations.should_receive(:remove).once.with [:some_categories]
-      
+
       @allocation.remove [:some_categories]
     end
   end
-  
+
   describe 'process!' do
     context 'no ids' do
       before(:each) do
@@ -130,7 +122,7 @@ describe Picky::Query::Allocation do
       context 'with ids' do
         it 'should output an array of information' do
           @backend.stub! :ids => [1,2,3]
-          
+
           @allocation.process! 20, 0
 
           @allocation.to_result.should == [:some_result_identifier, :some_score, 3, [:some_result], [1, 2, 3]]
@@ -148,7 +140,7 @@ describe Picky::Query::Allocation do
       context 'with ids' do
         it 'should output an array of information' do
           @backend.stub! :ids => [1,2,3]
-          
+
           @allocation.process! 20, 0
 
           @allocation.to_result.should == [:some_result_identifier, :some_score, 3, [:some_result1, :some_result2], [1, 2, 3]]
@@ -162,7 +154,7 @@ describe Picky::Query::Allocation do
       end
       it 'should return nil' do
         @backend.stub! :ids => []
-        
+
         @allocation.process! 20, 0
 
         @allocation.to_result.should == nil
@@ -177,7 +169,7 @@ describe Picky::Query::Allocation do
     end
     it 'should output the correct json string' do
       @backend.stub! :ids => [1,2,3,4,5,6,7]
-      
+
       @allocation.process! 20, 0
 
       @allocation.to_json.should == '["some_result_identifier","some_score",7,["some_result1","some_result2"],[1,2,3,4,5,6,7]]'
@@ -185,10 +177,21 @@ describe Picky::Query::Allocation do
   end
 
   describe "calculate_score" do
-    it 'should delegate to the combinations' do
-      @combinations.should_receive(:calculate_score).once.with :some_weights
+    context 'non-empty combinations' do
+      it 'should delegate to backend and combinations' do
+        @backend.should_receive(:weight).once.with(@combinations).and_return 1
+        @combinations.should_receive(:weighted_score).once.with(:some_weights).and_return 2
 
-      @allocation.calculate_score :some_weights
+        @allocation.calculate_score(:some_weights).should == 3
+      end
+    end
+    context 'empty combinations' do
+      before(:each) do
+        @combinations.stub! :empty? => true
+      end
+      it 'should just be zero' do
+        @allocation.calculate_score(:some_weights).should == 0
+      end
     end
   end
 

data/spec/lib/query/combinations_spec.rb

@@ -6,78 +6,55 @@ describe Picky::Query::Combinations do
 
   before(:each) do
     @combinations_ary = stub :combinations_ary
-    
+
     @combinations = described_class.new @combinations_ary
   end
-  
+
   describe "to_result" do
     before(:each) do
       @combination1 = stub :combination1, :to_result => :result1
       @combination2 = stub :combination2, :to_result => :result2
-      
+
       @combinations_ary = [@combination1, @combination2]
-      
+
       @combinations = described_class.new @combinations_ary
     end
     it "resultifies the combinations" do
       @combinations.to_result.should == [:result1, :result2]
     end
   end
-  
+
   describe "weighted_score" do
     it "uses the weights' score method" do
       weights = stub :weights
       weights.should_receive(:score_for).once.with @combinations_ary
-      
+
       @combinations.weighted_score weights
     end
   end
-  
+
   describe "total_score" do
     before(:each) do
       @combination1 = stub :combination1, :weight => 3.14
       @combination2 = stub :combination2, :weight => 2.76
-      
+
       @combinations_ary = [@combination1, @combination2]
-      
+
       @combinations = described_class.new @combinations_ary
     end
     it "sums the scores" do
-      @combinations.total_score.should == 5.90
+      @combinations.score.should == 5.90
     end
   end
-  
-  describe "calculate_score" do
-    before(:each) do
-      @combinations.stub! :total_score => 0
-      @combinations.stub! :weighted_score => 0
-    end
-    it "first sums, then weighs" do
-      @combinations.should_receive(:total_score).once.ordered.and_return 0
-      @combinations.should_receive(:weighted_score).once.ordered.and_return 0
-      
-      @combinations.calculate_score :anything
-    end
-    it "calls sum_score" do
-      @combinations.should_receive(:total_score).once.with.and_return 0
-      
-      @combinations.calculate_score :anything
-    end
-    it "calls sum_score" do
-      @combinations.should_receive(:weighted_score).once.with(:weights).and_return 0
-      
-      @combinations.calculate_score :weights
-    end
-  end
-  
+
   describe 'hash' do
     it "delegates to the combinations array" do
       @combinations_ary.should_receive(:hash).once.with
-      
+
       @combinations.hash
     end
   end
-  
+
   describe 'remove' do
     before(:each) do
       @combination1 = stub :combination1, :category => :other