picky 2.6.0 → 2.7.0

data/spec/lib/indexers/base_spec.rb

@@ -2,14 +2,49 @@ require 'spec_helper'
 
 describe Indexers::Base do
 
-  let(:indexer) { described_class.new }
+  let(:some_index_or_category) { stub :some_index_or_category, :name => 'some index or category' }
+  let(:indexer) { described_class.new some_index_or_category }
+  
+  describe 'index_or_category' do
+    it 'returns the right thing' do
+      indexer.index_or_category.should == some_index_or_category
+    end
+  end
+  
+  describe 'source' do
+    it 'delegates it to the index or category' do
+      some_index_or_category.should_receive(:source).once.with
+      
+      indexer.source
+    end
+  end
   
   describe 'index' do
     it 'messages, then processed' do
-      indexer.should_receive(:indexing_message).once.with.ordered
-      indexer.should_receive(:process).once.with.ordered
+      indexer.should_receive(:start_indexing_message).once.with.ordered
+      indexer.should_receive(:prepare).once.with(:categories).ordered
+      indexer.should_receive(:process).once.with(:categories).ordered
+      indexer.should_receive(:finish_indexing_message).once.with.ordered
+      
+      indexer.index :categories
+    end
+  end
+  
+  describe 'prepare' do
+    it 'calls a certain method on each category' do
+      some_index_or_category.stub! :source
+      
+      category1 = stub :category1
+      category2 = stub :category2
+      category3 = stub :category3
+      
+      categories = [category1, category2, category3]
+      
+      categories.each do |category|
+        category.should_receive(:prepare_index_directory).once.with
+      end
       
-      indexer.index
+      indexer.prepare categories
     end
   end
   

data/spec/lib/indexers/parallel_spec.rb

@@ -4,9 +4,9 @@ describe Indexers::Parallel do
 
   before(:each) do
     @source     = stub :source
-    @tokenizer  = stub :tokenizer
+    @index      = stub :index, :name => :some_index, :source => @source
+    
     @categories = stub :categories
-    @index      = stub :index, :name => :some_index, :categories => @categories
     
     @indexer = described_class.new @index
     @indexer.stub! :timed_exclaim
@@ -25,12 +25,4 @@ describe Indexers::Parallel do
     end
   end
   
-  describe "index" do
-    it "should process" do
-      @indexer.should_receive(:process).once.with
-      
-      @indexer.index
-    end
-  end
-  
 end

data/spec/lib/indexers/serial_spec.rb

@@ -5,39 +5,28 @@ describe Indexers::Serial do
   before(:each) do
     @tokenizer = stub :tokenizer
     @source  = stub :source
-    @category  = stub :category, :identifier => :some_identifier, :tokenizer => @tokenizer, :source => @source
+    @category  = stub :category,
+                      :identifier => :some_identifier,
+                      :tokenizer => @tokenizer,
+                      :source => @source
     
     @indexer = described_class.new @category
     @indexer.stub! :timed_exclaim
   end
   
-  describe "tokenizer" do
-    it "returns the right one" do
-      @indexer.tokenizer.should == @tokenizer
-    end
-  end
-  
-  describe "indexing_message" do
+  describe "start_indexing_message" do
     it "informs the user about what it is going to index" do
-      @indexer.should_receive(:timed_exclaim).once.with '"some_identifier": Starting serial indexing.'
+      @indexer.should_receive(:timed_exclaim).once.with '"some_identifier": Starting serial data preparation.'
       
-      @indexer.indexing_message
+      @indexer.start_indexing_message
     end
   end
   
-  describe "tokenizer" do
-    it "returns it" do
-      @indexer.should_receive(:tokenizer).once.with
-      
-      @indexer.tokenizer
-    end
-  end
-  
-  describe "index" do
-    it "should process" do
-      @indexer.should_receive(:process).once.with
+  describe "finish_indexing_message" do
+    it "informs the user about what it is going to index" do
+      @indexer.should_receive(:timed_exclaim).once.with '"some_identifier": Finished serial data preparation.'
       
-      @indexer.index
+      @indexer.finish_indexing_message
     end
   end
   
@@ -47,8 +36,4 @@ describe Indexers::Serial do
     end
   end
   
-  describe "chunked" do
-    
-  end
-  
 end

data/spec/lib/indexes_class_spec.rb

@@ -7,11 +7,11 @@ describe Indexes do
     @indexes = described_class.instance
   end
 
-  describe 'clear' do
+  describe 'clear_indexes' do
     it 'clears the indexes' do
-      Indexes.register @index
+      @indexes.register @index
 
-      Indexes.clear
+      @indexes.clear_indexes
 
       @indexes.indexes.should == []
     end
@@ -19,7 +19,7 @@ describe Indexes do
 
   describe 'register' do
     it 'adds the given index to the indexes' do
-      Indexes.clear
+      @indexes.clear_indexes
       
       Indexes.register @index
 

data/spec/lib/indexes_indexed_spec.rb

@@ -38,12 +38,12 @@ describe Indexes do
     end
     describe 'clear' do
       it 'clears the indexes' do
-        indexes.clear
+        indexes.clear_indexes
         
         indexes.indexes.should == []
       end
       it 'clears the mapping' do
-        indexes.clear
+        indexes.clear_indexes
         
         indexes.index_mapping.should == {}
       end

data/spec/lib/indexes_indexing_spec.rb

@@ -21,7 +21,6 @@ describe Indexes do
     end
     describe 'index_for_tests' do
       it 'takes a snapshot, then indexes and caches each' do
-        indexes.should_receive(:take_snapshot).once.with.ordered
         @index1.should_receive(:index).once.with.ordered
         @index2.should_receive(:index).once.with.ordered
       
@@ -33,9 +32,9 @@ describe Indexes do
         indexes.indexes.should == [@index1, @index2]
       end
     end
-    describe 'clear' do
+    describe 'clear_indexes' do
       it 'clears the indexes' do
-        indexes.clear
+        indexes.clear_indexes
       
         indexes.indexes.should == []
       end
@@ -50,13 +49,10 @@ describe Indexes do
         end
       end
     end
-    it_delegates_each :take_snapshot
-    it_delegates_each :generate_caches
-    it_delegates_each :backup_caches
-    it_delegates_each :restore_caches
-    it_delegates_each :check_caches
-    it_delegates_each :clear_caches
-    it_delegates_each :create_directory_structure
+    it_delegates_each :check
+    it_delegates_each :clear
+    it_delegates_each :backup
+    it_delegates_each :restore
   end
   
 end

data/spec/lib/indexes_spec.rb

@@ -16,11 +16,11 @@ describe Indexes do
     end
   end
 
-  describe 'clear' do
+  describe 'clear_indexes' do
     it 'clears the indexes' do
       @indexes.register @index
 
-      @indexes.clear
+      @indexes.clear_indexes
 
       @indexes.indexes.should == []
     end
@@ -28,7 +28,7 @@ describe Indexes do
 
   describe 'register' do
     it 'adds the given index to the indexes' do
-      @indexes.clear
+      @indexes.clear_indexes
       
       @indexes.register @index
 

data/spec/lib/indexing/bundle/{super_base_spec.rb → base_spec.rb}

@@ -1,12 +1,12 @@
 require 'spec_helper'
 
-describe Indexing::Bundle::SuperBase do
+describe Indexing::Bundle::Base do
 
   before(:each) do
     @configuration = stub :configuration, :identifier => 'some_identifier'
     Backend::Files.stub! :new
     @similarity = Similarity::DoubleMetaphone.new 3
-    @bundle = described_class.new :some_name, @configuration, @similarity
+    @bundle = described_class.new :some_name, @configuration, :some_weights, :some_partial, @similarity
   end
   
   describe 'identifier' do

data/spec/lib/indexing/bundle/memory_partial_generation_speed_spec.rb

@@ -27,9 +27,9 @@ describe Indexing::Bundle::Memory do
   describe 'speed' do
     context 'medium arrays' do
       before(:each) do
-        random_keys  = generate_random_keys 300
-        random_ids   = generate_random_ids  300
-        @exact.index = Hash[random_keys.zip(random_ids)]
+        random_keys     = generate_random_keys 300
+        random_ids      = generate_random_ids  300
+        @exact.inverted = Hash[random_keys.zip(random_ids)]
       end
       it 'should be fast' do
         performance_of do

data/spec/lib/indexing/bundle/memory_spec.rb

@@ -10,19 +10,19 @@ describe Indexing::Bundle::Memory do
     @weights     = stub :weights
     @similarity  = stub :similarity
   end
-  let(:index) { described_class.new :some_name, @category, @similarity, @partial, @weights }
+  let(:index) { described_class.new :some_name, @category, @weights, @partial, @similarity }
   
   describe 'raise_cache_missing' do
     it 'does something' do
       expect {
         index.raise_cache_missing :similarity
-      }.to raise_error("Error: The similarity cache for some_index:some_category:some_name is missing.")
+      }.to raise_error("Error: The similarity cache for test:some_index:some_category:some_name is missing.")
     end
   end
   
   describe 'warn_cache_small' do
     it 'warns the user' do
-      index.should_receive(:warn).once.with "Warning: similarity cache for some_index:some_category:some_name smaller than 16 bytes."
+      index.should_receive(:warn).once.with "Warning: similarity cache for test:some_index:some_category:some_name smaller than 16 bytes."
       
       index.warn_cache_small :similarity
     end
@@ -30,7 +30,7 @@ describe Indexing::Bundle::Memory do
   
   describe 'identifier' do
     it 'should return a specific identifier' do
-      index.identifier.should == 'some_index:some_category:some_name'
+      index.identifier.should == 'test:some_index:some_category:some_name'
     end
   end
   
@@ -40,9 +40,9 @@ describe Indexing::Bundle::Memory do
         index.stub! :index => {}
       end
       it 'should assign it an empty array' do
-        index.initialize_index_for :some_token
+        index.initialize_inverted_index_for :some_token
 
-        index.index[:some_token].should == []
+        index.inverted[:some_token].should == []
       end
     end
     context 'token already assigned' do
@@ -50,7 +50,7 @@ describe Indexing::Bundle::Memory do
         index.stub! :index => { :some_token => :already_assigned }
       end
       it 'should not assign it anymore' do
-        index.initialize_index_for :some_token
+        index.initialize_inverted_index_for :some_token
 
         index.index[:some_token].should == :already_assigned
       end
@@ -64,8 +64,8 @@ describe Indexing::Bundle::Memory do
       index.stub! :files => files
       
       @ary = stub :ary
-      @index.should_receive(:[]).any_number_of_times.and_return @ary
-      index.stub! :index => @index
+      inverted = stub :inverted, :[] => @ary
+      index.stub! :inverted => inverted
     end
     context 'id key format' do
       before(:each) do
@@ -101,11 +101,11 @@ describe Indexing::Bundle::Memory do
 
   describe 'load_from_index_file' do
     it 'should call two methods in order' do
-      index.should_receive(:load_from_index_generation_message).once.ordered
+      index.should_receive(:load_from_prepared_index_generation_message).once.ordered
       index.should_receive(:clear).once.ordered
       index.should_receive(:retrieve).once.ordered
 
-      index.load_from_index_file
+      index.load_from_prepared_index_file
     end
   end
 
@@ -129,7 +129,7 @@ describe Indexing::Bundle::Memory do
 
   describe 'generate_caches_from_source' do
     it 'should call two methods in order' do
-      index.should_receive(:load_from_index_file).once.ordered
+      index.should_receive(:load_from_prepared_index_file).once.ordered
       index.should_receive(:generate_caches_from_memory).once.ordered
 
       index.generate_caches_from_source
@@ -138,7 +138,9 @@ describe Indexing::Bundle::Memory do
   
   describe 'dump' do
     it 'should trigger dumps' do
-      index.should_receive(:dump_index).once.with
+      index.stub! :timed_exclaim
+      
+      index.should_receive(:dump_inverted).once.with
       index.should_receive(:dump_weights).once.with
       index.should_receive(:dump_similarity).once.with
       index.should_receive(:dump_configuration).once.with
@@ -260,7 +262,7 @@ describe Indexing::Bundle::Memory do
   
   describe 'initialization' do
     it 'should initialize the index correctly' do
-      index.index.should == {}
+      index.inverted.should == {}
     end
     it 'should initialize the weights index correctly' do
       index.weights.should == {}

data/spec/lib/indexing/bundle/redis_spec.rb

@@ -10,19 +10,19 @@ describe Indexing::Bundle::Redis do
     @weights     = stub :weights
     @similarity  = stub :similarity
   end
-  let(:index) { described_class.new :some_name, @category, @similarity, @partial, @weights }
+  let(:index) { described_class.new :some_name, @category, @weights, @partial, @similarity }
 
   describe 'raise_cache_missing' do
     it 'does something' do
       expect {
         index.raise_cache_missing :similarity
-      }.to raise_error("Error: The similarity cache for some_index:some_category:some_name is missing.")
+      }.to raise_error("Error: The similarity cache for test:some_index:some_category:some_name is missing.")
     end
   end
   
   describe 'warn_cache_small' do
     it 'warns the user' do
-      index.should_receive(:warn).once.with "Warning: similarity cache for some_index:some_category:some_name smaller than 16 bytes."
+      index.should_receive(:warn).once.with "Warning: similarity cache for test:some_index:some_category:some_name smaller than 16 bytes."
       
       index.warn_cache_small :similarity
     end
@@ -30,19 +30,19 @@ describe Indexing::Bundle::Redis do
 
   describe 'identifier' do
     it 'should return a specific identifier' do
-      index.identifier.should == 'some_index:some_category:some_name'
+      index.identifier.should == 'test:some_index:some_category:some_name'
     end
   end
   
   describe 'initialize_index_for' do
     context 'token not yet assigned' do
       before(:each) do
-        index.stub! :index => {}
+        index.stub! :inverted => {}
       end
       it 'should assign it an empty array' do
-        index.initialize_index_for :some_token
+        index.initialize_inverted_index_for :some_token
 
-        index.index[:some_token].should == []
+        index.inverted[:some_token].should == []
       end
     end
     context 'token already assigned' do
@@ -50,7 +50,7 @@ describe Indexing::Bundle::Redis do
         index.stub! :index => { :some_token => :already_assigned }
       end
       it 'should not assign it anymore' do
-        index.initialize_index_for :some_token
+        index.initialize_inverted_index_for :some_token
 
         index.index[:some_token].should == :already_assigned
       end
@@ -64,8 +64,8 @@ describe Indexing::Bundle::Redis do
       index.stub! :files => files
       
       @ary = stub :ary
-      @index.should_receive(:[]).any_number_of_times.and_return @ary
-      index.stub! :index => @index
+      inverted = stub :inverted, :[] => @ary
+      index.stub! :inverted => inverted
     end
     context 'id key format' do
       before(:each) do
@@ -99,13 +99,13 @@ describe Indexing::Bundle::Redis do
     end
   end
 
-  describe 'load_from_index_file' do
+  describe 'load_from_prepared_index_file' do
     it 'should call two methods in order' do
-      index.should_receive(:load_from_index_generation_message).once.ordered
+      index.should_receive(:load_from_prepared_index_generation_message).once.ordered
       index.should_receive(:clear).once.ordered
       index.should_receive(:retrieve).once.ordered
 
-      index.load_from_index_file
+      index.load_from_prepared_index_file
     end
   end
 
@@ -129,7 +129,7 @@ describe Indexing::Bundle::Redis do
 
   describe 'generate_caches_from_source' do
     it 'should call two methods in order' do
-      index.should_receive(:load_from_index_file).once.ordered
+      index.should_receive(:load_from_prepared_index_file).once.ordered
       index.should_receive(:generate_caches_from_memory).once.ordered
 
       index.generate_caches_from_source
@@ -138,7 +138,9 @@ describe Indexing::Bundle::Redis do
   
   describe 'dump' do
     it 'should trigger dumps' do
-      index.should_receive(:dump_index).once.with
+      index.stub! :timed_exclaim
+      
+      index.should_receive(:dump_inverted).once.with
       index.should_receive(:dump_weights).once.with
       index.should_receive(:dump_similarity).once.with
       index.should_receive(:dump_configuration).once.with
@@ -256,7 +258,7 @@ describe Indexing::Bundle::Redis do
   
   describe 'initialization' do
     it 'should initialize the index correctly' do
-      index.index.should == {}
+      index.inverted.should == {}
     end
     it 'should initialize the weights index correctly' do
       index.weights.should == {}

data/spec/lib/query/allocation_spec.rb

@@ -34,7 +34,7 @@ describe Query::Allocation do
         @allocation.stub! :ids => :ids
       end
       it "represents correctly" do
-        @allocation.to_s.should == "Allocation: some_result_identifier, score, 10, combinations_result, ids"
+        @allocation.to_s.should == "Allocation([:some_result_identifier, :score, 10, \"combinations_result\", :ids])"
       end
     end
   end

data/spec/lib/query/token_spec.rb

@@ -87,13 +87,11 @@ describe Query::Token do
         it 'generates all similar' do
           @token.next_similar(@bundle).should == nil
         end
-        # TODO
-        #
-        # it 'should have a certain text' do
-        #   @token.next_similar @bundle
-        #   
-        #   @token.text.should == :nonsimilar
-        # end
+        it 'should have a certain text' do
+          @token.next_similar @bundle
+          
+          @token.text.should == :nonsimilar
+        end
       end
     end
   end

data/spec/lib/sources/base_spec.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+
+describe Sources::Base do
+  context 'with the base class' do
+    let(:source) { described_class.new }
+    
+    describe 'connect_backend' do
+      it 'exists' do
+        source.connect_backend
+      end
+    end
+    
+    describe 'take_snapshot' do
+      it 'exists and takes a single parameter' do
+        source.take_snapshot :some_index
+      end
+    end
+  end
+  
+  context 'with subclass' do
+    let(:take_snapshot_called) { 0 }
+    let(:subclass) do
+      Class.new(described_class) do
+        def take_snapshot index
+          index.call index
+        end
+      end.new
+    end
+    
+    describe 'with snapshot' do
+      it 'is called only once when called in nested blocks' do
+        index = stub :index, :identifier => :some_index
+        subclass.stub! :timed_exclaim
+
+        index.should_receive(:call).once.with index
+
+        subclass.with_snapshot(index) do
+          subclass.with_snapshot(index) do
+            subclass.with_snapshot(index) do
+
+            end
+          end
+          subclass.with_snapshot(index) do
+            subclass.with_snapshot(index) do
+
+            end
+          end
+        end
+      end
+    end
+  end
+  
+end

data/spec/lib/sources/db_spec.rb

@@ -102,13 +102,6 @@ describe Sources::DB do
       @source.should_receive(:get_data).any_number_of_times.and_return [[:some_id, 'some_text']].cycle
       @source.stub! :count => 17
     end
-    it 'calls connect_backend' do
-      @source.should_receive(:connect_backend).once.with()
-      
-      @source.harvest @category do |id, text|
-        p [id, text]
-      end
-    end
   end
 
   describe "harvest_statement_with_offset" do