picky-client 3.3.3 → 3.4.0

data/lib/picky-client/convenience.rb

@@ -41,6 +41,9 @@ module Picky
     #
     # If you don't pass it a block, it will just use the AR results.
     #
+    # Note: Usually, after this the ids are not needed anymore.
+    #       Use #clear_ids to remove them.
+    #
     # === Parameters
     # * model_class: The model to use for the results. Will call #find on the given class.
     #
@@ -49,7 +52,7 @@ module Picky
     # * The rest of the options are directly passed through to the ModelClass.find(ids, options) method. Default is {}.
     #
     def populate_with model_class, options = {}, &block
-      the_ids = ids options.delete(:up_to)
+      the_ids  = ids options.delete(:up_to)
 
       objects = model_class.find the_ids, options
 
@@ -67,7 +70,6 @@ module Picky
       objects.collect! &block if block_given?
 
       amend_ids_with objects
-      clear_ids
 
       objects
     end

data/spec/picky-client/convenience_spec.rb

@@ -12,7 +12,7 @@ describe Picky::Convenience do
       :duration => 0.12345
     }.extend Picky::Convenience
   end
-  
+
   describe "entries" do
     context "default" do
       context "without block" do
@@ -75,7 +75,7 @@ describe Picky::Convenience do
       end
     end
   end
-  
+
   describe "populate_with" do
     before(:each) do
       @results = {
@@ -87,7 +87,7 @@ describe Picky::Convenience do
            :duration => 0.123,
            :count => 1234
          }.extend Picky::Convenience
-      
+
       class ARClass
         attr_reader :id
         def initialize id
@@ -109,8 +109,12 @@ describe Picky::Convenience do
       @results.populate_with(ARClass) { |ar_instance| ar_instance.id.to_s }
       @results.entries.should == (1..20).map { |id| id.to_s } # "rendering" using to_s
     end
+    it "keeps the ids by default" do
+      @results.populate_with(ARClass) { |ar_instance| ar_instance.id.to_s }
+      @results.ids.should_not be_empty
+    end
   end
-  
+
   describe 'replace_ids_with' do
     before(:each) do
       @results = {

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: picky-client
 version: !ruby/object:Gem::Version
-  version: 3.3.3
+  version: 3.4.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-11-03 00:00:00.000000000 Z
+date: 2011-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: yajl-ruby
-  requirement: &70131322216900 !ruby/object:Gem::Requirement
+  requirement: &70210313757500 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: 0.7.8
   type: :runtime
   prerelease: false
-  version_requirements: *70131322216900
+  version_requirements: *70210313757500
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &70131322216400 !ruby/object:Gem::Requirement
+  requirement: &70210313757000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,7 +32,7 @@ dependencies:
         version: 3.0.0
   type: :runtime
   prerelease: false
-  version_requirements: *70131322216400
+  version_requirements: *70210313757000
 description: Picky Client
 email: florian.hanke+picky-client@gmail.com
 executables: []