pickup 0.0.10 → 0.0.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e2e6ae63af48eb1ff181735d1d88db79470e7b8d
-  data.tar.gz: aab0f2462466c3149d0820a4a70f198d94daa489
+  metadata.gz: 1533293d956a1a06ceccf39a693f5718f1a2ead1
+  data.tar.gz: bbc60771078bea080db4eab391d6a448d927a8de
 SHA512:
-  metadata.gz: 3a0cd64924a3b175b456cd5421f5da3112a8a8d1802c8f678809e399c832c3fcd5cc4c58641ce6562e58edd70bd88e0e9c1792a15a3c747410335d4e7abe3d15
-  data.tar.gz: bd3adec20e7b61d7f14e8d0cb2d4f36ba8744f3b78cd20142158a2fe4523ba63fbf032f7cd8ae9955ae36059fa725d644f7a1fbe9d4208dc5e4845b26a5d2851
+  metadata.gz: 38b74b2aae9cfb9ad5bd606a2332364786b74954f6718a94c6a2eed2ab263a83abff0f3ee2e944a06fb04a3dd064d6e0f9c99f06ce44c0f629185a818e541c0c
+  data.tar.gz: 24789240487187618292db31609d935124523c5014fb568181782c0e8df45d87ec41a42964af3cfaab4e36b6ee846dd5f14fa41bb4dfa3f73f3d6a406e6e697d

data/README.md

@@ -1,6 +1,6 @@
 # Pickup
 
-Pickup helps you to pick item from collection by it's weight/probability
+Pickup helps you to pick an item from a collection by its weight or probability.
 
 ## Installation
 
@@ -136,4 +136,4 @@ pickup.pick(1, key_func: name_func)
 2. Create your feature branch (`git checkout -b my-new-feature`)
 3. Commit your changes (`git commit -am 'Added some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
-5. Create new Pull Request
+5. Create new Pull Request

data/lib/pickup.rb

@@ -117,6 +117,7 @@ class Pickup
     def random(count)
       raise "List is shorter then count of items you want to get" if uniq && list.size < count
       nums = count.times.map{ rand(max) }.sort
+      return [] if max == 0
       get_random_items(nums)
     end
 

data/lib/pickup/version.rb

@@ -1,3 +1,3 @@
 class Pickup
-  VERSION = "0.0.10"
+  VERSION = "0.0.11"
 end

data/spec/pickup/pickup_spec.rb

@@ -4,6 +4,7 @@ require 'ostruct'
 require 'stringio'
 
 describe Pickup do
+
   before do
     @list = {
       "selmon"  => 1,     # 1
@@ -49,7 +50,7 @@ describe Pickup do
       # Inspect the fake IO object for the deprecated warning.
       $stderr.rewind
       $stderr.string.chomp.must_equal("[DEPRECATED] Passing uniq as a boolean to MappedList's initialize method is deprecated. Please use the opts hash instead.")
-    
+
       # Restore the original stderr.
       $stderr = orig_stderr
     end
@@ -116,4 +117,11 @@ describe Pickup do
   it "should take 5 fish (using custom weight function)" do
     @pickup3.pick(5, key_func: @key_func, weight_func: @weight_func).size.must_equal 5
   end
+
+  let(:list) { { "foo" => 0 } }
+  let(:pickup) { Pickup.new(list) }
+
+  it "should not devide by zero" do
+    pickup.pick(1)
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pickup
 version: !ruby/object:Gem::Version
-  version: 0.0.10
+  version: 0.0.11
 platform: ruby
 authors:
 - fl00r
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-26 00:00:00.000000000 Z
+date: 2015-03-16 00:00:00.000000000 Z
 dependencies: []
 description: Pickup helps you to pick item from collection by it's weight/probability
 email:
@@ -17,7 +17,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
 - Gemfile
 - LICENSE
 - README.md
@@ -37,17 +37,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '1.9'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.6
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Pickup helps you to pick item from collection by it's weight/probability