pickles 0.1.8 → 0.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 763495a5866fc3cfc1096efddba1c0c0bfec8e53
-  data.tar.gz: 4d2291b4b4af79ff2a6b1b3639a9fc8183fd3311
+  metadata.gz: 8118ba0ab14b4b72c919b150f89486f1e6adb6a9
+  data.tar.gz: b9735e920420d9fcaaf34d87d7923d77dacdf0a4
 SHA512:
-  metadata.gz: baa010f04476adc48f95725fee9bf0f045c2e093656faa128f7fa0b0440c524dd0b2d1b33a883a475993fe9b11b5ebc410bb94b0d6f19a18e111960dcd127aae
-  data.tar.gz: 7deaf0a5273bb476b5b7aa167bd2d03a2259b8037510a78e8c5c1bf79fc3729d1e6805ed19d0d3be566b36d2a28b948cdf5d6601ccf76e769d040cdb80ae305b
+  metadata.gz: 94df6c00755830b691ba3323d62653c1759723c62c9a57c591e61a0bc2f4527cd5acb6a6863dd5b5ea2946367742d8b3c6cb18ee32e4b43f7bb511048d7ec44e
+  data.tar.gz: 7832423793a2791d27882482a4eb6d4530d47e6b7af0be48fd3ae98b829576e3a67b56afeece897306d7d107c2d3b20b5e475b4799a0f0241bac83a964354365

data/lib/cucumber/pickles/config.rb

@@ -14,7 +14,7 @@ end
 
 class Pickles::Config
 
-  using HashSymbolizeKeys
+  using HashStringifyKeys
 
   attr_accessor :css_node_map, :xpath_node_map, :log_xhr_response
 

data/lib/cucumber/pickles/helpers/node_finders.rb

@@ -78,7 +78,8 @@ module NodeFinders
     within ||= Capybara.current_session
     options[:visible] = false
 
-    locator, index = Locator::Index.execute(input_locator)
+    locator, index       = Locator::Index.execute(input_locator)
+    locator, label_xpath = Locator::Equal.execute(locator)
 
     if index
       index_xpath = "[#{index}]"
@@ -89,8 +90,6 @@ module NodeFinders
     # case 3
     _rescued_find([:xpath, xpath, options], locator, within: within, message: "@contenteditable with placeholder = #{locator}") do
 
-      locator, label_xpath = Locator::Equal.execute(input_locator)
-
       inputtable_field_xpath = "*[self::input or self::textarea or @contenteditable]"
 
       xpath = "(#{label_xpath})#{index_xpath}/ancestor::*[.//#{inputtable_field_xpath}][position()=1]//#{inputtable_field_xpath}"

data/lib/cucumber/pickles/steps/fill_in/complex_input.rb

@@ -2,9 +2,11 @@ class FillIN::ComplexInput
 
   include Pickles
 
+  attr_reader :value, :label
+
   def initialize(label, value, within)
-    @label = label
-    @value = value
+    @label  = label
+    @value  = value
     @within = within || Capybara.current_session
   end
 

data/lib/cucumber/pickles/steps/fill_in/factory.rb

@@ -9,7 +9,11 @@ class FillIN::Factory
   end
 
   def call
-    if !@value.nil? && @value[':']
+    if in_quotes?
+      remove_quotes!
+    end
+
+    if !@value.nil? && @value[':'] && !in_quotes?
       step = FillIN::ComplexInput
     elsif @label =~ TAG
       @label = $1
@@ -22,4 +26,15 @@ class FillIN::Factory
     step.new(@label, @value, @within)
   end
 
+private
+
+  def in_quotes?
+    @in_quotes ||= @value && @value[0] == "\"" && @value[-1] == "\""
+  end
+
+  def remove_quotes!
+    @value[0]  = ''
+    @value[-1] = ''
+  end
+
 end

data/lib/cucumber/pickles/steps/fill_in/input.rb

@@ -1,5 +1,7 @@
 class FillIN::Input
 
+  attr_reader :label, :value
+
   def initialize(label, value, within)
     @label = label
     @value = value

data/lib/cucumber/pickles/version.rb

@@ -1,3 +1,3 @@
 module Pickles
-  VERSION = "0.1.8"
+  VERSION = "0.1.9"
 end

data/spec/helpers/waiter_spec.rb

@@ -16,6 +16,7 @@ RSpec.describe '#Waiter' do
     @session.evaluate_script(
       <<~JS
         new XMLHttpRequest().open("GET", '')
+        new XMLHttpRequest().send()
       JS
     )
 

data/spec/steps/fill_in/factory_spec.rb

@@ -39,6 +39,16 @@ RSpec.describe '#FillIN::Factory' do
     expect(step).to be_instance_of(FillIN::ComplexInput)
   end
 
+  it 'uses default input step if value has : and surrounded by quotes' do
+    label = "input"
+    value = "\"1:2:3\""
+
+    step = FillIN::Factory.new(label, value).call
+
+    expect(step).to be_instance_of(FillIN::Input)
+    expect(step.value).to eq "1:2:3"
+  end
+
   it 'uses input step by default' do
     label = "input"
     value = "1"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pickles
 version: !ruby/object:Gem::Version
-  version: 0.1.8
+  version: 0.1.9
 platform: ruby
 authors:
 - vs