pickle 0.4.3 → 0.4.4

data/History.txt

@@ -1,3 +1,14 @@
+== 0.4.4
+large object space fix, and allow escaped quotes as string values
+
+* 1 bugfix
+  * When using super-huge GC limits (for speeding up tests), occasionally we'll see abandoned Mongoid::Document classes appear in the ObjectSpace.
+    This patch should fix that. [Devin Walters and Nick Karpenske]
+  
+* 1 improvement
+  * allow escaped quotes (\") in quoted fields [Jonathan Hinkle]
+
+
 == 0.4.3
 ruby 1.9.2 compatibility fix
 

data/README.rdoc

@@ -347,6 +347,8 @@ To run the features (rails 2.3 only ATM):
 
 The following people have made Pickle better:
 
+* {Jonathan Hinkle}[http://github.com/hynkle]
+* {Devin Walters and Nick Karpenske}[http://github.com/bendyworks]
 * {Marc Lee}[http://github.com/maleko]
 * {Sebastian Zuchmanski}[http://github.com/sebcioz]
 * {Paul Gideon Dann}[http://github.com/giddie]

data/VERSION

@@ -1 +1 @@
-0.4.3
+0.4.4

data/features/pickle/create_from_active_record.feature

@@ -16,6 +16,10 @@ Feature: I can easily create models from my blueprints
     Then a user should exist with name: "Fred"
     And a user should exist with status: "crayzee"
     But a user should not exist with name: "Wilma"
+
+  Scenario: I create a user with quotes in its status, and see if it looks right
+    Given a user exists with name: "Fred", status: "a little \"off\""
+    Then a user should exist with status: "a little \"off\""
   
   Scenario: I create a user via a mapping
     Given I exist with status: "pwned", name: "fred"
@@ -43,19 +47,22 @@ Feature: I can easily create models from my blueprints
     
   Scenario: create and find using tables
     Given the following users exist:
-      | name  | status                   |
-      | Jim   | married                  |
-      | Ethel | in a relationship with x |
+      | name   | status                    |
+      | Jim    | married                   |
+      | Ethel  | in a relationship with x  |
+      | Garvin | in an "open" relationship |
     Then the following users should exist:
-      | name  |
-      | Jim   |
-      | Ethel |
+      | name   |
+      | Jim    |
+      | Ethel  |
+      | Garvin |
     And the following users should exist:
-      | status                   |
-      | married                  |
-      | in a relationship with x |
-    And the 1st user should be the 3rd user
-    And the 2nd user should be the last user
+      | status                    |
+      | married                   |
+      | in a relationship with x  |
+      | in an "open" relationship |
+    And the 1st user should be the 4th user
+    And the 3rd user should be the last user
     
     Scenario: create and find using tables with referencable names
       Given the following users exist:

data/lib/pickle/adapters/mongoid.rb

@@ -17,7 +17,7 @@ module Mongoid
 
       # get a list of column names for a given class
       def self.column_names(klass)
-        klass.fields.keys
+        klass.try(:fields).try(:keys) || []
       end
 
       # Get an instance by id of the model

data/lib/pickle/parser/matchers.rb

@@ -14,7 +14,7 @@ module Pickle
       end
   
       def match_quoted
-        '(?:[^\\"]|\\.)*'
+        '(?:\\\\"|[^\\"]|\\.)*'
       end
   
       def match_label

data/pickle.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{pickle}
-  s.version = "0.4.3"
+  s.version = "0.4.4"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Ian White"]
-  s.date = %q{2010-11-04}
+  s.date = %q{2010-12-14}
   s.description = %q{Easy model creation and reference in your cucumber features}
   s.email = %q{ian.w.white@gmail.com}
   s.extra_rdoc_files = [

data/spec/pickle/parser/matchers_spec.rb

@@ -41,7 +41,7 @@ describe Pickle::Parser::Matchers do
       atom_should_match     :match_label, [': "gday"', ': "gday mate"']
       atom_should_not_match :match_label, [': "gday""', ': gday']
   
-      atom_should_match     :match_field, ['foo: "this is the life"', 'bar_man: "and so is this"', 'boolean: false', 'boolean: true', 'numeric: 10', 'numeric: 12.5', 'numeric: +10', 'numeric: +12.5', 'numeric: -10', 'numeric: -12.5', 'nil_field: nil']
+      atom_should_match     :match_field, ['foo: "this is the life"', 'bar_man: "and so is this"', 'quoted_baz: "words \"in quotes\""', 'boolean: false', 'boolean: true', 'numeric: 10', 'numeric: 12.5', 'numeric: +10', 'numeric: +12.5', 'numeric: -10', 'numeric: -12.5', 'nil_field: nil']
       atom_should_not_match :match_field, ['foo bar: "this aint workin"', 'not_numeric: --10', 'not_numeric: -ten']
   
       atom_should_match     :match_fields, ['foo: "bar"', 'foo: "bar", baz: "bah"']

data/spec/pickle/parser_spec.rb

@@ -53,6 +53,10 @@ describe Pickle::Parser do
       it '(\'foo: "bar"\') should == { "foo" => "bar"}' do
         @parser.parse_fields('foo: "bar"').should == { "foo" => "bar"}
       end
+
+      it '(\'foo: "something \"quoted\""\') should == { "foo" => "bar"}' do
+        @parser.parse_fields('foo: "something \"quoted\""').should == { "foo" => 'something "quoted"' }
+      end
     
       it '("bool: true") should == { "bool" => true}' do
         @parser.parse_fields('bool: true').should == {"bool" => true}
@@ -70,8 +74,8 @@ describe Pickle::Parser do
         @parser.parse_fields('float: 10.1').should == {"float" => 10.1}
       end
 
-      it '(\'foo: "bar", bar_man: "wonga wonga", gump: 123\') should == {"foo" => "bar", "bar_man" => "wonga wonga", "gump" => 123}' do
-        @parser.parse_fields('foo: "bar", bar_man: "wonga wonga", gump: 123').should == {"foo" => "bar", "bar_man" => "wonga wonga", "gump" => 123}
+      it '(\'foo: "bar", bar_man: "wonga wonga", baz_woman: "one \"two\" three", gump: 123\') should == {"foo" => "bar", "bar_man" => "wonga wonga", "gump" => 123}' do
+        @parser.parse_fields('foo: "bar", bar_man: "wonga wonga", baz_woman: "one \"two\" three", gump: 123').should == {"foo" => "bar", "bar_man" => "wonga wonga", "baz_woman" => "one \"two\" three", "gump" => 123}
       end
     end
   

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: pickle
 version: !ruby/object:Gem::Version 
-  hash: 9
+  hash: 7
   prerelease: false
   segments: 
   - 0
   - 4
-  - 3
-  version: 0.4.3
+  - 4
+  version: 0.4.4
 platform: ruby
 authors: 
 - Ian White
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-11-04 00:00:00 +00:00
+date: 2010-12-14 00:00:00 +00:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency