physical 0.4.7 → 0.4.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4afd0ceee652dcc6cfb4cd62b89784d25991d99102f65c11a4905a8b48ea1525
-  data.tar.gz: 8e1bb6c41964c9c51ae5dd38d5c8bd7e16a1401221f0895cab3628f6c9cb1ff0
+  metadata.gz: 8198a4417d9f1dd923a4bfee9bf8695ecb1c270853182a92835e64c1b9f4e10c
+  data.tar.gz: 8a007792624c95421bce9a09abb978de1142b8a2bfbfe6cef049c860ca101416
 SHA512:
-  metadata.gz: bb8ca914487384660d59b352b5b7732cddcc251c8e3355e59549080b54d469a6f9d3f5b55424acf6467b90289a7d47e59f9a34adbf78ebe8c48b69b7582fa21a
-  data.tar.gz: 3caa65b04977f5a091077fe2e6ebcc9c11fa335a6b11cd8091dc1d8da6c4e2e7ca3312b3561b3200537ef8210d22bfbcca5dd7bafc6c5cf8c8ec39fb587589a7
+  metadata.gz: b39b9310b28cd5bd9cfe3ea0511f6c615f3c130060693296e6aa01b18d3c893c9cd1704954133e9655c6a47fbe66f636eabc95c4a012f1e34ae4a0e634f6c0b3
+  data.tar.gz: 4881137e7cd922d5a9e56bcaec2fd5701b1e21f3e4ed53528585c14a2c24e0f2b90d93b2b36c7327160dae03cdc9c3e0f3a6171abb898d17843de862bf1f02a1

data/CHANGELOG.md

@@ -6,12 +6,28 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+## [0.4.9] - 2023-08-02
+
+### Added
+- Extract cuboid property handling into mixin [#25]
+- Add properties to `Physical::Location` [#26]
+- Add pallets to `Physical::Shipment` [#29]
+
+### Changed
+- Faster package weight and volume calculations [#23]
+
+## [0.4.8] - 2023-03-21
+
+### Added
+- Add `#items_value` to `Physical::Package` [#21]
+
 ## [0.4.7] - 2022-12-14
 
 ### Changed
-- Relax Dry::Types dependency to "~> 1.0"
+- Relax Dry::Types dependency to "~> 1.0" [#20]
 
 ## [0.4.5] - 2022-09-28
+
 ### Added
 - Add `Physical::Pallet` class [#12]
 - Convenience methods for weight, volume, and fill [#15]
@@ -24,22 +40,27 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Ruby 3 support [#18]
 
 ## [0.4.4] - 2019-10-29
+
 ### Added
 - Add `#sku`, `#cost` and `#description` to `Physical::Item`
 
 ## [0.4.3] - 2019-10-14
+
 ### Added
 - Add `#latitude` and `#longitude` to `Physical::Location`
 
 ## [0.4.2] - 2019-09-04
+
 ### Changed
 - Relax `Measured` Gem dependency
 
 ## [0.4.1] - 2019-07-15
+
 ### Added
 - Add `max_weight` to `Physical::Package`
 
 ## [0.4.0] - 2019-07-10
+
 ### Added
 - `Measured::Density` Type and density calculations [@tvdeyen](https://github.com/mamhoff/physical/pull/19)
 - Use `Measured::Density` Type when initializing `Physical::Package#void_fill_density` [@mamhoff](https://github.com/mamhoff/physical/pull/22)

data/lib/physical/cuboid.rb

@@ -4,6 +4,8 @@ require 'measured'
 
 module Physical
   class Cuboid
+    include PropertyReaders
+
     attr_reader :dimensions, :length, :width, :height, :weight, :id, :properties
 
     def initialize(id: nil, dimensions: [], weight: Measured::Weight(0, :g), properties: {})
@@ -33,27 +35,6 @@ module Physical
 
     private
 
-    NORMALIZED_METHOD_REGEX = /(\w+)\??$/.freeze
-
-    def method_missing(method)
-      symbolized_properties = properties.symbolize_keys
-      method_name = normalize_method_name(method)
-      if symbolized_properties.key?(method_name)
-        symbolized_properties[method_name]
-      else
-        super
-      end
-    end
-
-    def respond_to_missing?(method, *args)
-      method_name = normalize_method_name(method)
-      properties.symbolize_keys.key?(method_name) || super
-    end
-
-    def normalize_method_name(method)
-      method.to_s.sub(NORMALIZED_METHOD_REGEX, '\1').to_sym
-    end
-
     def fill_dimensions(dimensions)
       dimensions.fill(dimensions.length..2) do |index|
         @dimensions[index] || Measured::Length(self.class::DEFAULT_LENGTH, :cm)

data/lib/physical/location.rb

@@ -4,6 +4,8 @@ require 'carmen'
 
 module Physical
   class Location
+    include PropertyReaders
+
     ADDRESS_TYPES = %w(residential commercial po_box).freeze
 
     attr_reader :country,
@@ -20,7 +22,8 @@ module Physical
                 :address_type,
                 :company_name,
                 :latitude,
-                :longitude
+                :longitude,
+                :properties
 
     def initialize(
       name: nil,
@@ -37,7 +40,8 @@ module Physical
       email: nil,
       address_type: nil,
       latitude: nil,
-      longitude: nil
+      longitude: nil,
+      properties: {}
     )
 
       @country = if country.is_a?(Carmen::Country)
@@ -65,6 +69,7 @@ module Physical
       @address_type = address_type
       @latitude = latitude
       @longitude = longitude
+      @properties = properties
     end
 
     def residential?

data/lib/physical/package.rb

@@ -3,24 +3,31 @@
 module Physical
   class Package
     extend Forwardable
-    attr_reader :container, :items, :void_fill_density, :id
+    attr_reader :id, :container, :items, :void_fill_density, :items_weight, :used_volume
 
     def initialize(id: nil, container: nil, items: [], void_fill_density: Measured::Density(0, :g_ml), dimensions: nil, weight: nil, properties: {})
       @id = id || SecureRandom.uuid
       @void_fill_density = Types::Density[void_fill_density]
       @container = container || Physical::Box.new(dimensions: dimensions || [], weight: weight || Measured::Weight(0, :g), properties: properties)
+
       @items = Set[*items]
+      @items_weight = @items.map(&:weight).reduce(Measured::Weight(0, :g), &:+)
+      @used_volume = @items.map(&:volume).reduce(Measured::Volume(0, :ml), &:+)
     end
 
     delegate [:dimensions, :width, :length, :height, :properties, :volume] => :container
 
     def <<(other)
       @items.add(other)
+      @items_weight += other.weight
+      @used_volume += other.volume
     end
     alias_method :add, :<<
 
     def >>(other)
       @items.delete(other)
+      @items_weight -= other.weight
+      @used_volume -= other.volume
     end
     alias_method :delete, :>>
 
@@ -28,9 +35,12 @@ module Physical
       container.weight + items_weight + void_fill_weight
     end
 
-    # @return [Measured::Weight]
-    def items_weight
-      items.map(&:weight).reduce(Measured::Weight(0, :g), &:+)
+    # Cost is optional. We will only return an aggregate if all items
+    # have cost defined. Otherwise we will return nil.
+    # @return Money
+    def items_value
+      items_cost = items.map(&:cost)
+      items_cost.reduce(&:+) if items_cost.compact.size == items_cost.size
     end
 
     def void_fill_weight
@@ -39,11 +49,6 @@ module Physical
       Measured::Weight(void_fill_density.convert_to(:g_ml).value * remaining_volume.convert_to(:ml).value, :g)
     end
 
-    # @return [Measured::Volume]
-    def used_volume
-      items.map(&:volume).reduce(Measured::Volume(0, :ml), &:+)
-    end
-
     def remaining_volume
       container.inner_volume - used_volume
     end

data/lib/physical/property_readers.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+module Physical
+  module PropertyReaders
+    private
+
+    NORMALIZED_METHOD_REGEX = /(\w+)\??$/.freeze
+
+    def method_missing(method)
+      symbolized_properties = properties.symbolize_keys
+      method_name = normalize_method_name(method)
+      if symbolized_properties.key?(method_name)
+        symbolized_properties[method_name]
+      else
+        super
+      end
+    end
+
+    def respond_to_missing?(method, *args)
+      method_name = normalize_method_name(method)
+      properties.symbolize_keys.key?(method_name) || super
+    end
+
+    def normalize_method_name(method)
+      method.to_s.sub(NORMALIZED_METHOD_REGEX, '\1').to_sym
+    end
+  end
+end

data/lib/physical/shipment.rb

@@ -6,14 +6,16 @@ module Physical
                 :origin,
                 :destination,
                 :service_code,
+                :pallets,
                 :packages,
                 :options
 
-    def initialize(id: nil, origin: nil, destination: nil, service_code: nil, packages: [], options: {})
+    def initialize(id: nil, origin: nil, destination: nil, service_code: nil, pallets: [], packages: [], options: {})
       @id = id || SecureRandom.uuid
       @origin = origin
       @destination = destination
       @service_code = service_code
+      @pallets = pallets
       @packages = packages
       @options = options
     end

data/lib/physical/spec_support/factories/location_factory.rb

@@ -14,6 +14,7 @@ FactoryBot.define do
     city { 'Herndon' }
     sequence(:zip, 10_001, &:to_s)
     phone { '555-555-0199' }
+    email { 'jane@company.com' }
     region { country.subregions.coded(region_code) }
     country { Carmen::Country.coded(country_code) }
     initialize_with { new(**attributes) }

data/lib/physical/spec_support/factories/shipment_factory.rb

@@ -4,6 +4,7 @@ FactoryBot.define do
   factory :physical_shipment, class: "Physical::Shipment" do
     origin { FactoryBot.build(:physical_location) }
     destination { FactoryBot.build(:physical_location) }
+    pallets { build_list(:physical_pallet, 1) }
     packages { build_list(:physical_package, 2) }
     service_code { "usps_priority_mail" }
     initialize_with { new(**attributes) }

data/lib/physical/spec_support/shared_examples/a_cuboid.rb

@@ -0,0 +1,197 @@
+# frozen_string_literal: true
+
+RSpec.shared_examples "a cuboid" do
+  subject(:cuboid) { described_class.new(**args) }
+
+  it_behaves_like "has property readers"
+
+  let(:args) do
+    {
+      dimensions: [
+        Measured::Length.new(1.1, :cm),
+        Measured::Length.new(3.3, :cm),
+        Measured::Length.new(2.2, :cm)
+      ]
+    }
+  end
+
+  it { is_expected.to be_a(Physical::Cuboid) }
+  it { is_expected.to respond_to(:id) }
+
+  describe "#dimensions" do
+    subject(:dimensions) { cuboid.dimensions }
+
+    it "has dimensions as Measured::Length objects with rational values" do
+      expect(dimensions).to eq(
+        [
+          Measured::Length.new(1.1, :cm),
+          Measured::Length.new(3.3, :cm),
+          Measured::Length.new(2.2, :cm)
+        ]
+      )
+    end
+
+    context "when given a one-element dimensions array" do
+      let(:args) do
+        {
+          dimensions: [Measured::Length(2, :cm)]
+        }
+      end
+
+      specify "the other dimensions are filled up with default length" do
+        expect(dimensions).to eq(
+          [
+            Measured::Length.new(2, :cm),
+            Measured::Length.new(default_length, :cm),
+            Measured::Length.new(default_length, :cm)
+          ]
+        )
+      end
+    end
+
+    context "when given a two-element dimensions array" do
+      let(:args) do
+        {
+          dimensions: [1, 2].map { |d| Measured::Length(d, :cm) }
+        }
+      end
+
+      it "the last dimension is filled up with default length" do
+        expect(dimensions).to eq(
+          [
+            Measured::Length.new(1, :cm),
+            Measured::Length.new(2, :cm),
+            Measured::Length.new(default_length, :cm)
+          ]
+        )
+      end
+    end
+
+    context "when given no arguments" do
+      let(:args) { {} }
+
+      it "assumes cm as the dimension_unit and the default length as value" do
+        expect(dimensions).to eq(
+          [
+            Measured::Length.new(default_length, :cm),
+            Measured::Length.new(default_length, :cm),
+            Measured::Length.new(default_length, :cm)
+          ]
+        )
+      end
+    end
+  end
+
+  describe "dimension methods" do
+    it "has getter methods for each dimension as Measured::Length object" do
+      expect(cuboid.length).to eq(Measured::Length.new(1.1, :cm))
+      expect(cuboid.width).to eq(Measured::Length.new(3.3, :cm))
+      expect(cuboid.height).to eq(Measured::Length.new(2.2, :cm))
+    end
+  end
+
+  describe "#weight" do
+    subject(:weight) { cuboid.weight }
+
+    context "with no weight given" do
+      let(:args) { {} }
+      it { is_expected.to eq(Measured::Weight(0, :g)) }
+    end
+
+    context "with a weight" do
+      let(:args) { { weight: Measured::Weight(1, :lb) } }
+      it { is_expected.to eq(Measured::Weight(453.59237, :g)) }
+    end
+  end
+
+  describe "#volume" do
+    subject(:volume) { cuboid.volume }
+
+    context "if all three dimensions are given" do
+      let(:args) do
+        {
+          dimensions: [1.1, 2.1, 3.2].map { |d| Measured::Length(d, :cm) }
+        }
+      end
+
+      it { is_expected.to eq(Measured::Volume(7.392, :ml)) }
+    end
+
+    context "if a dimension is missing" do
+      let(:args) do
+        {
+          dimensions: [1.1, 2.1].map { |d| Measured::Length(d, :cm) }
+        }
+      end
+
+      it { is_expected.to eq(Measured::Volume(default_length, :ml)) }
+    end
+  end
+
+  describe "#density" do
+    subject(:density) { cuboid.density.value.to_f }
+
+    let(:args) do
+      {
+        dimensions: dimensions,
+        weight: weight
+      }
+    end
+
+    context "if volume is larger than 0" do
+      let(:dimensions) do
+        [1.1, 2.1, 3.2].map { |d| Measured::Length(d, :in) }
+      end
+
+      context "if weight is 1" do
+        let(:weight) { Measured::Weight(1, :pound) }
+
+        it "returns the density in gramms per cubiq centimeter (ml)" do
+          is_expected.to eq(3.7445758536530196)
+        end
+      end
+
+      context "if weight is 0" do
+        let(:weight) { Measured::Weight(0, :pound) }
+
+        it { is_expected.to eq(0.0) }
+      end
+    end
+
+    context "if volume is 0" do
+      let(:dimensions) do
+        [1.1, 2.1].map { |d| Measured::Length(d, :in) }
+      end
+
+      let(:weight) { Measured::Weight(1, :pound) }
+      let(:expected_volume) { default_length.zero? ? BigDecimal::INFINITY : 0 }
+
+      it { is_expected.to eq(expected_volume) }
+    end
+
+    context "if volume is infinite" do
+      let(:dimensions) do
+        [1.1, 2.1].map { |d| Measured::Length(d, :in) }
+      end
+
+      let(:weight) { Measured::Weight(1, :pound) }
+      let(:expected_volume) { default_length.zero? ? BigDecimal::INFINITY : 0 }
+
+      it { is_expected.to eq(expected_volume) }
+    end
+  end
+
+  describe "#==" do
+    let(:args) { Hash[id: 123] }
+    let(:other_cuboid) { described_class.new(**args) }
+    let(:non_cuboid) { double(id: 123) }
+
+    it "compares cuboids" do
+      aggregate_failures do
+        expect(cuboid == other_cuboid).to be(true)
+        expect(cuboid == non_cuboid).to be(false)
+        expect(cuboid.nil?).to be(false)
+      end
+    end
+  end
+end

data/lib/physical/spec_support/shared_examples/has_property_readers.rb

@@ -0,0 +1,87 @@
+# frozen_string_literal: true
+
+RSpec.shared_examples 'has property readers' do
+  subject(:instance) { described_class.new(**args) }
+
+  describe "#properties" do
+    subject(:properties) { instance.properties }
+
+    let(:args) do
+      {
+        properties: { flammable: true }
+      }
+    end
+
+    it { is_expected.to eq({ flammable: true }) }
+  end
+
+  describe "properties methods" do
+    context "if method is a property" do
+      let(:args) do
+        {
+          properties: { already_packaged: true }
+        }
+      end
+
+      it "returns its value" do
+        expect(instance.already_packaged).to be(true)
+      end
+
+      it { is_expected.to respond_to(:already_packaged?) }
+    end
+
+    context "if method is a string property" do
+      let(:args) do
+        {
+          properties: { "already_packaged" => true }
+        }
+      end
+
+      it "returns its value" do
+        expect(instance.already_packaged).to be(true)
+      end
+
+      it { is_expected.to respond_to(:already_packaged?) }
+    end
+
+    context "if method is a boolean property" do
+      let(:args) do
+        {
+          properties: { already_packaged: true }
+        }
+      end
+
+      it "it is also accessible by its predicate method" do
+        expect(instance.already_packaged?).to be(true)
+      end
+
+      it { is_expected.to respond_to(:already_packaged?) }
+
+      context "with a falsey value" do
+        let(:args) do
+          {
+            properties: { already_packaged: false }
+          }
+        end
+
+        it "returns its value" do
+          expect(instance.already_packaged).to be(false)
+        end
+      end
+    end
+
+    context "if method is not a property" do
+      let(:args) do
+        {
+          properties: {}
+        }
+      end
+
+      it "raises method missing" do
+        expect { instance.already_packaged? }.to raise_error(NoMethodError)
+      end
+
+      it { is_expected.not_to respond_to(:already_packaged?) }
+    end
+  end
+end

data/lib/physical/spec_support/shared_examples.rb

@@ -1,45 +1,4 @@
 # frozen_string_literal: true
 
-RSpec.shared_examples 'a cuboid' do
-  let(:args) do
-    {
-      dimensions: [
-        Measured::Length.new(1.1, :cm),
-        Measured::Length.new(3.3, :cm),
-        Measured::Length.new(2.2, :cm)
-      ]
-    }
-  end
-
-  it { is_expected.to be_a(Physical::Cuboid) }
-
-  it "has dimensions as Measured::Length objects with rational values" do
-    expect(subject.dimensions).to eq(
-      [
-        Measured::Length.new(1.1, :cm),
-        Measured::Length.new(3.3, :cm),
-        Measured::Length.new(2.2, :cm)
-      ]
-    )
-  end
-
-  it "has getter methods for each dimension as Measured::Length object" do
-    expect(subject.length).to eq(Measured::Length.new(1.1, :cm))
-    expect(subject.width).to eq(Measured::Length.new(3.3, :cm))
-    expect(subject.height).to eq(Measured::Length.new(2.2, :cm))
-  end
-
-  describe "#==" do
-    let(:args) { Hash[id: 123] }
-    let(:other_cuboid) { described_class.new(**args) }
-    let(:non_cuboid) { double(id: 123) }
-
-    it "compares cuboids" do
-      aggregate_failures do
-        expect(subject == other_cuboid).to be(true)
-        expect(subject == non_cuboid).to be(false)
-        expect(subject.nil?).to be(false)
-      end
-    end
-  end
-end
+require "physical/spec_support/shared_examples/a_cuboid"
+require "physical/spec_support/shared_examples/has_property_readers"

data/lib/physical/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Physical
-  VERSION = "0.4.7"
+  VERSION = "0.4.9"
 end

data/lib/physical.rb

@@ -4,6 +4,7 @@ require "money"
 require "measured/density"
 require "physical/types"
 require "physical/version"
+require "physical/property_readers"
 require "physical/cuboid"
 require "physical/box"
 require "physical/package"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: physical
 version: !ruby/object:Gem::Version
-  version: 0.4.7
+  version: 0.4.9
 platform: ruby
 authors:
 - Martin Meyerhoff
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-12-14 00:00:00.000000000 Z
+date: 2023-08-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: carmen
@@ -199,6 +199,7 @@ files:
 - lib/physical/location.rb
 - lib/physical/package.rb
 - lib/physical/pallet.rb
+- lib/physical/property_readers.rb
 - lib/physical/shipment.rb
 - lib/physical/spec_support/factories/box_factory.rb
 - lib/physical/spec_support/factories/item_factory.rb
@@ -207,6 +208,8 @@ files:
 - lib/physical/spec_support/factories/pallet_factory.rb
 - lib/physical/spec_support/factories/shipment_factory.rb
 - lib/physical/spec_support/shared_examples.rb
+- lib/physical/spec_support/shared_examples/a_cuboid.rb
+- lib/physical/spec_support/shared_examples/has_property_readers.rb
 - lib/physical/test_support.rb
 - lib/physical/types.rb
 - lib/physical/version.rb
@@ -230,7 +233,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.33
+rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: A facade to deal with physical packages