physical 0.4.4 → 0.4.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: df340805fcfc8168b20b7ad8b1c6100be37fb1163b52d8d87b2f4fc7aa9f6440
-  data.tar.gz: 610081278560cfda0563c368baed947ddc3d932ea6786f21b21e5e21c324de98
+  metadata.gz: 4afd0ceee652dcc6cfb4cd62b89784d25991d99102f65c11a4905a8b48ea1525
+  data.tar.gz: 8e1bb6c41964c9c51ae5dd38d5c8bd7e16a1401221f0895cab3628f6c9cb1ff0
 SHA512:
-  metadata.gz: 44f4503f2905735ac04eaf80e004491f7fb4644ea97e58a5718fdda12b0e775217f8a80709759b5ec7487b3cfcd336ae59fd12e35d2c3904e71d062ec4b105bf
-  data.tar.gz: 21eb1efd17a46c0b993683a176646575f4340d5dc2d8015c7d65778601059a9cf3b969e0c004a6c841ec48bd0a3af2a449b359c3d619ac2a0953420883679263
+  metadata.gz: bb8ca914487384660d59b352b5b7732cddcc251c8e3355e59549080b54d469a6f9d3f5b55424acf6467b90289a7d47e59f9a34adbf78ebe8c48b69b7582fa21a
+  data.tar.gz: 3caa65b04977f5a091077fe2e6ebcc9c11fa335a6b11cd8091dc1d8da6c4e2e7ca3312b3561b3200537ef8210d22bfbcca5dd7bafc6c5cf8c8ec39fb587589a7

data/.circleci/config.yml

@@ -7,12 +7,7 @@ jobs:
   build:
     docker:
       # specify the version you desire here
-       - image: circleci/ruby:2.4.5
-
-      # Specify service dependencies here if necessary
-      # CircleCI maintains a library of pre-built images
-      # documented at https://circleci.com/docs/2.0/circleci-images/
-      # - image: circleci/postgres:9.4
+       - image: cimg/ruby:3.0.4
 
     working_directory: ~/repo
 
@@ -37,6 +32,10 @@ jobs:
             - ./vendor/bundle
           key: v1-dependencies-{{ checksum "Gemfile.lock" }}
 
+      - run:
+          name: run Rubocop
+          command: bundle exec rubocop
+
       # run tests!
       - run:
           name: run tests

data/.gitignore

@@ -11,3 +11,7 @@
 .rspec_status
 .ruby-version
 Gemfile.lock
+
+# RubyMine
+.idea
+.rakeTasks

data/.rubocop-relaxed.yml

@@ -0,0 +1,169 @@
+# Relaxed.Ruby.Style
+## Version 2.2
+
+Style/Alias:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylealias
+
+Style/AsciiComments:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#styleasciicomments
+
+Style/BeginBlock:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylebeginblock
+
+Style/BlockDelimiters:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#styleblockdelimiters
+
+Style/CommentAnnotation:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylecommentannotation
+
+Style/Documentation:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#styledocumentation
+
+Layout/DotPosition:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#layoutdotposition
+
+Style/DoubleNegation:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#styledoublenegation
+
+Style/EndBlock:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#styleendblock
+
+Style/FormatString:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#styleformatstring
+
+Style/IfUnlessModifier:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#styleifunlessmodifier
+
+Style/Lambda:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylelambda
+
+Style/ModuleFunction:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylemodulefunction
+
+Style/MultilineBlockChain:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylemultilineblockchain
+
+Style/NegatedIf:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylenegatedif
+
+Style/NegatedWhile:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylenegatedwhile
+
+Style/ParallelAssignment:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#styleparallelassignment
+
+Style/PercentLiteralDelimiters:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylepercentliteraldelimiters
+
+Style/PerlBackrefs:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#styleperlbackrefs
+
+Style/Semicolon:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylesemicolon
+
+Style/SignalException:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylesignalexception
+
+Style/SingleLineBlockParams:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylesinglelineblockparams
+
+Style/SingleLineMethods:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylesinglelinemethods
+
+Layout/SpaceBeforeBlockBraces:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#layoutspacebeforeblockbraces
+
+Layout/SpaceInsideParens:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#layoutspaceinsideparens
+
+Style/SpecialGlobalVars:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylespecialglobalvars
+
+Style/StringLiterals:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylestringliterals
+
+Style/TrailingCommaInArguments:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#styletrailingcommainarguments
+
+Style/TrailingCommaInArrayLiteral:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#styletrailingcommainarrayliteral
+
+Style/TrailingCommaInHashLiteral:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#styletrailingcommainhashliteral
+
+Style/SymbolArray:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#stylesymbolarray
+
+Style/WhileUntilModifier:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylewhileuntilmodifier
+
+Style/WordArray:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylewordarray
+
+Lint/AmbiguousRegexpLiteral:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#lintambiguousregexpliteral
+
+Lint/AssignmentInCondition:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#lintassignmentincondition
+
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/BlockNesting:
+  Enabled: false
+
+Metrics/ClassLength:
+  Enabled: false
+
+Metrics/ModuleLength:
+  Enabled: false
+
+Metrics/CyclomaticComplexity:
+  Enabled: false
+
+Metrics/LineLength:
+  Enabled: false
+
+Metrics/MethodLength:
+  Enabled: false
+
+Metrics/ParameterLists:
+  Enabled: false
+
+Metrics/PerceivedComplexity:
+  Enabled: false

data/.rubocop.yml

@@ -1,321 +1,8 @@
 AllCops:
-  Exclude:
-    - Gemfile
-    - Rakefile
-    - bin/*
-    - vendor/**/*
+  TargetRubyVersion: 2.4
 
-Layout/EmptyLinesAroundBlockBody:
-  Enabled: false
-
-Layout/EmptyLinesAroundModuleBody:
-  Enabled: false
-
-Layout/EmptyLinesAroundClassBody:
-  Enabled: false
-
-Layout/EmptyLinesAroundMethodBody:
-  Enabled: false
-
-Naming/MemoizedInstanceVariableName:
-  Enabled: false
-
-Style/RedundantSelf:
-  Enabled: false
-
-CollectionMethods:
-  Enabled: false
-
-# Sometimes I believe this reads better
-# This also causes spacing issues on multi-line fixes
-Style/BracesAroundHashParameters:
-  Enabled: false
-
-# We use class vars and will have to continue doing so for compatability
-Style/ClassVars:
-  Enabled: false
-
-# We need these names for backwards compatability
-Naming/PredicateName:
-  Enabled: false
-
-Naming/AccessorMethodName:
-  Enabled: false
-
-# This has been used for customization
-Style/MutableConstant:
-  Enabled: false
-
-# `something.count > 0` is often used in Solidus admin and IMO better to read then `something.count.positive?`
-Style/NumericPredicate:
-  Enabled: false
-
-Style/ClassAndModuleChildren:
-  Enabled: false
-
-Style/EmptyElse:
-  Enabled: false
-
-Style/GuardClause:
-  Enabled: false
-
-Style/Next:
-  Enabled: false
-
-Style/WordArray:
-  Enabled: false
-
-Style/ConditionalAssignment:
-  Enabled: false
-
-Performance/Count:
-  Enabled: false
-
-Style/RaiseArgs:
-  Enabled: false
-
-Naming/BinaryOperatorParameterName:
-  Enabled: false
-
-# We can use good judgement here
-Style/RegexpLiteral:
-  Enabled: false
-
-# Unicode comments are useful
-Style/AsciiComments:
-  Enabled: false
-
-Layout/EndAlignment:
-  Enabled: false
-
-Layout/ElseAlignment:
-  Enabled: false
-
-Layout/IndentationWidth:
-  Enabled: false
-
-Layout/AlignParameters:
-  Enabled: false
-
-Layout/ClosingParenthesisIndentation:
-  Enabled: false
-
-Layout/MultilineMethodCallIndentation:
-  Enabled: false
-
-Layout/IndentArray:
-  Enabled: false
-
-Layout/IndentHash:
-  Enabled: false
-
-Layout/AlignHash:
-  Enabled: false
-
-Style/TrailingCommaInArguments:
-  Enabled: false
-
-Style/TrailingCommaInArrayLiteral:
-  Enabled: false
-
-Style/TrailingCommaInHashLiteral:
-  Enabled: false
-
-Layout/SpaceInsideHashLiteralBraces:
-  Enabled: false
-
-# Symbol Arrays are ok and the %i syntax widely unknown
-Style/SymbolArray:
-  Enabled: false
-
-Rails/DynamicFindBy:
-  Whitelist:
-    - find_by_param
-    - find_by_param!
-
-# We use a lot of
-#
-#     expect {
-#       something
-#     }.to { happen }
-#
-# syntax in the specs files.
-Lint/AmbiguousBlockAssociation:
-  Exclude:
-    - 'spec/**/*'
-
-# We use eval to add common_spree_dependencies into the Gemfiles of each of our gems
-Security/Eval:
-  Exclude:
-    - 'Gemfile'
-    - '*/Gemfile'
-
-Naming/VariableNumber:
-  Enabled: false
-
-# Write empty methods as you wish.
-Style/EmptyMethod:
-  Enabled: false
-
-# The Rails Guides are in contradiction with this cop.
-Style/FormatStringToken:
-  Exclude:
-    - 'config/routes.rb'
-
-# From http://relaxed.ruby.style/
-
-Style/Alias:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylealias
-
-Style/BeginBlock:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylebeginblock
-
-Style/BlockDelimiters:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#styleblockdelimiters
-
-Style/Documentation:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#styledocumentation
-
-Layout/DotPosition:
-  EnforcedStyle: trailing
-  Enabled: true
-  StyleGuide: http://relaxed.ruby.style/#styledotposition
-
-Style/DoubleNegation:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#styledoublenegation
-
-Style/EndBlock:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#styleendblock
-
-Style/FormatString:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#styleformatstring
-
-Style/IfUnlessModifier:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#styleifunlessmodifier
-
-Style/Lambda:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylelambda
-
-Style/ModuleFunction:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylemodulefunction
-
-Style/MultilineBlockChain:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylemultilineblockchain
-
-Style/NegatedIf:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylenegatedif
-
-Style/NegatedWhile:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylenegatedwhile
-
-Style/ParallelAssignment:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#styleparallelassignment
-
-Style/PercentLiteralDelimiters:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylepercentliteraldelimiters
-
-Style/PerlBackrefs:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#styleperlbackrefs
-
-Style/Semicolon:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylesemicolon
-
-Style/SignalException:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylesignalexception
-
-Style/SingleLineBlockParams:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylesinglelineblockparams
-
-Style/SingleLineMethods:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylesinglelinemethods
-
-Layout/SpaceBeforeBlockBraces:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylespacebeforeblockbraces
-
-Layout/SpaceInsideParens:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylespaceinsideparens
-
-Style/SpecialGlobalVars:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylespecialglobalvars
-
-Style/StringLiterals:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylestringliterals
-
-Style/SymbolProc:
-  Enabled: false
-
-Style/WhileUntilModifier:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylewhileuntilmodifier
-
-Lint/AmbiguousRegexpLiteral:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#lintambiguousregexpliteral
-
-Lint/AssignmentInCondition:
-  Enabled: true
-  StyleGuide: http://relaxed.ruby.style/#lintassignmentincondition
-
-Metrics/AbcSize:
-  Enabled: false
-
-Metrics/BlockNesting:
-  Enabled: false
-
-Metrics/ClassLength:
-  Enabled: false
-
-Metrics/ModuleLength:
-  Enabled: false
+inherit_from:
+- .rubocop-relaxed.yml
 
 Metrics/BlockLength:
   Enabled: false
-
-Metrics/CyclomaticComplexity:
-  Enabled: false
-
-Metrics/LineLength:
-  Enabled: true
-  Max: 120
-  Exclude:
-    - 'spec/**/*'
-
-Metrics/MethodLength:
-  Enabled: false
-  Max: 25
-
-Metrics/ParameterLists:
-  Enabled: false
-
-Metrics/PerceivedComplexity:
-  Enabled: false
-
-Bundler/OrderedGems:
-  Enabled: false
-
-Style/NumericLiterals:
-  Enabled: false

data/CHANGELOG.md

@@ -6,6 +6,23 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+## [0.4.7] - 2022-12-14
+
+### Changed
+- Relax Dry::Types dependency to "~> 1.0"
+
+## [0.4.5] - 2022-09-28
+### Added
+- Add `Physical::Pallet` class [#12]
+- Convenience methods for weight, volume, and fill [#15]
+- Add inner dimensions for `Pallet` class [#16]
+
+### Changed
+- Fix Ruby 2.7 deprecation warnings [#3]
+- Set rounding mode for Money gem [#6]
+- Bump Rake version [#10]
+- Ruby 3 support [#18]
+
 ## [0.4.4] - 2019-10-29
 ### Added
 - Add `#sku`, `#cost` and `#description` to `Physical::Item`

data/Gemfile

@@ -1,10 +1,8 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in physical.gemspec
 gemspec
-
-group :test do
-  gem 'rspec_junit_formatter'
-end

data/Rakefile

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/bin/console

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require "bundler/setup"
 require "physical"

data/lib/physical/box.rb

@@ -13,8 +13,10 @@ module Physical
                 :inner_height,
                 :max_weight
 
-    def initialize(inner_dimensions: [], max_weight: Measured::Weight(DEFAULT_MAX_WEIGHT, :g), **args)
-      super args
+    def initialize(**args)
+      inner_dimensions = args.delete(:inner_dimensions) || []
+      max_weight = args.delete(:max_weight) || Measured::Weight(DEFAULT_MAX_WEIGHT, :g)
+      super(**args)
       @inner_dimensions = fill_dimensions(Types::Dimensions[inner_dimensions])
       @inner_length, @inner_width, @inner_height = *@inner_dimensions
       @max_weight = Types::Weight[max_weight]
@@ -26,5 +28,17 @@ module Physical
         :ml
       )
     end
+
+    # @param [Physical::Item] item
+    # @return [Boolean]
+    def item_fits?(item)
+      return false if item.weight > max_weight
+
+      box_dimensions = inner_dimensions.sort
+      item.dimensions.sort.each.with_index do |axis, index|
+        return false if axis >= box_dimensions[index]
+      end
+      true
+    end
   end
 end

data/lib/physical/cuboid.rb

@@ -22,6 +22,7 @@ module Physical
     def density
       return Measured::Density(Float::INFINITY, :g_ml) if volume.value.zero?
       return Measured::Density(0.0, :g_ml) if volume.value.infinite?
+
       Measured::Density(weight.convert_to(:g).value / volume.convert_to(:ml).value, :g_ml)
     end
 
@@ -32,7 +33,7 @@ module Physical
 
     private
 
-    NORMALIZED_METHOD_REGEX = /(\w+)\??$/
+    NORMALIZED_METHOD_REGEX = /(\w+)\??$/.freeze
 
     def method_missing(method)
       symbolized_properties = properties.symbolize_keys

data/lib/physical/item.rb

@@ -8,11 +8,11 @@ module Physical
                 :sku,
                 :description
 
-    def initialize(cost: nil, sku: nil, description: nil, **kwargs)
-      @cost = Types::Money.optional[cost]
-      @sku = sku
-      @description = description
-      super kwargs
+    def initialize(**kwargs)
+      @cost = Types::Money.optional[kwargs.delete(:cost)]
+      @sku = kwargs.delete(:sku)
+      @description = kwargs.delete(:description)
+      super(**kwargs)
     end
   end
 end

data/lib/physical/location.rb

@@ -4,7 +4,7 @@ require 'carmen'
 
 module Physical
   class Location
-    ADDRESS_TYPES = %w(residential commercial po_box)
+    ADDRESS_TYPES = %w(residential commercial po_box).freeze
 
     attr_reader :country,
                 :zip,
@@ -23,28 +23,28 @@ module Physical
                 :longitude
 
     def initialize(
-        name: nil,
-        company_name: nil,
-        address1: nil,
-        address2: nil,
-        address3: nil,
-        city: nil,
-        region: nil,
-        zip: nil,
-        country: nil,
-        phone: nil,
-        fax: nil,
-        email: nil,
-        address_type: nil,
-        latitude: nil,
-        longitude: nil
-      )
+      name: nil,
+      company_name: nil,
+      address1: nil,
+      address2: nil,
+      address3: nil,
+      city: nil,
+      region: nil,
+      zip: nil,
+      country: nil,
+      phone: nil,
+      fax: nil,
+      email: nil,
+      address_type: nil,
+      latitude: nil,
+      longitude: nil
+    )
 
-      if country.is_a?(Carmen::Country)
-        @country = country
-      else
-        @country = Carmen::Country.coded(country.to_s)
-      end
+      @country = if country.is_a?(Carmen::Country)
+                   country
+                 else
+                   Carmen::Country.coded(country.to_s)
+                 end
 
       if region.is_a?(Carmen::Region)
         @region = region

data/lib/physical/package.rb

@@ -14,22 +14,23 @@ module Physical
 
     delegate [:dimensions, :width, :length, :height, :properties, :volume] => :container
 
-    def <<(item)
-      @items.add(item)
+    def <<(other)
+      @items.add(other)
     end
     alias_method :add, :<<
 
-    def >>(item)
-      @items.delete(item)
+    def >>(other)
+      @items.delete(other)
     end
     alias_method :delete, :>>
 
     def weight
-      container.weight + items.map(&:weight).reduce(Measured::Weight(0, :g), &:+) + void_fill_weight
+      container.weight + items_weight + void_fill_weight
     end
 
-    def remaining_volume
-      container.inner_volume - items.map(&:volume).reduce(Measured::Volume(0, :ml), &:+)
+    # @return [Measured::Weight]
+    def items_weight
+      items.map(&:weight).reduce(Measured::Weight(0, :g), &:+)
     end
 
     def void_fill_weight
@@ -38,9 +39,19 @@ module Physical
       Measured::Weight(void_fill_density.convert_to(:g_ml).value * remaining_volume.convert_to(:ml).value, :g)
     end
 
+    # @return [Measured::Volume]
+    def used_volume
+      items.map(&:volume).reduce(Measured::Volume(0, :ml), &:+)
+    end
+
+    def remaining_volume
+      container.inner_volume - used_volume
+    end
+
     def density
       return Measured::Density(Float::INFINITY, :g_ml) if container.volume.value.zero?
       return Measured::Density(0.0, :g_ml) if container.volume.value.infinite?
+
       Measured::Density(weight.convert_to(:g).value / container.volume.convert_to(:ml).value, :g_ml)
     end
   end

data/lib/physical/pallet.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+require 'measured'
+
+module Physical
+  class Pallet < Cuboid
+    DEFAULT_LENGTH = BigDecimal::INFINITY
+    DEFAULT_MAX_WEIGHT = BigDecimal::INFINITY
+
+    attr_reader :max_weight
+
+    def initialize(**args)
+      max_weight = args.delete(:max_weight) || Measured::Weight(DEFAULT_MAX_WEIGHT, :g)
+      super(**args)
+      @max_weight = Types::Weight[max_weight]
+    end
+
+    alias_method :inner_volume, :volume
+    alias_method :inner_dimensions, :dimensions
+    alias_method :inner_length, :length
+    alias_method :inner_width, :width
+    alias_method :inner_height, :height
+
+    # @param [Physical::Package] package
+    # @return [Boolean]
+    def package_fits?(package)
+      return false if package.weight > max_weight
+
+      pallet_dimensions = dimensions.sort
+      package.dimensions.sort.each.with_index do |axis, index|
+        return false if axis >= pallet_dimensions.sort[index]
+      end
+      true
+    end
+  end
+end

data/lib/physical/spec_support/factories/box_factory.rb

@@ -1,12 +1,10 @@
 # frozen_string_literal: true
 
-require 'factory_bot'
-
 FactoryBot.define do
   factory :physical_box, class: "Physical::Box" do
     dimensions { [20, 15, 30].map { |d| Measured::Length(d, :cm) } }
     inner_dimensions { dimensions.map { |d| d - Measured::Length(1, :cm) } }
     weight { Measured::Weight(0.1, :kg) }
-    initialize_with { new(attributes) }
+    initialize_with { new(**attributes) }
   end
 end

data/lib/physical/spec_support/factories/item_factory.rb

@@ -1,11 +1,9 @@
 # frozen_string_literal: true
 
-require 'factory_bot'
-
 FactoryBot.define do
   factory :physical_item, class: "Physical::Item" do
-    dimensions { [1, 2, 3].map { |d| Measured::Length(d, :cm)} }
+    dimensions { [1, 2, 3].map { |d| Measured::Length(d, :cm) } }
     weight { Measured::Weight(50, :g) }
-    initialize_with { new(attributes) }
+    initialize_with { new(**attributes) }
   end
 end

data/lib/physical/spec_support/factories/location_factory.rb

@@ -12,10 +12,10 @@ FactoryBot.define do
     address1 { '11 Lovely Street' }
     address2 { 'South' }
     city { 'Herndon' }
-    sequence(:zip, 10001) { |i| i.to_s }
+    sequence(:zip, 10_001, &:to_s)
     phone { '555-555-0199' }
     region { country.subregions.coded(region_code) }
     country { Carmen::Country.coded(country_code) }
-    initialize_with { new(attributes) }
+    initialize_with { new(**attributes) }
   end
 end

data/lib/physical/spec_support/factories/package_factory.rb

@@ -1,14 +1,10 @@
 # frozen_string_literal: true
 
-require 'factory_bot'
-require_relative 'box_factory'
-require_relative 'item_factory'
-
 FactoryBot.define do
   factory :physical_package, class: "Physical::Package" do
     container { FactoryBot.build(:physical_box) }
     items { build_list(:physical_item, 2) }
     void_fill_density { Measured::Density(0.01, :g_ml) }
-    initialize_with { new(attributes) }
+    initialize_with { new(**attributes) }
   end
 end

data/lib/physical/spec_support/factories/pallet_factory.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+FactoryBot.define do
+  factory :physical_pallet, class: "Physical::Pallet" do
+    dimensions { [80, 120, 165].map { |d| Measured::Length(d, :cm) } }
+    weight { Measured::Weight(22, :kg) }
+    initialize_with { new(**attributes) }
+  end
+end

data/lib/physical/spec_support/factories/shipment_factory.rb

@@ -1,15 +1,11 @@
 # frozen_string_literal: true
 
-require 'factory_bot'
-require_relative 'location_factory'
-require_relative 'package_factory'
-
 FactoryBot.define do
   factory :physical_shipment, class: "Physical::Shipment" do
     origin { FactoryBot.build(:physical_location) }
     destination { FactoryBot.build(:physical_location) }
     packages { build_list(:physical_package, 2) }
     service_code { "usps_priority_mail" }
-    initialize_with { new(attributes) }
+    initialize_with { new(**attributes) }
   end
 end

data/lib/physical/spec_support/shared_examples.rb

@@ -28,17 +28,17 @@ RSpec.shared_examples 'a cuboid' do
     expect(subject.width).to eq(Measured::Length.new(3.3, :cm))
     expect(subject.height).to eq(Measured::Length.new(2.2, :cm))
   end
-  
+
   describe "#==" do
     let(:args) { Hash[id: 123] }
-    let(:other_cuboid) { described_class.new(args) }
+    let(:other_cuboid) { described_class.new(**args) }
     let(:non_cuboid) { double(id: 123) }
-    
+
     it "compares cuboids" do
       aggregate_failures do
         expect(subject == other_cuboid).to be(true)
         expect(subject == non_cuboid).to be(false)
-        expect(subject == nil).to be(false)
+        expect(subject.nil?).to be(false)
       end
     end
   end

data/lib/physical/test_support.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+# Add to spec_helper.rb to require Physical factories:
+#
+#   require "physical/test_support"
+#   FactoryBot.definition_file_paths.concat(Physical::TestSupport.factory_paths)
+#   FactoryBot.reload
+
+module Physical
+  module TestSupport
+    def self.factory_paths
+      spec = Gem::Specification.find_by_name("physical")
+      root = Pathname.new(spec.gem_dir)
+      Dir[
+        root.join("lib", "physical", "spec_support", "factories", "*_factory.rb")
+      ].map { |path| path.sub(/.rb\z/, "") }
+    end
+  end
+end

data/lib/physical/types.rb

@@ -1,5 +1,6 @@
+# frozen_string_literal: true
+
 require 'measured'
-require 'money'
 require 'dry-types'
 
 module Physical

data/lib/physical/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Physical
-  VERSION = "0.4.4"
+  VERSION = "0.4.7"
 end

data/lib/physical.rb

@@ -1,11 +1,13 @@
 # frozen_string_literal: true
 
+require "money"
 require "measured/density"
 require "physical/types"
 require "physical/version"
 require "physical/cuboid"
 require "physical/box"
 require "physical/package"
+require "physical/pallet"
 require "physical/item"
 require "physical/location"
 require "physical/shipment"

data/physical.gemspec

@@ -21,12 +21,15 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
   spec.required_ruby_version = '>= 2.4'
   spec.add_runtime_dependency "carmen", "~> 1.0"
+  spec.add_runtime_dependency "dry-types", "~> 1.5"
   spec.add_runtime_dependency "measured", "~> 2.4"
-  spec.add_runtime_dependency "dry-types", "~> 1.0.0"
   spec.add_runtime_dependency "money", ">= 5"
 
   spec.add_development_dependency "bundler", [">= 1.16", "< 3"]
-  spec.add_development_dependency "factory_bot", "~> 4.8"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "factory_bot", "~> 6.2"
+  spec.add_development_dependency "rake", ">= 12.3.3"
   spec.add_development_dependency "rspec", "~> 3.0"
+  spec.add_development_dependency "rspec_junit_formatter", "~> 0.4"
+  spec.add_development_dependency "rubocop"
+  spec.add_development_dependency "simplecov"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: physical
 version: !ruby/object:Gem::Version
-  version: 0.4.4
+  version: 0.4.7
 platform: ruby
 authors:
 - Martin Meyerhoff
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-10-29 00:00:00.000000000 Z
+date: 2022-12-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: carmen
@@ -25,33 +25,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: measured
+  name: dry-types
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.4'
+        version: '1.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.4'
+        version: '1.5'
 - !ruby/object:Gem::Dependency
-  name: dry-types
+  name: measured
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '2.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '2.4'
 - !ruby/object:Gem::Dependency
   name: money
   requirement: !ruby/object:Gem::Requirement
@@ -92,28 +92,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.8'
+        version: '6.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.8'
+        version: '6.2'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -128,6 +128,48 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rspec_junit_formatter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.4'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.4'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: A package with boxes and items
 email:
 - mamhoff@gmail.com
@@ -138,6 +180,7 @@ files:
 - ".circleci/config.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop-relaxed.yml"
 - ".rubocop.yml"
 - ".travis.yml"
 - CHANGELOG.md
@@ -155,14 +198,16 @@ files:
 - lib/physical/item.rb
 - lib/physical/location.rb
 - lib/physical/package.rb
+- lib/physical/pallet.rb
 - lib/physical/shipment.rb
-- lib/physical/spec_support/factories.rb
 - lib/physical/spec_support/factories/box_factory.rb
 - lib/physical/spec_support/factories/item_factory.rb
 - lib/physical/spec_support/factories/location_factory.rb
 - lib/physical/spec_support/factories/package_factory.rb
+- lib/physical/spec_support/factories/pallet_factory.rb
 - lib/physical/spec_support/factories/shipment_factory.rb
 - lib/physical/spec_support/shared_examples.rb
+- lib/physical/test_support.rb
 - lib/physical/types.rb
 - lib/physical/version.rb
 - physical.gemspec
@@ -170,7 +215,7 @@ homepage: https://github.com/friendlycart/physical
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -185,9 +230,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6.2
-signing_key: 
+rubygems_version: 3.2.33
+signing_key:
 specification_version: 4
 summary: A facade to deal with physical packages
 test_files: []

data/lib/physical/spec_support/factories.rb

@@ -1,7 +0,0 @@
-# frozen_string_literal: true
-
-require 'physical/spec_support/factories/item_factory'
-require 'physical/spec_support/factories/box_factory'
-require 'physical/spec_support/factories/package_factory'
-require 'physical/spec_support/factories/location_factory'
-require 'physical/spec_support/factories/shipment_factory'