physical 0.4.3 → 0.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: b5071305935c7247bcd7f1cdc6f67693d5c8cb37
-  data.tar.gz: 6040fbc65b93b5d0aced798b9c4f4007952e954f
+SHA256:
+  metadata.gz: df340805fcfc8168b20b7ad8b1c6100be37fb1163b52d8d87b2f4fc7aa9f6440
+  data.tar.gz: 610081278560cfda0563c368baed947ddc3d932ea6786f21b21e5e21c324de98
 SHA512:
-  metadata.gz: 346db67ecfe973dfcf2553331d0d67836e62cff6de2ea688227e37f01703cb1871a4d49b7670d71d0023d5a17cb92e4005bef7e9ebc9a2317c0320a8fbc5b89f
-  data.tar.gz: 937e4dbd4098d311d36622db26514e40b15e4f6c9690facb0fda1bc37056e68dc73f14b1c4b1ec03f406bd1e927b0c4172c06311fb0a02992e0dfe28c7b215c1
+  metadata.gz: 44f4503f2905735ac04eaf80e004491f7fb4644ea97e58a5718fdda12b0e775217f8a80709759b5ec7487b3cfcd336ae59fd12e35d2c3904e71d062ec4b105bf
+  data.tar.gz: 21eb1efd17a46c0b993683a176646575f4340d5dc2d8015c7d65778601059a9cf3b969e0c004a6c841ec48bd0a3af2a449b359c3d619ac2a0953420883679263

data/.gitignore

@@ -9,4 +9,5 @@
 
 # rspec failure tracking
 .rspec_status
+.ruby-version
 Gemfile.lock

data/CHANGELOG.md

@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+## [0.4.4] - 2019-10-29
+### Added
+- Add `#sku`, `#cost` and `#description` to `Physical::Item`
+
 ## [0.4.3] - 2019-10-14
 ### Added
 - Add `#latitude` and `#longitude` to `Physical::Location`

data/lib/physical/cuboid.rb

@@ -26,7 +26,8 @@ module Physical
     end
 
     def ==(other)
-      id == other.id
+      other.is_a?(self.class) &&
+        id == other&.id
     end
 
     private

data/lib/physical/item.rb

@@ -3,5 +3,16 @@
 module Physical
   class Item < Cuboid
     DEFAULT_LENGTH = 0
+
+    attr_reader :cost,
+                :sku,
+                :description
+
+    def initialize(cost: nil, sku: nil, description: nil, **kwargs)
+      @cost = Types::Money.optional[cost]
+      @sku = sku
+      @description = description
+      super kwargs
+    end
   end
 end

data/lib/physical/location.rb

@@ -81,9 +81,9 @@ module Physical
 
     def to_hash
       {
-        country: country.code,
+        country: country&.code,
         postal_code: zip,
-        region: region.code,
+        region: region&.code,
         city: city,
         name: name,
         address1: address1,
@@ -98,7 +98,8 @@ module Physical
     end
 
     def ==(other)
-      to_hash == other.to_hash
+      other.is_a?(self.class) &&
+        to_hash == other&.to_hash
     end
   end
 end

data/lib/physical/spec_support/shared_examples.rb

@@ -28,4 +28,18 @@ RSpec.shared_examples 'a cuboid' do
     expect(subject.width).to eq(Measured::Length.new(3.3, :cm))
     expect(subject.height).to eq(Measured::Length.new(2.2, :cm))
   end
+  
+  describe "#==" do
+    let(:args) { Hash[id: 123] }
+    let(:other_cuboid) { described_class.new(args) }
+    let(:non_cuboid) { double(id: 123) }
+    
+    it "compares cuboids" do
+      aggregate_failures do
+        expect(subject == other_cuboid).to be(true)
+        expect(subject == non_cuboid).to be(false)
+        expect(subject == nil).to be(false)
+      end
+    end
+  end
 end

data/lib/physical/types.rb

@@ -1,4 +1,5 @@
 require 'measured'
+require 'money'
 require 'dry-types'
 
 module Physical
@@ -9,6 +10,7 @@ module Physical
     Length = Types.Instance(::Measured::Length)
     Volume = Types.Instance(::Measured::Volume)
     Density = Types.Instance(::Measured::Density)
+    Money = Types.Instance(::Money)
 
     Dimensions = Types::Strict::Array.of(Length)
   end

data/lib/physical/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Physical
-  VERSION = "0.4.3"
+  VERSION = "0.4.4"
 end

data/physical.gemspec

@@ -23,6 +23,7 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency "carmen", "~> 1.0"
   spec.add_runtime_dependency "measured", "~> 2.4"
   spec.add_runtime_dependency "dry-types", "~> 1.0.0"
+  spec.add_runtime_dependency "money", ">= 5"
 
   spec.add_development_dependency "bundler", [">= 1.16", "< 3"]
   spec.add_development_dependency "factory_bot", "~> 4.8"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: physical
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.4.4
 platform: ruby
 authors:
 - Martin Meyerhoff
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-10-14 00:00:00.000000000 Z
+date: 2019-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: carmen
@@ -52,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 1.0.0
+- !ruby/object:Gem::Dependency
+  name: money
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -125,7 +139,6 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
-- ".ruby-version"
 - ".travis.yml"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
@@ -173,7 +186,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14.1
+rubygems_version: 2.7.6.2
 signing_key: 
 specification_version: 4
 summary: A facade to deal with physical packages

data/.ruby-version

@@ -1 +0,0 @@
-2.4.4