physical 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fdda01f27d8c75a1b222e13ca9f84e54e1f2a4c0
-  data.tar.gz: ee3cdd019c063a04141e29a6a1e83f2d25d3b483
+  metadata.gz: 686fa9f5c3c2f0730b7b48eb0ad8260efc421068
+  data.tar.gz: c1cb821fdf67cfed55be6fff0868d84fc9edc563
 SHA512:
-  metadata.gz: 48f2da61f204e7ebb71339f5be3c0379928121ce1a94af7e2cc84179e49331789d8316a85fe66c3d1f45557a1089595df1a4ee990634abd4dc30e7f27303edc4
-  data.tar.gz: a3170e37c25c1d677bb2028d31bdc8905c4418b3fdb9ff49cf81c9deb7a73faa4e87463ce4b4cdc3a3fb45a42fe98a4dcd6a27bdc1e3245fe74e1f5ed820bbfd
+  metadata.gz: 9ddf78ab2078a8a05229ac80fd6d8aded0d8be0ad81a5300662c93f013351331ff4a2aaaffc1f659fc3a79162b66c11762b150e881890dec5ea9ca94e2d0f228
+  data.tar.gz: 608a2c01f153f33dffa3373ad81f15724b34e4c33f79f968d0e804a3d0499b272fbba379a5511e95d35b855773f0f71e9db782e50145063bf06bda3f8d4794e0

data/README.md

@@ -52,9 +52,7 @@ You will be able to retrieve the package's weight and dimensions using the `#wei
 
 ### Convenience methods
 
-The length, width and height of a package are defined as the package's longest, middle, and shortest side, respectively. For the package from the previous example, `package.length` will be 5 inches, `package.width` will be 4 inches, and `package.height` will be 3 inches. Packages do not have a notion of "right side up" yet.
-
-The package's `length` is also accessible as `package.x`. The package's `width` is also accessible as `package.y`. The package's `height` is also accessible as `package.z` as well as `package.depth`.
+The length, width and height of a package are defined as the dimension array's first, second, and third argument, respectively. For the package from the previous example, `package.length` will be 3 inches, `package.width` will be 4 inches, and `package.height` will be 5 inches.
 
 ### Packages with Items
 

data/lib/physical/box.rb

@@ -13,14 +13,9 @@ module Physical
     def initialize(inner_dimensions: [], **args)
       super args
       @inner_dimensions = fill_dimensions(Types::Dimensions[inner_dimensions])
-      @inner_length, @inner_width, @inner_height = *@inner_dimensions.reverse
+      @inner_length, @inner_width, @inner_height = *@inner_dimensions
     end
 
-    alias :inner_x :inner_length
-    alias :inner_y :inner_width
-    alias :inner_z :inner_height
-    alias :inner_depth :inner_height
-
     def inner_volume
       Measured::Volume(
         inner_dimensions.map { |d| d.convert_to(:cm).value }.reduce(1, &:*),

data/lib/physical/cuboid.rb

@@ -11,15 +11,10 @@ module Physical
       @weight = Types::Weight[weight]
       @dimensions = []
       @dimensions = fill_dimensions(Types::Dimensions[dimensions])
-      @length, @width, @height = *@dimensions.reverse
+      @length, @width, @height = *@dimensions
       @properties = properties
     end
 
-    alias :x :length
-    alias :y :width
-    alias :z :height
-    alias :depth :height
-
     def volume
       Measured::Volume(dimensions.map { |d| d.convert_to(:cm).value }.reduce(1, &:*), :ml)
     end
@@ -33,7 +28,7 @@ module Physical
     def fill_dimensions(dimensions)
       dimensions.fill(dimensions.length..2) do |index|
         @dimensions[index] || Measured::Length(self.class::DEFAULT_LENGTH, :cm)
-      end.sort
+      end
     end
   end
 end

data/lib/physical/package.rb

@@ -12,7 +12,7 @@ module Physical
       @items = Set[*items]
     end
 
-    delegate [:dimensions, :width, :length, :height, :depth, :x, :y, :z, :properties] => :container
+    delegate [:dimensions, :width, :length, :height, :properties] => :container
 
     def <<(item)
       @items.add(item)

data/lib/physical/spec_support/shared_examples.rb

@@ -5,9 +5,9 @@ RSpec.shared_examples 'a cuboid' do
     {
       dimensions: [
         Measured::Length.new(1.1, :cm),
-        Measured::Length.new(2.2, :cm),
-        Measured::Length.new(3.3, :cm)
-      ].shuffle
+        Measured::Length.new(3.3, :cm),
+        Measured::Length.new(2.2, :cm)
+      ]
     }
   end
 
@@ -17,19 +17,15 @@ RSpec.shared_examples 'a cuboid' do
     expect(subject.dimensions).to eq(
       [
         Measured::Length.new(1.1, :cm),
-        Measured::Length.new(2.2, :cm),
-        Measured::Length.new(3.3, :cm)
+        Measured::Length.new(3.3, :cm),
+        Measured::Length.new(2.2, :cm)
       ]
     )
   end
 
   it "has getter methods for each dimension as Measured::Length object" do
-    expect(subject.length).to eq(Measured::Length.new(3.3, :cm))
-    expect(subject.x).to eq(Measured::Length.new(3.3, :cm))
-    expect(subject.width).to eq(Measured::Length.new(2.2, :cm))
-    expect(subject.y).to eq(Measured::Length.new(2.2, :cm))
-    expect(subject.height).to eq(Measured::Length.new(1.1, :cm))
-    expect(subject.z).to eq(Measured::Length.new(1.1, :cm))
-    expect(subject.depth).to eq(Measured::Length.new(1.1, :cm))
+    expect(subject.length).to eq(Measured::Length.new(1.1, :cm))
+    expect(subject.width).to eq(Measured::Length.new(3.3, :cm))
+    expect(subject.height).to eq(Measured::Length.new(2.2, :cm))
   end
 end

data/lib/physical/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Physical
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: physical
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Martin Meyerhoff