phraseapp-ruby 1.2.3 → 1.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0e926755df0329c0d07c05742d15d836fd6d128d
-  data.tar.gz: ccc1a225517a8fcf61d3be85ab36673b68f2ffe2
+  metadata.gz: 11e4707b7b9c2da831994392d1fdd9812de354e9
+  data.tar.gz: 22ff9f24809cc29e66dd4f5292e8c01da1517d93
 SHA512:
-  metadata.gz: f0c0f3c17fbd1645d212e7e017fd890ba39954d2e9d511c0f1076800466d648f9561602b5faffa66bb8707a17efd8aa8f4a607dad20b7f62d6477f3b31a00aa1
-  data.tar.gz: 5f66c9c8410dc8a40bca5c2eab2626143efa223b4ddd154a79212d6c9a38d90e4cf266ff9fc3367c644435971c625100bd4f8c55ebd3bb67254c5d3b8397e229
+  metadata.gz: b2d4640c59a99f737a8c5f831fa08d2011f98a0b9e0ecbac9897fc06651a561bccc68d8459b5471bf637a85143f3bdd9041ab0a118dd668e5e2bebec41b7f051
+  data.tar.gz: 21ea75c0ff64a75643ae777546e1597918aeb00cf712b480318c159c699658bc4a07dd2930521a66f3fde9d3384cac44c00ca9e09d59517eddaa8ed4c6d0ed83

data/lib/phraseapp-ruby/request_handler.rb

@@ -6,9 +6,11 @@ module PhraseApp
 
   module RequestErrors
     class ErrorResponse
-      attr_accessor :message
+      attr_reader :message
 
       def initialize(http_response)
+        hash = JSON.load(http_response.body)
+        self.message = hash['message']
       end
 
       def error
@@ -17,21 +19,24 @@ module PhraseApp
     end
 
     class ValidationErrorResponse
-    	attr_accessor :error_response
-      attr_accessor :errors
+      attr_reader :message
+      attr_reader :errors
 
       def initialize(http_response)
         hash = JSON.load(http_response.body)
-        puts hash.inspect
-      end
-
-      def errors
-        self.error + "\n" + self.errors.join("\n")
+        self.message = hash['message']
+        self.errors = hash['errors'].map { |error| ValidationErrorMessage.new(error) }
       end
     end
 
     class ValidationErrorMessage
-    	attr_accessor :resource, :field, :message
+      attr_reader :resource, :field, :message
+
+      def initialize(error)
+        self.resource = error["resource"]
+        self.field = error["field"]
+        self.message = error["message"]
+      end
 
       def to_s
   	    return sprintf("\t[%s:%s] %s", self.resource, self.field, self.message)
@@ -39,13 +44,12 @@ module PhraseApp
     end
 
     class RateLimitingError
-      attr_accessor :limit, :remaining, :reset
+      attr_reader :limit, :remaining, :reset
 
       def initialize(resp)
         self.limit = resp["X-Rate-Limit-Limit"].to_i
   	    self.remaining = resp["X-Rate-Limit-Remaining"].to_i
         self.reset = Time.at(resp["X-Rate-Limit-Reset"].to_i)
-      	return re, nil
       end
 
       def to_s
@@ -157,22 +161,13 @@ module PhraseApp
       when expectedStatus
 	    	return
       when 400
-    		e = PhraseApp::RequestErrors::ErrorResponse.new(resp)
-		    return e
+        return PhraseApp::RequestErrors::ErrorResponse.new(resp)
       when 404
     		return raise("not found")
       when 422
-    		e = PhraseApp::RequestErrors::ValidationErrorResponse.new(resp)
-		    if e != nil
-    			return e
-		    end
-    		return e
+        return PhraseApp::RequestErrors::ValidationErrorResponse.new(resp)
       when 429
-		    e, err = PhraseApp::RequestErrors::RateLimitingError.new(resp)
-        if err != nil
-    			return err
-        end
-    		return e
+        return PhraseApp::RequestErrors::RateLimitingError.new(resp)
       else
 		    return raise("unexpected status code (#{resp.code}) received; expected #{expectedStatus}")
     end

data/lib/phraseapp-ruby/version.rb

@@ -1,3 +1,3 @@
 module PhraseApp
-  VERSION = '1.2.3'
+  VERSION = '1.2.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: phraseapp-ruby
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 1.2.4
 platform: ruby
 authors:
 - PhraseApp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-17 00:00:00.000000000 Z
+date: 2015-12-22 00:00:00.000000000 Z
 dependencies: []
 description: PhraseApp API client libary
 email:
@@ -41,7 +41,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Interact with the PhraseApp API