phpcop 0.3.1 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7ef9b83034da7e194fb6d2ed9f9d98ebd1c4b2ba
-  data.tar.gz: 2707957b3b3b80b58e03babe2acf2eec19808805
+  metadata.gz: 2e3d4d38c484bea2b33984349716824b4d6539d4
+  data.tar.gz: ded7b85d0f430d9834361f8e959c89165ada3f72
 SHA512:
-  metadata.gz: 84d475a58cecdcf05d00ea15c36241af52ca3a4704ec8dc3e52947ce15a7e07d86af26b5d43865456bd0f86340609ebd7d842f3005aeb59d294c8c23ee22d06d
-  data.tar.gz: 0833da19a707ac122d95aedd14fcfd86642db1a5a66a5a3e23569e64c7593619d5b21aa6bb9c1849877e2b111dc226e49a1eff77772cf8d1eca5b369e3bbc860
+  metadata.gz: ce4756471d9fd32b1e5d002dd6f211700131bf047c6e88b8e248466a2ec38eeaf91401940c2a7441a776f670c86023c7d9b7edefe197bb75b5ca0b7fb49e9d1a
+  data.tar.gz: 562fad8df27cf6d9236f7443586c15c46fb26ebe8e4518a612e63798f76a616622dd2158de0d91aea519aa0f726e53eb69ae52845749a7ac5e943cbb09bc35f2

data/config/default.yml

@@ -25,5 +25,11 @@ AllCops:
   ccpm/methods:
     enabled: true
     description: >
-      http://www.php-fig.org/psr/psr-1/#4-3-methods
+      Method names MUST be declared in camelCase().
     see: 'http://www.php-fig.org/psr/psr-1/#4-3-methods'
+  ccpm/constants:
+    enabled: true
+    description: >
+      Class constants MUST be declared in all upper case with underscore
+      separators.
+    see: 'http://www.php-fig.org/psr/psr-1/#4-1-constants'

data/lib/phpcop/cop/ccpm/constants.rb

@@ -0,0 +1,43 @@
+# encoding: utf-8
+# frozen_string_literal: true
+
+module PhpCop
+  module Cop
+    # Acronym to Class Constants, Properties and Methods
+    module CCPM
+      # Test constant in php class
+      class Constants < Cop
+        MSG_ALERT_DESCRIB = 'Class constants MUST be declared in all upper '\
+         'case with underscore separators.'
+
+        def initialize(file, line, line_number)
+          super(file, line.to_s, line_number)
+          test_line
+        end
+
+        private
+
+        def test_line
+          test_constant_valid if @line.include?(' const ')
+        end
+
+        def test_constant_valid
+          name = @line.slice!(/const.*=/)
+          unless name.nil?
+            name = name.gsub('const ', '').gsub(' =', '')
+            n_constant = name.upcase
+            return_an_error(@file, @line_number, 0) unless n_constant.eql? name
+          end
+        end
+
+        def return_an_error(file, line, column)
+          @errors += 1
+          line += 1
+          puts format(MSG_ALERT_FILE, file, line, column)
+          puts MSG_ALERT_DESCRIB
+          puts ''
+        end
+      end
+    end
+  end
+end

data/lib/phpcop/runner.rb

@@ -69,6 +69,8 @@ module PhpCop
         test_file_php_encoding(file, line, line_number)
       when 'methods'
         test_ccpm_methods(file, line, line_number)
+      when 'constants'
+        test_ccpm_constants(file, line, line_number)
       end
     end
 
@@ -85,5 +87,10 @@ module PhpCop
       test = PhpCop::Cop::CCPM::Methods.new(file, line, line_number)
       @count_errors += test.errors
     end
+
+    def test_ccpm_constants(file, line, line_number)
+      test = PhpCop::Cop::CCPM::Constants.new(file, line, line_number)
+      @count_errors += test.errors
+    end
   end
 end

data/lib/phpcop/version.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 
 module Phpcop
-  VERSION = '0.3.1'
+  VERSION = '0.4.3'
 end

data/lib/phpcop.rb

@@ -13,3 +13,4 @@ require 'phpcop/cop/cop.rb'
 require 'phpcop/cop/files/phptags.rb'
 require 'phpcop/cop/files/phpencoding.rb'
 require 'phpcop/cop/ccpm/methods.rb'
+require 'phpcop/cop/ccpm/constants.rb'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: phpcop
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.4.3
 platform: ruby
 authors:
 - Jeremy VAILLANT
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-21 00:00:00.000000000 Z
+date: 2016-04-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -102,6 +102,7 @@ files:
 - lib/phpcop/cli.rb
 - lib/phpcop/configloader.rb
 - lib/phpcop/configstore.rb
+- lib/phpcop/cop/ccpm/constants.rb
 - lib/phpcop/cop/ccpm/methods.rb
 - lib/phpcop/cop/cop.rb
 - lib/phpcop/cop/files/phpencoding.rb