photile 0.1.9 → 0.1.10

data/lib/photile.rb

@@ -1,5 +1,5 @@
 class Photile
-  VERSION = "0.1.9"
+  VERSION = "0.1.10"
   REQUIREMENTS = "photile requires the following libraries to be installed: imagemagick, imagemagick-common and libjpeg-turbo-progs"
 end
 

data/lib/photile/cli.rb

@@ -23,6 +23,7 @@ class Photile::Cli
 
       opts.on('-t', '--tile WIDTHxHEIGHT', Regexp.new(/\d+x\d+/), 'Tile to the given dimensions') do |dimensions|
         dim = dimensions.split('x')
+        validate_2d_dimensions dim
         options << {:tile => {:width => dim.first.to_i, :height => dim.last.to_i}}
       end
 
@@ -68,6 +69,10 @@ class Photile::Cli
     raise "Invalid percentage: #{metric} #{value}%. Acceptable range: 0-100" if value < 0 || value > 100
   end
 
+  def self.validate_2d_dimensions(dims)
+    raise "Invalid dimensions: #{dims.first}x#{dims.last}. Acceptable dimensions are > 0" if dims.first <= 0 || dims.last <= 0
+  end
+
   def self.validate_file_exist(file)
     raise "File [#{file}] not found" if !FileTest.exists? file
   end

data/photile.gemspec

@@ -15,6 +15,7 @@ Gem::Specification.new do |s|
   s.license                     = 'MIT'
   s.homepage                    = 'https://github.com/nitindhar7/photile'
   s.add_development_dependency  'rake', ['>= 0.8.7']
+  s.add_development_dependency  'uuid', ['>= 2.3.6']
   s.required_ruby_version       = '>= 1.8.7'
   s.requirements                << 'imagemagick' << 'imagemagick-common' << 'libjpeg-turbo-progs'
 end

data/test/test_cli.rb

@@ -0,0 +1,66 @@
+require 'test/unit'
+require 'photile'
+require 'uuid'
+
+class CliTest < Test::Unit::TestCase
+
+  def test_validate_percent_value
+    # percentage too high
+    exception = assert_raise RuntimeError do
+      Photile::Cli.validate_percent_value('metricX', 800)
+    end
+    assert_equal 'Invalid percentage: metricX 800%. Acceptable range: 0-100', exception.message
+
+    # percentage too low
+    exception = assert_raise RuntimeError do
+      Photile::Cli.validate_percent_value('metricX', -100)
+    end
+    assert_equal 'Invalid percentage: metricX -100%. Acceptable range: 0-100', exception.message
+
+    # percentage within acceptable range
+    Photile::Cli.validate_percent_value('metricX', 50)
+  end
+
+  def test_validate_2d_dimensions
+    # valid dimensions
+    Photile::Cli.validate_2d_dimensions([1,1])
+    Photile::Cli.validate_2d_dimensions([100,100])
+    assert true
+
+    # dimensions are negative
+    exception = assert_raise RuntimeError do
+      Photile::Cli.validate_2d_dimensions([-1,-1])
+    end
+    assert_equal 'Invalid dimensions: -1x-1. Acceptable dimensions are > 0', exception.message
+
+    # dimensions are 0
+    exception = assert_raise RuntimeError do
+      Photile::Cli.validate_2d_dimensions([0,0])
+    end
+    assert_equal 'Invalid dimensions: 0x0. Acceptable dimensions are > 0', exception.message
+  end
+
+  def test_validate_file_exist
+    # non existent files
+    exception = assert_raise RuntimeError do
+      Photile::Cli.validate_file_exist("photile-#{UUID.new.generate}.tmp")
+    end
+
+    # create a new file, validate it and clean it
+    filename = "photile-#{UUID.new.generate}.tmp"
+    File.new(filename, "w")
+    Photile::Cli.validate_file_exist(filename)
+    File.delete(filename)
+    assert true
+  end
+
+  def test_cli_tile_regexp
+    # valid regexp's
+    assert !Regexp.new(/\d+x\d+/).match("1x1").nil?
+    assert !Regexp.new(/\d+x\d+/).match("100x100").nil?
+
+    # invalid regexp structure
+    assert Regexp.new(/\d+x\d+/).match("1y1").nil?
+  end
+
+end

data/test/test_consts.rb

@@ -0,0 +1,17 @@
+require 'test/unit'
+require 'photile'
+
+class ConstsTest < Test::Unit::TestCase
+
+  def test_version
+    assert !Regexp.new(/\d+\.\d+\.\d+/).match(Photile::VERSION).nil?
+  end
+
+  def test_requirements
+    assert_equal "photile requires the following libraries " +
+                 "to be installed: imagemagick, imagemagick-common " +
+                 "and libjpeg-turbo-progs",
+                 Photile::REQUIREMENTS
+  end
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: photile
 version: !ruby/object:Gem::Version
-  version: 0.1.9
+  version: 0.1.10
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-19 00:00:00.000000000 Z
+date: 2013-01-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -27,6 +27,22 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: 0.8.7
+- !ruby/object:Gem::Dependency
+  name: uuid
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 2.3.6
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 2.3.6
 description: Photile is just a layer on top of Imagemagick and Jpegtran to make certain
   image processing tasks dead simple.
 email: nitindhar7@yahoo.com
@@ -43,6 +59,8 @@ files:
 - lib/photile.rb
 - lib/photile/cli.rb
 - photile.gemspec
+- test/test_cli.rb
+- test/test_consts.rb
 - test/test_requirements.rb
 homepage: https://github.com/nitindhar7/photile
 licenses: