phony_rails 0.2.0 → 0.2.1

data/README.md

@@ -27,11 +27,11 @@ In your model add:
 
     class SomeModel < ActiveRecord::Base
 
-      # Normalizes the attribute itself before validation 
+      # Normalizes the attribute itself before validation
       phony_normalize :phone_number, :default_country_code => 'US'
 
       # Normalizes attribute before validation and saves into other attribute
-      phony_normalize :phone_number, :as => :phone_number_normalized_version, :default_country_code => 'US' 
+      phony_normalize :phone_number, :as => :phone_number_normalized_version, :default_country_code => 'US'
 
       # Creates method normalized_fax_number that returns the normalized version of fax_number
       phony_normalized_method :fax_number
@@ -78,11 +78,11 @@ In your views use:
 
     <%= "311012341234".phony_formatted(:format => :international, :spaces => '-') %>
     <%= "+31-10-12341234".phony_formatted(:format => :international, :spaces => '-') %>
-    <%= "+31(0)1012341234".phony_formatted(:format => :international, :spaces => '-') %>    
+    <%= "+31(0)1012341234".phony_formatted(:format => :international, :spaces => '-') %>
 
 To first normalize the String to a certain country use:
 
-    <%= "010-12341234".phony_formatted(normalize => :NL, :format => :international, :spaces => '-') %>    
+    <%= "010-12341234".phony_formatted(normalize => :NL, :format => :international, :spaces => '-') %>
 
 You can also use the bang method (phony_formatted!):
 
@@ -98,28 +98,31 @@ Say you want to find a record by a phone number. Best is to normalize user input
 
 ## Changelog
 
+0.2.1
+* Better error handling by @k4nar
+
 0.1.12
 * Further loosened gemspec dependencies.
 
 0.1.11
-* Better gemspec dependency versions by rjhaveri.
+* Better gemspec dependency versions by @rjhaveri.
 
 0.1.10
 * Changes from henning-koch.
 * Some pending fixes.
 
 0.1.8
-* Improved validation methods by ddidier.
+* Improved validation methods by @ddidier.
 
 0.1.6
 * Added :as option to phony_normalize.
 
 0.1.5
-* some tests and a helper method by ddidier.
+* some tests and a helper method by @ddidier.
 
 0.1.2
-* Using countries gem as suggested by brutuscat.
-* Fixes bugs mentioned by ddidier.
+* Using countries gem as suggested by @brutuscat.
+* Fixes bugs mentioned by @ddidier.
 
 0.1.0
 * Added specs.

data/lib/phony_rails.rb

@@ -49,6 +49,7 @@ module PhonyRails
         options[:country_code] ||= self.country_code if self.respond_to?(:country_code)
         attributes.each do |attribute|
           attribute_name = options[:as] || attribute
+          raise RuntimeError, "No attribute #{attribute_name} found on #{self.class.name} (PhonyRails)" if not self.attribute_method?(attribute_name)
           write_attribute(attribute_name, PhonyRails.normalize_number(read_attribute(attribute), options))
         end
       end
@@ -69,12 +70,9 @@ module PhonyRails
           raise ArgumentError, ':as option can not be used on phony_normalize with multiple attribute names! (PhonyRails)' if attributes.size > 1
           raise ArgumentError, "'#{options[:as]}' is not an attribute on #{self.name}. You might want to use 'phony_normalized_method :#{attributes.first}' (PhonyRails)" if not self.attribute_method?(options[:as])
         end
-        attributes.each do |attribute|
-          raise ArgumentError, "No attribute #{attribute} found on #{self.name} (PhonyRails)" if not self.attribute_method?(attribute)
-          # Add before validation that saves a normalized version of the phone number
-          self.before_validation do
-            set_phony_normalized_numbers(attributes, options)
-          end
+        # Add before validation that saves a normalized version of the phone number
+        self.before_validation do
+          set_phony_normalized_numbers(attributes, options)
         end
       end
 

data/lib/phony_rails/version.rb

@@ -1,3 +1,3 @@
 module PhonyRails
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/spec/lib/phony_rails_spec.rb

@@ -14,7 +14,7 @@ describe PhonyRails do
         s.phony_formatted!(:normalize => :NL, :format => :international).should eql('+31 10 1234123')
         s.should eql("+31 10 1234123")
       end
-      
+
     end
 
     describe 'with normalize option' do
@@ -143,6 +143,12 @@ describe PhonyRails do
         Home.phony_normalize(:phone_number, :as => 'phone_number_as_normalized')
       }.should_not raise_error(ArgumentError)
     end
+
+    it "should accept a non existing attribute name" do
+      lambda {
+        Dummy.phony_normalize(:non_existing_attribute)
+      }.should_not raise_error
+    end
   end
 
   describe 'using ActiveRecord#phony_normalized_method' do
@@ -219,5 +225,14 @@ describe PhonyRails do
       home.valid?.should be_true
       home.phone_number_as_normalized.should eql('31101234123')
     end
+
+    it "should raise a RuntimeError at validation if the attribute doesn't exist" do
+      Dummy.phony_normalize :non_existing_attribute
+
+      dummy = Dummy.new
+      lambda {
+        dummy.valid?
+      }.should raise_error(RuntimeError)
+    end
   end
 end

data/spec/spec_helper.rb

@@ -26,6 +26,9 @@ class Home < ActiveRecord::Base
   phony_normalize :phone_number # normalized on validation
 end
 
+class Dummy < Home
+end
+
 RSpec.configure do |config|
-  # some (optional) config here  
+  # some (optional) config here
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: phony_rails
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-13 00:00:00.000000000 Z
+date: 2013-04-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: phony
@@ -105,7 +105,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.8.25
 signing_key: 
 specification_version: 3
 summary: This Gem adds useful methods to your Rails app to validate, display and save