phony_rails 0.1.9 → 0.1.10

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    phony_rails (0.1.8)
+    phony_rails (0.1.10)
       activerecord (~> 3.0)
       countries (~> 0.8.2)
       phony (~> 1.7.7)
@@ -43,7 +43,7 @@ GEM
       rb-fsevent (~> 0.9.1)
       rb-inotify (~> 0.8.8)
     multi_json (1.3.6)
-    phony (1.7.7)
+    phony (1.7.10)
     rb-fchange (0.0.5)
       ffi
     rb-fsevent (0.9.1)

data/README.md

@@ -78,6 +78,10 @@ Say you want to find a record by a phone number. Best is to normalize user input
 
 ## Changelog
 
+0.1.10
+* Changes from henning-koch.
+* Some pending fixes.
+
 0.1.8
 * Improved validation methods by ddidier.
 
@@ -122,3 +126,5 @@ Say you want to find a record by a phone number. Best is to normalize user input
 3. Commit your changes (`git commit -am 'Added some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
+
+Thanks to all contributors: ddidier, brutuscat, henning-koch.

data/lib/phony_rails.rb

@@ -68,7 +68,7 @@ module PhonyRails
         options.assert_valid_keys :country_code, :default_country_code, :as
         if options[:as].present?
           raise ArgumentError, ':as option can not be used on phony_normalize with multiple attribute names! (PhonyRails)' if attributes.size > 1
-          raise ArgumentError, "'#{options[:as]}' is not an attribute on #{self.class}. You might want to use 'phony_normalized_method :#{attributes.first}' (PhonyRails)" if not self.attribute_method?(options[:as])
+          raise ArgumentError, "'#{options[:as]}' is not an attribute on #{self.name}. You might want to use 'phony_normalized_method :#{attributes.first}' (PhonyRails)" if not self.attribute_method?(options[:as])
         end
         attributes.each do |attribute|
           raise ArgumentError, "No attribute #{attribute} found on #{self.name} (PhonyRails)" if not self.attribute_method?(attribute)
@@ -86,8 +86,9 @@ module PhonyRails
         main_options = attributes.last.is_a?(Hash) ? attributes.pop : {}
         main_options.assert_valid_keys :country_code, :default_country_code
         attributes.each do |attribute|
-          raise StandardError, "Instance method normalized_#{attribute} already exists on #{self.name} (PhonyRails)" if self.instance_methods.include?(:"normalized_#{attribute}")
-          define_method :"normalized_#{attribute}" do |options = {}|
+          raise StandardError, "Instance method normalized_#{attribute} already exists on #{self.name} (PhonyRails)" if method_defined?(:"normalized_#{attribute}")
+          define_method :"normalized_#{attribute}" do |*args|
+            options = args.first || {}
             raise ArgumentError, "No attribute/method #{attribute} found on #{self.class.name} (PhonyRails)" if not self.respond_to?(attribute)
             options[:country_code] ||= self.country_code if self.respond_to?(:country_code)
             PhonyRails.normalize_number(self.send(attribute), main_options.merge(options))

data/lib/phony_rails/version.rb

@@ -1,3 +1,3 @@
 module PhonyRails
-  VERSION = "0.1.9"
+  VERSION = "0.1.10"
 end

data/spec/lib/phony_rails_spec.rb

@@ -62,7 +62,7 @@ describe PhonyRails do
       }.should raise_error(ArgumentError)
     end
 
-    it "should not accept :as option with unexiting attribute name" do
+    it "should not accept :as option with unexisting attribute name" do
       lambda {
         Home.phony_normalize(:non_existing_attribute, :as => 'non_existing_attribute')
       }.should raise_error(ArgumentError)

metadata

@@ -1,72 +1,73 @@
---- !ruby/object:Gem::Specification
+--- !ruby/object:Gem::Specification 
 name: phony_rails
-version: !ruby/object:Gem::Version
-  version: 0.1.9
-  prerelease: 
+version: !ruby/object:Gem::Version 
+  prerelease: false
+  segments: 
+  - 0
+  - 1
+  - 10
+  version: 0.1.10
 platform: ruby
-authors:
+authors: 
 - Joost Hietbrink
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-13 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
+
+date: 2012-10-18 00:00:00 +02:00
+default_executable: 
+dependencies: 
+- !ruby/object:Gem::Dependency 
   name: phony
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 1.7.7
-  type: :runtime
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
+  requirement: &id001 !ruby/object:Gem::Requirement 
+    requirements: 
     - - ~>
-      - !ruby/object:Gem::Version
+      - !ruby/object:Gem::Version 
+        segments: 
+        - 1
+        - 7
+        - 7
         version: 1.7.7
-- !ruby/object:Gem::Dependency
-  name: countries
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 0.8.2
   type: :runtime
+  version_requirements: *id001
+- !ruby/object:Gem::Dependency 
+  name: countries
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
+  requirement: &id002 !ruby/object:Gem::Requirement 
+    requirements: 
     - - ~>
-      - !ruby/object:Gem::Version
+      - !ruby/object:Gem::Version 
+        segments: 
+        - 0
+        - 8
+        - 2
         version: 0.8.2
-- !ruby/object:Gem::Dependency
-  name: activerecord
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '3.0'
   type: :runtime
+  version_requirements: *id002
+- !ruby/object:Gem::Dependency 
+  name: activerecord
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
+  requirement: &id003 !ruby/object:Gem::Requirement 
+    requirements: 
     - - ~>
-      - !ruby/object:Gem::Version
-        version: '3.0'
-description: This Gem adds useful methods to your Rails app to validate, display and
-  save phone numbers.
-email:
+      - !ruby/object:Gem::Version 
+        segments: 
+        - 3
+        - 0
+        version: "3.0"
+  type: :runtime
+  version_requirements: *id003
+description: This Gem adds useful methods to your Rails app to validate, display and save phone numbers.
+email: 
 - joost@joopp.com
 executables: []
+
 extensions: []
+
 extra_rdoc_files: []
-files:
+
+files: 
 - .gitignore
 - .rspec
 - Gemfile
@@ -85,33 +86,37 @@ files:
 - spec/lib/phony_rails_spec.rb
 - spec/lib/validators/phony_validator_spec.rb
 - spec/spec_helper.rb
+has_rdoc: true
 homepage: https://github.com/joost/phony_rails
 licenses: []
+
 post_install_message: 
 rdoc_options: []
-require_paths:
+
+require_paths: 
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
-required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
+required_ruby_version: !ruby/object:Gem::Requirement 
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      segments: 
+      - 0
+      version: "0"
+required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      segments: 
+      - 0
+      version: "0"
 requirements: []
+
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.3.6
 signing_key: 
 specification_version: 3
-summary: This Gem adds useful methods to your Rails app to validate, display and save
-  phone numbers.
-test_files:
+summary: This Gem adds useful methods to your Rails app to validate, display and save phone numbers.
+test_files: 
 - spec/lib/phony_rails_spec.rb
 - spec/lib/validators/phony_validator_spec.rb
 - spec/spec_helper.rb
-has_rdoc: