phony_rails 0.1.5 → 0.1.6

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    phony_rails (0.1.2)
+    phony_rails (0.1.5)
       activerecord (~> 3.0)
       countries (~> 0.8.2)
       phony (~> 1.7.4)

data/README.md

@@ -24,8 +24,15 @@ Or install it yourself as:
 In your model add:
 
     class SomeModel < ActiveRecord::Base
-      phony_normalize :phone_number, :default_country_code => 'US' # Normalizes the attribute itself on validation
-      phony_normalized_method :fax_number # Creates method normalized_fax_number that returns the normalized version of fax_number
+
+      # Normalizes the attribute itself before 
+      phony_normalize :phone_number, :default_country_code => 'US'validation
+
+      # Normalizes attribute before validation and saves into other attribute
+      phony_normalize :phone_number, :as => :phone_number_normalized_version, :default_country_code => 'US' 
+
+      # Creates method normalized_fax_number that returns the normalized version of fax_number
+      phony_normalized_method :fax_number
     end
 
 The `:default_country_code` options is used to specify a country_code when normalizing.
@@ -42,6 +49,9 @@ In your views use:
 
 ## Changelog
 
+0.1.6
+* Added :as option to phony_normalize.
+
 0.1.5
 * some tests and a helper method by ddidier.
 

data/lib/phony_rails.rb

@@ -49,7 +49,8 @@ module PhonyRails
         options = options.clone
         options[:country_code] ||= self.country_code if self.respond_to?(:country_code)
         attributes.each do |attribute|
-          write_attribute(attribute, PhonyRails.normalize_number(read_attribute(attribute), options))
+          attribute_name = options[:as] || attribute
+          write_attribute(attribute_name, PhonyRails.normalize_number(read_attribute(attribute), options))
         end
       end
 
@@ -63,9 +64,11 @@ module PhonyRails
       # It checks your model object for a a country_code attribute (eg. 'NL') to do the normalizing so make sure
       # you've geocoded before calling this method!
       def phony_normalize(*attributes)
-        options = attributes.last.is_a?(Hash) ? attributes.pop : {} 
-        options.assert_valid_keys :country_code, :default_country_code
+        options = attributes.last.is_a?(Hash) ? attributes.pop : {}
+        options.assert_valid_keys :country_code, :default_country_code, :as
+        raise ArgumentError, ':as option can not be used on phony_normalize with multiple attribute names! (PhonyRails)' if !options[:as].blank? && attributes.size > 1
         attributes.each do |attribute|
+          raise ArgumentError, "No attribute #{attribute} found on #{self.class.name} (PhonyRails)" if not self.attribute_method?(attribute)
           # Add before validation that saves a normalized version of the phone number
           self.before_validation do 
             set_phony_normalized_numbers(attributes, options)

data/lib/phony_rails/version.rb

@@ -1,3 +1,3 @@
 module PhonyRails
-  VERSION = "0.1.5"
+  VERSION = "0.1.6"
 end

data/spec/lib/phony_rails_spec.rb

@@ -55,6 +55,26 @@ describe PhonyRails do
     end
   end
 
+  describe 'defining ActiveRecord#phony_normalize' do
+    it "should not accept :as option with multiple attribute names" do
+      lambda {
+        Home.phony_normalize(:phone_number, :phone1_method, :as => 'non_existing_attribute')
+      }.should raise_error(ArgumentError)
+    end
+
+    it "should not accept :as option with unexiting attribute name" do
+      lambda {
+        Home.phony_normalize(:non_existing_attribute, :as => 'non_existing_attribute')
+      }.should raise_error(ArgumentError)
+    end
+
+    it "should accept :as option with single attribute name" do
+      lambda {
+        Home.phony_normalize(:phone_number, :as => 'something_else')
+      }.should_not raise_error(ArgumentError)
+    end
+  end
+
   describe 'using ActiveRecord#phony_normalized_method' do
   # Following examples have complete number (with country code!)
     it "should return a normalized version of an attribute" do
@@ -119,8 +139,15 @@ describe PhonyRails do
   describe 'using ActiveRecord#phony_normalize' do
     it "should set a normalized version of an attribute" do
       home = Home.new(:phone_number => "+31-(0)10-1234123")
-      home.valid?
+      home.valid?.should be_true
       home.phone_number.should eql('31101234123')
     end
+
+    it "should set a normalized version of an attribute using :as option" do
+      Home.phony_normalize :phone_number, :as => :phone_number_as_normalized
+      home = Home.new(:phone_number => "+31-(0)10-1234123")
+      home.valid?.should be_true
+      home.phone_number_as_normalized.should eql('31101234123')
+    end    
   end
 end

data/spec/spec_helper.rb

@@ -14,6 +14,7 @@ ActiveRecord::Schema.define do
 create_table :homes do |table|
   table.column :phone_attribute, :string
   table.column :phone_number, :string
+  table.column :phone_number_as_normalized, :string
 end
 end
 

metadata

@@ -1,73 +1,72 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: phony_rails
-version: !ruby/object:Gem::Version 
-  prerelease: false
-  segments: 
-  - 0
-  - 1
-  - 5
-  version: 0.1.5
+version: !ruby/object:Gem::Version
+  version: 0.1.6
+  prerelease: 
 platform: ruby
-authors: 
+authors:
 - Joost Hietbrink
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2012-06-29 00:00:00 +02:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2012-07-02 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: phony
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
-    requirements: 
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 1
-        - 7
-        - 4
+      - !ruby/object:Gem::Version
         version: 1.7.4
   type: :runtime
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: countries
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
-    requirements: 
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.7.4
+- !ruby/object:Gem::Dependency
+  name: countries
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 0
-        - 8
-        - 2
+      - !ruby/object:Gem::Version
         version: 0.8.2
   type: :runtime
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: activerecord
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
-    requirements: 
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.8.2
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 3
-        - 0
-        version: "3.0"
+      - !ruby/object:Gem::Version
+        version: '3.0'
   type: :runtime
-  version_requirements: *id003
-description: This Gem adds useful methods to your Rails app to validate, display and save phone numbers.
-email: 
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.0'
+description: This Gem adds useful methods to your Rails app to validate, display and
+  save phone numbers.
+email:
 - joost@joopp.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - Gemfile
 - Gemfile.lock
 - LICENSE
@@ -81,37 +80,33 @@ files:
 - spec/lib/phony_rails_spec.rb
 - spec/lib/phony_validator_spec.rb
 - spec/spec_helper.rb
-has_rdoc: true
 homepage: https://github.com/joost/phony_rails
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      segments: 
-      - 0
-      version: "0"
+required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.3.6
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
-summary: This Gem adds useful methods to your Rails app to validate, display and save phone numbers.
-test_files: 
+summary: This Gem adds useful methods to your Rails app to validate, display and save
+  phone numbers.
+test_files:
 - spec/lib/phony_rails_spec.rb
 - spec/lib/phony_validator_spec.rb
 - spec/spec_helper.rb
+has_rdoc: