phony 2.2.5 → 2.2.7

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    Y2I0ZWIxMzc3NTZlMzdlYTYyOGM4MjUwZjc1MDdkYTQ4ODJlYzY1Ng==
+    NmYyM2E1MmVmYTM2OTE0YzIyM2U2MzE4YWY1MTMxMTdjYTQ0ZDU5OA==
   data.tar.gz: !binary |-
-    YTM5OWNkMTNmNjEyYjU5YzY2MTA0MjBkNDFkMTZkYWRiM2JkZWNjMA==
+    ZjgyODQ1OGVhZjFkNDI0OWVjOWNiYjhkMzJhOThhOGZkYzUxMDZjNQ==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    ZGZiNWViN2VjMWU1ZjEwZGFhZmVlNGJjNjdlOWMwYjU5MDNkYTI1OTY3NzAw
-    ZTdiODdhMGMzYmY3ZDgwNTBkMWE4ODkxNDJlOWIxZjBhZDgxY2RhNjJiYzUz
-    NDExMDllYTczMmU3NjA5OWI0NDFiZTEwMDM5MDlhMzdlZmEwODY=
+    NTI5ZGNhOGYwM2YyYTljNTU2OGZmNmMyMWE2MDE5NzY0YjYwM2E0ZTQ2OWYz
+    ZmE0NmJhZGU0NThiODc3ZGI0MjgxNTBlNjAwMzgzMjc0NTE4OGQwYjhmMzgw
+    NTYxOWU0MDI0MmYzYmM0OWMyMDFiNTBmNDUzZTNiZGE3MDc2NTI=
   data.tar.gz: !binary |-
-    ZWVkMDFmMTYwMDI0YjJmYWNiZmY1ZjBkMjQ1NTZkNTgzYzg5ZDhlMmM5MTQ4
-    ZjQyZGU3MDU1MjlmNTRjODQ3NzIwYWRjZTA1YTE4YTE0ZDE0NTk0YWRjMDc2
-    ZTMwYTRhYTBiOTJkMTAyZDI3MWVkNDlkNmNiMDBmMmVhNzA1Y2Q=
+    OTkyY2I5YmNhNzhmZDRlY2RmMzRmNzVhNjYzNjAxOTc5MDMyNTVlNzQzMzY3
+    ZDU2NDIwYzcxOTE5YmJjMTk5NGJmMWY2N2UzNjM1NDVlY2U4OTcyNzI3YzBh
+    MDY0YWJmNDM3MWM3ZTcxZTkwOWNkNjAwZGU5MDE3MTcxZWE1ZmI=

data/lib/phony/countries/germany.rb

@@ -4073,17 +4073,18 @@ service = [
 # http://www.itu.int/dms_pub/itu-t/oth/02/02/T02020000510001PDFE.pdf
 # "Numbers assigned in the past, which are generally grandfathered, may be as short as five digits."
 #
-
+# http://www.bundesnetzagentur.de/cln_1911/DE/Sachgebiete/Telekommunikation/Unternehmen_Institutionen/Nummerierung/Nummerierungskonzept/nummerierungskonzept_node.html
+#
+# TODO Define lower end of last part correctly.
+#
 Phony.define do
    country '49',
-     one_of(service)           >> split(3,0) |
-     one_of('176')             >> split(3,5) |
-     one_of('1609')            >> split(3,5) |
+     one_of(service)           >> split(3,0)    |
      match(/\A(151[124567]|152[012359]|157[035789]|1590)\d*\z/) >> split(3,4) |
-     match(/\A(1[57]\d)\d*\z/) >> split(3,4) |
-     match(/\A(16\d)\d*\z/)    >> split(3,5) |
-     one_of(ndcs2)             >> split(3,0..6) |
-     one_of(ndcs3)             >> split(3,0..5) |
-     one_of(ndcs4)             >> split(3,0..4) |
-     fixed(5)                  >> split(3,3..3)
-end
+     match(/\A(15\d)\d*\z/)    >> split(3,4)    |
+     match(/\A(1[67]\d)\d*\z/) >> split(3,1..5) | # Seite 49 [?]
+     one_of(ndcs2)             >> split(3,2..10) | # 5-9 Stellen nach Seite 32 [?]
+     one_of(ndcs3)             >> split(3,1..9) |
+     one_of(ndcs4)             >> split(3,0..8) |
+     fixed(5)                  >> split(3,0..7)
+end

data/spec/functional/plausibility_spec.rb

@@ -292,16 +292,38 @@ describe 'plausibility' do
         Phony.plausible?('+49 209 169 - 3530').should be_true # Gelsenkirchen
         Phony.plausible?('+49 40 123 45678').should be_true
         Phony.plausible?('+49 40 123 456789').should be_true # TODO ?
+        Phony.plausible?('+49 160 123 1234').should be_true # Mobile Number 7 digits
+        Phony.plausible?('+49 160 123 12345').should be_true # Mobile Number 8 digits
         Phony.plausible?('+49 171 123 4567').should be_true
-        Phony.plausible?('+49 171 123 45678').should be_false
+        Phony.plausible?('+49 171 123 45678').should be_true # is a valid number according German authority "bundesnetzagentur": http://www.bundesnetzagentur.de/SharedDocs/Downloads/DE/Sachgebiete/Telekommunikation/Unternehmen_Institutionen/Nummerierung/Rufnummern/ONRufnr/NummernplanOrtsnetzrufnummern.pdf?__blob=publicationFile&v=2 (04.24.2014)
         Phony.plausible?('+49 177 123 1234').should be_true
         Phony.plausible?('+49 176 123 12345').should be_true
         Phony.plausible?('+49 991 1234').should be_true   # stricter 3 digit ndc rules
         Phony.plausible?('+49 2041 123').should be_true # Grandfathered numbers.
         Phony.plausible?('+49 2041 1234567').should be_true
-        Phony.plausible?('+49 2041 12345689').should be_false # Could be a call-through number
         Phony.plausible?('+49 31234 123456').should be_true
-        Phony.plausible?('+49 31234 1234567').should be_false # Could be a call-through number
+        Phony.plausible?('+49 7141 12345670').should be_true
+        Phony.plausible?('+49 1609 1234567').should be_true # Bug: https://github.com/floere/phony/issues/146
+        # Following tests implement specifications from
+        # http://www.bundesnetzagentur.de/SharedDocs/Downloads/DE/Sachgebiete/Telekommunikation/Unternehmen_Institutionen/Nummerierung/Rufnummern/ONRufnr/NummernplanOrtsnetzrufnummern.pdf?__blob=publicationFile&v=2 (04.24.2014)
+        # Page 3
+        Phony.plausible?('+49 89    12345678').should be_true # NZ-E
+        Phony.plausible?('+49 89    123456789').should be_true # NZ-E & NZ-Z
+        Phony.plausible?('+49 89    1234567890').should be_true # NZ-Z
+        Phony.plausible?('+49 209   1234567').should be_true # NZ-E
+        Phony.plausible?('+49 209   12345678').should be_true # NZ-E & NZ-Z
+        Phony.plausible?('+49 209   123456789').should be_true # NZ-Z
+        Phony.plausible?('+49 6421  123456').should be_true # NZ-E
+        Phony.plausible?('+49 6421  1234567').should be_true # NZ-E & NZ-Z
+        Phony.plausible?('+49 6421  12345678').should be_true # NZ-Z
+        Phony.plausible?('+49 33053 12345').should be_true # NZ-E
+        Phony.plausible?('+49 33053 123456').should be_true # NZ-E & NZ-Z
+        Phony.plausible?('+49 33053 1234567').should be_true # NZ-Z
+        # Point 2.3c) Numbers can be up to 13 Digits long without prefix according to E.164
+        Phony.plausible?('+49 33053 12345678').should be_true
+        Phony.plausible?('+49 6421 123456789').should be_true
+        Phony.plausible?('+49 209 1234567890').should be_true
+        Phony.plausible?('+49 40 12345678901').should be_true
       end
 
       it 'is correct for Israelian numbers' do

metadata

@@ -1,18 +1,18 @@
 --- !ruby/object:Gem::Specification
 name: phony
 version: !ruby/object:Gem::Version
-  version: 2.2.5
+  version: 2.2.7
 platform: ruby
 authors:
 - Florian Hanke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-20 00:00:00.000000000 Z
+date: 2014-04-27 00:00:00.000000000 Z
 dependencies: []
 description: ! 'Fast international phone number (E164 standard) normalizing, splitting
   and formatting. Lots of formatting options: International (+.., 00..), national
-  (0..), and local).'
+  (0..), and local.'
 email: florian.hanke+phony@gmail.com
 executables: []
 extensions: []