phony 2.17.1 → 2.18.5

data/spec/functional/config_spec.rb

@@ -0,0 +1,44 @@
+# encoding: utf-8
+#
+describe 'Phony::Config' do
+  describe 'load' do
+    before do
+      # NOTE We redefine Phony as if it was not loaded for this set of tests.
+      Object.__send__(:remove_const, :Phony) if Object.constants.include?(:Phony)
+      
+      load 'phony/config.rb'
+    end
+    after(:all) do
+      # After running this suite, we load all of Phony for the following tests.
+      load 'phony/config.rb'
+      
+      Phony::Config.load
+    end
+    
+    it 'does not fail when loading all' do
+      Phony::Config.load
+      
+      Phony.split('15551115511').should == ['1', '555', '111', '5511']
+    end
+    it 'raises when a CC is used that has not been loaded.' do
+      Phony::Config.load('41')
+      
+      expect { Phony.split('15551115511') }.to raise_error
+    end
+    it 'raises when a CC is used that has not been loaded.' do
+      Phony::Config.load(only: ['41'])
+      
+      expect { Phony.split('15551115511') }.to raise_error
+    end
+    it 'raises when a CC is used that has not been loaded.' do
+      Phony::Config.load(except: ['1'])
+      
+      expect { Phony.split('15551115511') }.to raise_error
+    end
+    it 'does not raise when a CC is used that has been loaded.' do
+      Phony::Config.load(except: ['41'])
+      
+      Phony.split('15551115511').should == ['1', '555', '111', '5511']
+    end
+  end
+end

data/spec/functional/plausibility_spec.rb

@@ -251,7 +251,7 @@ describe 'plausibility' do
       it_is_correct_for 'Gabonese Republic', :samples => '+241 1 627 739'
       it_is_correct_for 'Gambia', :samples => '+220  989 5148'
       it_is_correct_for 'Germany', :samples => [
-        '+49 157 753 6870'
+        '+49 1577 536 8701'
       ]
       it_is_correct_for 'Georgia', :samples => ['+995 220 123 45',
                                                 '+995 32 123 4567',
@@ -598,6 +598,11 @@ describe 'plausibility' do
         Phony.plausible?('+81 120 123 123').should be_truthy
         Phony.plausible?('+81 800 123 1234').should be_truthy
       end
+
+      it 'is correct for Philippine' do
+        Phony.plausible?('+63 976 1234567').should be_truthy # mobile phone with area code 9
+        Phony.plausible?('+63 876 1234567').should be_truthy # mobile phone with area code 8
+      end
     end
   end
 end

data/spec/lib/phony/countries_spec.rb

@@ -33,13 +33,13 @@ describe 'country descriptions' do
     end
 
     describe 'Argentina' do
-      it_splits '541112345678', ['54', '11', '1234', '5678']
-      it_splits '542911234567', ['54', '291', '123', '4567']
-      it_splits '542965123456', ['54', '2965', '12', '3456']
-      it_splits '5491112345678', ['54', '911', '1234', '5678']
-      it_splits '5492201234567', ['54', '9220', '123', '4567']
-      it_splits '5492221123456', ['54', '92221', '12', '3456']
-      it_splits '548001234567', ['54', '800', '123', '4567']
+      it_splits '541112345678', ['54', '11', '1234', '5678']    # 2-digit area code / landline
+      it_splits '542911234567', ['54', '291', '123', '4567']    # 3-digit area code / landline
+      it_splits '542903123456', ['54', '2903', '12', '3456']    # 4-digit area code / landline
+      it_splits '5491112345678', ['54', '911', '1234', '5678']  # 2-digit area code / international mobile
+      it_splits '5492201234567', ['54', '9220', '123', '4567']  # 3-digit area code / international mobile
+      it_splits '5492221123456', ['54', '92221', '12', '3456']  # 4-digit area code / international mobile
+      it_splits '548001234567', ['54', '800', '123', '4567']    # Non-geographic number
     end
 
     describe 'Austria' do
@@ -291,7 +291,7 @@ describe 'country descriptions' do
       it_splits '49800222340010',  ['49', '800', '222', '340010'] # Service number
 
       it_splits '4915111231234',   ['49', '151', '1123', '1234']  # Mobile number
-      it_splits '4915771231234',   ['49', '157', '7123', '1234']  # Mobile number
+      it_splits '4915771231234',   ['49', '1577', '123', '1234']  # Mobile number
       it_splits '491601234567',    ['49', '160', '1234', '567']   # Mobile number
       it_splits '4916312345678',   ['49', '163', '1234', '5678']  # Mobile number
       it_splits '4915211231234',   ['49', '1521', '123', '1234']  # Mobile number
@@ -401,6 +401,7 @@ describe 'country descriptions' do
       it_splits '35311234567',  ['353', '1', '123', '4567']  # Dublin, 7 digit subscriber #
       it_splits '353539233333', ['353', '53', '923', '3333'] # Wexford, 7 digit subscriber
       it_splits '3532212345',   ['353', '22', '12345']       # Mallow, 5 digit subscriber #
+      it_splits '353441234567', ['353', '44', '123', '4567'] # Mullingar, Castlepollard, Tyrellspass 7 digit subscriber #
       it_splits '35345123456',  ['353', '45', '123456']      # Naas, 6 digit subscriber #
       it_splits '353801234567', ['353', '80', '123', '4567'] # Mobile
       it_splits '353761234567', ['353', '76', '123', '4567'] # VoIP
@@ -409,14 +410,16 @@ describe 'country descriptions' do
     end
 
     describe 'Israel (972)' do
-      it_splits '972100',       ['972', '1', '00']  # Police
-      it_splits '97221231234',  ['972', '2', '123', '1234']  # Jerusalem Area
-      it_splits '97282411234',  ['972', '8', '241', '1234']  # Gaza Strip (Palestine)
-      it_splits '97291231234',  ['972', '9', '123', '1234']  # Sharon Area
-      it_splits '972501231234', ['972', '50', '123', '1234']  # Mobile (Pelephone)
-      it_splits '972591231234', ['972', '59', '123', '1234']  # Mobile Jawwal (Palestine)
-      it_splits '972771231234', ['972', '77', '123', '1234']  # Cable Phone Services
+      it_splits '972100',       ['972', '1', '00']                  # Police
+      it_splits '97221231234',  ['972', '2', '123', '1234']         # Jerusalem Area
+      it_splits '97282411234',  ['972', '8', '241', '1234']         # Gaza Strip (Palestine)
+      it_splits '97291231234',  ['972', '9', '123', '1234']         # Sharon Area
+      it_splits '972501231234', ['972', '50', '123', '1234']        # Mobile (Pelephone)
+      it_splits '972591231234', ['972', '59', '123', '1234']        # Mobile Jawwal (Palestine)
+      it_splits '972771231234', ['972', '77', '123', '1234']        # Cable Phone Services
       it_splits '9721700123123', ['972', '1', '700', '123', '123']  # Cable Phone Services
+      it_splits '972511234567', ['972', '51', '123', '4567']        # Mobile (We4G)
+      it_splits '972791111111', ['972', '79', '111', '1111']        # Landline (Hallo, Cellact, Telzar)
     end
     describe 'Israel (970)' do
       it_splits '97021231234',  ['970', '2', '123', '1234']  # Jerusalem Area

data/spec/lib/phony/dsl_spec.rb

@@ -16,8 +16,8 @@ describe Phony::DSL do
     it 'checks for ( in regex' do
       expect { dsl.match(/123/) }.to raise_error("Regexp /123/ needs a group in it that defines which digits belong to the NDC.")
     end
-    it 'checks for ( in regex' do
-      dsl.match(/(123)/).should be_kind_of(Phony::NationalSplitters::Regex)
+    it 'should return a Phony::NationalSplitters::Regex' do
+      dsl.match(/(123)/).class.name.should == Phony::NationalSplitters::Regex.name
     end
   end
 

data/spec/lib/phony/local_splitters/regex_spec.rb

@@ -1,7 +1,14 @@
 require 'spec_helper'
 
+main = self
+
 describe Phony::LocalSplitters::Regex do
   
+  before do
+    load 'spec_helper_extensions.rb'
+    main.send :include, SpecHelperExtensions
+  end
+  
   describe 'instance_for' do
     it 'does not cache' do
       described_class.instance_for({}).should_not equal(described_class.instance_for({}))

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: phony
 version: !ruby/object:Gem::Version
-  version: 2.17.1
+  version: 2.18.5
 platform: ruby
 authors:
 - Florian Hanke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-01 00:00:00.000000000 Z
+date: 2019-06-28 00:00:00.000000000 Z
 dependencies: []
 description: 'Fast international phone number (E164 standard) normalizing, splitting
   and formatting. Lots of formatting options: International (+.., 00..), national
@@ -21,7 +21,9 @@ extra_rdoc_files:
 files:
 - README.textile
 - lib/phony.rb
+- lib/phony/config.rb
 - lib/phony/countries.rb
+- lib/phony/countries/argentina.rb
 - lib/phony/countries/austria.rb
 - lib/phony/countries/bangladesh.rb
 - lib/phony/countries/belarus.rb
@@ -77,6 +79,7 @@ files:
 - lib/phony/national_splitters/variable.rb
 - lib/phony/trunk_code.rb
 - lib/phony/vanity.rb
+- spec/functional/config_spec.rb
 - spec/functional/plausibility_spec.rb
 - spec/lib/phony/countries_spec.rb
 - spec/lib/phony/country_codes_spec.rb
@@ -132,4 +135,5 @@ test_files:
 - spec/lib/phony/local_splitters/regex_spec.rb
 - spec/lib/phony/local_splitters/fixed_spec.rb
 - spec/lib/phony/vanity_spec.rb
+- spec/functional/config_spec.rb
 - spec/functional/plausibility_spec.rb