phony 2.16.3 → 2.16.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a7c21a8c6e8081e6ef55bb582caa1b4c395bc134
-  data.tar.gz: 2d15cf9be4f0912ac1e03b81cd12750aabdf5cc2
+  metadata.gz: 5d694ea5581b74590cc1986eca397aa059a4835e
+  data.tar.gz: 4cfc87a6bdceb938a024a285bf04a514162bc47d
 SHA512:
-  metadata.gz: 8d4384ce970c0650b68b6c8afb8b936784ac52c0fd862462c690bc22487e633c2ac8033288cb27a1521e1272e5a456d3e32130f0fb1f5160404806874f059888
-  data.tar.gz: 7f634655df245f4c5de104a80a4f32aeec95338cb4129aadf0297193fc8576923798ac4acdf8fcd01992e59598525d9cd366c55611151345fb8bda1308033b7e
+  metadata.gz: 340c1f1ff5187c9e722fa0c82d1caa01637ae92466e8d1dec8c302742074e8b0ff850a3bff9b16f9d0794819f50899c428054199998efd76acc1dd8bd7121d1d
+  data.tar.gz: c1d20505af244d4864512d0d03c2de405056da6d96fc92c7396f803d9a887b12e5750bf23829cd86b098521267036ef704051a06d1145f5e4b806c92f6b6ac9a

data/lib/phony.rb

@@ -89,7 +89,7 @@ module Phony
   #
   class SplittingError < ArgumentError
     def initialize number
-      super %Q{Phony could not split the given number. Is #{number.blank? ? 'it' : number.inspect} a phone number?}
+      super %Q{Phony could not split the given number. Is #{(number.nil? || number == '') ? 'it' : number.inspect} a phone number?}
     end
   end
   

data/lib/phony/countries.rb

@@ -491,8 +491,9 @@ Phony.define do
               /\A20\d+\z/ => [2,3,4], # Telecom Malagasy (Telma)
               /\A23\d+\z/ => [2,3,4], # Digitel
               /\A30\d+\z/ => [2,3,4], # mobile Madamobil (CDMA2000)
-              /\A31\d+\z/ => [2,3,4], # mobile Sacel
+              /\A31\d+\z/ => [2,3,4], # mobile Airtel Madagascar
               /\A32\d+\z/ => [2,3,4], # mobile Orange Madagascar
+              /\A33\d+\z/ => [2,3,4], # mobile Airtel Madagascar
               /\A34\d+\z/ => [2,3,4], # mobile Telecom Malagasy (Telma)
               /\A5\d+\z/ => [3,3,3],  # pager
               /\A22\d+\z/ => [3,3,3], # satellite GULFSAT Téléphonie
@@ -1024,7 +1025,10 @@ Phony.define do
   # Bangladesh (People's Republic of)
   #  country '880' # see special file
 
-  country '881', todo # International Mobile, shared code
+  # Global Mobile Satellite System (i.e. Iridium, Globalstar, etc)
+  #  https://www.numberingplans.com/?page=plans&sub=phonenr&alpha_2_input=QM
+  country '881', fixed(1) >> split(3,5)
+
   country '882', todo # International Networks, shared code
   country '883', todo # -
   country '884', todo # -

data/lib/phony/countries/south_korea.rb

@@ -1,22 +1,24 @@
 # South Korean (Republic of Korea) phone numbers.
 #
 # http://en.wikipedia.org/wiki/Telephone_numbers_in_South_Korea
+# https://www.numberingplans.com/?page=plans&sub=phonenr&alpha_2_input=KR
 #
 
 # TODO 4-digit services, like "unreasonable infringement of livelihood report" number :)
 #
 
 special = %w{ 100 101 105 106 107 108 109 111 112 113 114 115 116 117 118 119 120 121 122 123 125 127 128 129 131 132 134 141 182 188 }
-# mobile  = ('10'..'19').to_a # Note: Mobile not used as it is (for now) handled by the fixed catchall.
+mobile  = ('10'..'19').to_a
 
 Phony.define do
   country '82',
     trunk('0') |
     match(/^(#{special.join("|")})$/) >> split(3,3) | # Special actually don't need to be split – but better err.
-    one_of('2')                       >> split(4,4) | # Seoul, also includes "services".
-    fixed(2)                          >> split(4,4)   # Catchall.
-    
-    # See above.
-    #
-    # one_of(*mobile)                 >> split(4,4) |
-end
+    one_of(*mobile) >> split(4,4) |
+    one_of('2') >> matched_split(
+      /\A\d{7}\z/ => [3,4],
+      /\A\d{8}\z/ => [4,4]) | # Seoul, also includes "services".
+    fixed(2) >> matched_split(
+      /\A\d{7}\z/ => [3,4],
+      /\A\d{8}\z/ => [4,4]) # Rest of cities
+end

data/spec/functional/plausibility_spec.rb

@@ -189,7 +189,8 @@ describe 'plausibility' do
                                                    '+389 7 234 5678']
       it_is_correct_for 'Madagascar', :samples => ['+261 20 012 345 678',
                                                    '+261 20 124 3456',
-                                                   '+261 512 345 678']
+                                                   '+261 512 345 678',
+                                                   '+261 33 345 6789']
       it_is_correct_for 'Malawi', :samples => ['+265 1725 123',
                                                '+265 213 456 789',
                                                '+265 9123 456',
@@ -280,6 +281,16 @@ describe 'plausibility' do
                                                                    '+252 160 12 34',
                                                                    '+252 500 123 45',
                                                                    '+252 67 1234 567']
+
+      it 'is correct for South Korea' do
+        Phony.plausible?('+82 2 1234 5678').should be_truthy
+        Phony.plausible?('+82 2 711 2222').should be_truthy
+        Phony.plausible?('+82 51 1234 5678').should be_truthy
+        Phony.plausible?('+82 51 123 5678').should be_truthy
+        Phony.plausible?('+82 10 2797 5588').should be_truthy
+        Phony.plausible?('+82 10 8797 1234').should be_truthy
+      end
+
       it_is_correct_for 'South Sudan', :samples => ['+211 123 212 345',
                                                     '+211 973 212 345']
       it_is_correct_for 'Suriname (Republic of)', :samples => ['+597 212 345', '+597 612 3456']

data/spec/lib/phony/countries_spec.rb

@@ -632,8 +632,10 @@ describe 'country descriptions' do
       it_splits '2399920012', %w(239 9 920 012)
     end
     describe 'South Korea' do
-      it_splits '82212345678',  ['82', '2', '1234', '5678']  # Seoul
-      it_splits '825112345678', ['82', '51', '1234', '5678'] # Busan
+      it_splits '82212345678',  ['82', '2', '1234', '5678']  # Seoul (8 digits)
+      it_splits '8227111222',   ['82', '2', '711', '1222']   # Seoul (7 digits)
+      it_splits '825112345678', ['82', '51', '1234', '5678'] # Busan (8 digits)
+      it_splits '82511234567',  ['82', '51', '123', '4567']  # Busan (7 digits)
       it_splits '821027975588', ['82', '10', '2797', '5588'] # mobile
       it_splits '821087971234', ['82', '10', '8797', '1234'] # mobile
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: phony
 version: !ruby/object:Gem::Version
-  version: 2.16.3
+  version: 2.16.4
 platform: ruby
 authors:
 - Florian Hanke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-08 00:00:00.000000000 Z
+date: 2018-05-31 00:00:00.000000000 Z
 dependencies: []
 description: 'Fast international phone number (E164 standard) normalizing, splitting
   and formatting. Lots of formatting options: International (+.., 00..), national