phony 2.15.0 → 2.20.1

data/spec/lib/phony/country_codes_spec.rb

@@ -1,106 +1,179 @@
 require 'spec_helper'
 
 describe Phony::CountryCodes do
+  
+  let(:countries) { Phony::CountryCodes.instance }
+  
+  describe '#plausible?' do
+    it 'raises an error on a too long ccc' do
+      expect do
+        countries.plausible?('+1 868 7620266', ccc: '1868123')
+      end.to raise_error(ArgumentError, %Q{The provided ccc option is too long and includes more than a cc ('1') and ndc ('868'). It also includes '123'.})
+    end
+  end
+  
+  describe 'ccc handling' do
+    it 'splits a ccc correctly' do
+      cc, ndc, *local = countries.split('1868')
+      cc.should eq('1')
+      ndc.should eq('868')
+    end
+    it 'splits a ccc correctly' do
+      cc, ndc, *local = countries.split('1868')
+      cc.should eq('1')
+      ndc.should eq('868')
+    end
+  end
+  
+  describe '#[]' do
+    it 'returns a country' do
+      countries['41'].class.should eql Phony::Country
+    end
+  end
+  
+  describe '#country_for' do
+    it 'returns a country' do
+      countries.send(:country_for, '41').class.should eql Phony::Country
+    end
+  end
+  
+  describe '#countrify' do
+    it 'returns a country' do
+      countries.send(:countrify, '441231212', '41').should eql '41441231212'
+    end
+  end
+  describe '#countrify!' do
+    it 'in-place replaces the number' do
+      number = '441231212'
+      countries.send(:countrify!, number, '41').should eql number
+      
+      number.should == '41441231212'
+    end
+  end
+  
+  describe '#vanity?' do
+    it 'returns true if so' do
+      countries.vanity?('1800HELLOES').should eql true
+    end
+    it 'returns false if not' do
+      countries.vanity?('18001234567').should eql false
+    end
+  end
 
-  before(:all) do
-    @countries = Phony::CountryCodes.instance
+  describe 'normalize' do
+    it 'normalizes correctly' do
+      countries.normalize('0041-44-364-35-32').should eql '41443643532'
+    end
+    it 'normalizes correctly with CC option' do
+      countries.normalize('044-364-35-32', cc: '41').should eql '41443643532'
+    end
+
+    context 'specific countries' do
+      it 'handles Congo correctly' do
+        countries.normalize('+242 0571 73992').should eql '242057173992'
+        countries.normalize('+242 2221 15932').should eql '242222115932'
+      end
+    end
   end
 
   describe 'formatted' do
     it 'formats correctly' do
-      @countries.formatted('41443643532', :format => :international, :spaces => :-).should eql '+41-44-364-35-32'
+      countries.formatted('41443643532', :format => :international, :spaces => :-).should eql '+41-44-364-35-32'
     end
     it 'formats correctly' do
-      @countries.formatted('41443643532', :format => :international_relative, :spaces => :-).should eql '0041-44-364-35-32'
+      countries.formatted('41443643532', :format => :international_relative, :spaces => :-).should eql '0041-44-364-35-32'
     end
     it 'formats correctly' do
-      @countries.formatted('41443643532', :format => :national, :spaces => :-).should eql '044-364-35-32'
+      countries.formatted('41443643532', :format => :national, :spaces => :-).should eql '044-364-35-32'
     end
     context 'specific' do
       it 'formats Ireland correctly' do
-        @countries.formatted("3533451234", :format => :national).should eql '0345 1234'
+        countries.formatted("3533451234", :format => :national).should eql '0345 1234'
       end
       it 'formats Ireland correctly' do
-        @countries.formatted("353411231234", :format => :national).should eql '041 123 1234'
+        countries.formatted("353411231234", :format => :national).should eql '041 123 1234'
       end
       it 'formats Spain correctly' do
-        @countries.formatted("34123456789", :format => :national).should eql '123 456 789'
+        countries.formatted("34123456789", :format => :national).should eql '123 456 789'
       end
       it 'formats Cambodia correctly' do
-        @countries.formatted('85512239123', :format => :national).should eql '012 239 123'
+        countries.formatted('85512239123', :format => :national).should eql '012 239 123'
       end
       it 'formats the US correctly' do
-        @countries.formatted('18005551212', :format => :national, :spaces => :-).should eql '(800)-555-1212'
+        countries.formatted('18005551212', :format => :national, :spaces => :-).should eql '(800)-555-1212'
       end
       it 'formats the US correctly' do
-        @countries.formatted('18005551212', :format => :national, :spaces => :-).should eql '(800)-555-1212'
+        countries.formatted('18005551212', :format => :national, :spaces => :-).should eql '(800)-555-1212'
       end
     end
     context 'default' do
       it "should format swiss numbers" do
-        @countries.formatted('41443643532').should eql '+41 44 364 35 32'
+        countries.formatted('41443643532').should eql '+41 44 364 35 32'
       end
       it "should format swiss service numbers" do
-        @countries.formatted('41800112233').should eql '+41 800 112 233'
+        countries.formatted('41800112233').should eql '+41 800 112 233'
       end
       it "should format austrian numbers" do
-        @countries.formatted('43198110').should eql '+43 1 98110'
+        countries.formatted('43198110').should eql '+43 1 98110'
       end
       it "should format american numbers" do
-        @countries.formatted('18705551122').should eql '+1 (870) 555-1122'
+        countries.formatted('18705551122').should eql '+1 (870) 555-1122'
       end
       it "should format irish numbers" do
-        @countries.formatted('35311234567').should eql '+353 1 123 4567'
+        countries.formatted('35311234567').should eql '+353 1 123 4567'
       end
     end
     describe "international" do
       it "should format north american numbers" do
-        @countries.formatted('18091231234', :format => :international).should eql '+1 (809) 123-1234'
+        countries.formatted('18091231234', :format => :international).should eql '+1 (809) 123-1234'
       end
       it "should format austrian numbers" do
-        @countries.formatted('43198110', :format => :international).should eql '+43 1 98110'
+        countries.formatted('43198110', :format => :international).should eql '+43 1 98110'
       end
       it "should format austrian numbers" do
-        @countries.formatted('43198110', :format => :international_absolute).should eql '+43 1 98110'
+        countries.formatted('43198110', :format => :international_absolute).should eql '+43 1 98110'
       end
       it "should format french numbers" do
-        @countries.formatted('33142278186', :format => :+).should eql '+33 1 42 27 81 86'
+        countries.formatted('33142278186', :format => :+).should eql '+33 1 42 27 81 86'
       end
       it "should format austrian numbers" do
-        @countries.formatted('43198110', :format => :international_relative).should eql '0043 1 98110'
+        countries.formatted('43198110', :format => :international_relative).should eql '0043 1 98110'
       end
       it 'should format liechtensteiner numbers' do
-        @countries.formatted('4233841148', :format => :international_relative).should eql '00423 384 11 48'
+        countries.formatted('4233841148', :format => :international_relative).should eql '00423 384 11 48'
       end
       it "should format irish numbers" do
-        @countries.formatted('35311234567', :format => :international).should eql '+353 1 123 4567'
+        countries.formatted('35311234567', :format => :international).should eql '+353 1 123 4567'
       end
       it "should format luxembourgian numbers" do
-        @countries.formatted('352222809', :format => :international).should eql '+352 22 28 09'
+        countries.formatted('352222809', :format => :international).should eql '+352 22 28 09'
       end
       it "should format luxembourgian 4-digit ndc numbers" do
-        @countries.formatted('35226222809', :format => :international).should eql '+352 26 22 28 09'
+        countries.formatted('35226222809', :format => :international).should eql '+352 2622 28 09'
       end
       it "should format luxembourgian mobile numbers" do
-        @countries.formatted('352621123456', :format => :international).should eql '+352 621 123 456'
+        countries.formatted('352621123456', :format => :international).should eql '+352 621 123 456'
       end
       it "should format luxembourgian city numbers" do
-        @countries.formatted('3524123456', :format => :international).should eql '+352 4 12 34 56'
+        countries.formatted('3524123456', :format => :international).should eql '+352 41 23 45 6'
       end
       it "should format luxembourgian machine to machine numbers" do
-        @countries.formatted('352602112345678', :format => :international).should eql '+352 6021 12 34 56 78'
+        countries.formatted('352602112345678', :format => :international).should eql '+352 6021 12 34 56 78'
       end
       it "should format luxembourgian numbers" do
-        @countries.formatted('352370431', :format => :international).should eql '+352 37 04 31'
+        countries.formatted('352370431', :format => :international).should eql '+352 37 04 31'
       end
       it "should format luxembourgian numbers" do
-        @countries.formatted('35227855', :format => :international).should eql '+352 27 85 5'
+        countries.formatted('35227855', :format => :international).should eql '+352 27 85 5'
+      end
+      it "should format nigerian lagosian numbers" do
+        countries.formatted('23414480000', :format => :international).should eql '+234 1 448 0000'
       end
-      it "should format nigerian numbers" do
-        @countries.formatted('23414480000', :format => :international).should eql '+234 1 448 0000'
+      it "should format nigerian beninese numbers" do
+        countries.formatted('23452123456', :format => :international).should eql '+234 52 123 456'
       end
       it "should format nigerian mobile numbers" do
-        @countries.formatted('2347061234567', :format => :international).should eql '+234 706 123 4567'
+        countries.formatted('2347061234567', :format => :international).should eql '+234 706 123 4567'
       end
       context 'with no spaces' do
         it "should format north american numbers" do

data/spec/lib/phony/country_spec.rb

@@ -2,45 +2,84 @@ require 'spec_helper'
 
 describe Phony::Country do
   
+  describe 'general' do
+    let(:country) do
+      national_splitter = Phony::NationalSplitters::Variable.new 4, ['44']
+      local_splitter    = Phony::LocalSplitters::Fixed.instance_for [3, 2, 2]
+      national_code     = Phony::NationalCode.new national_splitter, local_splitter
+      
+      Phony::Country.new national_code
+    end
+    describe '#clean' do
+      it 'cleans the number' do
+        country.clean('+41-44-123-12-12').should eql '41441231212'
+      end
+    end
+    describe '#vanity_to_number' do
+      it 'turns the vanity number into a number' do
+        country.vanity_to_number('1-800-HELLO').should eql '1-800-43556'
+      end
+    end
+  end
+  
   context 'regression' do
-    describe 'iceland' do
-      before(:each) do
+    describe 'Iceland' do
+      let(:country) do
         national_splitter = Phony::NationalSplitters::None.instance_for
         local_splitter    = Phony::LocalSplitters::Fixed.instance_for [3, 4]
 
         national_code     = Phony::NationalCode.new national_splitter, local_splitter
-        @iceland          = described_class.new national_code
+        described_class.new national_code
+      end
+      it 'splits correctly' do
+        country.split('112').should == [nil, false, '112']
+      end
+    end
+    describe 'San Marino' do
+      it 'normalizes correctly' do
+        Phony.normalize('+3780549903549').should == '3780549903549'
+      end
+      xit 'automatically adds the sole NC' do
+        Phony.normalize('+378903549').should == '3780549903549'
+      end
+    end
+    describe 'Japan' do
+      it 'normalizes correctly' do
+        Phony.normalize('+81-03-1234-5634').should == '81312345634'
+        Phony.normalize('03-1234-5634', cc: '81').should == '81312345634'
+      end
+      it 'formats correctly' do
+        Phony.format('81312345634').should == '+81-3-1234-5634'
       end
       it 'splits correctly' do
-        @iceland.split('112').should == [nil, false, '112']
+        Phony.split('81312345634').should == %w(81 3 1234 5634)
       end
     end
   end
   
-  context "without special cases" do
-    before(:each) do
+  context "without special cases (with switzerland)" do
+    let(:country) do
       national_splitter = Phony::NationalSplitters::Variable.new 4, ['44']
       local_splitter    = Phony::LocalSplitters::Fixed.instance_for [3, 2, 2]
       national_code     = Phony::NationalCode.new national_splitter, local_splitter
       
-      @switzerland      = Phony::Country.new national_code
-      @switzerland.with '41' # TODO Remove this kludge.
+      Phony::Country.new national_code
     end
     
     describe "split" do
       it "should handle ZH" do
-        @switzerland.split('443643532').should == [nil, '44', '364', '35', '32']
+        country.split('443643532').should == [nil, '44', '364', '35', '32']
       end
     end
     describe 'normalize' do
       it "should handle ZH" do
-        @switzerland.normalize('0443643532').should == '443643532'
+        country.normalize('0443643532').should == '443643532'
       end
     end
   end
   
   context "without special cases" do
-    before(:each) do
+    let(:country) do
       special_national_splitter = Phony::NationalSplitters::Variable.new nil, ['800']
       special_local_splitter    = Phony::LocalSplitters::Fixed.instance_for [3, 3]
       special_code              = Phony::NationalCode.new special_national_splitter, special_local_splitter
@@ -49,17 +88,17 @@ describe Phony::Country do
       local_splitter            = Phony::LocalSplitters::Fixed.instance_for [3, 2, 2]
       national_code             = Phony::NationalCode.new national_splitter, local_splitter
       
-      @switzerland              = Phony::Country.new special_code, national_code
+      Phony::Country.new special_code, national_code
     end
     
     describe "split" do
       it "should handle ZH" do
-        @switzerland.split('443643532').should == [nil, '44', '364', '35', '32']
+        country.split('443643532').should == [nil, '44', '364', '35', '32']
       end
       it "should handle 800" do
-        @switzerland.split('800333666').should == [nil, '800', '333', '666']
+        country.split('800333666').should == [nil, '800', '333', '666']
       end
     end
   end
   
-end
+end

data/spec/lib/phony/dsl_spec.rb

@@ -16,8 +16,8 @@ describe Phony::DSL do
     it 'checks for ( in regex' do
       expect { dsl.match(/123/) }.to raise_error("Regexp /123/ needs a group in it that defines which digits belong to the NDC.")
     end
-    it 'checks for ( in regex' do
-      dsl.match(/(123)/).should be_kind_of(Phony::NationalSplitters::Regex)
+    it 'should return a Phony::NationalSplitters::Regex' do
+      dsl.match(/(123)/).class.name.should == Phony::NationalSplitters::Regex.name
     end
   end
 

data/spec/lib/phony/local_splitters/regex_spec.rb

@@ -1,7 +1,14 @@
 require 'spec_helper'
 
+main = self
+
 describe Phony::LocalSplitters::Regex do
   
+  before do
+    load 'spec_helper_extensions.rb'
+    main.send :include, SpecHelperExtensions
+  end
+  
   describe 'instance_for' do
     it 'does not cache' do
       described_class.instance_for({}).should_not equal(described_class.instance_for({}))
@@ -53,35 +60,35 @@ describe Phony::LocalSplitters::Regex do
     context 'Local splitter without mappings' do
       let(:local_splitter) { described_class.instance_for({})}
       it 'returns false' do
-        result.should be_false
+        result.should be_falsey
       end
     end
 
     context 'Mapping does not exist for a number' do
       let(:local_splitter) { described_class.instance_for(/\A5/ => [1,2,3])}
       it 'returns false' do
-        result.should be_false
+        result.should be_falsey
       end
     end
 
     context "Mapping exists, but the length is greater" do
       let(:local_splitter) { described_class.instance_for(/\A123/ => [2,2])}
       it 'returns false' do
-        result.should be_false
+        result.should be_falsey
       end
     end
 
     context "Mapping exists, but the length is less" do
       let(:local_splitter) { described_class.instance_for(/\A123/ => [2,2,3])}
       it 'returns false' do
-        result.should be_false
+        result.should be_falsey
       end
     end
 
     context 'Mapping exists and the length is equal' do
       let(:local_splitter) { described_class.instance_for(/\A123/ => [2,2,2])}
       it 'returns true' do
-        result.should be_true
+        result.should be_truthy
       end
     end
 

data/spec/lib/phony/national_splitters/default_spec.rb

@@ -19,7 +19,7 @@ describe Phony::NationalSplitters::Default do
     
     describe 'plausible?' do
       it 'is always plausible' do
-        splitter.plausible?(:anything, :anything).should be_true
+        splitter.plausible?(:anything, :anything).should be_truthy
       end
     end
     

data/spec/lib/phony/trunk_code_spec.rb

@@ -0,0 +1,85 @@
+require 'spec_helper'
+
+describe Phony::TrunkCode do
+  
+  describe '#format' do
+    it 'is correct' do
+      code = described_class.new('0')
+      expect(code.format('%s %s')).to eq '0'
+    end
+    it 'is correct' do
+      code = described_class.new('0', format: true)
+      expect(code.format('%s %s')).to eq '0'
+    end
+    it 'is correct' do
+      code = described_class.new('0', format: false)
+      expect(code.format('%s %s')).to eq nil
+    end
+    it 'is correct' do
+      code = described_class.new('06')
+      expect(code.format('%s %s')).to eq '06'
+    end
+    it 'is correct' do
+      code = described_class.new('06', format: true)
+      expect(code.format('%s %s')).to eq '06'
+    end
+    it 'is correct' do
+      code = described_class.new('06', format: false)
+      expect(code.format('%s %s')).to eq nil
+    end
+  end
+  
+  describe '#normalize' do
+    it 'is correct' do
+      code = described_class.new('0')
+      expect(code.normalize('0123')).to eq '0123'
+    end
+    it 'is correct' do
+      code = described_class.new('0', normalize: true)
+      expect(code.normalize('0123')).to eq '0123'
+    end
+    it 'is correct' do
+      code = described_class.new('0', normalize: false)
+      expect(code.normalize('0123')).to eq '0123'
+    end
+    it 'is correct' do
+      code = described_class.new('06')
+      expect(code.normalize('06123')).to eq '06123'
+    end
+    it 'is correct' do
+      code = described_class.new('06', normalize: true)
+      expect(code.normalize('06123')).to eq '06123'
+    end
+    it 'is correct' do
+      code = described_class.new('06', normalize: false)
+      expect(code.normalize('0123')).to eq '0123'
+    end
+  end
+  
+  describe '#split' do
+    it 'is correct' do
+      code = described_class.new('0')
+      expect(code.split('0123')).to eq [code, '0123']
+    end
+    it 'is correct' do
+      code = described_class.new('0', split: true)
+      expect(code.split('0123')).to eq [code, '123']
+    end
+    it 'is correct' do
+      code = described_class.new('0', split: false)
+      expect(code.split('0123')).to eq [code, '0123']
+    end
+    it 'is correct' do
+      code = described_class.new('06')
+      expect(code.split('06123')).to eq [code, '06123']
+    end
+    it 'is correct' do
+      code = described_class.new('06', split: true)
+      expect(code.split('06123')).to eq [code, '123']
+    end
+    it 'is correct' do
+      code = described_class.new('06', split: false)
+      expect(code.split('06123')).to eq [code, '06123']
+    end
+  end
+end

data/spec/lib/phony/vanity_spec.rb

@@ -0,0 +1,30 @@
+# encoding: utf-8
+#
+require 'spec_helper'
+
+describe Phony::Vanity do
+  
+  let(:vanity) { described_class }
+
+  describe '.replace' do
+    it 'replaces letters with digits' do
+      vanity.replace('1-800-HELLO').should == '1-800-43556'
+    end
+  end
+  
+  describe '.vanity?' do
+    it 'returns true on a vanity number' do
+      vanity.vanity?('800HELLOES').should == true
+    end
+    it 'returns false on a non-vanity number' do
+      vanity.vanity?('8004355637').should == false
+    end
+  end
+  
+  describe '.normalized' do
+    it 'normalizes the vanity number' do
+      vanity.normalized('1-800-HELLO').should == '1800HELLO'
+    end
+  end
+
+end

data/spec/lib/phony_spec.rb

@@ -0,0 +1,70 @@
+require 'spec_helper'
+
+describe Phony::NormalizationError do
+  it 'is correctly raised on normalize' do
+    expect do
+      Phony.normalize('000')
+    end.to raise_error(Phony::NormalizationError)
+  end
+  it 'is correctly raised on normalize' do
+    expect do
+      Phony.normalize('000')
+    end.to raise_error(%Q{Phony could not normalize the given number. Is it a phone number?})
+  end
+  it 'is correctly raised on normalize!' do
+    expect do
+      Phony.normalize!('000')
+    end.to raise_error(Phony::NormalizationError)
+  end
+  it 'is correctly raised on normalize!' do
+    expect do
+      Phony.normalize!('000')
+    end.to raise_error(%Q{Phony could not normalize the given number. Is it a phone number?})
+  end
+end
+
+describe Phony::SplittingError do
+  it 'is correctly raised on split' do
+    expect do
+      Phony.split('000')
+    end.to raise_error(Phony::SplittingError)
+  end
+  it 'is correctly raised on split' do
+    expect do
+      Phony.split('000')
+    end.to raise_error(%Q{Phony could not split the given number. Is "000" a phone number?})
+  end
+  it 'is correctly raised on split!' do
+    expect do
+      Phony.split!('000')
+    end.to raise_error(Phony::SplittingError)
+  end
+  it 'is correctly raised on split!' do
+    expect do
+      Phony.split!('000')
+    end.to raise_error(%Q{Phony could not split the given number. Is it a phone number?})
+  end
+end
+
+describe Phony::FormattingError do
+  it 'is correctly raised on format' do
+    expect do
+      Phony.format('000')
+    end.to raise_error(Phony::FormattingError)
+  end
+  it 'is correctly raised on format' do
+    expect do
+      Phony.format('000')
+    end.to raise_error(%Q{Phony could not format the given number. Is it a phone number?})
+  end
+  it 'is correctly raised on format!' do
+    expect do
+      Phony.format!('000')
+    end.to raise_error(Phony::FormattingError)
+  end
+  it 'is correctly raised on format!' do
+    expect do
+      Phony.format!('000')
+    end.to raise_error(%Q{Phony could not format the given number. Is it a phone number?})
+  end
+end