phony 2.0.2 → 2.1.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    Y2RlOWNmOWMwNDk4YzU1ODgyMmYyMTYzYmQ1MjdlYWU2MzY3MDA5OA==
+    OTIxZGU3ZmFlODE0ZGE2ZDAwYWVlODk5N2VhZWJkNDgxNDdlYzg1ZQ==
   data.tar.gz: !binary |-
-    OTc1YjNlM2Y0ZTRhYzFiMjVhZGYzZjEzMDM1NDFmMDVhMjIxYzYzOQ==
-!binary "U0hBNTEy":
+    ODZmM2Q4MDE2YTQ1NGZjZjg0N2EyZTAwNzc2NDUyNTY1NzA3ZWY5Mw==
+SHA512:
   metadata.gz: !binary |-
-    NzQwNjNiYjVmNzMwM2M3YWIxOTU0MTc4MzRiZWMxYWFmYjQ2Y2NkMDdkNTU0
-    N2QyNzIxZGMwZWFiYzNiM2Q5ZDBkMWEwN2U0Y2QxMjY0NjZjZmI2ODc3OGIz
-    NWVkODNkY2NmMDkzOTA2YjA5NzJiZjc2MTYyNTc0NGMzNGZhMGI=
+    ZTA0OWFmMzAzYzVmZjU1ZGZmYjcxMjI5YjljMGE1NTY0ZjU1ZDk4ZjgzNzc5
+    ZTY0ZTFhMWIwYjI1ZTUyNWUxZWM1M2Q2NTVjNWI0OWM3MGI4ZGY5ODRhZjc3
+    MjM5MzEzNDc3ZmEzMmQwZmVlZGVhNjg0ZmJiZGIxZDIyODBjMTE=
   data.tar.gz: !binary |-
-    Y2VmYmU3MDMzOGNkZGMyNjk2NTgzNjhlMmIzNDBlYWIyMDUzNzNlYzY2NGUz
-    OWJhYTk2ZWQ5Zjk3ODUwYjc0NWRhYTVkYjk2YjlkNjkwY2QwMmJkODViMTli
-    YmJlYTNlMGE4YTA0MWYyYzBlYTA5OGRlMGRlY2I4MmRjMmQ5YTY=
+    OWM1NTM1YTE5ZDQ3NjQ2NWNiNzQzNzIxMjM1NGY5MTc4NjMyNzZiZDg0ZjI4
+    ZjUwOTQ1OWM4NmM4MjJiYzM0MDQwNTVkMDdkZjY2NjdlMzMzYzEyMmMzM2Vm
+    YjJmMmEyOWZhMzI5ZGU0NmU4NTkyZTgxMmVjNTU5ZjQyYTI0ZGY=

data/README.textile

@@ -3,16 +3,22 @@
 
 h1. Phony
 
-Used in e.g.: "airbnb.com":http://airbnb.com, "restorm.com":http://restorm.com, "socialcam.com":http://socialcam.com, "zendesk.com":http://www.zendesk.com/ (and many, many others).
+The (admittedly crazy) goal of this Gem is to be able to format/split all phone numbers in the world.
+
+Used in: "airbnb.com":http://airbnb.com, "restorm.com":http://restorm.com, "socialcam.com":http://socialcam.com, "zendesk.com":http://www.zendesk.com/ (and many, many others).
 
 There's also a Rails wrapper: https://github.com/joost/phony_rails.
 
 h2. Description
 
-This gem can normalize, format and split E164 numbers. E164 numbers are international numbers with a country dial prefix, usually an area code and a subscriber number. Here's an example from Australia: +61 412 345 678. 61 is the country code of Australia, 4 denotes a mobile number and 12 345 678 is the subscriber number.
-"More about E164 numbers in this Wiki":http://en.wikipedia.org/wiki/E.164.
+This gem normalizes, formats and splits *E164 phone numbers*. A valid E164 phone number *must* include a country code.
+
+E164 numbers are international numbers with a country dial prefix, usually an area code and a subscriber number. For example, the Austalian number number @+61 412 345 678@ can be broken down into the following components:
+* a country code of @61@
+* a mobile number denoted by the @4@ (specific to Australia)
+* a subscriber number of @12 345 678@
 
-The (admittedly crazy) *goal* of this Gem is to be able to format/split all phone numbers in the world.
+Learn more about E164 numbers "here":http://en.wikipedia.org/wiki/E.164.
 
 Currently handles Abhas, Afghan, Algerian, Argentinan, Austrian, Australian, Azerbaijani, Belgian, Brazilian, Cambodian, Chilean, Chinese, Croatian, Cuban, Cypriot, Czech, Danish, Dutch, Egyptian, El Salvadorian, Estonian, French, German, Ghanan, Gibraltar, Greek, Haiti, Hong Kong, Hungarian, Indian, Iran, Irish, Israel, Italian, Kazakh, Lithuanian, Luxembourgian, Malaysian, Malta, Mexican, Monaco, Morocco, New Zealand, Nigerian, Norwegian, Peruvian, Polish, Romanian, Russian, Rwandan, Seychelles, Singapore, Slovakian, South African, South Korean, South Osetian, Spanish, Sri Lankan, Sudan, Swedish, Swiss, Thailand, Tunisian, Turkish, Liechtenstein, UK, US, Venezuelan, and Vietnamese numbers.
 
@@ -22,9 +28,15 @@ If it doesn't, please "enter an issue":http://github.com/floere/phony/issues.
 
 h2. Installation
 
-<pre><code>gem install phony</code></pre>
+Using with Rails? Check out: https://github.com/joost/phony_rails.
+
+With Bundler:
+Append @gem 'phony'@ to your @Gemfile@ and @bundle install@ it.
+
+Without Bundler:
+Run @gem install phony@ from your command line.
 
-h2(#examples). Some examples
+h2(#usage). Usage
 
 h3(#plausibility). Plausibility
 

data/lib/phony.rb

@@ -24,6 +24,7 @@ require File.expand_path '../phony/countries/austria', __FILE__
 require File.expand_path '../phony/countries/bangladesh', __FILE__
 require File.expand_path '../phony/countries/belarus', __FILE__
 require File.expand_path '../phony/countries/brazil', __FILE__
+require File.expand_path '../phony/countries/cambodia', __FILE__
 require File.expand_path '../phony/countries/china', __FILE__
 require File.expand_path '../phony/countries/georgia', __FILE__
 require File.expand_path '../phony/countries/germany', __FILE__
@@ -67,13 +68,13 @@ module Phony
       super %Q{Phony could not normalize the given number. Is it a phone number?}
     end
   end
-    
+
   # Phony uses a single country codes instance.
   #
   @codes = CountryCodes.instance
 
   class << self
-    
+
     # Get the Country for the given CC.
     #
     # Example:

data/lib/phony/countries.rb

@@ -20,7 +20,7 @@
 # Note: The ones that are commented are defined in their special files.
 #
 Phony.define do
-  
+
   # Reserved.
   #
   country '0', fixed(1) >> split(10) # Reserved.
@@ -854,12 +854,6 @@ Phony.define do
   country '853', todo # Macao, China
   country '854', todo # Spare code
 
-  # Cambodia (Kingdom of)
-  # http://en.wikipedia.org/wiki/Telephone_numbers_in_Cambodia
-  country '855',
-          match(/^(1\d{1})/) >> split(3, 3) |
-          fixed(2) >> matched_split(/^\d{6}$/ => [3,3], /^\d{7}$/ => [3,4])
-
   # Lao People's Democratic Republic http://www.wtng.info/wtng-856-la.html, https://www.numberingplans.com
   country '856',
           one_of('30') >> split(3,4) | # geographic

data/lib/phony/countries/cambodia.rb

@@ -0,0 +1,86 @@
+# Cambodia (Kingdom of)
+# http://en.wikipedia.org/wiki/Telecommunications_in_Cambodia#Mobile_networks
+# http://en.wikipedia.org/wiki/Telephone_numbers_in_Cambodia
+# http://www.itu.int/dms_pub/itu-t/oth/02/02/T02020000230001MSWE.doc
+
+ndcs = [
+  '23', # Phnom Penh
+  '24', # Kandal
+  '25', # Kampong Speu
+  '26', # Kampong Chhnang
+  '32', # Takeo
+  '33', # Kampot
+  '34', # Sihanoukville
+  '35', # Koh Kong
+  '36', # Kep
+  '42', # Kampong Cham
+  '43', # Prey Veng
+  '44', # Svay Rieng
+  '52', # Pursat
+  '53', # Battambang
+  '54', # Banteay Meanchey
+  '55', # Pailin
+  '62', # Kampong Thom
+  '63', # Siem Reap
+  '64', # Preah Vihear
+  '65', # Oddar Meanchey
+  '72', # Kratie
+  '73', # Mondulkiri
+  '74', # Stung Treng
+  '75', # Ratanakiri
+]
+
+six_digit_mobile_prefixes = [
+  '60', # Beeline
+  '66', # Beeline
+  '67', # Beeline
+  '68', # Beeline
+  '90', # Beeline
+  '11', # Mobitel
+  '17', # Mobitel
+  '61', # Mobitel
+  '77', # Mobitel
+  '78', # Mobitel
+  '85', # Mobitel
+  '89', # Mobitel
+  '92', # Mobitel
+  '95', # Mobitel
+  '99', # Mobitel
+  '18', # Excell
+  '13', # qb
+  '80', # qb
+  '83', # qb
+  '84', # qb
+  '10', # Smart
+  '15', # Smart
+  '16', # Smart
+  '69', # Smart
+  '70', # Smart
+  '81', # Smart
+  '86', # Smart
+  '87', # Smart
+  '93', # Smart
+  '98', # Smart
+]
+
+seven_digit_mobile_prefixes = [
+  '31', # Beeline
+  '38', # CooTel
+  '76', # Mobitel
+  '88', # Metfone
+  '96', # Smart
+  '97', # Metfone
+]
+
+six_or_seven_digit_mobile_prefixes = [
+  '12' # Mobitel
+]
+
+Phony.define do
+  country '855', one_of(six_digit_mobile_prefixes)   >> matched_split(/^[1-9]/ => [3, 3]) |
+                 one_of(seven_digit_mobile_prefixes) >> matched_split(/^[2-9]/ => [3, 4]) |
+                 one_of(six_or_seven_digit_mobile_prefixes) >> matched_split(
+                   /^[2-9]\d{5}$/ => [3, 3], /^[1-9]\d{6}$/ => [3, 4]
+                 ) |
+                 one_of(ndcs) >> matched_split(/^[2-9]\d{5}$/ => [3, 3], /^[2-9]\d{6}$/ => [3, 4])
+end

data/lib/phony/countries/italy.rb

@@ -4,93 +4,95 @@
 #
 
 ndcs_2digit = [
-   '02', # Milan
-   '06', # Rome (including State of Vatican City) and Aprilia
+  '02', # Milan
+  '06', # Rome (including State of Vatican City) and Aprilia
 ]
 
-ndcs = [
-  '010', # Genoa
-  '011', # Turin
- '0122', # Sestrieres, Bardonecchia and other Susa Valley mountain resorts
- '0125', # Ivrea
- '0131', # Alessandria
- '0141', # Asti
-  '015', # Biella
- '0161', # Vercelli
- '0165', # Aosta, Courmayeur
- '0166', # Cervinia
- '0171', # Cuneo
- '0185', # Tigullio
- '0187', # La Spezia and Cinque Terre
-  '019', # Savona
-  '030', # Brescia
-  '031', # Como
- '0321', # Novara
- '0331', # Varese
- '0341', # Lecco
- '0342', # Sondrio
-  '035', # Bergamo
- '0369', # Mediaset Cologno Monzese and Segrate TV studios, geographical rate (used for polls, television programs, etc.)
- '0376', # Mantua
- '0382', # Pavia
-  '039', # Monza
-  '040', # Trieste
-  '041', # Venice
- '0425', # Rovigo
- '0432', # Udine
- '0444', # Vicenza
-  '045', # Verona
- '0461', # Trento
- '0471', # Bolzano
- '0481', # Gorizia
-  '049', # Padua
-  '050', # Pisa
-  '051', # Bologna
- '0521', # Parma
- '0522', # Reggio nell'Emilia
- '0523', # Piacenza
- '0532', # Ferrara
- '0536', # Sassuolo
- '0541', # Rimini
- '0549', # San Marino (Most Serene Republic of San Marino)
-  '055', # Florence
- '0573', # Pistoia
- '0577', # Siena
- '0586', # Livorno
-  '059', # Modena
-  '070', # Cagliari
-  '071', # Ancona
-  '075', # Perugia
- '0769', # RAI Saxa Rubra Studios, geographical rate (used for polls, television programs, etc.)
- '0771', # Fondi
- '0773', # Latina
- '0775', # Frosinone
- '0789', # Olbia and Costa Smeralda
-  '079', # Sassari
-  '080', # Bari
-  '081', # Naples
- '0823', # Caserta
- '0824', # Benevento
- '0825', # Avellino
-  '085', # Pescara
- '0865', # Isernia
- '0871', # Chieti
- '0872', # Lanciano
- '0873', # Vasto
- '0874', # Campobasso
- '0875', # Termoli
- '0881', # Foggia
-  '089', # Salerno
-  '090', # Messina
-  '091', # Palermo
-  '092', # Agrigento
-  '095', # Catania
- '0961', # Catanzaro
- '0965', # Reggio di Calabria
- '0971', # Potenza
-  '099', # Taranto
- ]
+ndcs_3digit = [
+ '010', # Genoa
+ '011', # Turin
+ '015', # Biella
+ '019', # Savona
+ '030', # Brescia
+ '031', # Como
+ '035', # Bergamo
+ '039', # Monza
+ '040', # Trieste
+ '041', # Venice
+ '045', # Verona
+ '049', # Padua
+ '050', # Pisa
+ '051', # Bologna
+ '055', # Florence
+ '059', # Modena
+ '070', # Cagliari
+ '071', # Ancona
+ '075', # Perugia
+ '079', # Sassari
+ '080', # Bari
+ '081', # Naples
+ '085', # Pescara
+ '089', # Salerno
+ '090', # Messina
+ '091', # Palermo
+ '092', # Agrigento
+ '095', # Catania
+ '099', # Taranto
+]
 
+ndcs_4digit = [
+  '0122', # Sestrieres, Bardonecchia and other Susa Valley mountain resorts
+  '0125', # Ivrea
+  '0131', # Alessandria
+  '0141', # Asti
+  '0161', # Vercelli
+  '0165', # Aosta, Courmayeur
+  '0166', # Cervinia
+  '0171', # Cuneo
+  '0185', # Tigullio
+  '0187', # La Spezia and Cinque Terre
+  '0321', # Novara
+  '0331', # Varese
+  '0341', # Lecco
+  '0342', # Sondrio
+  '0369', # Mediaset Cologno Monzese and Segrate TV studios, geographical rate (used for polls, television programs, etc.)
+  '0376', # Mantua
+  '0382', # Pavia
+  '0425', # Rovigo
+  '0432', # Udine
+  '0444', # Vicenza
+  '0461', # Trento
+  '0471', # Bolzano
+  '0481', # Gorizia
+  '0521', # Parma
+  '0522', # Reggio nell'Emilia
+  '0523', # Piacenza
+  '0532', # Ferrara
+  '0536', # Sassuolo
+  '0541', # Rimini
+  '0549', # San Marino (Most Serene Republic of San Marino)
+  '0573', # Pistoia
+  '0577', # Siena
+  '0586', # Livorno
+  '0769', # RAI Saxa Rubra Studios, geographical rate (used for polls, television programs, etc.)
+  '0771', # Fondi
+  '0773', # Latina
+  '0775', # Frosinone
+  '0789', # Olbia and Costa Smeralda
+  '0823', # Caserta
+  '0824', # Benevento
+  '0825', # Avellino
+  '0865', # Isernia
+  '0871', # Chieti
+  '0872', # Lanciano
+  '0873', # Vasto
+  '0874', # Campobasso
+  '0875', # Termoli
+  '0881', # Foggia
+  '0961', # Catanzaro
+  '0965', # Reggio di Calabria
+  '0971', # Potenza
+]
 
 mobile = [
  '310',
@@ -153,8 +155,9 @@ service = [ # Not exhaustive.
 
 Phony.define do
   country '39', trunk('0', :normalize => false) |
-                one_of(*service)                >> split(3,3) |
-                one_of(*mobile)                 >> split(3,4) |
-                one_of(*ndcs_2digit)            >> split(4,4) |
-                one_of(*ndcs, :max_length => 3) >> split(3,4)
+                one_of(*service)     >> split(3,3) |
+                one_of(*mobile)      >> split(3,4) |
+                one_of(*ndcs_2digit) >> split(4,4) |
+                one_of(*ndcs_3digit) >> split(3,4) |
+                one_of(*ndcs_4digit) >> split(3,3)
 end

data/lib/phony/country.rb

@@ -45,13 +45,28 @@ module Phony
       end
     end
     
-    def countrify! number
-      # The sensible default is to add the country code
-      # if it does not already start with it.
-      #
-      # Note: This won't be correct in some cases, but it is the best we can do.
+    # TODO This is now in country_codes and country.
+    #
+    @@basic_cleaning_pattern = /\D/
+    def clean number
+      clean! number && number.dup
+    end
+    def clean! number
+      # Remove non-digit chars.
       #
-      number.sub! /\b#{@cc}?/, @cc
+      number.gsub!(@@basic_cleaning_pattern, EMPTY_STRING) || number
+    end
+    
+    # Adds the country code to the front
+    # if it does not already start with it.
+    #
+    # Note: This won't be correct in some cases, but it is the best we can do.
+    #
+    def countrify number
+      countrify! number || number
+    end
+    def countrify! number
+      number.sub! /\A(?!#{@cc})?/, @cc
     end
     
     # Removes 0s from partially normalized numbers
@@ -63,11 +78,15 @@ module Phony
     # In some cases it doesn't, like Italy.
     #
     def normalize national_number
-      @codes.each do |code|
-        normalized = code.normalize national_number
-        return normalized if normalized && !normalized.empty?
+      clean! national_number
+      normalized = @codes.reduce(national_number) do |number, code|
+        result = code.normalize number
+        break result if result
+        number
       end
-      return nil
+      return unless normalized
+      countrify! normalized
+      normalized
     end
     
     # Tests for plausibility of this national number.

data/lib/phony/country_codes.rb

@@ -14,8 +14,7 @@ module Phony
       @international_relative_format = '00%s%s%s'
       @national_format               = '%s%s'
 
-      @normalize_format = '%s%s'
-      @default_space    = ' '
+      @default_space = ' '
     end
 
     def self.instance
@@ -27,6 +26,18 @@ module Phony
     def [] cc
       countries[cc.size][cc]
     end
+    
+    # TODO This is now in country_codes and country.
+    #
+    @@basic_cleaning_pattern = /\A00?|\(0\)|\D/
+    def clean number
+      clean! number && number.dup
+    end
+    def clean! number
+      # Remove non-digit chars.
+      #
+      number.gsub!(@@basic_cleaning_pattern, EMPTY_STRING) || number
+    end
 
     # 00 for the standard international call prefix.
     # http://en.wikipedia.org/wiki/List_of_international_call_prefixes
@@ -39,28 +50,15 @@ module Phony
     #  * (0) anywhere.
     #  * Non-digits.
     #
-    @@basic_cleaning_pattern = /^00?|\(0\)|\D/
-    def clean number
-      clean! number && number.dup
-    end
-    def clean! number
-      # Remove non-digit chars.
-      #
-      number.gsub!(@@basic_cleaning_pattern, EMPTY_STRING) || number
-    end
     def normalize number, options = {}
-      clean! number
-      countrify! number, options
-      country, cc, rest = split_cc number
-      @normalize_format % [cc, country.normalize(rest)]
-    end
-    
-    #
-    #
-    def countrify! number, options = {}
-      if cc = options[:cc]
-        self[cc].countrify! number
+      country = if cc = options[:cc]
+        self[cc]
+      else
+        clean! number
+        country, cc, number = split_cc number
+        country
       end
+      country.normalize number
     end
 
     # Splits this number into cc, ndc and locally split number parts.

data/lib/phony/national_code.rb

@@ -27,7 +27,7 @@ module Phony
     # Note: Some cases, like Italy, don't remove the relative zero.
     #
     def normalize national_number
-      national_number.gsub(/\A0+/, EMPTY_STRING)
+      national_number.gsub /\A0+/, EMPTY_STRING
     end
 
   end

data/lib/phony/trunk_code.rb

@@ -22,9 +22,7 @@ module Phony
       national_number.gsub! @trunk_code_replacement, EMPTY_STRING if @split
       return [@code, national_number]
     end
-
-    # Never normalizes.
-    # 
+    
     def normalize national_number
       return national_number unless @normalize
       national_number.gsub @trunk_code_replacement, EMPTY_STRING

data/spec/functional/plausibility_spec.rb

@@ -154,6 +154,7 @@ describe 'plausibility' do
         Phony.plausible?('+39 06 1234 4567').should be_true
         Phony.plausible?('+39 335 123 4567').should be_true
         Phony.plausible?('+39 335 123').should be_false
+        Phony.plausible?('+39 0471 123 456').should be_true
       end
       it 'is correct for German numbers' do
         Phony.plausible?('+49 209 169 - 0').should be_true # Gelsenkirchen
@@ -164,20 +165,20 @@ describe 'plausibility' do
         Phony.plausible?('+49 171 123 45678').should be_false
         Phony.plausible?('+49 177 123 1234').should be_true
         Phony.plausible?('+49 176 123 12345').should be_true
-        # Phony.plausible?('+49 991 1234').should be_true   # stricter 3 digit ndc rules
+        Phony.plausible?('+49 991 1234').should be_true   # stricter 3 digit ndc rules
         Phony.plausible?('+49 2041 123').should be_true # Grandfathered numbers.
         Phony.plausible?('+49 2041 1234567').should be_true
-        # Phony.plausible?('+49 2041 12345689').should be_false # Could be a call-through number
+        Phony.plausible?('+49 2041 12345689').should be_false # Could be a call-through number
         Phony.plausible?('+49 31234 123456').should be_true
-        # Phony.plausible?('+49 31234 1234567').should be_false # Could be a call-through number
+        Phony.plausible?('+49 31234 1234567').should be_false # Could be a call-through number
       end
 
-      it 'is correct for Isralian numbers' do
+      it 'is correct for Israelian numbers' do
         Phony.plausible?('+972 2 123 1234').should be_true
         Phony.plausible?('+972 59 123 1234').should be_true
       end
       it "is correct for US numbers" do
-        # Sorry, still need E164 conform numbers.
+        # Still need E164 conform numbers.
         #
         Phony.plausible?('4346667777', cc: '1').should be_false
 
@@ -327,18 +328,53 @@ describe 'plausibility' do
       it_is_correct_for 'Burundi', :samples => '+257  1234 5678'
 
       it 'is correct for Cambodia' do
-        # 7 digit identifiers
-        Phony.plausible?("+855965787807").should be_true    # Smart
-        Phony.plausible?("+855312067777").should be_true    # Beeline
-        Phony.plausible?("+855383001801").should be_true    # CooTel
-        Phony.plausible?("+855973001801").should be_true    # Metfone
-        Phony.plausible?("+855883001801").should be_true    # Metfone
-        Phony.plausible?("+85510234567").should be_true     # Smart
-        Phony.plausible?("+85511234564").should be_true     # Mobitel (former Mfone)
-        Phony.plausible?("+855 12 236 142").should be_true  # Mobitel
-        Phony.plausible?("+855 234 601 183").should be_true # Long fixed line (Phnom Penh)
-        Phony.plausible?("855 33 123 456").should be_true   # Regular fixed line (Kampot)
-        Phony.plausible?("+855102345678").should be_false   # Too many digits for a 01 prefix
+        # http://en.wikipedia.org/wiki/Telecommunications_in_Cambodia#Mobile_networks
+        # http://en.wikipedia.org/wiki/Telephone_numbers_in_Cambodia
+        # http://www.itu.int/dms_pub/itu-t/oth/02/02/T02020000230001MSWE.doc
+
+        Phony.plausible?("+855312345678").should be_true     # Beeline (7 digit id)
+        Phony.plausible?("+85531234567").should be_false     # Beeline (too short)
+        Phony.plausible?("+85560234567").should be_true      # Beeline (6 digit id)
+        Phony.plausible?("+855602345678").should be_false    # Beeline (too long)
+
+        Phony.plausible?("+855762345678").should be_true     # Mobitel (7 digit id)
+        Phony.plausible?("+85576234567").should be_false     # Mobitel (too short)
+        Phony.plausible?("+85517234567").should be_true      # Mobitel (6 digit id)
+        Phony.plausible?("+855172345678").should be_false    # Mobitel (too long)
+        Phony.plausible?("+85512234567").should be_true      # Mobitel (6 digit id)
+        Phony.plausible?("+855121345678").should be_true     # Mobitel (7 digit id)
+        Phony.plausible?("+85512123456").should be_false     # Mobitel (6 digit invalid)
+
+        Phony.plausible?("+855383001801").should be_true     # CooTel (7 digit id)
+        Phony.plausible?("+85538300180").should be_false     # CooTel (too short)
+
+        Phony.plausible?("+85518234567").should be_true      # Excell (6 digit id)
+        Phony.plausible?("+855182345678").should be_false    # Excell (too long)
+
+        Phony.plausible?("+855882345678").should be_true     # Metfone (7 digit id)
+        Phony.plausible?("+85588234567").should be_false     # Metfone (too short)
+        Phony.plausible?("+855972345678").should be_true     # Metfone (7 digit id)
+        Phony.plausible?("+85597234567").should be_false     # Metfone (too short)
+
+        Phony.plausible?("+85513234567").should be_true      # qb (6 digit id)
+        Phony.plausible?("+855132345678").should be_false    # qb (too long)
+
+        Phony.plausible?("+855962345678").should be_true     # Smart (7 digit id)
+        Phony.plausible?("+85596234567").should be_false     # Smart (too short)
+        Phony.plausible?("+85510234567").should be_true      # Smart (6 digit id)
+        Phony.plausible?("+855102345678").should be_false    # Smart (too long)
+
+        # AXXXXX (A must be between 1 and 9)
+        Phony.plausible?("+85512023456").should be_false     # invalid numbering plan
+        Phony.plausible?("+855380234567").should be_false    # invalid numbering plan
+        Phony.plausible?("+85592123456").should be_true      # valid for 6 digit id
+
+        Phony.plausible?("+85514234567").should be_false     # invalid mobile operator
+        Phony.plausible?("+85527234567").should be_false     # invalid ndc
+
+        Phony.plausible?("+85523471234").should be_true      # Fixed line (NDC + '47' + 4 digit id)
+        Phony.plausible?("+855234712345").should be_true     # Fixed line (NDC + '47' + 5 digit id)
+        Phony.plausible?("+85523123456").should be_false     # Fixed line (NDC + invalid A)
       end
 
       it_is_correct_for 'Cameroon', :samples => '+237  7372 8186'

data/spec/lib/phony/countries_spec.rb

@@ -123,7 +123,7 @@ describe 'country descriptions' do
       it_splits '85512236142', ["855", "12", "236", "142"]   # mobile (Mobitel)
       it_splits '855977100872', ["855", "97", "710", "0872"] # mobile (Metfone)
       it_splits '855234601183', ["855", "23", "460", "1183"] # Long fixed line (Phnom Penh)
-      it_splits '85533123456', ["855", "33", "123", "456"]   # Regular fixed line (Kampot)
+      it_splits '85533234567', ["855", "33", "234", "567"]   # Regular fixed line (Kampot)
     end
     describe 'Chile' do
       it_splits '5621234567', ['56', '2', '1234567']       # Santiago
@@ -334,6 +334,7 @@ describe 'country descriptions' do
       it_splits '390141595661', ['39', '0141', '595', '661'] # Asti
       it_splits '3903123391',   ['39', '031', '233', '91']   # Como
       it_splits '390909709511', ['39', '090', '970', '9511'] # Barcellona
+      it_splits '390471811353', ['39', '0471', '811', '353'] # Bolzano
     end
     describe 'Japan' do
       it_splits '81312345678', %w(81 3 1234 5678)

data/spec/lib/phony/country_spec.rb

@@ -24,6 +24,7 @@ describe Phony::Country do
       national_code     = Phony::NationalCode.new national_splitter, local_splitter
       
       @switzerland      = Phony::Country.new national_code
+      @switzerland.with '41' # TODO Remove this kludge.
     end
     
     describe "split" do
@@ -33,7 +34,7 @@ describe Phony::Country do
     end
     describe 'normalize' do
       it "should handle ZH" do
-        @switzerland.normalize('0443643532').should == '443643532'
+        @switzerland.normalize('0443643532').should == '41443643532'
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: phony
 version: !ruby/object:Gem::Version
-  version: 2.0.2
+  version: 2.1.0
 platform: ruby
 authors:
 - Florian Hanke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-16 00:00:00.000000000 Z
+date: 2014-01-06 00:00:00.000000000 Z
 dependencies: []
 description: ! 'Fast international phone number (E164 standard) normalizing, splitting
   and formatting. Lots of formatting options: International (+.., 00..), national
@@ -19,10 +19,14 @@ extensions: []
 extra_rdoc_files:
 - README.textile
 files:
+- README.textile
+- lib/phony.rb
+- lib/phony/countries.rb
 - lib/phony/countries/austria.rb
 - lib/phony/countries/bangladesh.rb
 - lib/phony/countries/belarus.rb
 - lib/phony/countries/brazil.rb
+- lib/phony/countries/cambodia.rb
 - lib/phony/countries/china.rb
 - lib/phony/countries/georgia.rb
 - lib/phony/countries/germany.rb
@@ -54,7 +58,6 @@ files:
 - lib/phony/countries/united_kingdom.rb
 - lib/phony/countries/uruguay.rb
 - lib/phony/countries/zimbabwe.rb
-- lib/phony/countries.rb
 - lib/phony/country.rb
 - lib/phony/country_codes.rb
 - lib/phony/dsl.rb
@@ -69,8 +72,6 @@ files:
 - lib/phony/national_splitters/variable.rb
 - lib/phony/trunk_code.rb
 - lib/phony/vanity.rb
-- lib/phony.rb
-- README.textile
 - spec/functional/normalize_spec.rb
 - spec/functional/plausibility_spec.rb
 - spec/lib/phony/countries_spec.rb
@@ -106,7 +107,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.2.0
 signing_key: 
 specification_version: 4
 summary: Fast international phone number (E164 standard) normalizing, splitting and