phony 1.4.6 → 1.5.0

data/lib/phony.rb

@@ -45,6 +45,7 @@ module Phony
     # Useful before inserting the number into a database.
     #
     def normalize phone_number
+      raise ArgumentError, "Phone number cannot be nil. Use e.g. number && Phony.normalize(number)." unless phone_number
       normalize! phone_number.dup
     end
     def normalize! phone_number
@@ -54,6 +55,7 @@ module Phony
     # Splits the phone number into pieces according to the country codes.
     #
     def split phone_number
+      raise ArgumentError, "Phone number cannot be nil. Use e.g. number && Phony.split(number)." unless phone_number
       split! phone_number.dup
     end
     def split! phone_number
@@ -63,6 +65,7 @@ module Phony
     # Formats a E164 number according to local customs.
     #
     def format phone_number, options = {}
+      raise ArgumentError, "Phone number cannot be nil. Use e.g. number && Phony.format(number)." unless phone_number
       formatted! phone_number.dup, options
     end
     def format! phone_number, options = {}

data/spec/lib/phony_spec.rb

@@ -4,6 +4,24 @@ require 'spec_helper'
 
 describe Phony do
   
+  describe 'nil cases' do
+    it "should raise on normalize nil" do
+      expect {
+        Phony.normalize(nil)
+      }.to raise_error(ArgumentError, "Phone number cannot be nil. Use e.g. number && Phony.normalize(number).")
+    end
+    it "should raise on format nil" do
+      expect {
+        Phony.format(nil)
+      }.to raise_error(ArgumentError, "Phone number cannot be nil. Use e.g. number && Phony.format(number).")
+    end
+    it "should raise on split nil" do
+      expect {
+        Phony.split(nil)
+      }.to raise_error(ArgumentError, "Phone number cannot be nil. Use e.g. number && Phony.split(number).")
+    end
+  end
+  
   describe "normalize" do
     describe "some examples" do
       it "should normalize an already normalized number" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: phony
 version: !ruby/object:Gem::Version
-  version: 1.4.6
+  version: 1.5.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-10-11 00:00:00.000000000 +02:00
+date: 2011-10-12 00:00:00.000000000 +02:00
 default_executable: 
 dependencies: []
 description: ! 'Fast international phone number (E164 standard) normalizing, splitting