phony 1.1.6 → 1.1.7

data/README.textile

@@ -5,7 +5,7 @@ h2. Description
 This gem can normalize, format and split E164 numbers.
 "More about E164 numbers in this Wiki":http://en.wikipedia.org/wiki/E.164.
 
-Currently handles Austrian, Australian, Belgian, Czech, Egyptian, French, German, Greek, Hungarian, Italian, (The) Netherlands, New Zealand, Norwegian, Polish, Russian, South African, Spanish, Swiss, Liechtenstein, US numbers.
+Currently handles Afghan, Austrian, Australian, Belgian, Brazilian, Chilean, Czech, Danish, Dutch, Egyptian, French, German, Greek, Hungarian, Italian, (The) Netherlands, New Zealand, Norwegian, Peruvian, Polish, Russian, Romanian, South African, Spanish, Swedish, Swiss, Liechtenstein, US, Venezuelan numbers.
 And to some extend, all others. Just try if it works for you.
 
 h2. Installation

data/lib/phony/countries/all_other.rb

@@ -97,8 +97,10 @@ module Phony
           ), # http://en.wikipedia.org/wiki/Telephone_numbers_in_Brazil
           '56' => Countries::Chile,
           '57' => fixed(2), # TODO Colombia (Republic of)
-          '58' => fixed(2), # TODO Venezuela (Bolivarian Republic of)
-
+          '58' => fixed(3,  # Venezuela (Bolivarian Republic of)
+                        :local_format => [7]
+          ),
+          
           '60' => fixed(2), # TODO Malaysia
           '61' => fixed(1,  # Australia
                         :local_format => [4, 4]
@@ -108,25 +110,27 @@ module Phony
           '64' => fixed(1,  # New Zealand
                         :local_format => [3, 4]
                   ),
-          # TODO From here on.
-          #
-          '65' => fixed(2), # Singapore (Republic of)
-          '66' => fixed(2), # Thailand
+          '65' => fixed(2), # TODO Singapore (Republic of)
+          '66' => fixed(2), # TODO Thailand
 
-          '81' => fixed(2), # Japan
-          '82' => fixed(2), # Korea (Republic of)
-          '84' => fixed(2), # Viet Nam (Socialist Republic of)
-          '86' => fixed(2), # China (People's Republic of)
+          '81' => fixed(2), # TODO Japan
+          '82' => fixed(2), # TODO Korea (Republic of)
+          '84' => fixed(2), # TODO Viet Nam (Socialist Republic of)
+          '86' => fixed(2), # TODO China (People's Republic of)
 
-          '90' => fixed(2), # Turkey
-          '91' => fixed(2), # India (Republic of)
-          '92' => fixed(2), # Pakistan (Islamic Republic of)
-          '93' => fixed(2), # Afghanistan
-          '94' => fixed(2), # Sri Lanka (Democratic Socialist Republic of)
-          '95' => fixed(2), # Myanmar (Union of)
-          '98' => fixed(2), #Iran (Islamic Republic of)
+          '90' => fixed(2), # TODO Turkey
+          '91' => fixed(2), # TODO India (Republic of)
+          '92' => fixed(2), # TODO Pakistan (Islamic Republic of)
+          '93' => fixed(2,  # Afghanistan
+                        :local_format => [7] # Actually, the document says 6, but the examples use 7.
+          ), # http://www.wtng.info/wtng-93-af.html
+          '94' => fixed(2), # TODO Sri Lanka (Democratic Socialist Republic of)
+          '95' => fixed(2), # TODO Myanmar (Union of)
+          '98' => fixed(2), # TODO Iran (Islamic Republic of)
         },
         3 => {
+          # TODO From here on.
+          #
           '210' => fixed(2), # -
           '211' => fixed(2), # -
           '212' => fixed(2), # Morocco

data/spec/lib/phony/countries/germany_spec.rb

@@ -22,6 +22,9 @@ describe Phony::Countries::Germany do
     it "should handle service numbers with 180 [regression]" do
       @germany.split('1805878323').should == ['180', '587', '8323']
     end
+    it "should handle service numbers with 181 [regression]" do
+      @germany.split('1815878323').should == ['181', '587', '8323']
+    end
   end
   
 end

data/spec/lib/phony_spec.rb

@@ -5,6 +5,9 @@ require 'spec_helper'
 describe Phony do
   
   describe "split" do
+    it 'handles afghan numbers' do
+      Phony.split('93201234567').should == ['93', '20', '1234567'] # Kabul
+    end
     it "should handle austrian numbers" do
       Phony.split('43198110').should == ['43', '1', '98110']
     end
@@ -13,7 +16,7 @@ describe Phony do
     end
     it 'handles chilean numbers' do
       Phony.split('5621234567').should == ['56', '2', '1234567']   # Santiago
-      Phony.split('5675123456').should == ['56', '75', '123456']    # Curico
+      Phony.split('5675123456').should == ['56', '75', '123456']   # Curico
       Phony.split('56912345678').should == ['56', '9', '12345678'] # mobile
     end
     it 'handles danish numbers' do
@@ -71,6 +74,9 @@ describe Phony do
     it "should handle US numbers" do
       Phony.split('15551115511').should == ['1', '555', '111', '5511']
     end
+    it "should handle venezuelan numbers" do
+      Phony.split('582121234567').should == ["58", "212", "1234567"]
+    end
     it "should handle new zealand numbers" do
       Phony.split('6491234567').should == ['64', '9', '123', '4567']
     end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 1
   - 1
-  - 6
-  version: 1.1.6
+  - 7
+  version: 1.1.7
 platform: ruby
 authors: 
 - Florian Hanke