phone_gap-build 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 12844dadae8e2b81b176ddcf2d7b3f28d18403b9
-  data.tar.gz: 0593bbe7132d9c502057e7d2a5bdbc046f8d68c5
+  metadata.gz: 2e0c5f823e46d6457be86cb5297cd24b461aa5fc
+  data.tar.gz: 792c13d4c77551350b495716467a691c6850aabb
 SHA512:
-  metadata.gz: 7baeb0e1accd202d53dd2f1f143fffc27b27801a38f7df9d9e81fabf731141f1e54702fb6afbe59edd547cde74594c628c7220fab186a95310bf0ded95e00e9f
-  data.tar.gz: b66b04811b0acbd665c740b60ec5048e8027349d0d72ef6c7eaf8617c269c5d31a38d9ebbd278bc9878db918f78fe5041f83f6c1dc97a46da61ae483a10e95c3
+  metadata.gz: 619c405c7655213e187d098711b087b272981d3896a9741fbdef2a99db832cefe4124ec6d17e65023da43c4b358f08bf783f3587d70726ffaed8da079d13c1d3
+  data.tar.gz: 6c6661f1685aa071b3858fda80a482c74525496662e11fca7cdd68ea35142108b6c4fbc50581698c58897f6af0c23632a82ca1ce73a900153d871373debfcade

data/lib/phone_gap/build/app.rb

@@ -28,6 +28,7 @@ module PhoneGap
         ApiRequest.new.post("#{PATH}/#{id}/build")
       end
 
+      # @TODO fix this ugly method!
       def build_complete?(params = {})
         complete = false
         error = false
@@ -37,12 +38,13 @@ module PhoneGap
           response = ApiRequest.new.get("#{PATH}/#{id}")
           if response.success?
             json_object = JSON.parse(response.body)
-            complete = json_object['status'].all? { |platform, status| status == 'complete' }
+            complete = json_object['status'].all? { |platform, status| %w(complete skip).include?(status) }
             error = json_object['status'].any? { |platform, status| status == 'error' }
           end
           sleep (params[:poll_interval] || poll_interval) unless complete or error
         end
         raise BuildError.new('An error occurred building at least one of the apps.') if error
+        raise BuildError.new('Builds did not complete within the allotted time.') if !error && !complete
         complete
       end
     end

data/lib/phone_gap/build/version.rb

@@ -1,5 +1,5 @@
 module PhoneGap
   module Build
-    VERSION = '0.5.0'
+    VERSION = '0.5.1'
   end
 end

data/spec/phone_gap/build/app_spec.rb

@@ -100,7 +100,7 @@ describe PhoneGap::Build::App do
 
     describe '#build_complete?' do
 
-      let(:http_response) { double('http response', success?: false) }
+      let(:http_response) { double('http response', success?: true, body: '{"status": { "ios": "complete"}}') }
 
       before do
         api_request.stub(:get).with("/apps/#{id}").and_return http_response
@@ -152,6 +152,15 @@ describe PhoneGap::Build::App do
           end
         end
 
+        context 'when the build doesnt complete' do
+
+          let(:http_response) { double('http response', success?: true, body: '{"status": { "ios": "nil"}}') }
+
+          it 'returns throws an exception' do
+            expect{subject.build_complete?}.to raise_error PhoneGap::Build::BuildError
+          end
+        end
+
         context 'when there was an error building' do
 
           let(:http_response) { double('http response', success?: true, body: '{"status": { "ios": "error"}}') }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: phone_gap-build
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Seb Glazebrook
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-22 00:00:00.000000000 Z
+date: 2014-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httmultiparty