phlex-reactive 0.4.4 → 0.4.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 68b6f765fc61e5be0b5c338effc94c2c4b283aa64d54f916e44767b4aecf62b9
-  data.tar.gz: e8c2e1c676b6d40d2d89e6acada741c2712746fd9e1bd5b9f54770c730a679b9
+  metadata.gz: 781352f05403f22ccf974061e325f0066b9809c20de36a881279fcea424c55a5
+  data.tar.gz: dfd1747be189e0c451f390f396d535aa5c36f7e0fd8d95f31a331a584537976c
 SHA512:
-  metadata.gz: 23c24dcacc6defa4d9479c82aa4cd01778e7a7e02cbe2893ef18539becab491de69195d7da50a5876001633e8f3bfe73a582298a7b4161f2d3f4d5c882caef76
-  data.tar.gz: a2373220f92ad0a9b84ef2ab555b0d6453e889792a334cb89a46d221acd4d6bce64864aa0b7b32e493461613d7fce076f46eb1fe3565a6eb91a7b19b47f01b36
+  metadata.gz: 14e5f543ebb18929407b21a90f6851fcbc685954d23c2ef9aa6a37ed770c85bdf7d477bb430799f81837d04a31154ea85343406e6767f128862fecec82aca401
+  data.tar.gz: 55d32359caa8bb5aa7be4b8db1c55cdf58651b08361dd4bd5e87e4b7bf50dd4cdb32d3aaede40be35966e28cf994ff8047006c085f17fc9002bc26f9cc3cf4d7

data/app/javascript/phlex/reactive/reactive_controller.js

@@ -168,9 +168,22 @@ export default class extends Controller {
   // a per-controller promise makes each dispatch wait for the previous one, so
   // it always uses the freshest token.
   dispatch(event) {
-    const { action, params, debounce } = event.params
+    const { action, params, debounce, confirm } = event.params
     if (!action) return
 
+    // Confirmation gate (issue #52). A destructive reactive trigger can't use
+    // Hotwire's data-turbo-confirm — this controller preempts the event — so a
+    // `confirm:` message threads a data-reactive-confirm-param and we prompt
+    // HERE, BEFORE any preventDefault/enqueue/debounce. On decline we still
+    // preventDefault (so a `submit`/click can't natively navigate on cancel)
+    // and bail — nothing is enqueued, no timer is scheduled. window.confirm is
+    // synchronous + screen-reader friendly and keeps the no-dependency default;
+    // a richer/async dialog can be layered on additively later.
+    if (confirm && !window.confirm(confirm)) {
+      event.preventDefault()
+      return
+    }
+
     // Stop native behavior (button submit / FORM NAVIGATION) HERE, synchronously
     // within the event dispatch. preventDefault() only works while the event is
     // still being handled — deferring it into the request-queue microtask (below)

data/lib/phlex/reactive/component.rb

@@ -304,13 +304,22 @@ module Phlex
       # live-update-as-you-type doesn't POST per keystroke. A blur flushes a
       # pending dispatch so the last edit is never dropped. Omit it for the
       # immediate-dispatch default.
+      #
+      # `confirm:` (a message string) gates the action behind a confirmation
+      # prompt (issue #52). Destructive reactive triggers can't use Hotwire's
+      # `data-turbo-confirm` — the reactive controller calls preventDefault and
+      # enqueues the POST itself, so Turbo's confirm handling never runs. The
+      # client shows window.confirm(message) FIRST and bails before any
+      # enqueue/debounce if the user declines (and prevents the native default so
+      # a `submit` trigger can't navigate on cancel). Omit it for no prompt.
+      #   button(**on(:destroy, confirm: "Really delete this item?")) { "Delete" }
       # The verbatim JSON for an empty explicit-params payload. The common
       # trigger (on(:increment), no params) hits this on EVERY render — skipping
       # params.to_json (which re-serializes {} to the same "{}" each time) avoids
       # a per-render allocation while keeping the wire format byte-identical.
       EMPTY_PARAMS_JSON = "{}"
 
-      def on(action_name, event: "click", debounce: nil, **params)
+      def on(action_name, event: "click", debounce: nil, confirm: nil, **params)
         attrs = {
           data: {
             action: "#{event}->reactive#dispatch",
@@ -319,6 +328,7 @@ module Phlex
           }
         }
         attrs[:data][:reactive_debounce_param] = debounce if debounce
+        attrs[:data][:reactive_confirm_param] = confirm if confirm
         attrs[:type] = "button" if event == "click"
         attrs
       end

data/lib/phlex/reactive/version.rb

@@ -2,6 +2,6 @@
 
 module Phlex
   module Reactive
-    VERSION = "0.4.4"
+    VERSION = "0.4.5"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: phlex-reactive
 version: !ruby/object:Gem::Version
-  version: 0.4.4
+  version: 0.4.5
 platform: ruby
 authors:
 - Mikael Henriksson