phlex-reactive 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8811ee6a3c0f044fd7c9d16843a641296b33b8fcb5872f5bc8822257f837148e
-  data.tar.gz: 9398a1c088680e83b8bed3398342345ceb817703183df0985a1948e29df021cf
+  metadata.gz: 786d397de0be7e32424c73079906cdf8d32d0325727d06027025d888693754e6
+  data.tar.gz: b080f12ff8c8f4271066993548f9c951278fe2dacabf9b7d21c2113704f58da4
 SHA512:
-  metadata.gz: b17a5d83f62e801d0f8673f824f929a82d1c7efc2d0aa2274034639ed94b2c8c4723f11484427f051c7be15d523a0b99cd11594bed0d701e4ff2e07604a1edd8
-  data.tar.gz: b5990726c0531bd2d6bc2da23df8bb2dbf5220ee702306c86f8094690da8c4a1752fa8ffb7949261050858256e5fd70854491603ac2306221c9f7bf2078f943c
+  metadata.gz: 316b9b2094490dd5045d1362276a8f31ba4deee96df08e6614dc9db8f62a2ceb822f5a474d2204dcb65f7ed1bb27b3c99303f14a180a336c2d5bc3d21c3bf31a
+  data.tar.gz: f54ecfe74e977b3d4a399cd004071792a3a7245636d1c82f19441b0240fb2d24d32bb072a3ae863a9e04efcab5a31182560628237f72bf77ff73ac387592e4c4

data/CHANGELOG.md

@@ -72,6 +72,27 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ### Fixed
 
+- **0.4.0 regression: re-renders lost the `request`, crashing `form_authenticity_token`
+  and other request-dependent helpers (#42).** The 0.4.0 render-path perf rework
+  built the cached off-request view context from a bare
+  `ActionController::Base.new.view_context`, whose controller has `request == nil`.
+  Any reactive component whose `view_template` calls `form_authenticity_token`,
+  `protect_against_forgery?`, or a host-aware URL helper (all of which read
+  `request.env`) then raised `NoMethodError: undefined method 'env' for nil` on
+  **every** re-render — through the action endpoint AND on broadcasts — so any app
+  with a reactive component rendering a Rails CSRF form could not adopt 0.4.0. Fixed
+  by building the cached view context through a request-bound controller
+  (`Phlex::Reactive.request_bound_view_context`), replicating exactly what
+  `ActionController::Renderer#render` does to set up its mock request: an
+  `ActionDispatch::Request` whose host is derived from the routes'
+  `default_url_options`. The 0.4.0 `render_in` speedup is kept — the request is set
+  up once when the per-thread context is built (not per render), and steady-state
+  render throughput/allocations are unchanged (retained-per-render stays 0). Covered
+  at the request level (a reactive `save` re-rendering a CSRF form returns 200, not
+  500), the broadcast level (the form component broadcasts without crashing), and the
+  unit level (a request is present on the cached context; host-aware `*_url` helpers
+  resolve when the renderer carries routes).
+
 - **Multipart path silently dropped an explicit nested-hash / array param (#39).**
   When an action declared a `:file` param alongside an explicit nested (hash/array)
   param, the nested param was dropped on the multipart path while the JSON path

data/lib/phlex/reactive/streamable.rb

@@ -83,7 +83,10 @@ module Phlex
 
         # Turbo::Streams::TagBuilder needs a real VIEW CONTEXT (it calls
         # `.formats` on it), not a controller class. Build one off-request from
-        # the configured renderer controller. Memoized PER THREAD — building a
+        # the configured renderer controller, bound to a real request so
+        # request-dependent helpers (form_authenticity_token, host-aware URL
+        # helpers) work during a re-render/broadcast (issue #42). Memoized PER
+        # THREAD — building a
         # view context instantiates the renderer controller and assembles its
         # whole helper module set, so doing it per render/broadcast was the
         # hottest server-side allocation in the action round trip. The builder
@@ -260,7 +263,7 @@ module Phlex
           cached = store[self]
 
           unless cached && cached.renderer.equal?(current) && cached.generation == generation
-            view_context = current.new.view_context
+            view_context = Phlex::Reactive.request_bound_view_context(current)
             cached = ThreadViewContext.new(
               view_context,
               ::Turbo::Streams::TagBuilder.new(view_context),

data/lib/phlex/reactive/version.rb

@@ -2,6 +2,6 @@
 
 module Phlex
   module Reactive
-    VERSION = "0.4.0"
+    VERSION = "0.4.1"
   end
 end

data/lib/phlex/reactive.rb

@@ -78,6 +78,30 @@ module Phlex
         @renderer ||= defined?(::ActionController::Base) ? ::ActionController::Base : nil
       end
 
+      # Build an off-request view context whose controller has a REAL `request`.
+      #
+      # A bare `controller.new.view_context` (the naive off-request context) has
+      # `request == nil`, so any request-dependent helper raises
+      # `undefined method 'env' for nil` — form_authenticity_token,
+      # protect_against_forgery?, and host-aware URL helpers all read
+      # `request.env` (issue #42). We replicate exactly what
+      # ActionController::Renderer#render does to set up its mock request — build
+      # an ActionDispatch::Request from the renderer's env (which derives the host
+      # from the routes' default_url_options), bind the routes, and attach it —
+      # then return the controller's view context instead of rendering a template.
+      # The result keeps the 0.4.0 render_in speedup (no renderer.render
+      # machinery) while restoring the request those helpers need.
+      def request_bound_view_context(controller_class)
+        ar_renderer = controller_class.renderer
+        request = ::ActionDispatch::Request.new(ar_renderer.send(:env_for_request))
+        request.routes = controller_class._routes
+
+        instance = controller_class.new
+        instance.set_request!(request)
+        instance.set_response!(controller_class.make_response!(request))
+        instance.view_context
+      end
+
       # DOM id of the host-app container a Response#flash appends into.
       # Default "flash"; override to match your layout's flash region.
       def flash_target
@@ -136,7 +160,7 @@ module Phlex
         generation = off_request_view_context_generation
 
         unless cache && cache[:renderer].equal?(current) && cache[:generation] == generation
-          view_context = current.new.view_context
+          view_context = request_bound_view_context(current)
           cache = {
             view_context: view_context,
             builder: ::Turbo::Streams::TagBuilder.new(view_context),

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: phlex-reactive
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Mikael Henriksson