phlex-reactive 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 25876f4b6f97e3cd517a4b5a575e3156ac7cadd4025e9f5cdf5f10b0bb001346
-  data.tar.gz: f5ea2f6cee8e7b17f66725549e98f2bc9d1cc3c29cf90acfb2d1b88c1176e2ea
+  metadata.gz: 458474fb8c8cdba105626b01860a196a32ebd144cbc79fd9140dc5fce937924f
+  data.tar.gz: 214a174853a11f054ed246a9cd5fa16c96133aaaf65c1eaa07716f9c61db1eb3
 SHA512:
-  metadata.gz: ec2bc617e5a888e268e6e746f85a225e92d88145114687be55b825c9659b2d9ef75b35d25d67d6dc950070acadf3f387b2d2608108f4b91d2a0dfcd8982495e1
-  data.tar.gz: c2249b5dd3783ec5f9d4881290e15030ca4de9e6e4e1af238f239feb55c63df76a5c5f4d1098e9bb1022547766752a03825b63d7dac60830dcc6cd5526d929ca
+  metadata.gz: d4d6d052aa218e41555dc1d94ff4966e93dff8420dda1402974b470bff49050d4864c1d003c7ef6a2e27d33bbf1ef69bf3e384a8e9ac554d163ab59bdfa2a6e8
+  data.tar.gz: 713f21d6a6155e6dd11923ac756428868aac85074e82c969a1133863f68328a83547a5177d27b1b656a162d2363b352d7aaeaf5af79cdd5768ac86c043fe97d9

data/CHANGELOG.md

@@ -6,6 +6,21 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
 
+## [0.2.1]
+
+### Fixed
+
+- **Zeitwerk eager-load crash in host apps.** A host app with
+  `config.eager_load = true` (the production default) runs
+  `Zeitwerk::Loader.eager_load_all`, which walked this gem's loader and raised
+  `Zeitwerk::NameError` on two files that don't follow Zeitwerk's
+  file→constant rule: `version.rb` (defines `VERSION`, not `Version`) and the
+  Rails generators under `lib/generators` (whose path/constant scheme is
+  intentionally non-Zeitwerk). The loader now requires `version.rb` up front and
+  ignores it, and ignores `lib/generators` (Rails loads generators itself), so
+  the gem eager-loads cleanly. Added a regression spec that calls
+  `eager_load_all`. No API changes.
+
 ## [0.2.0]
 
 ### Added
@@ -49,6 +64,7 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
   scaffolds a reactive component (and an RSpec spec when the app uses RSpec),
   state-backed by default or record-backed with `--record`.
 
-[Unreleased]: https://github.com/mhenrixon/phlex-reactive/compare/v0.2.0...HEAD
+[Unreleased]: https://github.com/mhenrixon/phlex-reactive/compare/v0.2.1...HEAD
+[0.2.1]: https://github.com/mhenrixon/phlex-reactive/compare/v0.2.0...v0.2.1
 [0.2.0]: https://github.com/mhenrixon/phlex-reactive/compare/v0.1.0...v0.2.0
 [0.1.0]: https://github.com/mhenrixon/phlex-reactive/releases/tag/v0.1.0

data/lib/phlex/reactive/version.rb

@@ -2,6 +2,6 @@
 
 module Phlex
   module Reactive
-    VERSION = "0.2.0"
+    VERSION = "0.2.1"
   end
 end

data/lib/phlex/reactive.rb

@@ -3,6 +3,12 @@
 require "zeitwerk"
 require "globalid"
 
+# VERSION is a plain constant, not a Zeitwerk-managed file (it defines VERSION,
+# not Version). Require it up front and ignore the file below so the loader
+# never tries to load it — otherwise eager_load_all (host app with
+# config.eager_load = true) raises Zeitwerk::NameError.
+require_relative "reactive/version"
+
 module Phlex
   # phlex-reactive: reactive Phlex components for Rails.
   #
@@ -125,8 +131,23 @@ end
 
 loader = Zeitwerk::Loader.new
 loader.tag = "phlex-reactive"
-loader.push_dir(File.expand_path("..", __dir__))
-loader.ignore("#{__dir__}/../phlex-reactive.rb")
+# Root is lib/ so files map to the Phlex::Reactive namespace
+# (lib/phlex/reactive/foo.rb -> Phlex::Reactive::Foo).
+lib = File.expand_path("..", __dir__)
+loader.push_dir(lib)
+# The gem-name shim (`require "phlex-reactive"`) is a plain require, not a
+# managed file.
+loader.ignore("#{lib}/phlex-reactive.rb")
+# version.rb defines VERSION (a constant, not a `Version` class) and is required
+# above — Zeitwerk must not try to load it.
+loader.ignore("#{lib}/phlex/reactive/version.rb")
+# Rails generators are discovered and loaded by Rails' own generator system,
+# not the app autoloader. Their path/constant scheme
+# (generators/phlex/reactive/... defining Phlex::Reactive::Generators::...)
+# deliberately doesn't follow Zeitwerk's rules, so the loader must ignore them.
+loader.ignore("#{lib}/generators")
+# The engine is required explicitly below (only when Rails is present) and must
+# not be eager-loaded before that.
 loader.do_not_eager_load("#{__dir__}/reactive/engine.rb")
 loader.setup
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: phlex-reactive
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Mikael Henriksson