phlex-reactive 0.16.11 → 0.16.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: aa14c0a09a3ba2484361ba2b0d932e8445c8c186bbcae71d1defe50d16d7f53a
-  data.tar.gz: dbc8eb7a7f4b352c8d859a62a692492522429cf6cd8723543d8b3f8731aec347
+  metadata.gz: 7f176f438a8cddf912348d8c6d0ddf095fa3a6fa1ae2b52b109a8be514a48139
+  data.tar.gz: 49f4e78d5e21ea343fe5bfb6d77d1a3f58e3cb0d592a018536bc9ae52d5c827d
 SHA512:
-  metadata.gz: 4fae6bf61c3967ce6a802351bcdc8b355718cc0ead6ac74b55e11cf73dc2b4614a4ec29935a451abaa2ebe3e089ac5d313b938fa59e0bfab8c5dd5fedb8a4538
-  data.tar.gz: f694fbbe45f6854ac2455c37e4515ee752e9d2df63fdd726d9ac660d9d9afec1da8f5c4ee604899c11c6675092b4de13f1a14919b3d08675d90adad6bfd8020d
+  metadata.gz: 6027a094e3dc14403d914c2f9406396b75fef0b4ea68615480b6d1c6a8e6e0b061c5f3e0df4b18ddc7e54642d54a0caf2490b5fe3d088b430864699106de6858
+  data.tar.gz: 87dd2ef191e0faf521bd869defc0cf645ed25466d1abadfae1db9641f74a6d9c8a6e9ca015834f81a29492e1c14c43eccc21d580478151f6d0d00506fa1473bd

data/CHANGELOG.md

@@ -6,6 +6,27 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
 
+### Added
+
+- **`:strict_integer` and `:strict_float` param types (#460).** `:integer` and
+  `:float` cast with `to_i`/`to_f`, so a cleared number field reaches the action
+  as `0` and `"12abc"` as `12`, and an action cannot tell a blank field from a
+  typed `0`. The two new built-ins follow the drop contract instead: a blank or
+  unparsable value is dropped, so the keyword default applies. `:strict_integer`
+  is `Integer(value, 10)`, so `"1.5"`, a JSON `1.0` and `"0x10"` drop and `"010"`
+  is `10`; `:strict_float` reads decimal notation, so it also drops hex and a
+  string too large or too small for a Float (`"1e400"`, `"1e-400"`). Both take a JSON number
+  as well as a string,
+  and work in nested and array schemas, where a dropped element follows the
+  existing array rule. `:integer` and `:float` are unchanged.
+
+### Fixed
+
+- **The docs now say what `:integer` and `:float` do (#460).** The Actions &
+  events guide and the counter example said a non-numeric value is dropped; it
+  never was. Both pages, and the README, now describe `to_i`/`to_f` and point at
+  the strict types.
+
 ## [0.16.11] - 2026-10-19
 
 ### Added

data/README.md

@@ -722,14 +722,32 @@ Use in controllers: `render turbo_stream: Counter.replace(counter)`.
 | `reply.pending(records, in:, job:) { … }` + `include Phlex::Reactive::Settles` / `reactive_settle` | For an action that **enqueues** work: mark targets pending, let your job settle them (row + count + empty-state) when it finishes. See [Async actions](#async-actions-replypending--reactive_settle). |
 | `Container.broadcast_collection_to(*keys, container:, in:, append:/prepend:/remove:)` | The broadcast-side `reply.append`/`reply.remove`: the row **plus** the count companion **plus** the empty-state toggle, to peers. |
 
-Param types: `:string` (default), `:integer`, `:float`, `:boolean`, `:file`,
-`:date`, `:datetime`, `:decimal`. Anything not in the schema is dropped before
-reaching your method. `:date`/`:datetime` parse ISO8601 (a value that won't
-parse is dropped — the keyword default applies); `:decimal` parses through
-`BigDecimal` (dropped on a non-numeric value). The schema is **compiled once at
-declaration**: a typo'd type symbol (`params: { count: :interger }`) raises
-`Phlex::Reactive::UnknownParamType` at class load, not silently coercing to a
-string at click time.
+Param types: `:string` (default), `:integer`, `:float`, `:strict_integer`,
+`:strict_float`, `:boolean`, `:file`, `:date`, `:datetime`, `:decimal`. Anything
+not in the schema is dropped before reaching your method. `:date`/`:datetime`
+parse ISO8601 (a value that won't parse is dropped — the keyword default
+applies); `:decimal` parses through `BigDecimal` (dropped on a non-numeric
+value). The schema is **compiled once at declaration**: a typo'd type symbol
+(`params: { count: :interger }`) raises `Phlex::Reactive::UnknownParamType` at
+class load, not silently coercing to a string at click time.
+
+`:integer` and `:float` cast with `to_i`/`to_f` and never drop, so a cleared
+number field arrives as `0` and `"12abc"` as `12`. When `0` means something,
+declare `:strict_integer` (`Integer(value, 10)`) or `:strict_float`
+(decimal notation only): a blank or unparsable value is dropped, so the keyword default
+applies and a typed `0` stays `0`. `:strict_integer` also drops a fraction, even
+a JSON `1.0`; `:strict_float` also drops hex and a string too large or too small
+for a Float (`"1e400"`, `"1e-400"`). A bare `1e-400` in a JSON body is already
+`0.0` when the parser hands it over, so it arrives as zero.
+
+```ruby
+action :save, params: { quantity: :strict_integer, weight: :strict_float }
+
+def save(quantity: nil, weight: nil) # nil when blank or unparsable; a typed 0 stays 0
+  authorize! @widget, :update?
+  @widget.update!(quantity:, weight:)
+end
+```
 
 **Custom param types (`Phlex::Reactive.param_type`).** Register your own type in
 an initializer — the block receives the raw client value and returns the coerced

data/lib/phlex/reactive/component/dsl.rb

@@ -288,7 +288,9 @@ module Phlex
           #
           # Param types are coerced server-side; anything not in the schema is
           # dropped before reaching your method (no mass assignment):
-          #   * Scalars — :string (default), :integer, :float, :boolean
+          #   * Scalars — :string (default), :integer, :float, :boolean,
+          #     :strict_integer, :strict_float (drop a blank or unparsable value;
+          #     :integer and :float read it as 0)
           #   * Array of scalar — wrap the type in an array: [:integer]
           #   * Array of hash (Rails nested attributes) — wrap a hash schema:
           #       action :save, params: {

data/lib/phlex/reactive/param_schema.rb

@@ -25,7 +25,8 @@ module Phlex
     #
     # A type is one of:
     #   * a scalar symbol           (:string/:integer/:float/:boolean/:file/:date/
-    #                                :datetime/:decimal, or an app-registered type)
+    #                                :datetime/:decimal/:strict_integer/:strict_float,
+    #                                or an app-registered type)
     #   * a Hash schema             ({ id: :integer, ... })   — nested object
     #   * a one-element Array       ([:integer] / [{ ... }])  — array of that
     class ParamSchema
@@ -53,7 +54,7 @@ module Phlex
         # dups it so app registration doesn't mutate this template). Each entry
         # is a callable(value) -> coerced | DROP. The scalar casts here are the
         # EXACT ones the controller ran, so the existing request-spec matrix is
-        # unchanged.
+        # unchanged (the strict pair came later and has no controller history).
         # rubocop:disable Style/ItBlockParameter, Style/SymbolProc
         # Explicit `(value)` params, NOT `it` or `&:to_s`: the date/datetime/decimal
         # casters wrap an INNER `parse_or_drop { ... }` block, and `it` there would
@@ -73,18 +74,42 @@ module Phlex
             file: nil,
             date: ->(value) { parse_or_drop { Date.iso8601(value.to_s) } },
             datetime: ->(value) { parse_or_drop { DateTime.iso8601(value.to_s) } },
-            decimal: ->(value) { parse_or_drop { BigDecimal(value.to_s) } }
+            decimal: ->(value) { parse_or_drop { BigDecimal(value.to_s) } },
+            # Issue #460: :integer and :float above read a blank field as 0 and
+            # keep that meaning; these two drop it, so a typed 0 stays
+            # distinguishable. to_s first: a JSON body sends 12, not "12". Base 10
+            # so "0x10" isn't another number and "010" isn't octal.
+            strict_integer: ->(value) { parse_or_drop { Integer(value.to_s, 10) } },
+            strict_float: ->(value) { parse_or_drop { strict_float(value.to_s) } }
           }
         end
         # rubocop:enable Style/ItBlockParameter, Style/SymbolProc
 
         private
 
-        # Run a parse that raises on bad input (Date/DateTime iso8601, BigDecimal)
-        # and turn the failure into DROP — the keyword default then applies rather
-        # than a fabricated value. ::ArgumentError covers BigDecimal("abc") and a
-        # blank/garbage string; ::Date::Error (an ArgumentError subclass) covers
-        # the iso8601 parsers; ::TypeError covers a nil slipping through.
+        # Float() alone is not strict: it reads "0x10" as 16.0 (:strict_integer's
+        # base 10 refuses the same string), takes "1e400" to Infinity and "1e-400"
+        # to a fabricated 0.0 without raising, and warns on stderr for both under
+        # -w, once per client value. So BigDecimal screens first: it refuses hex
+        # and never warns, and nothing out of range reaches Float(). Float() then
+        # stays the grammar, refusing the "1_" and "1d3" BigDecimal accepts.
+        #
+        # The zero check reads the mantissa, not BigDecimal#zero?: BigDecimal
+        # itself rounds "1e-999999999999999999999" to an exact zero.
+        def strict_float(text)
+          float = BigDecimal(text).to_f
+          return DROP unless float.finite? && (float.nonzero? || !text.match?(/\A[^e]*[1-9]/i))
+
+          Float(text)
+        end
+
+        # Run a parse that raises on bad input (Date/DateTime iso8601, BigDecimal,
+        # Integer, Float) and turn the failure into DROP — the keyword default then
+        # applies rather than a fabricated value. ::ArgumentError covers
+        # BigDecimal("abc") and a blank/garbage string; ::Date::Error (an
+        # ArgumentError subclass) covers the iso8601 parsers; ::TypeError covers a
+        # nil slipping through; ::FloatDomainError covers BigDecimal under an
+        # app's BigDecimal.mode exception flags ("Infinity", "1e400").
         #
         # MUST be top-level-qualified (::): the phlex gem defines Phlex::Argument
         # Error (a subclass of the stdlib one), and this file is nested under
@@ -93,7 +118,7 @@ module Phlex
         # parse failure would escape as a 500.
         def parse_or_drop
           yield
-        rescue ::ArgumentError, ::TypeError
+        rescue ::ArgumentError, ::TypeError, ::FloatDomainError
           DROP
         end
 

data/lib/phlex/reactive/version.rb

@@ -2,6 +2,6 @@
 
 module Phlex
   module Reactive
-    VERSION = "0.16.11"
+    VERSION = "0.16.12"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: phlex-reactive
 version: !ruby/object:Gem::Version
-  version: 0.16.11
+  version: 0.16.12
 platform: ruby
 authors:
 - Mikael Henriksson