phlex-forms 0.2.9 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f6247172989a97967a471140547a44b29058f77827ce8d699b2f8ae9d0aa60ce
-  data.tar.gz: 5aaeccec4ad938988ee09ad31f8b42ca92bc29f55fd3a5c481a1d1b21f17d1b8
+  metadata.gz: 9541561e98ecd2afda34daf77d2eeebd725aac0badde75fdbf51401628d081f6
+  data.tar.gz: 5d4008e8e6e5748ae12fdbcd12a667d016ab30549da71498dbc2e286fe202d81
 SHA512:
-  metadata.gz: 4dd96934af47c850597cd9f750bf03f97052301e6d9850239cb864f13fe914d17767b9c00f4b30fb23dcb0ea44c92b4e3d9f463d90e3832823d00dffd6700f70
-  data.tar.gz: 0a8acefb7a3bb47d002633482592aec0aa425b4b5df99d8a360efeb37455e1b9ea4ff9ba8dd918c4b15cdf08aa72ac8ab8bcbda6f37ef5c8d9f6091e966a540e
+  metadata.gz: f10fd9155f6ff9841bdae9c34fb2ac89dbbdbc49df33c012af7efad526fa914d21c6379430e1ee66a1aadeff387dcc9bab353d33cb017ce8b07798dd8058dd2c
+  data.tar.gz: 7ea1bdaa7fea101bde79b7975759c79b30bc502fb50c2b18e279a5cf4032b294745055e23f2f66ed22cba33c4e43c637c6499ea3c62059f425a3b3aec141ad83

data/CHANGELOG.md

@@ -7,6 +7,31 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+- **`rich_textarea` forwards its block into `<lexxy-editor>`**: Lexxy configures
+  an editor through CHILD elements — `<lexxy-prompt>` for @mentions,
+  `<lexxy-code-language-picker>` for code blocks — but the component rendered
+  the element with no block and `Form#rich_textarea` never forwarded one, so
+  `f.rich_textarea(:content) { ... }` silently dropped its content. A host
+  could wire @mentions and get an editor that never prompts, with no error
+  anywhere (a host app's mention endpoint 500'd for months unnoticed, because
+  nothing ever called it).
+- **`rich_textarea` wires Active Storage's direct-upload endpoints**: Lexxy
+  uploads attachments through `data-direct-upload-url` /
+  `data-blob-url-template` on the element. Lexxy's own Rails tag helper sets
+  them; this component built the element itself and did not, so rich text
+  editors silently lost image uploads. Set as PATHS (a multi-host app must not
+  pin uploads to whichever host rendered the page first), fully guarded — no
+  Rails dependency is introduced, and a caller-supplied value always wins.
+
+- **`FileInput` multiple uploads submit an array** (Rails `file_field` parity):
+  with `multiple:` set, the input name now gets `[]` appended (unless already
+  present), for the standalone component, the `Plain` variant, and the form
+  builder path. Without it the browser collapsed a multi-file selection into
+  ONE scalar param, which a host app's `params.expect(attr: [])` silently
+  discarded — uploads no-opped with a success response.
+
 ### Added
 
 - **`checkbox_group` — batched checkbox group for array-valued fields** (the

data/README.md

@@ -4,7 +4,7 @@ A model-bound form builder for [Phlex](https://www.phlex.fun) — forms as
 first-class Phlex classes, types inferred from your model, DaisyUI styling by
 default (and a plain-HTML theme when you want none), and optional
 **server-truth live validation** over
-[phlex-reactive](https://github.com/mhenrixon/phlex-reactive).
+[phlex-reactive](https://github.com/zoolutions/phlex-reactive).
 
 ```ruby
 class UserForm < Forms::Base
@@ -158,7 +158,7 @@ Both work on inline forms (`f.row { … }`) and inside `fields_for` builders.
 
 `as: :tags` renders a polished tag/chip input — label + error/hint chrome and
 daisyUI styling on top of
-[phlex-reactive](https://github.com/mhenrixon/phlex-reactive)'s client-only tag
+[phlex-reactive](https://github.com/zoolutions/phlex-reactive)'s client-only tag
 primitives (form state, no server round trips). **Requires phlex-reactive** (the `:tags` role is
 registered only when it's loaded).
 

data/lib/forms/field.rb

@@ -30,6 +30,12 @@ module Forms
     # PhlexForms::Theme), so the same field renders daisy or plain.
 
     def input(*modifiers, type: :text, **)
+      # type: :hidden reroutes to #hidden so EVERY path to a hidden field lands on
+      # the bare leaf — `f.Input(:token, :hidden)` and `f.Input(:token, type:
+      # :hidden)` would otherwise still emit the styled `input w-full`. Positional
+      # modifiers are dropped with it: a hidden field has no visual variants.
+      return hidden(**) if type.to_s == "hidden"
+
       theme[:input].new(*modifiers, type:, **field_attributes, **)
     end
 
@@ -43,8 +49,13 @@ module Forms
     end
     alias rich_text_area rich_textarea
 
+    # Bare <input type="hidden">, never the styled :input leaf — daisyui's
+    # `.input` beats WebKit's non-!important `input[type=hidden] { display: none }`
+    # and turns the field into a focusable phantom tab stop in Safari. Built from
+    # the explicit accessors (not field_attributes) so the meaningless
+    # `error: invalid?` is never introduced.
     def hidden(**)
-      theme[:input].new(type: :hidden, **field_attributes, **)
+      theme[:hidden].new(name: field_name, id: field_id, value: field_value, **)
     end
 
     # daisyui v5 "icon/text inside the field" wrapper. The block renders the

data/lib/forms/file_input.rb

@@ -8,7 +8,10 @@ module Forms
     def initialize(*modifiers, name: nil, id: nil, multiple: false, accept: nil,
                    error: false, disabled: false, required: false, full_width: true, **attributes)
       @modifiers = normalize_modifiers(modifiers)
-      @name = name
+      # Rails file_field parity: a multiple input needs an array param name, or
+      # the browser collapses the selection into one scalar file — which a host
+      # app's `params.expect(attr: [])` then silently discards.
+      @name = multiple && name && !name.to_s.end_with?("[]") ? "#{name}[]" : name
       @id = id
       @multiple = multiple
       @accept = accept

data/lib/forms/form.rb

@@ -78,8 +78,8 @@ module Forms
       render theme[:submit].new(*, model: @model, **, &)
     end
 
-    def rich_textarea(name, *modifiers, **)
-      render field_object(name).rich_textarea(*modifiers, **)
+    def rich_textarea(name, *modifiers, **, &)
+      render field_object(name).rich_textarea(*modifiers, **), &
     end
     alias rich_text_area rich_textarea
 

data/lib/forms/hidden.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+module Forms
+  # A model-bound hidden field: a bare <input type="hidden"> carrying name/id/
+  # value plus whatever the caller passes through. Deliberately NOT a
+  # DelegatedField/DaisyUI::Input like Forms::Input — a hidden field must never
+  # carry visual styling. daisyui's `.input { display: inline-flex }` overrides
+  # WebKit's *non*-!important UA rule `input[type=hidden] { display: none }`, so a
+  # styled hidden field renders as an empty box and joins the keyboard tab order
+  # in Safari (Chromium's UA rule is !important, hiding the bug there).
+  #
+  #   Forms::Hidden.new(name: "user[token]", id: "user_token", value: "abc123")
+  #
+  # Same component under both themes (:hidden role) — there are no styling
+  # classes for a Plain twin to strip. It takes no positional variants and no
+  # error:: a hidden field has no visual or error state.
+  class Hidden < Phlex::HTML
+    def initialize(name: nil, id: nil, value: nil, **attributes)
+      @name = name
+      @id = id
+      @value = value
+      @attributes = attributes
+      super()
+    end
+
+    def view_template
+      input(type: "hidden", name: @name, id: @id, value: @value.to_s, **@attributes)
+    end
+  end
+end

data/lib/forms/rich_textarea.rb

@@ -14,21 +14,54 @@ module Forms
       @id = id || name.to_s.gsub(/[\[\]]/, "_").gsub(/_+$/, "")
       @value = value
       @options = options
+      apply_direct_upload_defaults
       super()
     end
 
-    def view_template
+    # Lexxy configures the editor through CHILD elements — `<lexxy-prompt>` for
+    # @mentions, `<lexxy-code-language-picker>` for code blocks — so the block
+    # has to reach the element, not be dropped.
+    def view_template(&)
       lexxy_editor(
         name: @name,
         id: @id,
         value: formatted_value,
         class: editor_classes,
-        **@options.except(:class, :error)
+        **@options.except(:class, :error),
+        &
       )
     end
 
     private
 
+    # Lexxy uploads attachments through Active Storage's direct-upload
+    # endpoints, read off the element. Lexxy's own Rails tag helper sets them;
+    # this component builds the element itself, so without these an editor
+    # silently loses image uploads. Paths, not URLs: a multi-host app must not
+    # pin uploads to whichever host rendered the page first.
+    #
+    # Fully guarded — the gem has no Rails dependency, and a host without
+    # Active Storage (or with its own values) is left alone.
+    def apply_direct_upload_defaults
+      helpers = rails_url_helpers or return
+
+      data = (@options[:data] ||= {})
+      data[:direct_upload_url] ||= helpers.rails_direct_uploads_path
+      data[:blob_url_template] ||= helpers.rails_service_blob_path(":signed_id", ":filename")
+    rescue StandardError
+      nil
+    end
+
+    def rails_url_helpers
+      return unless defined?(Rails) && Rails.respond_to?(:application)
+
+      helpers = Rails.application&.routes&.url_helpers
+      return unless helpers.respond_to?(:rails_direct_uploads_path)
+      return unless helpers.respond_to?(:rails_service_blob_path)
+
+      helpers
+    end
+
     def formatted_value
       return nil if @value.nil? || (@value.respond_to?(:blank?) && @value.blank?)
 

data/lib/phlex_forms/theme.rb

@@ -4,7 +4,9 @@ module PhlexForms
   # A theme maps component roles (:input, :select, :control, ...) to component
   # classes. The binding contract — the leaf initializer signatures
   # (*modifiers, name:, id:, value:, error:, required:, ...) — is the stable
-  # interface, so the same form class renders under any theme.
+  # interface, so the same form class renders under any theme. The one exception
+  # is :hidden, which takes name:/id:/value: only — a hidden field has neither a
+  # visual variant nor an error state.
   #
   # Built-ins:
   #   Theme.daisy — the DaisyUI-delegating Forms::* leaves (default when the
@@ -56,7 +58,7 @@ module PhlexForms
           textarea: Forms::Textarea, rich_textarea: Forms::RichTextarea,
           checkbox: Forms::Checkbox, toggle: Forms::Toggle, radio: Forms::Radio,
           checkbox_group: Forms::CheckboxGroup,
-          file: Forms::FileInput, wrapped_input: Forms::WrappedInput,
+          file: Forms::FileInput, wrapped_input: Forms::WrappedInput, hidden: Forms::Hidden,
           control: Forms::FormControl, label: Forms::Label,
           field_error: Forms::FieldError, field_hint: Forms::FieldHint,
           submit: Forms::Submit, row: Forms::Row, group: Forms::Group,
@@ -74,7 +76,7 @@ module PhlexForms
           textarea: Forms::Plain::Textarea, rich_textarea: Forms::Plain::Textarea,
           checkbox: Forms::Plain::Checkbox, toggle: Forms::Plain::Checkbox, radio: Forms::Plain::Radio,
           checkbox_group: Forms::Plain::CheckboxGroup,
-          file: Forms::Plain::FileInput, wrapped_input: Forms::Plain::WrappedInput,
+          file: Forms::Plain::FileInput, wrapped_input: Forms::Plain::WrappedInput, hidden: Forms::Hidden,
           control: Forms::Plain::Control, label: Forms::Plain::Label,
           field_error: Forms::Plain::FieldError, field_hint: Forms::Plain::FieldHint,
           submit: Forms::Plain::Submit, row: Forms::Plain::Row, group: Forms::Plain::Group,

data/lib/phlex_forms/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PhlexForms
-  VERSION = "0.2.9"
+  VERSION = "0.3.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: phlex-forms
 version: !ruby/object:Gem::Version
-  version: 0.2.9
+  version: 0.3.1
 platform: ruby
 authors:
 - Mikael Henriksson
@@ -128,6 +128,7 @@ files:
 - lib/forms/form.rb
 - lib/forms/form_control.rb
 - lib/forms/group.rb
+- lib/forms/hidden.rb
 - lib/forms/input.rb
 - lib/forms/label.rb
 - lib/forms/live.rb
@@ -178,13 +179,13 @@ files:
 - lib/phlex_forms/version.rb
 - lib/rubocop/phlex_forms/cop/legacy_form_method.rb
 - lib/rubocop/phlex_forms/cop/raw_form.rb
-homepage: https://github.com/mhenrixon/phlex-forms
+homepage: https://github.com/zoolutions/phlex-forms
 licenses:
 - MIT
 metadata:
-  source_code_uri: https://github.com/mhenrixon/phlex-forms
-  changelog_uri: https://github.com/mhenrixon/phlex-forms/blob/main/CHANGELOG.md
-  bug_tracker_uri: https://github.com/mhenrixon/phlex-forms/issues
+  source_code_uri: https://github.com/zoolutions/phlex-forms
+  changelog_uri: https://github.com/zoolutions/phlex-forms/blob/main/CHANGELOG.md
+  bug_tracker_uri: https://github.com/zoolutions/phlex-forms/issues
   rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths: