phew 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 163b79015f30a7af7db5e50634043dd713ea4747
-  data.tar.gz: c3f9fdd68ebfe6225a6b01e48ac7880679a419a5
+SHA256:
+  metadata.gz: 76bdc848ba00cbe93dcbd8bd4f18255af08e7b11eb35704404a4e80fe9d3d06a
+  data.tar.gz: a15961a04d5673672b9d3deec4f58e9ec559a9c925b2608648def511249aab82
 SHA512:
-  metadata.gz: a062cbf070fb5fe243389b431c41fa46d756194bb5cf62eee84ffa543aee1c4da25a46866b68c5b81f369e937cc5e81c02d64173a6120e6b4cddcc21c4252e5c
-  data.tar.gz: 52534feb77e7db63f8fdc3ffaec0019b50bb499e86e02e3e9b4bb568af785cf57d8a4390fcac7d1b1e2dff1c2ea15e0d6fd22c6ccfd5d08d03a2ddc68c4051fc
+  metadata.gz: 6999d0de88e2e3feae5d92d7556821dbeff21f3fbb3968ab698a0f28611f0d098ef03414d3d8691761cd748300af5495812afcb4161ada42d05df4426df0933d
+  data.tar.gz: fc76fd22022ef3883ffae54df23e0a207c3d836de672a47def2204e3d3e48a5032e759945c082b3fafce5dbbaea7aec8b0cf9e3af61492411958bfdf63e3d40f

data/Gemfile

@@ -1,6 +1,6 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # The gem's dependencies are specified in the gemspec
 gemspec
-
-gem 'pry', '~> 0.10.0', type: :development

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rake/clean'
 require 'bundler/gem_helper'
 require 'rake/testtask'
@@ -7,17 +9,17 @@ Bundler::GemHelper.install_tasks
 namespace :test do
   Rake::TestTask.new(:unit) do |t|
     t.libs = ['lib']
-    t.test_files = FileList['test/unit/*_test.rb']
+    t.test_files = FileList['test/**/*_test.rb']
     t.warning = true
   end
 
-  Rake::TestTask.new(:end_to_end) do |t|
+  Rake::TestTask.new(:features) do |t|
     t.libs = ['lib']
-    t.test_files = FileList['test/end_to_end/*_test.rb']
+    t.test_files = FileList['features/**/*_test.rb']
     t.warning = true
   end
 
-  task all: [:unit, :end_to_end]
+  task all: [:unit, :features]
 end
 
 task test: 'test:all'

data/bin/phew

@@ -1,4 +1,6 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 require 'phew'
 
 Gtk.init
@@ -29,7 +31,7 @@ module Phew
       false
     end
 
-    def on_key_press_event evt
+    def on_key_press_event(evt)
       destroy if evt.state[:control_mask] && evt.keyval == 'q'.ord
       false
     end
@@ -112,24 +114,30 @@ module Phew
       win.show_all
     end
 
-    def fill_font_list script
+    def fill_font_list(script)
       scriptmodel.clear
 
-      fontmap = @context.get_font_map
-
-      fontmap.list_families.each do |fam|
+      font_families.each do |fam|
         font = @font_repository.get_font fam.name
 
-        sample_cov = font.coverage_summary script.sample_string
-        mostly = [:none, :fallback, :approximate, :exact].max_by { |i| sample_cov[i] }
-
-        if mostly == :exact
+        if sample_coverage(font, script) == :exact
           row = scriptmodel.append
           scriptmodel.set_value row, 0, fam.name
         end
       end
     end
 
+    def sample_coverage(font, script)
+      sample_cov = font.coverage_summary script.sample_string
+      [:none, :fallback, :approximate, :exact].max_by { |i| sample_cov[i] }
+    end
+
+    def font_families
+      fontmap = @context.get_font_map
+
+      fontmap.list_families
+    end
+
     def run
       Gtk.main
     end

data/lib/phew.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gir_ffi-gtk3'
 require 'gir_ffi-pango'
 

data/lib/phew/font.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Phew
   # Font family. Handles coverage, among other things.
   class Font
@@ -6,7 +8,7 @@ module Phew
     #
     # @param [Pango::Context] context Pango context to retrieve font from.
     # @param [String] text_description Description of the font to create.
-    def initialize context, text_description
+    def initialize(context, text_description)
       fd = Pango::FontDescription.from_string text_description
       fontmap = context.get_font_map
       @font = fontmap.load_font context, fd
@@ -16,7 +18,7 @@ module Phew
     #
     # @return A hash with keys :none, :fallback, :approximate, :exact, and values
     #   indicating the number of characters in the text that have that coverage.
-    def coverage_summary text
+    def coverage_summary(text)
       lang = Pango::Language.new
       cov = @font.get_coverage lang
       text_cov = text.each_codepoint.map { |cp| cov.get cp }

data/lib/phew/font_repository.rb

@@ -1,16 +1,19 @@
+# frozen_string_literal: true
+
 module Phew
   # Cache for font information retrieved from a Pango context
   class FontRepository
     # @param [Pango::Context] context Pango context to retrieve fonts from.
-    def initialize context
+    def initialize(context)
       @store = {}
       @context = context
     end
+
     # Retrieve a font based on the given text description. The text description
     # should be in the format accepted by Font#new.
     #
     # @param [String] text_description Description of the font to retrieve.
-    def get_font text_description
+    def get_font(text_description)
       @store[text_description] ||= Font.new @context, text_description
     end
   end

data/lib/phew/script.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 module Phew
   # A script.
   class Script
-    def initialize name
+    def initialize(name)
       symbol = name.to_sym
       @symbol = symbol
       @lang = Pango.script_get_sample_language symbol

data/test/{unit → phew}/font_repository_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../test_helper'
 
 describe Phew::FontRepository do

data/test/{unit → phew}/font_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../test_helper'
 
 describe Phew::Font do

data/test/test_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'minitest/autorun'
 
 require 'phew'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: phew
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Matijs van Zuijlen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-16 00:00:00.000000000 Z
+date: 2018-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gir_ffi-gtk
@@ -16,42 +16,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.11.0
+        version: 0.12.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.11.0
+        version: 0.12.0
 - !ruby/object:Gem::Dependency
   name: gir_ffi-pango
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.0.9
+        version: 0.0.10
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.0.9
+        version: 0.0.10
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: atspi_app_driver
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: 0.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: 0.3.0
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -67,19 +67,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '5.5'
 - !ruby/object:Gem::Dependency
-  name: atspi_app_driver
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.7
+        version: '12.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.7
+        version: '12.0'
 description: List and compare installed fonts on GNOME
 email:
 - matijs@matijs.net
@@ -103,10 +103,9 @@ files:
 - lib/phew/font.rb
 - lib/phew/font_repository.rb
 - lib/phew/script.rb
-- test/end_to_end/basic_run_test.rb
+- test/phew/font_repository_test.rb
+- test/phew/font_test.rb
 - test/test_helper.rb
-- test/unit/font_repository_test.rb
-- test/unit/font_test.rb
 homepage: http://www.github.com/mvz/phew-font-viewer
 licenses:
 - GPL-3
@@ -122,7 +121,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.3
+      version: 2.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -130,7 +129,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: A GNOME Font Viewer

data/test/end_to_end/basic_run_test.rb

@@ -1,53 +0,0 @@
-require_relative '../test_helper'
-require 'atspi_app_driver'
-
-# Test driver for the Phew application.
-class PhewDriver < AtspiAppDriver
-  def initialize
-    verbose = ENV['VERBOSE'] == 'true'
-    super 'phew', verbose: verbose
-  end
-end
-
-describe 'The Phew application' do
-  before do
-    @driver = PhewDriver.new
-    @driver.boot
-  end
-
-  it 'starts and can be quit with Ctrl-q' do
-    sleep 0.05
-    @driver.press_ctrl_q
-
-    status = @driver.cleanup
-    status.exitstatus.must_equal 0
-  end
-
-  it 'shows a dropdown list of scripts' do
-    frame = @driver.frame
-
-    box = frame.find_role :combo_box
-
-    latin = box.find_role :menu_item, /latin/
-    latin.wont_be_nil
-
-    textbox = frame.find_role :text
-    textbox.wont_be_nil
-    textbox.get_text(0, 100).must_equal ''
-
-    box.get_action_name(0).must_equal 'press'
-    box.do_action 0
-    latin.get_action_name(0).must_equal 'click'
-    latin.do_action 0
-
-    textbox.get_text(0, 100).must_equal 'The quick brown fox jumps over the lazy dog.'
-
-    @driver.press_ctrl_q
-    status = @driver.cleanup
-    status.exitstatus.must_equal 0
-  end
-
-  after do
-    @driver.cleanup
-  end
-end