pheme 3.1.2 → 3.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 00c644d86dd28023ad4f19c881f9e62e4c3fc37db5145d1c74ad45ee6172febd
-  data.tar.gz: fe23557df0047f7747f18fef98c36d758f2349cb5dd19b3aaa4c75c14f161109
+  metadata.gz: 43b82532ae9c2d1e266860d9553d1b9e6c47fba937de781431f50f87921fa8b6
+  data.tar.gz: 14cd293a8fdbabab40154bf10a6e1cee36d4c609749a7ca4f0ee44d4df1780ee
 SHA512:
-  metadata.gz: 220fb2de76fbe6782849a23cb104128681bbd0b6510de4fc47a67d806d9752a83c4e4fa69c8e720c4630371132027fce624e381708b21be3aa0ffb99ae1faff3
-  data.tar.gz: 7492c1a2d0550b1cdf922222afd291bd14c515d18bd680365a69a974a56380fb3f721d38a004428b963b1c34e7fcb50b1cf5173bbed777f5b5479a0508f9ffe2
+  metadata.gz: 1b1da30552e2ba5fb12a898c1af86a0f48654a6c3a3bca615ae00d7a762bd4a7db6f660bcfd99149d00ec0ebeaccdd4b115c06ce5233b382706045aa5d470d9e
+  data.tar.gz: d86bfe1b06f0d5040e4461a24bfc5cfe2e264c8014563b26c8e0e49912834f3db03286f49dd042f65b6f13a38547c8866406ff04a8f82814bfb644ef5b24c288

data/CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 3.1.3 - 2019-02-14
+### Fixed
+- Increase code coverage to 100%.
+
 ## 3.1.2 - 2019-02-14
 ### Fixed
 - Trying to recover code coverage, it only worked for first few builds.

data/lib/pheme/version.rb

@@ -1,3 +1,3 @@
 module Pheme
-  VERSION = '3.1.2'.freeze
+  VERSION = '3.1.3'.freeze
 end

data/pheme.gemspec

@@ -36,5 +36,6 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rspec-collection_matchers'
   s.add_development_dependency 'rspec-its'
   s.add_development_dependency 'rspec_junit_formatter', '~> 0.2'
+  s.add_development_dependency 'simplecov'
   s.add_development_dependency 'ws-style'
 end

data/spec/logger_spec.rb

@@ -0,0 +1,10 @@
+RSpec.describe Pheme do
+  describe '.log' do
+    let(:method) { 'info' }
+    let(:text) { 'Some informational message' }
+
+    subject { Pheme.log(method, text) }
+
+    it { subject }
+  end
+end

data/spec/message_handler_spec.rb

@@ -1,13 +1,34 @@
 describe Pheme::MessageHandler do
   before(:each) { use_default_configuration! }
-  let(:message) { RecursiveOpenStruct.new(status: "complete") }
+  let(:message) { RecursiveOpenStruct.new(status: status) }
   let(:timestamp) { '2018-04-17T21:45:05.915Z' }
   subject { ExampleMessageHandler.new(message: message, metadata: { timestamp: timestamp }) }
 
   describe "#handle" do
-    it "handles the message correctly" do
-      expect(Pheme.logger).to receive(:info).with("Done")
-      subject.handle
+    context 'complete message' do
+      let(:status) { 'complete' }
+
+      it "handles the message correctly" do
+        expect(Pheme.logger).to receive(:info).with("Done")
+        subject.handle
+      end
+    end
+
+    context 'rejected message' do
+      let(:status) { 'rejected' }
+
+      it 'handles the message correctly' do
+        expect(Pheme.logger).to receive(:error).with("Oops")
+        subject.handle
+      end
+    end
+
+    context 'base handler' do
+      subject { described_class.new(message: nil).handle }
+
+      it 'does not implement handle' do
+        expect { subject }.to raise_error(NotImplementedError)
+      end
     end
   end
 end

data/spec/queue_poller_spec.rb

@@ -2,6 +2,14 @@ describe Pheme::QueuePoller do
   let(:queue_url) { "https://sqs.us-east-1.amazonaws.com/whatever" }
   let(:timestamp) { '2018-04-17T21:45:05.915Z' }
 
+  context 'base poller' do
+    subject { described_class.new(queue_url: 'https://sqs.aws.com').handle(nil, nil) }
+
+    it 'does not implement handle' do
+      expect { subject }.to raise_error(NotImplementedError)
+    end
+  end
+
   describe ".new" do
     context "when initialized with valid params" do
       it "does not raise an error" do
@@ -29,6 +37,22 @@ describe Pheme::QueuePoller do
         ExampleQueuePoller.new(queue_url: "queue_url", sqs_client: sqs_client)
       end
     end
+
+    context 'received too many messages' do
+      let(:aws_poller) { instance_double('Aws::SQS::QueuePoller') }
+      let(:max_messages) { 50 }
+
+      before do
+        allow(Aws::SQS::QueuePoller).to receive(:new).and_return(aws_poller)
+        allow(aws_poller).to receive(:before_request).and_yield(OpenStruct.new(received_message_count: max_messages))
+      end
+
+      subject { described_class.new(queue_url: 'http://sqs.aws.com', max_messages: max_messages) }
+
+      it 'throws error' do
+        expect { subject }.to raise_error(UncaughtThrowError, /stop_polling/)
+      end
+    end
   end
 
   let(:poller) { ExampleQueuePoller.new(queue_url: queue_url, format: format) }
@@ -246,5 +270,27 @@ describe Pheme::QueuePoller do
         subject.poll
       end
     end
+
+    context 'SignalException' do
+      let(:message) { { status: 'complete' } }
+      let(:notification) { { 'MessageId' => SecureRandom.uuid, 'Message' => message.to_json, 'Type' => 'Notification', 'Timestamp' => timestamp } }
+      let!(:queue_message) do
+        OpenStruct.new(
+          body: notification.to_json,
+          message_id: message_id,
+        )
+      end
+
+      before do
+        allow(subject.queue_poller).to receive(:poll).and_yield(queue_message)
+        allow(subject.queue_poller).to receive(:delete_message).and_raise(SignalException.new('KILL'))
+      end
+
+      subject { ExampleQueuePoller.new(queue_url: queue_url) }
+
+      it 'stops polling' do
+        expect { subject.poll }.to raise_error(UncaughtThrowError, /stop_polling/)
+      end
+    end
   end
 end

data/spec/spec_helper.rb

@@ -1,5 +1,13 @@
+require 'simplecov'
 require 'coveralls'
-Coveralls.wear!
+
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new([
+  SimpleCov::Formatter::HTMLFormatter,
+  Coveralls::SimpleCov::Formatter,
+])
+SimpleCov.start do
+  add_filter 'spec'
+end
 
 require 'rspec'
 require 'rspec/its'

data/spec/topic_publisher_spec.rb

@@ -1,6 +1,14 @@
 describe Pheme::TopicPublisher do
   before(:each) { use_default_configuration! }
 
+  context 'base publisher' do
+    subject { described_class.new(topic_arn: 'arn::foo::bar').publish_events }
+
+    it 'does not implement handle' do
+      expect { subject }.to raise_error(NotImplementedError)
+    end
+  end
+
   describe ".new" do
     context "when initialized with valid params" do
       it "does not raise an error" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pheme
 version: !ruby/object:Gem::Version
-  version: 3.1.2
+  version: 3.1.3
 platform: ruby
 authors:
 - Peter Graham
@@ -192,6 +192,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.2'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: ws-style
   requirement: !ruby/object:Gem::Requirement
@@ -238,6 +252,7 @@ files:
 - lib/pheme/version.rb
 - pheme.gemspec
 - spec/configuration_spec.rb
+- spec/logger_spec.rb
 - spec/message_handler_spec.rb
 - spec/message_type/aws_event_spec.rb
 - spec/message_type/sns_message_spec.rb
@@ -276,6 +291,7 @@ specification_version: 4
 summary: Ruby SNS publisher + SQS poller & message handler
 test_files:
 - spec/configuration_spec.rb
+- spec/logger_spec.rb
 - spec/message_handler_spec.rb
 - spec/message_type/aws_event_spec.rb
 - spec/message_type/sns_message_spec.rb