phare 0.7.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5d342f532b5c065a64dbc6b1eba2cab4cf1f8b68
-  data.tar.gz: 171dc0037a16399f7937429fe222624cc53ef57d
+  metadata.gz: 32cfbf8d6a2dd16df575bfa14e2428449808a1b7
+  data.tar.gz: dc0e226459f1b14eece856393b4a8d66c6ebc06b
 SHA512:
-  metadata.gz: ce98e8dfc1bb05d124bd73df59583b20abbc666a4a9c99d2ad4a088394822569eae6185065eaacdf30aeeb7b9bbbcc6fb70cb0f514d21c05676b71e882a2feac
-  data.tar.gz: 3a14e83a6ef194f4399f44aa0ed6bb348b3694c4faa84544b77a9cf8da2fa98696bccb63ebdd0ba7f63577cec010af8030a8a3eea9cbd7d49bd2ece26a88fbc4
+  metadata.gz: f462e483cf50a306ced260ba16750d871af4a7b99662b51ae4301e89314f01a6d337a9acdca5430aebf9c3f441c341b795097c24739c8e2417ce8064c61502a5
+  data.tar.gz: 2390db0d20b16ffc98c3d33dc4bfb0912699881015f7e024da7e7876088d2dd65c6ffa3f7a0ba8b53669be9d82e039e744c2362cf17ef5a6efe03f9f0b153d43

data/.travis.yml

@@ -3,7 +3,6 @@ language: ruby
 rvm:
   - 2.1.1
   - 2.0.0
-  - 1.9.3
 
 script:
   - 'echo "Checking code style" && ./bin/phare'

data/LICENSE.md

@@ -1,4 +1,4 @@
-Copyright (c) 2014, Mirego
+Copyright (c) 2014-2015, Mirego
 All rights reserved.
 
 Redistribution and use in source and binary forms, with or without

data/README.md

@@ -122,7 +122,7 @@ skip:
 
 ## License
 
-`Phare` is © 2014 [Mirego](http://www.mirego.com) and may be freely distributed under the [New BSD license](http://opensource.org/licenses/BSD-3-Clause).  See the [`LICENSE.md`](https://github.com/mirego/phare/blob/master/LICENSE.md) file.
+`Phare` is © 2014-2015 [Mirego](http://www.mirego.com) and may be freely distributed under the [New BSD license](http://opensource.org/licenses/BSD-3-Clause).  See the [`LICENSE.md`](https://github.com/mirego/phare/blob/master/LICENSE.md) file.
 
 The lighthouse logo is based on [this lovely icon](http://thenounproject.com/term/lighthouse/11608/) by [Nick Lacke](http://thenounproject.com/nicklacke), from The Noun Project.
 

data/lib/phare.rb

@@ -8,9 +8,8 @@ require 'phare/git'
 
 require 'phare/check'
 require 'phare/check/rubocop'
-require 'phare/check/scss_lint'
-require 'phare/check/jshint'
-require 'phare/check/jscs'
+require 'phare/check/stylelint'
+require 'phare/check/eslint'
 
 require 'phare/check_suite'
 

data/lib/phare/check/eslint.rb

@@ -0,0 +1,59 @@
+# encoding: utf-8
+module Phare
+  class Check
+    class Eslint < Check
+      GLOBAL_BINARY = 'eslint'.freeze
+      LOCAL_BINARY = 'node_modules/.bin/eslint'.freeze
+
+      attr_reader :config, :path
+
+      def initialize(directory, options = {})
+        @directory = directory
+        @config = File.expand_path("#{directory}.eslintrc", __FILE__)
+        @path = File.expand_path("#{directory}app/assets/javascripts", __FILE__)
+        @extensions = %w(.js)
+        @options = options
+
+        super
+      end
+
+      def command
+        "#{binary} #{input}"
+      end
+
+    protected
+
+      def configuration_exists?
+        File.exist?(@config)
+      end
+
+      def binary
+        local_binary_exists? ? @directory + LOCAL_BINARY : GLOBAL_BINARY
+      end
+
+      def binary_exists?
+        local_binary_exists? || global_binary_exists?
+      end
+
+      def local_binary_exists?
+        !Phare.system_output("which #{@directory}#{LOCAL_BINARY}").empty?
+      end
+
+      def global_binary_exists?
+        !Phare.system_output("which #{GLOBAL_BINARY}").empty?
+      end
+
+      def input
+        @tree.changed? ? files_to_check.join(' ') : "'#{@path}/**/*#{@extensions.first}'"
+      end
+
+      def arguments_exists?
+        @tree.changed? || Dir.exist?(@path)
+      end
+
+      def print_banner
+        Phare.banner 'Running ESLint to check for JavaScript style…'
+      end
+    end
+  end
+end

data/lib/phare/check/stylelint.rb

@@ -0,0 +1,59 @@
+# encoding: utf-8
+module Phare
+  class Check
+    class Stylelint < Check
+      GLOBAL_BINARY = 'stylelint'.freeze
+      LOCAL_BINARY = 'node_modules/.bin/stylelint'.freeze
+
+      attr_reader :config, :path
+
+      def initialize(directory, options = {})
+        @directory = directory
+        @config = File.expand_path("#{directory}.stylelintrc", __FILE__)
+        @path = File.expand_path("#{directory}app/assets/stylesheets", __FILE__)
+        @extensions = %w(.scss)
+        @options = options
+
+        super
+      end
+
+      def command
+        "#{binary} #{input}"
+      end
+
+    protected
+
+      def configuration_exists?
+        File.exist?(@config)
+      end
+
+      def binary
+        local_binary_exists? ? @directory + LOCAL_BINARY : GLOBAL_BINARY
+      end
+
+      def binary_exists?
+        local_binary_exists? || global_binary_exists?
+      end
+
+      def local_binary_exists?
+        !Phare.system_output("which #{@directory}#{LOCAL_BINARY}").empty?
+      end
+
+      def global_binary_exists?
+        !Phare.system_output("which #{GLOBAL_BINARY}").empty?
+      end
+
+      def input
+        @tree.changed? ? files_to_check.join(' ') : "'#{@path}/**/*#{@extensions.first}'"
+      end
+
+      def arguments_exists?
+        @tree.changed? || Dir.exist?(@path)
+      end
+
+      def print_banner
+        Phare.banner 'Running Stylelint to check for SCSS style…'
+      end
+    end
+  end
+end

data/lib/phare/check_suite.rb

@@ -4,9 +4,8 @@ module Phare
 
     DEFAULT_CHECKS = {
       rubocop: Check::Rubocop,
-      scsslint: Check::ScssLint,
-      jshint: Check::JSHint,
-      jscs: Check::JSCS
+      stylelint: Check::Stylelint,
+      eslint: Check::Eslint
     }
 
     def initialize(options = {})

data/lib/phare/version.rb

@@ -1,3 +1,3 @@
 module Phare
-  VERSION = '0.7.1'
+  VERSION = '1.0.0'
 end

data/spec/phare/check/{jshint_spec.rb → eslint_spec.rb}

@@ -1,23 +1,34 @@
 require 'spec_helper'
 
-describe Phare::Check::JSHint do
-  let(:described_class) { Phare::Check::JSHint }
+describe Phare::Check::Eslint do
+  let(:described_class) { Phare::Check::Eslint }
 
   describe :should_run? do
     let(:check) { described_class.new('.') }
+    let(:config_exists?) { true }
+    let(:path_exists?) { true }
+    let(:local_which_output) { '' }
+    let(:global_which_output) { '' }
     before do
-      expect(Phare).to receive(:system_output).with('which jshint').and_return(which_output)
+      allow(Phare).to receive(:system_output).with('which eslint').and_return(global_which_output)
+      allow(Phare).to receive(:system_output).with('which .node_modules/.bin/eslint').and_return(local_which_output)
       allow(File).to receive(:exist?).with(check.config).and_return(config_exists?)
       allow(Dir).to receive(:exist?).with(check.path).and_return(path_exists?)
     end
 
-    context 'with found jshint command' do
-      let(:which_output) { 'jshint' }
-      let(:config_exists?) { true }
-      let(:path_exists?) { true }
-      it { expect(check).to be_able_to_run }
+    context 'with found eslint command' do
+      context 'for a local eslint' do
+        let(:local_which_output) { 'node_modules/.bin/eslint' }
+        it { expect(check).to be_able_to_run }
+      end
+
+      context 'for a global eslint' do
+        let(:global_which_output) { 'eslint' }
+        it { expect(check).to be_able_to_run }
+      end
 
       context 'with only excluded files and the --diff option' do
+        let(:global_which_output) { 'eslint' }
         let(:check) { described_class.new('.', diff: true) }
         let(:files) { ['foo.js'] }
 
@@ -30,8 +41,7 @@ describe Phare::Check::JSHint do
       end
     end
 
-    context 'with unfound jshint command' do
-      let(:which_output) { '' }
+    context 'with unfound eslint command' do
       let(:config_exists?) { false }
       let(:path_exists?) { false }
       it { expect(check).to_not be_able_to_run }
@@ -42,62 +52,58 @@ describe Phare::Check::JSHint do
     let(:check) { described_class.new('.') }
     let(:run!) { check.run }
 
-    context 'with available JSHint' do
+    context 'with available Eslint' do
       let(:command) { check.command }
-      let(:directory) { '.' }
-      let(:expanded_path) { '.jshintrc' }
 
       before do
-        expect(File).to receive(:expand_path).with("#{directory}app/assets/javascripts", anything).once.and_call_original
-        expect(File).to receive(:expand_path).with("#{directory}.jshintrc", anything).once.and_return(expanded_path)
         expect(check).to receive(:should_run?).and_return(true)
         expect(Phare).to receive(:system).with(command)
-        expect(Phare).to receive(:last_exit_status).and_return(jshint_exit_status)
+        expect(Phare).to receive(:last_exit_status).and_return(eslint_exit_status)
         expect(check).to receive(:print_banner)
       end
 
-      context 'with check errors' do
-        let(:jshint_exit_status) { 0 }
+      context 'without check errors' do
+        let(:eslint_exit_status) { 0 }
         before { expect(Phare).to receive(:puts).with('Everything looks good from here!') }
-        it { expect { run! }.to change { check.status }.to(jshint_exit_status) }
+        it { expect { run! }.to change { check.status }.to(eslint_exit_status) }
       end
 
-      context 'without check errors' do
-        let(:jshint_exit_status) { 1337 }
-        before { expect(Phare).to receive(:puts).with("Something went wrong. Program exited with #{jshint_exit_status}.") }
-        it { expect { run! }.to change { check.status }.to(jshint_exit_status) }
+      context 'with check errors' do
+        let(:eslint_exit_status) { 1 }
+        before { expect(Phare).to receive(:puts).with("Something went wrong. Program exited with #{eslint_exit_status}.") }
+        it { expect { run! }.to change { check.status }.to(eslint_exit_status) }
       end
 
       context 'with --diff option' do
-        let(:check) { described_class.new(directory, diff: true) }
-        let(:files) { ['app/foo.js', 'bar.js'] }
-        let(:jshint_exit_status) { 1337 }
+        let(:check) { described_class.new('.', diff: true) }
+        let(:files) { ['foo.rb', 'bar.rb'] }
+        let(:eslint_exit_status) { 0 }
 
         context 'without exclusions' do
-          let(:command) { "jshint --config #{expanded_path} --extra-ext .js,.es6 #{files.join(' ')}" }
+          let(:command) { "eslint #{files.join(' ')}" }
 
           before do
             expect(check.tree).to receive(:changes).and_return(files).at_least(:once)
             expect(check).to receive(:excluded_files).and_return([]).once
           end
 
-          it { expect { run! }.to change { check.status }.to(jshint_exit_status) }
+          it { expect { run! }.to change { check.status }.to(eslint_exit_status) }
         end
 
         context 'with exclusions' do
-          let(:command) { "jshint --config #{expanded_path} --extra-ext .js,.es6 bar.js" }
+          let(:command) { 'eslint bar.rb' }
 
           before do
-            expect(check).to receive(:excluded_files).and_return(['app/foo.js']).once
+            expect(check).to receive(:excluded_files).and_return(['foo.rb']).once
             expect(check.tree).to receive(:changes).and_return(files).at_least(:once)
           end
 
-          it { expect { run! }.to change { check.status }.to(jshint_exit_status) }
+          it { expect { run! }.to change { check.status }.to(eslint_exit_status) }
         end
       end
     end
 
-    context 'with unavailable JSHint' do
+    context 'with unavailable Eslint' do
       before do
         expect(check).to receive(:should_run?).and_return(false)
         expect(Phare).to_not receive(:system).with(check.command)

data/spec/phare/check/{scss_lint_spec.rb → stylelint_spec.rb}

@@ -1,21 +1,34 @@
 require 'spec_helper'
 
-describe Phare::Check::ScssLint do
-  let(:described_class) { Phare::Check::ScssLint }
+describe Phare::Check::Stylelint do
+  let(:described_class) { Phare::Check::Stylelint }
 
   describe :should_run? do
     let(:check) { described_class.new('.') }
+    let(:config_exists?) { true }
+    let(:path_exists?) { true }
+    let(:local_which_output) { '' }
+    let(:global_which_output) { '' }
     before do
-      expect(Phare).to receive(:system_output).with('which scss-lint').and_return(which_output)
+      allow(Phare).to receive(:system_output).with('which stylelint').and_return(global_which_output)
+      allow(Phare).to receive(:system_output).with('which .node_modules/.bin/stylelint').and_return(local_which_output)
+      allow(File).to receive(:exist?).with(check.config).and_return(config_exists?)
       allow(Dir).to receive(:exist?).with(check.path).and_return(path_exists?)
     end
 
-    context 'with found scss-lint command' do
-      let(:which_output) { 'scss-lint' }
-      let(:path_exists?) { true }
-      it { expect(check).to be_able_to_run }
+    context 'with found stylelint command' do
+      context 'for a local stylelint' do
+        let(:local_which_output) { 'node_modules/.bin/stylelint' }
+        it { expect(check).to be_able_to_run }
+      end
+
+      context 'for a global stylelint' do
+        let(:global_which_output) { 'stylelint' }
+        it { expect(check).to be_able_to_run }
+      end
 
       context 'with only excluded files and the --diff option' do
+        let(:global_which_output) { 'stylelint' }
         let(:check) { described_class.new('.', diff: true) }
         let(:files) { ['foo.scss'] }
 
@@ -28,8 +41,8 @@ describe Phare::Check::ScssLint do
       end
     end
 
-    context 'with unfound scss-lint command' do
-      let(:which_output) { '' }
+    context 'with unfound stylelint command' do
+      let(:config_exists?) { false }
       let(:path_exists?) { false }
       it { expect(check).to_not be_able_to_run }
     end
@@ -39,58 +52,58 @@ describe Phare::Check::ScssLint do
     let(:check) { described_class.new('.') }
     let(:run!) { check.run }
 
-    context 'with available ScssLint' do
+    context 'with available Stylelint' do
       let(:command) { check.command }
 
       before do
         expect(check).to receive(:should_run?).and_return(true)
         expect(Phare).to receive(:system).with(command)
-        expect(Phare).to receive(:last_exit_status).and_return(scsslint_exit_status)
+        expect(Phare).to receive(:last_exit_status).and_return(stylelint_exit_status)
         expect(check).to receive(:print_banner)
       end
 
-      context 'with check errors' do
-        let(:scsslint_exit_status) { 0 }
+      context 'without check errors' do
+        let(:stylelint_exit_status) { 0 }
         before { expect(Phare).to receive(:puts).with('Everything looks good from here!') }
-        it { expect { run! }.to change { check.status }.to(scsslint_exit_status) }
+        it { expect { run! }.to change { check.status }.to(stylelint_exit_status) }
       end
 
-      context 'without check errors' do
-        let(:scsslint_exit_status) { 1337 }
-        before { expect(Phare).to receive(:puts).with("Something went wrong. Program exited with #{scsslint_exit_status}.") }
-        it { expect { run! }.to change { check.status }.to(scsslint_exit_status) }
+      context 'with check errors' do
+        let(:stylelint_exit_status) { 1 }
+        before { expect(Phare).to receive(:puts).with("Something went wrong. Program exited with #{stylelint_exit_status}.") }
+        it { expect { run! }.to change { check.status }.to(stylelint_exit_status) }
       end
 
       context 'with --diff option' do
         let(:check) { described_class.new('.', diff: true) }
         let(:files) { ['foo.rb', 'bar.rb'] }
-        let(:scsslint_exit_status) { 1337 }
+        let(:stylelint_exit_status) { 0 }
 
         context 'without exclusions' do
-          let(:command) { "scss-lint #{files.join(' ')}" }
+          let(:command) { "stylelint #{files.join(' ')}" }
 
           before do
             expect(check.tree).to receive(:changes).and_return(files).at_least(:once)
             expect(check).to receive(:excluded_files).and_return([]).once
           end
 
-          it { expect { run! }.to change { check.status }.to(scsslint_exit_status) }
+          it { expect { run! }.to change { check.status }.to(stylelint_exit_status) }
         end
 
         context 'with exclusions' do
-          let(:command) { 'scss-lint bar.rb' }
+          let(:command) { 'stylelint bar.rb' }
 
           before do
             expect(check).to receive(:excluded_files).and_return(['foo.rb']).once
             expect(check.tree).to receive(:changes).and_return(files).at_least(:once)
           end
 
-          it { expect { run! }.to change { check.status }.to(scsslint_exit_status) }
+          it { expect { run! }.to change { check.status }.to(stylelint_exit_status) }
         end
       end
     end
 
-    context 'with unavailable ScssLint' do
+    context 'with unavailable Stylelint' do
       before do
         expect(check).to receive(:should_run?).and_return(false)
         expect(Phare).to_not receive(:system).with(check.command)

data/spec/phare/check_suite_spec.rb

@@ -45,19 +45,19 @@ describe Phare::CheckSuite do
     let(:only) { [] }
 
     context 'with "only" option' do
-      let(:only) { [:rubocop, :foo, :jshint] }
-      it { expect(suite.checks).to eql [:rubocop, :jshint] }
+      let(:only) { [:rubocop, :foo, :eslint] }
+      it { expect(suite.checks).to eql [:rubocop, :eslint] }
     end
 
     context 'with "skip" option' do
-      let(:skip) { [:scsslint, :foo, :jshint] }
-      it { expect(suite.checks).to eql [:rubocop, :jscs] }
+      let(:skip) { [:stylelint, :foo] }
+      it { expect(suite.checks).to eql [:rubocop, :eslint] }
     end
 
     context 'with both "only" and "skip" option' do
-      let(:skip) { [:scsslint, :rubocop] }
-      let(:only) { [:scsslint, :foo, :jshint] }
-      it { expect(suite.checks).to eql [:scsslint, :jshint] }
+      let(:skip) { [:stylelint, :rubocop] }
+      let(:only) { [:stylelint, :foo, :eslint] }
+      it { expect(suite.checks).to eql [:stylelint, :eslint] }
     end
 
     context 'with both "only" and "skip" option' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: phare
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 1.0.0
 platform: ruby
 authors:
 - Rémi Prévost
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-22 00:00:00.000000000 Z
+date: 2016-09-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -86,19 +86,17 @@ files:
 - bin/phare
 - lib/phare.rb
 - lib/phare/check.rb
-- lib/phare/check/jscs.rb
-- lib/phare/check/jshint.rb
+- lib/phare/check/eslint.rb
 - lib/phare/check/rubocop.rb
-- lib/phare/check/scss_lint.rb
+- lib/phare/check/stylelint.rb
 - lib/phare/check_suite.rb
 - lib/phare/cli.rb
 - lib/phare/git.rb
 - lib/phare/version.rb
 - phare.gemspec
-- spec/phare/check/jscs_spec.rb
-- spec/phare/check/jshint_spec.rb
+- spec/phare/check/eslint_spec.rb
 - spec/phare/check/rubocop_spec.rb
-- spec/phare/check/scss_lint_spec.rb
+- spec/phare/check/stylelint_spec.rb
 - spec/phare/check_suite_spec.rb
 - spec/phare/cli_spec.rb
 - spec/phare/git_spec.rb
@@ -123,16 +121,15 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Phare looks into your files and check for (Ruby, JavaScript and SCSS) coding
   style errors.
 test_files:
-- spec/phare/check/jscs_spec.rb
-- spec/phare/check/jshint_spec.rb
+- spec/phare/check/eslint_spec.rb
 - spec/phare/check/rubocop_spec.rb
-- spec/phare/check/scss_lint_spec.rb
+- spec/phare/check/stylelint_spec.rb
 - spec/phare/check_suite_spec.rb
 - spec/phare/cli_spec.rb
 - spec/phare/git_spec.rb

data/lib/phare/check/jscs.rb

@@ -1,54 +0,0 @@
-# encoding: utf-8
-
-require 'json'
-
-module Phare
-  class Check
-    class JSCS < Check
-      attr_reader :config, :path
-
-      def initialize(directory, options = {})
-        @config = File.expand_path("#{directory}.jscs.json", __FILE__)
-        @path = File.expand_path("#{directory}app/assets", __FILE__)
-        @extensions = %w(.js)
-        @options = options
-
-        super
-      end
-
-      def command
-        if @tree.changed?
-          "jscs #{files_to_check.join(' ')}"
-        else
-          "jscs #{@path}"
-        end
-      end
-
-    protected
-
-      def excluded_list
-        configuration_file['excludeFiles']
-      end
-
-      def configuration_file
-        @configuration_file ||= File.exist?('.jscs.json') ? JSON.parse(File.read('.jscs.json')) : {}
-      end
-
-      def binary_exists?
-        !Phare.system_output('which jscs').empty?
-      end
-
-      def configuration_exists?
-        File.exist?(@config)
-      end
-
-      def argument_exists?
-        @tree.changed? || Dir.exist?(@path)
-      end
-
-      def print_banner
-        Phare.banner 'Running JSCS to check for JavaScript style…'
-      end
-    end
-  end
-end

data/lib/phare/check/jshint.rb

@@ -1,52 +0,0 @@
-# encoding: utf-8
-module Phare
-  class Check
-    class JSHint < Check
-      attr_reader :config, :path
-
-      def initialize(directory, options = {})
-        @config = File.expand_path("#{directory}.jshintrc", __FILE__)
-        @path = File.expand_path("#{directory}app/assets/javascripts", __FILE__)
-        @glob = File.join(@path, '**/*')
-        @extensions = %w(.js .es6)
-        @options = options
-
-        super
-      end
-
-      def command
-        if @tree.changed?
-          "jshint --config #{@config} --extra-ext #{@extensions.join(',')} #{files_to_check.join(' ')}"
-        else
-          "jshint --config #{@config} --extra-ext #{@extensions.join(',')} #{@glob}"
-        end
-      end
-
-    protected
-
-      def excluded_list
-        configuration_file.split("\n") if configuration_file
-      end
-
-      def configuration_file
-        @configuration_file ||= File.exist?('.jshintignore') ? File.read('.jshintignore') : false
-      end
-
-      def binary_exists?
-        !Phare.system_output('which jshint').empty?
-      end
-
-      def configuration_exists?
-        File.exist?(@config)
-      end
-
-      def arguments_exists?
-        @tree.changed? || Dir.exist?(@path)
-      end
-
-      def print_banner
-        Phare.banner 'Running JSHint to check for JavaScript style…'
-      end
-    end
-  end
-end

data/lib/phare/check/scss_lint.rb

@@ -1,46 +0,0 @@
-# encoding: utf-8
-module Phare
-  class Check
-    class ScssLint < Check
-      attr_reader :path
-
-      def initialize(directory, options = {})
-        @path = File.expand_path("#{directory}app/assets/stylesheets", __FILE__)
-        @extensions = %w(.scss)
-        @options = options
-
-        super
-      end
-
-      def command
-        if @tree.changed?
-          "scss-lint #{files_to_check.join(' ')}"
-        else
-          "scss-lint #{@path}"
-        end
-      end
-
-    protected
-
-      def excluded_list
-        configuration_file['exclude']
-      end
-
-      def configuration_file
-        @configuration_file ||= File.exist?('.scss-lint.yml') ? YAML::load(File.open('.scss-lint.yml')) : {}
-      end
-
-      def binary_exists?
-        !Phare.system_output('which scss-lint').empty?
-      end
-
-      def arguments_exists?
-        @tree.changed? || Dir.exist?(@path)
-      end
-
-      def print_banner
-        Phare.banner 'Running SCSS-Lint to check for SCSS style…'
-      end
-    end
-  end
-end

data/spec/phare/check/jscs_spec.rb

@@ -1,107 +0,0 @@
-require 'spec_helper'
-
-describe Phare::Check::JSCS do
-  let(:described_class) { Phare::Check::JSCS }
-
-  describe :should_run? do
-    let(:check) { described_class.new('.') }
-
-    before do
-      expect(Phare).to receive(:system_output).with('which jscs').and_return(which_output)
-      allow(File).to receive(:exist?).with(check.config).and_return(config_exists?)
-      allow(Dir).to receive(:exist?).with(check.path).and_return(path_exists?)
-    end
-
-    context 'with found jscs command' do
-      let(:which_output) { 'jscs' }
-      let(:config_exists?) { true }
-      let(:path_exists?) { true }
-
-      it { expect(check).to be_able_to_run }
-
-      context 'with only excluded files and the --diff option' do
-        let(:check) { described_class.new('.', diff: true) }
-        let(:files) { ['foo.js'] }
-
-        before do
-          expect(check).to receive(:excluded_files).and_return(files).once
-          expect(check.tree).to receive(:changes).and_return(files).at_least(:once)
-        end
-
-        it { expect(check.should_run?).to be_falsey }
-      end
-    end
-
-    context 'with unfound jscs command' do
-      let(:which_output) { '' }
-      let(:config_exists?) { false }
-      let(:path_exists?) { false }
-      it { expect(check).to_not be_able_to_run }
-    end
-  end
-
-  describe :run do
-    let(:check) { described_class.new('.') }
-    let(:run!) { check.run }
-
-    context 'with available JSCS' do
-      let(:command) { check.command }
-
-      before do
-        expect(check).to receive(:should_run?).and_return(true)
-        expect(Phare).to receive(:system).with(command)
-        expect(Phare).to receive(:last_exit_status).and_return(jscs_exit_status)
-        expect(check).to receive(:print_banner)
-      end
-
-      context 'with check errors' do
-        let(:jscs_exit_status) { 0 }
-        it { expect { run! }.to change { check.status }.to(jscs_exit_status) }
-      end
-
-      context 'without check errors' do
-        let(:jscs_exit_status) { 1337 }
-        before { expect(Phare).to receive(:puts).with("Something went wrong. Program exited with #{jscs_exit_status}.") }
-        it { expect { run! }.to change { check.status }.to(jscs_exit_status) }
-      end
-
-      context 'with --diff option' do
-        let(:check) { described_class.new('.', diff: true) }
-        let(:files) { ['app/foo.js', 'bar.js'] }
-        let(:jscs_exit_status) { 1337 }
-
-        context 'without exclusions' do
-          let(:command) { "jscs #{files.join(' ')}" }
-
-          before do
-            expect(check.tree).to receive(:changes).and_return(files).at_least(:once)
-            expect(check).to receive(:excluded_files).and_return([]).once
-          end
-
-          it { expect { run! }.to change { check.status }.to(jscs_exit_status) }
-        end
-
-        context 'with exclusions' do
-          let(:command) { 'jscs bar.js' }
-
-          before do
-            expect(check).to receive(:excluded_files).and_return(['app/foo.js']).once
-            expect(check.tree).to receive(:changes).and_return(files).at_least(:once)
-          end
-
-          it { expect { run! }.to change { check.status }.to(jscs_exit_status) }
-        end
-      end
-    end
-
-    context 'with unavailable JSCS' do
-      before do
-        expect(check).to receive(:should_run?).and_return(false)
-        expect(Phare).to_not receive(:system).with(check.command)
-        expect(check).to_not receive(:print_banner)
-      end
-
-      it { expect { run! }.to change { check.status }.to(0) }
-    end
-  end
-end