phare 0.3 → 0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 35069f434b69d4d2b08242381c29e2f79430e9c8
-  data.tar.gz: b1830fa17a58c356fa2697a58891faf853564713
+  metadata.gz: 5e4055ee6e95ae9be4856e7031220de6735136a4
+  data.tar.gz: 03a9678f15427a0affb3e76faaeb6694fb2d9775
 SHA512:
-  metadata.gz: 0b9571363ff3a64770d27ec08fafeb1dfb43f2dc690f5c7625c0f7293f23d66e6ac3a0e82f13b8c2cf8b49e2cc937565c321daa357a03fab3f7662391d65452e
-  data.tar.gz: f58562f9ecdfbeec535604a86fff42170abae6a82e52b668b267861f38fa68d6663f7042c3a5c32347be1503d656f185ff10c46dd5a3c1ee80c9b008a612ccda
+  metadata.gz: 83ee6107f5879b34f1da3a9554d96f2bdaccc982bb12f9d768f359d8b6809dae1f048acd3e76ac56584a4790b50e6b475d76e071d9b6e36ccc3c529bd0ffbafb
+  data.tar.gz: 838988f8a43ba902060c4c4b8036228d946fd80d4337bacbe6879bb6369519c354f47140c7feb0031829cfd3d5797da72e5de932f7fb26b265459231e75a35e8

data/.rspec

@@ -0,0 +1 @@
+--color

data/.travis.yml

@@ -0,0 +1,17 @@
+language: ruby
+
+rvm:
+  - 2.0.0
+  - 1.9.3
+
+script:
+  - 'echo "Checking code style" && ./bin/phare'
+  - 'echo "Running specs" && bundle exec rake spec'
+
+notifications:
+  hipchat:
+    rooms:
+      secure: "OjYHtwmsG6bDC8mewX85yulCKxsVpvGiic32e6lDRq2TYmMtot/atOQaZ16YlMMN0CQqiJ8jfpil3HWCSK1iPZxSLHzCEu//bL6uoDJdPc/oXNV2BPAj0CxyHiJPpV3gdgdnZBbYGNdDPtjxo8FuZnM+cWIDl3yW0Y2rQkE7u0k="
+    template:
+      - '%{repository}#%{build_number} (%{branch} - %{commit} : %{author}): %{message} (<a href="%{build_url}">Build</a>/<a href="%{compare_url}">Changes</a>)'
+    format: 'html'

data/Rakefile

@@ -1 +1,11 @@
+require 'bundler'
+require 'rake'
 require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+
+task default: :spec
+
+desc 'Run all specs'
+RSpec::Core::RakeTask.new(:spec) do |task|
+  task.pattern = 'spec/**/*_spec.rb'
+end

data/bin/phare

@@ -4,4 +4,4 @@ $LOAD_PATH.unshift File.join(File.dirname(__FILE__), *%w[.. lib])
 
 require 'phare'
 
-Phare::CLI.new(ENV)
+Phare::CLI.new(ENV, ARGV).run

data/lib/phare.rb

@@ -1,10 +1,31 @@
 require 'English'
+require 'optparse'
 require 'phare/version'
 
 require 'phare/cli'
+
 require 'phare/check'
+require 'phare/check/rubocop'
+require 'phare/check/scss_lint'
+require 'phare/check/jshint'
+require 'phare/check/jscs'
+
+require 'phare/check_suite'
+
+module Phare
+  def self.system(*args)
+    Kernel.system(*args)
+  end
+
+  def self.system_output(args)
+    `#{args}`
+  end
+
+  def self.last_exit_status
+    $CHILD_STATUS.exitstatus
+  end
 
-require 'phare/checks/ruby_rubocop'
-require 'phare/checks/scss_lint'
-require 'phare/checks/javascript_jshint'
-require 'phare/checks/javascript_jscs'
+  def self.puts(*args)
+    STDOUT.puts(*args)
+  end
+end

data/lib/phare/check.rb

@@ -1,28 +1,33 @@
 module Phare
   class Check
-    attr_reader :status
-
-    def initialize(directory)
-      @directory = directory
-      @directory << '/' unless @directory.end_with?('/')
-    end
+    attr_reader :status, :command
 
     def run
-      @checks = []
+      if should_run?
+        print_banner
+        Phare.system(command)
+        @status = Phare.last_exit_status
 
-      @checks << ruby = Checks::RubyRubocop.new
-      ruby.run
+        if @status == 0
+          print_success_message
+        else
+          print_error_message
+        end
 
-      @checks << scsslint = Checks::ScssLint.new(@directory)
-      scsslint.run
+        Phare.puts ''
+      else
+        @status = 0
+      end
+    end
 
-      @checks << jshint = Checks::JavaScriptJSHint.new(@directory)
-      jshint.run
+  protected
 
-      @checks << jscs = Checks::JavaScriptJSCS.new(@directory)
-      jscs.run
+    def print_success_message
+      Phare.puts('Everything looks good from here!')
+    end
 
-      @status = @checks.map!(&:status).find { |status| status > 0 } || 0
+    def print_error_message
+      Phare.puts("Something went wrong. Program exited with #{@status}.")
     end
   end
 end

data/lib/phare/check/jscs.rb

@@ -0,0 +1,29 @@
+# encoding: utf-8
+module Phare
+  class Check
+    class JSCS < Check
+      attr_reader :config, :path
+
+      def initialize(directory)
+        @config = File.expand_path("#{directory}.jscs.json", __FILE__)
+        @path = File.expand_path("#{directory}app/assets", __FILE__)
+      end
+
+      def command
+        "jscs #{@path}"
+      end
+
+    protected
+
+      def should_run?
+        !Phare.system_output('which jscs').empty? && File.exists?(@config) && Dir.exists?(@path)
+      end
+
+      def print_banner
+        Phare.puts '---------------------------------------------'
+        Phare.puts 'Running JSCS to check for JavaScript style…'
+        Phare.puts '---------------------------------------------'
+      end
+    end
+  end
+end

data/lib/phare/check/jshint.rb

@@ -0,0 +1,30 @@
+# encoding: utf-8
+module Phare
+  class Check
+    class JSHint < Check
+      attr_reader :config, :path
+
+      def initialize(directory)
+        @config = File.expand_path("#{directory}.jshintrc", __FILE__)
+        @path = File.expand_path("#{directory}app/assets/javascripts", __FILE__)
+        @glob = File.join(@path, '**/*')
+      end
+
+      def command
+        "jshint --config #{@config} --extra-ext .js,.es6.js #{@glob}"
+      end
+
+    protected
+
+      def should_run?
+        !Phare.system_output('which jshint').empty? && File.exists?(@config) && Dir.exists?(@path)
+      end
+
+      def print_banner
+        Phare.puts '---------------------------------------------'
+        Phare.puts 'Running JSHint to check for JavaScript style…'
+        Phare.puts '---------------------------------------------'
+      end
+    end
+  end
+end

data/lib/phare/check/rubocop.rb

@@ -0,0 +1,26 @@
+# encoding: utf-8
+module Phare
+  class Check
+    class Rubocop < Check
+      def initialize(directory)
+        @path = directory
+      end
+
+      def command
+        'rubocop'
+      end
+
+    protected
+
+      def should_run?
+        !Phare.system_output('which rubocop').empty?
+      end
+
+      def print_banner
+        Phare.puts '----------------------------------------'
+        Phare.puts 'Running Rubocop to check for Ruby style…'
+        Phare.puts '----------------------------------------'
+      end
+    end
+  end
+end

data/lib/phare/check/scss_lint.rb

@@ -0,0 +1,28 @@
+# encoding: utf-8
+module Phare
+  class Check
+    class ScssLint < Check
+      attr_reader :path
+
+      def initialize(directory)
+        @path = File.expand_path("#{directory}app/assets/stylesheets", __FILE__)
+      end
+
+      def command
+        "scss-lint #{@path}"
+      end
+
+    protected
+
+      def should_run?
+        !Phare.system_output('which scss-lint').empty? && Dir.exists?(@path)
+      end
+
+      def print_banner
+        Phare.puts '------------------------------------------'
+        Phare.puts 'Running SCSS-Lint to check for SCSS style…'
+        Phare.puts '------------------------------------------'
+      end
+    end
+  end
+end

data/lib/phare/check_suite.rb

@@ -0,0 +1,43 @@
+module Phare
+  class CheckSuite
+    attr_reader :status
+
+    DEFAULT_CHECKS = {
+      rubocop: Check::Rubocop,
+      scsslint: Check::ScssLint,
+      jshint: Check::JSHint,
+      jscs: Check::JSCS
+    }
+
+    def initialize(options = {})
+      @options = options
+
+      @directory = options[:directory]
+      @directory << '/' unless @directory.end_with?('/')
+
+      @options[:skip] ||= []
+      @options[:only] ||= []
+    end
+
+    def checks
+      checks = DEFAULT_CHECKS.keys
+
+      if @options[:only].any?
+        checks = checks & @options[:only]
+      elsif @options[:skip]
+        checks = checks - @options[:skip]
+      else
+        checks
+      end
+    end
+
+    def run
+      @checks = checks.map do |check|
+        check = DEFAULT_CHECKS[check]
+        check.new(@directory).tap(&:run).status
+      end
+
+      @status = @checks.find { |status| status > 0 } || 0
+    end
+  end
+end

data/lib/phare/cli.rb

@@ -1,27 +1,59 @@
+# encoding: utf-8
 module Phare
   class CLI
-    def initialize(env)
-      if env['SKIP_CODE_CHECK']
-        puts '--------------------------------------------------------'
-        puts 'Skipping code style checking… Really? Well alright then…'
-        puts '--------------------------------------------------------'
+    attr_reader :suite
+
+    def initialize(env, argv)
+      @env = env
+      @argv = argv
+      parse_options
+
+      @suite = Phare::CheckSuite.new(@options)
+    end
+
+    def run
+      if @env['SKIP_CODE_CHECK']
+        Phare.puts '--------------------------------------------------------'
+        Phare.puts 'Skipping code style checking… Really? Well alright then…'
+        Phare.puts '--------------------------------------------------------'
 
         exit 0
       else
-        if Phare::Check.new(Dir.getwd).tap { |c| c.run }.status == 0
-          puts '------------------------------------------'
-          puts 'Everything looks good, keep on committing!'
-          puts '------------------------------------------'
+        if @suite.tap(&:run).status == 0
+          Phare.puts '------------------------------------------'
+          Phare.puts 'Everything looks good, keep on committing!'
+          Phare.puts '------------------------------------------'
 
           exit 0
         else
-          puts '------------------------------------------------------------------------'
-          puts 'Something’s wrong with your code style. Please fix it before committing.'
-          puts '------------------------------------------------------------------------'
+          Phare.puts '------------------------------------------------------------------------'
+          Phare.puts 'Something’s wrong with your code style. Please fix it before committing.'
+          Phare.puts '------------------------------------------------------------------------'
 
           exit 1
         end
       end
     end
+
+    def parse_options
+      @options = { directory: Dir.getwd }
+
+      OptionParser.new do |opts|
+        opts.banner = 'Usage: phare [options]'
+
+        opts.on('--directory', 'The directory in which to run the checks (default is the current directory') do |directory|
+          @options[:directory] = directory
+        end
+
+        opts.on('--skip x,y,z', 'Skip checks') do |checks|
+          @options[:skip] = checks.split(',').map(&:to_sym)
+        end
+
+        opts.on('--only x,y,z', 'Only run the specified checks') do |checks|
+          @options[:only] = checks.split(',').map(&:to_sym)
+        end
+
+      end.parse! @argv
+    end
   end
 end

data/lib/phare/version.rb

@@ -1,3 +1,3 @@
 module Phare
-  VERSION = '0.3'
+  VERSION = '0.4'
 end

data/phare.gemspec

@@ -8,8 +8,8 @@ Gem::Specification.new do |spec|
   spec.version       = Phare::VERSION
   spec.authors       = ['Rémi Prévost']
   spec.email         = ['remi@exomel.com']
-  spec.description   = ''
-  spec.summary       = ''
+  spec.description   = 'Phare looks into your files and check for (Ruby, JavaScript and SCSS) coding style errors.'
+  spec.summary       = spec.description
   spec.homepage      = 'https://github.com/mirego/phare'
   spec.license       = 'BSD 3-Clause'
 
@@ -20,4 +20,5 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rspec', '~> 3.0.0.beta2'
 end

data/spec/phare/check/jscs_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+
+describe Phare::Check::JSCS do
+  describe :should_run? do
+    let(:check) { described_class.new('.') }
+    before do
+      expect(Phare).to receive(:system_output).with('which jscs').and_return(which_output)
+      allow(File).to receive(:exists?).with(check.config).and_return(config_exists?)
+      allow(Dir).to receive(:exists?).with(check.path).and_return(path_exists?)
+    end
+
+    context 'with found jscs command' do
+      let(:which_output) { 'jscs' }
+      let(:config_exists?) { true }
+      let(:path_exists?) { true }
+      it { expect(check).to be_able_to_run }
+    end
+
+    context 'with unfound jscs command' do
+      let(:which_output) { '' }
+      let(:config_exists?) { false }
+      let(:path_exists?) { false }
+      it { expect(check).to_not be_able_to_run }
+    end
+  end
+
+  describe :run do
+    let(:check) { described_class.new('.') }
+    let(:run!) { check.run }
+
+    context 'with available JSCS' do
+      before do
+        expect(check).to receive(:should_run?).and_return(true)
+        expect(Phare).to receive(:system).with(check.command)
+        expect(Phare).to receive(:last_exit_status).and_return(jscs_exit_status)
+        expect(check).to receive(:print_banner)
+      end
+
+      context 'with check errors' do
+        let(:jscs_exit_status) { 0 }
+        it { expect { run! }.to change { check.status }.to(jscs_exit_status) }
+      end
+
+      context 'without check errors' do
+        let(:jscs_exit_status) { 1337 }
+        before { expect(Phare).to receive(:puts).with("Something went wrong. Program exited with #{jscs_exit_status}.") }
+        it { expect { run! }.to change { check.status }.to(jscs_exit_status) }
+      end
+    end
+
+    context 'with unavailable JSCS' do
+      before do
+        expect(check).to receive(:should_run?).and_return(false)
+        expect(Phare).to_not receive(:system).with(check.command)
+        expect(check).to_not receive(:print_banner)
+      end
+
+      it { expect { run! }.to change { check.status }.to(0) }
+    end
+  end
+end

data/spec/phare/check/jshint_spec.rb

@@ -0,0 +1,62 @@
+require 'spec_helper'
+
+describe Phare::Check::JSHint do
+  describe :should_run? do
+    let(:check) { described_class.new('.') }
+    before do
+      expect(Phare).to receive(:system_output).with('which jshint').and_return(which_output)
+      allow(File).to receive(:exists?).with(check.config).and_return(config_exists?)
+      allow(Dir).to receive(:exists?).with(check.path).and_return(path_exists?)
+    end
+
+    context 'with found jshint command' do
+      let(:which_output) { 'jshint' }
+      let(:config_exists?) { true }
+      let(:path_exists?) { true }
+      it { expect(check).to be_able_to_run }
+    end
+
+    context 'with unfound jshint command' do
+      let(:which_output) { '' }
+      let(:config_exists?) { false }
+      let(:path_exists?) { false }
+      it { expect(check).to_not be_able_to_run }
+    end
+  end
+
+  describe :run do
+    let(:check) { described_class.new('.') }
+    let(:run!) { check.run }
+
+    context 'with available JSHint' do
+      before do
+        expect(check).to receive(:should_run?).and_return(true)
+        expect(Phare).to receive(:system).with(check.command)
+        expect(Phare).to receive(:last_exit_status).and_return(jshint_exit_status)
+        expect(check).to receive(:print_banner)
+      end
+
+      context 'with check errors' do
+        let(:jshint_exit_status) { 0 }
+        before { expect(Phare).to receive(:puts).with('Everything looks good from here!') }
+        it { expect { run! }.to change { check.status }.to(jshint_exit_status) }
+      end
+
+      context 'without check errors' do
+        let(:jshint_exit_status) { 1337 }
+        before { expect(Phare).to receive(:puts).with("Something went wrong. Program exited with #{jshint_exit_status}.") }
+        it { expect { run! }.to change { check.status }.to(jshint_exit_status) }
+      end
+    end
+
+    context 'with unavailable JSHint' do
+      before do
+        expect(check).to receive(:should_run?).and_return(false)
+        expect(Phare).to_not receive(:system).with(check.command)
+        expect(check).to_not receive(:print_banner)
+      end
+
+      it { expect { run! }.to change { check.status }.to(0) }
+    end
+  end
+end

data/spec/phare/check/rubocop_spec.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+
+describe Phare::Check::Rubocop do
+  describe :should_run? do
+    let(:check) { described_class.new('.') }
+    before { expect(Phare).to receive(:system_output).with('which rubocop').and_return(which_output) }
+
+    context 'with found rubocop command' do
+      let(:which_output) { 'rubocop' }
+      it { expect(check).to be_able_to_run }
+    end
+
+    context 'with unfound rubocop command' do
+      let(:which_output) { '' }
+      it { expect(check).to_not be_able_to_run }
+    end
+  end
+
+  describe :run do
+    let(:check) { described_class.new('.') }
+    let(:run!) { check.run }
+
+    context 'with available Rubocop' do
+      before do
+        expect(check).to receive(:should_run?).and_return(true)
+        expect(Phare).to receive(:system).with(check.command)
+        expect(Phare).to receive(:last_exit_status).and_return(rubocop_exit_status)
+        expect(check).to receive(:print_banner)
+      end
+
+      context 'with check errors' do
+        let(:rubocop_exit_status) { 0 }
+        it { expect { run! }.to change { check.status }.to(0) }
+      end
+
+      context 'without check errors' do
+        let(:rubocop_exit_status) { 1337 }
+        before { expect(Phare).to receive(:puts).with("Something went wrong. Program exited with #{rubocop_exit_status}.") }
+        it { expect { run! }.to change { check.status }.to(rubocop_exit_status) }
+      end
+    end
+
+    context 'with unavailable Rubocop' do
+      before do
+        expect(check).to receive(:should_run?).and_return(false)
+        expect(Phare).to_not receive(:system).with(check.command)
+        expect(check).to_not receive(:print_banner)
+      end
+
+      it { expect { run! }.to change { check.status }.to(0) }
+    end
+  end
+end

data/spec/phare/check/scss_lint_spec.rb

@@ -0,0 +1,59 @@
+require 'spec_helper'
+
+describe Phare::Check::ScssLint do
+  describe :should_run? do
+    let(:check) { described_class.new('.') }
+    before do
+      expect(Phare).to receive(:system_output).with('which scss-lint').and_return(which_output)
+      allow(Dir).to receive(:exists?).with(check.path).and_return(path_exists?)
+    end
+
+    context 'with found scss-lint command' do
+      let(:which_output) { 'scss-lint' }
+      let(:path_exists?) { true }
+      it { expect(check).to be_able_to_run }
+    end
+
+    context 'with unfound scss-lint command' do
+      let(:which_output) { '' }
+      let(:path_exists?) { false }
+      it { expect(check).to_not be_able_to_run }
+    end
+  end
+
+  describe :run do
+    let(:check) { described_class.new('.') }
+    let(:run!) { check.run }
+
+    context 'with available ScssLint' do
+      before do
+        expect(check).to receive(:should_run?).and_return(true)
+        expect(Phare).to receive(:system).with(check.command)
+        expect(Phare).to receive(:last_exit_status).and_return(scsslint_exit_status)
+        expect(check).to receive(:print_banner)
+      end
+
+      context 'with check errors' do
+        let(:scsslint_exit_status) { 0 }
+        before { expect(Phare).to receive(:puts).with('Everything looks good from here!') }
+        it { expect { run! }.to change { check.status }.to(scsslint_exit_status) }
+      end
+
+      context 'without check errors' do
+        let(:scsslint_exit_status) { 1337 }
+        before { expect(Phare).to receive(:puts).with("Something went wrong. Program exited with #{scsslint_exit_status}.") }
+        it { expect { run! }.to change { check.status }.to(scsslint_exit_status) }
+      end
+    end
+
+    context 'with unavailable ScssLint' do
+      before do
+        expect(check).to receive(:should_run?).and_return(false)
+        expect(Phare).to_not receive(:system).with(check.command)
+        expect(check).to_not receive(:print_banner)
+      end
+
+      it { expect { run! }.to change { check.status }.to(0) }
+    end
+  end
+end

data/spec/phare/check_suite_spec.rb

@@ -0,0 +1,65 @@
+require 'spec_helper'
+
+describe Phare::CheckSuite do
+  describe :run do
+    let(:options) { { directory: '.' } }
+    let(:suite) { described_class.new(options) }
+
+    before do
+      Phare::CheckSuite::DEFAULT_CHECKS.values.each_with_index do |check, index|
+        exit_status = exit_status_proc.call(index)
+        allow_any_instance_of(check).to receive(:run)
+        allow_any_instance_of(check).to receive(:status).and_return(exit_status)
+      end
+    end
+
+    context 'with a single failing check' do
+      let(:exit_status_proc) do
+        proc { |index| index == 2 ? 1337 : 0 }
+      end
+
+      it { expect { suite.run }.to change { suite.status }.to(1337) }
+    end
+
+    context 'with a multiple failing checks' do
+      let(:exit_status_proc) do
+        proc { |index| (index * 500) + 20 }
+      end
+
+      it { expect { suite.run }.to change { suite.status }.to(20) }
+    end
+
+    context 'with no failing check' do
+      let(:exit_status_proc) { proc { |index| 0 } }
+
+      it { expect { suite.run }.to change { suite.status }.to(0) }
+    end
+  end
+
+  describe :checks do
+    let(:options) { { directory: '.', skip: skip, only: only } }
+    let(:suite) { described_class.new(options) }
+    let(:skip) { [] }
+    let(:only) { [] }
+
+    context 'with "only" option' do
+      let(:only) { [:rubocop, :foo, :jshint] }
+      it { expect(suite.checks).to eql [:rubocop, :jshint] }
+    end
+
+    context 'with "skip" option' do
+      let(:skip) { [:scsslint, :foo, :jshint] }
+      it { expect(suite.checks).to eql [:rubocop, :jscs] }
+    end
+
+    context 'with both "only" and "skip" option' do
+      let(:skip) { [:scsslint, :rubocop] }
+      let(:only) { [:scsslint, :foo, :jshint] }
+      it { expect(suite.checks).to eql [:scsslint, :jshint] }
+    end
+
+    context 'with both "only" and "skip" option' do
+      it { expect(suite.checks).to eql Phare::CheckSuite::DEFAULT_CHECKS.keys }
+    end
+  end
+end

data/spec/phare/cli_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+describe Phare::CLI do
+  let(:cli) { described_class.new(env, argv) }
+  let(:argv) { [] }
+  let(:run!) { cli.run }
+
+  describe :initialize do
+    context 'with code check skipping' do
+      let(:env) { { 'SKIP_CODE_CHECK' => '1' } }
+      it { expect { run! }.to exit_with_code(0) }
+    end
+
+    context 'without code check skipping' do
+      let(:env) { {} }
+
+      context 'with suite errors' do
+        before do
+          expect(cli.suite).to receive(:run)
+          expect(cli.suite).to receive(:status).and_return(1337)
+        end
+
+        it { expect { run! }.to exit_with_code(1) }
+      end
+
+      context 'without suite errors' do
+        before do
+          expect(cli.suite).to receive(:run)
+          expect(cli.suite).to receive(:status).and_return(0)
+        end
+
+        it { expect { run! }.to exit_with_code(0) }
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,44 @@
+$LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
+
+require 'rspec'
+require 'phare'
+
+RSpec.configure do |config|
+  config.before(:each) do
+    # Disable all logging
+    allow(Phare).to receive(:puts)
+  end
+end
+
+RSpec::Matchers.define :be_able_to_run do
+  match do |actual|
+    actual.send(:should_run?) == true
+  end
+end
+
+RSpec::Matchers.define :exit_with_code do |expected_code|
+  actual = nil
+
+  match do |block|
+    begin
+      block.call
+    rescue SystemExit => e
+      actual = e.status
+    end
+
+    actual && actual == expected_code
+  end
+
+  failure_message do |block|
+    "expected block to call exit(#{expected_code}) but exit" +
+      (actual.nil? ? ' not called' : "(#{actual}) was called")
+  end
+
+  failure_message_when_negated do |block|
+    "expected block not to call exit(#{expected_code})"
+  end
+
+  description do
+    "expect block to call exit(#{expected_code})"
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: phare
 version: !ruby/object:Gem::Version
-  version: '0.3'
+  version: '0.4'
 platform: ruby
 authors:
 - Rémi Prévost
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-04 00:00:00.000000000 Z
+date: 2014-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -38,7 +38,22 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-description: ''
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 3.0.0.beta2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 3.0.0.beta2
+description: Phare looks into your files and check for (Ruby, JavaScript and SCSS)
+  coding style errors.
 email:
 - remi@exomel.com
 executables:
@@ -47,7 +62,9 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .rspec
 - .rubocop.yml
+- .travis.yml
 - Gemfile
 - LICENSE.md
 - README.md
@@ -55,13 +72,21 @@ files:
 - bin/phare
 - lib/phare.rb
 - lib/phare/check.rb
-- lib/phare/checks/javascript_jscs.rb
-- lib/phare/checks/javascript_jshint.rb
-- lib/phare/checks/ruby_rubocop.rb
-- lib/phare/checks/scss_lint.rb
+- lib/phare/check/jscs.rb
+- lib/phare/check/jshint.rb
+- lib/phare/check/rubocop.rb
+- lib/phare/check/scss_lint.rb
+- lib/phare/check_suite.rb
 - lib/phare/cli.rb
 - lib/phare/version.rb
 - phare.gemspec
+- spec/phare/check/jscs_spec.rb
+- spec/phare/check/jshint_spec.rb
+- spec/phare/check/rubocop_spec.rb
+- spec/phare/check/scss_lint_spec.rb
+- spec/phare/check_suite_spec.rb
+- spec/phare/cli_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/mirego/phare
 licenses:
 - BSD 3-Clause
@@ -85,5 +110,13 @@ rubyforge_project:
 rubygems_version: 2.1.0
 signing_key: 
 specification_version: 4
-summary: ''
-test_files: []
+summary: Phare looks into your files and check for (Ruby, JavaScript and SCSS) coding
+  style errors.
+test_files:
+- spec/phare/check/jscs_spec.rb
+- spec/phare/check/jshint_spec.rb
+- spec/phare/check/rubocop_spec.rb
+- spec/phare/check/scss_lint_spec.rb
+- spec/phare/check_suite_spec.rb
+- spec/phare/cli_spec.rb
+- spec/spec_helper.rb

data/lib/phare/checks/javascript_jscs.rb

@@ -1,41 +0,0 @@
-module Phare
-  module Checks
-    class JavaScriptJSCS
-      attr_reader :status
-
-      def initialize(directory)
-        @config = File.expand_path("#{directory}.jscs.json", __FILE__)
-        @path = File.expand_path("#{directory}app/assets", __FILE__)
-        @command = "jscs #{@path}"
-      end
-
-      def run
-        if should_run?
-          print_banner
-          system(@command)
-          @status = $CHILD_STATUS.exitstatus
-
-          unless @status == 0
-            puts "Something went wrong. Program exited with #{@status}"
-          end
-
-          puts ''
-        else
-          @status = 0
-        end
-      end
-
-    protected
-
-      def should_run?
-        !`which jscs`.empty? && File.exists?(@config) && Dir.exists?(@path)
-      end
-
-      def print_banner
-        puts '---------------------------------------------'
-        puts 'Running JSCS to check for JavaScript style…'
-        puts '---------------------------------------------'
-      end
-    end
-  end
-end

data/lib/phare/checks/javascript_jshint.rb

@@ -1,44 +0,0 @@
-module Phare
-  module Checks
-    class JavaScriptJSHint
-      attr_reader :status
-
-      def initialize(directory)
-        @config = File.expand_path("#{directory}.jshintrc", __FILE__)
-        @path = File.expand_path("#{directory}app/assets/javascripts", __FILE__)
-        @glob = File.join(@path, '**/*')
-        @command = "jshint --config #{@config} --extra-ext .js,.es6.js #{@glob}"
-      end
-
-      def run
-        if should_run?
-          print_banner
-          system(@command)
-          @status = $CHILD_STATUS.exitstatus
-
-          if @status == 0
-            puts 'No code style errors found.'
-          else
-            puts "Something went wrong. Program exited with #{@status}"
-          end
-
-          puts ''
-        else
-          @status = 0
-        end
-      end
-
-    protected
-
-      def should_run?
-        !`which jshint`.empty? && File.exists?(@config) && Dir.exists?(@path)
-      end
-
-      def print_banner
-        puts '---------------------------------------------'
-        puts 'Running JSHint to check for JavaScript style…'
-        puts '---------------------------------------------'
-      end
-    end
-  end
-end

data/lib/phare/checks/ruby_rubocop.rb

@@ -1,39 +0,0 @@
-module Phare
-  module Checks
-    class RubyRubocop
-      attr_reader :status
-
-      def initialize
-        @command = 'rubocop'
-      end
-
-      def run
-        if should_run?
-          print_banner
-          system(@command)
-          @status = $CHILD_STATUS.exitstatus
-
-          unless @status == 0
-            puts "Something went wrong. Program exited with #{@status}"
-          end
-
-          puts ''
-        else
-          @status = 0
-        end
-      end
-
-    protected
-
-      def should_run?
-        !`which rubocop`.empty?
-      end
-
-      def print_banner
-        puts '----------------------------------------'
-        puts 'Running Rubocop to check for Ruby style…'
-        puts '----------------------------------------'
-      end
-    end
-  end
-end

data/lib/phare/checks/scss_lint.rb

@@ -1,42 +0,0 @@
-module Phare
-  module Checks
-    class ScssLint
-      attr_reader :status
-
-      def initialize(directory)
-        @path = File.expand_path("#{directory}app/assets/stylesheets", __FILE__)
-        @command = "scss-lint #{@path}"
-      end
-
-      def run
-        if should_run?
-          print_banner
-          system(@command)
-          @status = $CHILD_STATUS.exitstatus
-
-          if @status == 0
-            puts 'No code style errors found.'
-          else
-            puts "Something went wrong. Program exited with #{@status}"
-          end
-
-          puts ''
-        else
-          @status = 0
-        end
-      end
-
-    protected
-
-      def should_run?
-        !`which scss-lint`.empty? && Dir.exists?(@path)
-      end
-
-      def print_banner
-        puts '------------------------------------------'
-        puts 'Running SCSS-Lint to check for SCSS style…'
-        puts '------------------------------------------'
-      end
-    end
-  end
-end